FWD » Core Development » User Interface

11/08/2016

04:21 PM Bug #2557: Fix MENUBAR layouting in a window

Vadim Gindin wrote:
> @/menu/gui/mbar_warn.p@
>
> [...]
Btw., the test case abends when a sub-menu is selected... Hynek Cihlar

04:11 PM Bug #2557: Fix MENUBAR layouting in a window

Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Hynek Cihlar wrote:
> > > How does this relate to the new method @Th... Hynek Cihlar

02:43 PM Bug #2557: Fix MENUBAR layouting in a window

Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > How does this relate to the new method @ThinClient.isMenubarShowNeede... Vadim Gindin

07:48 AM Bug #2557: Fix MENUBAR layouting in a window

Hynek Cihlar wrote:
> How does this relate to the new method @ThinClient.isMenubarShowNeeded()@? What would be the t... Hynek Cihlar

07:00 AM Bug #2557: Fix MENUBAR layouting in a window

Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Vadim Gindin wrote:
> > > @/menu/gui/mbar_warn.p@
> > >
> > > [..... Hynek Cihlar

11:51 PM Bug #2557: Fix MENUBAR layouting in a window

Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > @/menu/gui/mbar_warn.p@
> >
> > [...]
>
> Vadim, send please al... Vadim Gindin

07:40 AM Bug #2966 (Closed): NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah

07:13 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> Yes, please merge 2966a to trunk.
>
> There is nothing more to do in this task?
There is no... Vadim Gindin

06:26 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Yes, please merge 2966a to trunk.
There is nothing more to do in this task? Greg Shah

11:56 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> It is difficult to tell, because the state of the database has been edited by the testing.
>
>... Vadim Gindin

11/07/2016

03:34 PM Bug #2557: Fix MENUBAR layouting in a window

Vadim Gindin wrote:
> @/menu/gui/mbar_warn.p@
>
> [...]
Vadim, send please also the steps to reproduce the issue. Hynek Cihlar

10:45 AM Bug #2557: Fix MENUBAR layouting in a window

@/menu/gui/mbar_warn.p@... Vadim Gindin

09:50 AM Bug #2557: Fix MENUBAR layouting in a window

Code review 2557a.
MessageAreaGuiImpl.java is missing a history entry.
@Window.afterConfigUpdate()@
I think th... Hynek Cihlar

09:01 AM Bug #2557: Fix MENUBAR layouting in a window

Please summarize the purpose of the changes in 2557a.
Hynek: please do a code review. Greg Shah

04:32 AM Bug #2557: Fix MENUBAR layouting in a window

Vadim Gindin wrote:
> Greg Shah wrote:
> > > May be I should add these bugs to that task?
> >
> > No. Please cr... Vadim Gindin

08:59 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

It is difficult to tell, because the state of the database has been edited by the testing.
Please just run main-re... Greg Shah

08:57 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I've ran 238 and 364 in a single mode. 238 has PASSED and 364 has FAILED.... Vadim Gindin

08:39 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Here are the failed tests: gso_238, gso_364, gso178_session1, gso178_session2. All of them are met first time in this... Vadim Gindin

05:02 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Hynek, I've fixed remarks and reverted WindowManager/AbstractWidget changes. Please review aga... Hynek Cihlar

11/05/2016

10:19 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek, I've fixed remarks and reverted WindowManager/AbstractWidget changes. Please review again. I need permission t... Vadim Gindin

09:52 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed ... Vadim Gindin

11/04/2016

12:19 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> > Can I make all this changes: create 2966b with WindowManager change and revert it in 2966a?
> ... Hynek Cihlar

12:16 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> Hynek: how much of that original @WindowManager@ change is still relevant?
All the changes are... Hynek Cihlar

11:49 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

> Can I make all this changes: create 2966b with WindowManager change and revert it in 2966a?
Actually, I would pr... Greg Shah

11:48 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek: how much of that original @WindowManager@ change is still relevant? Greg Shah

07:29 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed test. Have a look at atta... Hynek Cihlar

07:27 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek Cihlar wrote:
> Code review 2966a.
>
Also the methods @enableOSEvents()@ and @disableOSEvents()@ in @Wind... Hynek Cihlar

07:22 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Code review 2966a.
ThinClient.java
Duplicate file history entry.
Menu.java
* Wrong id in file history entry.
... Hynek Cihlar

06:39 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Actually I would run another cycle of runtime regression testing, because the first run was only for main-part. Vadim Gindin

06:11 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> There are no other tests that failed in both runs?
Yes, there are no other tests, that failed ... Vadim Gindin

05:59 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim: is the branch prepared for review or are you still using an update zip to remove the @WindowManager@ change? Greg Shah

05:57 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek: please do a code review of this branch. Greg Shah

05:57 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

The GSO 156 test is one that commonly fails. If you ran it manually and it was OK, then it is fine.
There are no ... Greg Shah

03:54 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Anyway in the second test (gso156_session2) there is wrong output:... Vadim Gindin

03:16 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

... Vadim Gindin

01:23 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Sure, only these tests are failed in both runs. Vadim Gindin

11/03/2016

01:17 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Did these same tests fail in the previous run? Greg Shah

01:14 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Here is how the error looks:... Vadim Gindin

01:11 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Regression testing finished. 2 tests are failed: gso156_session2 and gso156_session1 Vadim Gindin

01:52 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek Cihlar wrote:
> Greg Shah wrote:
> > > After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed t... Vadim Gindin

01:50 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> > After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed test. Have a look at attac... Vadim Gindin

11/02/2016

03:48 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> > After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed test. Have a look at attac... Hynek Cihlar

02:52 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

> After I reverted @WindowManager@ and @AbstractWidget@ I got 4 failed test. Have a look at attached reverted diff
... Greg Shah

01:21 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> Use an update zip file like we did before using branches. That zip will be applied over the upda... Vadim Gindin

06:23 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Use an update zip file like we did before using branches. That zip will be applied over the updated branch. Greg Shah

06:06 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I'd tried to some moment add changes to p2j in testcases folder (in testing environment), but during regression-testi... Vadim Gindin

05:53 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> > The errors are the same: "eating" characters during authorization.
>
> I have duplicated thi... Vadim Gindin

05:18 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

> The errors are the same: "eating" characters during authorization.
I have duplicated this same result. There is... Greg Shah

01:05 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> I'm running regression testing in my home dir on devsrv01. This way we can remove your testing e... Vadim Gindin

11/01/2016

07:48 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I'm running regression testing in my home dir on devsrv01. This way we can remove your testing environment and just ... Greg Shah

10/27/2016

04:20 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Vadim Gindin wrote:
> Hynek, please clarify. Is your change already in trunk or not yet?
Yes, the change from not... Hynek Cihlar

03:59 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Hynek, please clarify. Is your change already in trunk or not yet? Vadim Gindin

01:21 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Unfortunately the result is similar to previous:
gso_tests 67 failed tests,
tc_tests 254 failed tests
The errors a... Vadim Gindin

10/26/2016

01:49 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

The branch is rebased to the trunk revision 11126. Regression testing is running. Vadim Gindin

10/20/2016

12:47 PM Bug #3204: "No renderer found" bug in menus

The testcase @menu/sm_mnemonic.p@. Trunk revno 11120.
Open menubar and move moues pointer to some sub-menu trying... Vadim Gindin

12:43 PM Bug #3204 (New): "No renderer found" bug in menus

Vadim Gindin

10/12/2016

12:03 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> Please include it in 3111f.
Ok, will do.
Hynek Cihlar

12:00 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Nice work! The proposed change looks reasonable. Please include it in 3111f. Greg Shah

11:38 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Improved comment in focusmanager_fix.diff. Hynek Cihlar

11:35 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I can reproduce the error @java.lang.IllegalStateException: Widget 29 is not attached to a TopLevelWindow instance.@... Hynek Cihlar

10:45 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

I tried @brws_tlw_err.p@ locally and I see auto-return bug in GUI - I have to press @Enter@ to get to the next line. ... Stanislav Lomany

10:13 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Strangely, I don't see test failures associated with this. I say this because the test failures I see are related to... Greg Shah

10/11/2016

05:13 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Greg Shah wrote:
> Good work, Vadim, in isolating this recreate. As I mentioned in a separate email, I am seeing th... Hynek Cihlar

05:05 PM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Good work, Vadim, in isolating this recreate. As I mentioned in a separate email, I am seeing this exception too (in... Greg Shah

03:07 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

Here is the test that constantly reproduces this error: !brws_tlw_err.p!
1. This error also exists in trunk (local... Vadim Gindin

10/10/2016

04:16 AM Bug #2966: NullPointerException is raised when RMB is clicked to show popup menu

The test gso_216:... Vadim Gindin