Project

General

Profile

Activity

From 10/07/2019 to 11/05/2019

11/05/2019

02:11 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
While checking the diff I found missed changes in @progress.g@ due to renaming. So the committed rev 11342 (4077a) lo... Sergey Ivanovskiy
02:03 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Yes, @uri.normalize()@ should do...
Hynek Cihlar
02:02 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Yes, @uri.normalize()@ should do it.
>
> So @toASCIIString()@...
Sergey Ivanovskiy
01:58 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Sergey Ivanovskiy wrote:
> Yes, @uri.normalize()@ should do it.
So @toASCIIString()@ is not needed, correct?
Hynek Cihlar
01:55 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Yes, @uri.normalize()@ should do it.
Please review the committed revision 11341 that fixed the rest of the found i...
Sergey Ivanovskiy
12:36 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Sergey Ivanovskiy wrote:
> This change @from urlString to uri.normalize().toASCIIString()@ is needed because @uri@ c...
Hynek Cihlar
11:56 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
This change @from urlString to uri.normalize().toASCIIString()@ is needed because @uri@ can point to the temporary fi... Sergey Ivanovskiy
11:34 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Hynek, it looks like you examined the old code because I did this change in rev 11340 - changed this constant @file:@... Sergey Ivanovskiy
11:28 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> >I don't think we need to fallback in a ~/fwd dir for a temp locat...
Hynek Cihlar
10:48 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Hynek Cihlar wrote:
>I don't think we need to fallback in a ~/fwd dir for a temp location. The Java runtime uses jav...
Sergey Ivanovskiy

11/04/2019

05:20 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Code review 4077a.
@KW_NOT_EMBEDDED@ should be shortened to 11 chars.
coping => copying
Does it make sense t...
Hynek Cihlar
01:16 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Hynek Cihlar wrote:
> The correct spelling should be NOT-EMBEDDED-CONTENT.
Please review the committed revision 113...
Sergey Ivanovskiy
11:29 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Is there a way to get rid of coping the target file content into...
Sergey Ivanovskiy
10:59 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Sergey Ivanovskiy wrote:
> NOT-EMBEDED-CONTENT represents that the given resource is not embedded into template ...
Hynek Cihlar
10:59 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Sergey Ivanovskiy wrote:
> Is there a way to get rid of coping the target file content into a temporary file?
Can...
Hynek Cihlar
08:00 AM Feature #4077 (Review): add option to OPEN-MIME-RESOURCE to delete the original source file when ...
Please review the committed revision 11339 (4077a). Now @OPEN-MIME-RESOURCE@ is defined by... Sergey Ivanovskiy
03:28 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
For the web client we copy the file and then deliver its copied content. This temporary file is deleted only after it... Sergey Ivanovskiy

11/01/2019

06:23 PM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Marius, note that @drop-procedure@ is no longer part of the conversion logic. Removing the init method was problemati... Hynek Cihlar
06:01 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Sergey Ivanovskiy wrote:
> However, for Linux we can use @lsof | grep "absolute file path"@ in order to check if thi...
Hynek Cihlar
05:53 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
Prepared this diff for the commit candidate. Sergey Ivanovskiy
05:02 PM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
However, for Linux we can use @lsof | grep "absolute file path"@ in order to check if this file is opened. Another wa... Sergey Ivanovskiy
05:29 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
For the swing client we open the target file by external programs which don't send us notifications that the target f... Sergey Ivanovskiy
12:09 PM Feature #3856: implement a widget that replaces the Microsoft ImageList OCX (VB 6.0 common control)
h2. ImageList OCX details
Unfortunately we cannot use the commons controls from @mscomctl.ocx@ to create OE uast t...
Marius Gligor

10/31/2019

10:50 AM Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...
The current implementation uses @WebBrowserManager.openMimeResource@ to generate java code for @OPEN-MIME-RESOURCE@. ... Sergey Ivanovskiy
10:38 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
1. I've finished to write the PROGRESS-BAR widget documentation
("Progress Indicator Widget and OCX Replacement":/p...
Marius Gligor
05:46 AM Bug #4377: Custom widget font does not influence the widget size and doesn't propagate from frame...
Layout calculation of some widgets depends on the set font, but only font number is considered, not the custom font. ... Hynek Cihlar
05:40 AM Bug #4377: Custom widget font does not influence the widget size and doesn't propagate from frame...
When font number is assigned to a widget, the widget size is adapted to accommodate the assigned font size. This does... Hynek Cihlar
05:38 AM Bug #4377 (New): Custom widget font does not influence the widget size and doesn't propagate from...
Hynek Cihlar

10/30/2019

10:18 AM Feature #4077 (WIP): add option to OPEN-MIME-RESOURCE to delete the original source file when the...
Sergey Ivanovskiy

10/29/2019

05:29 PM Bug #4135: high dpi screens display in low dpi
Committed revision 11343 (4135a) tried to fix the drawing issue from #4135-25. The root cause seems to be related to ... Sergey Ivanovskiy
05:21 PM Bug #4135 (Review): high dpi screens display in low dpi
Sergey Ivanovskiy
11:25 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Some thoughts regarding @PROGRESS-BAR@ implementation.
@PROGRESS-BAR@ widget is designed to replace the Microsoft ...
Marius Gligor

10/28/2019

09:29 AM Bug #4135: high dpi screens display in low dpi
OK. Please look at this screen shot.
!DemoWidgets1.png!
Sergey Ivanovskiy
09:06 AM Bug #4135: high dpi screens display in low dpi
> If I understand correctly we developed sub pixel conception for these half integers
No. The reason for the shif...
Greg Shah

10/27/2019

01:00 PM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
There might be issues in Hotel GUI, this is meant (for now) to work with 4069a. Constantin Asofiei
07:28 AM Bug #4135: high dpi screens display in low dpi
I checked a similar approach in which the offscreen canvas remains unscaled and when it is drawn onto the screen canv... Sergey Ivanovskiy

10/25/2019

11:25 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Hynek Cihlar wrote:
> Marius Gligor wrote:
> > It's possible to insert an AST node before another node, when both a...
Marius Gligor
10:06 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Marius Gligor wrote:
> It's possible to insert an AST node before another node, when both are siblings nodes?
You...
Hynek Cihlar
09:42 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
I'm struggle to convert my uast test with Hotel GUI application but did not work. Doing many tests and conversions fi... Marius Gligor
05:05 AM Bug #4135: high dpi screens display in low dpi
In this article another method to scale images is described. https://phoboslab.org/log/2012/09/drawing-pixels-is-hard Sergey Ivanovskiy

10/24/2019

12:38 PM Bug #4135: high dpi screens display in low dpi
Committed revision 11338 (4135a) has dirty changes that show the kind of changes that should be done. If we uncomment... Sergey Ivanovskiy
09:56 AM Bug #4135: high dpi screens display in low dpi
Now debugging this way to scale the given image on the javascript client, but as an alternative solution we can scale... Sergey Ivanovskiy
09:44 AM Bug #4135: high dpi screens display in low dpi
> I suspect that this approach can be slower than if the client gets an original image of proper quality. The other s... Greg Shah
05:46 AM Bug #4135: high dpi screens display in low dpi
Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > Can you just scale the smaller images into larger ones on the Javas...
Sergey Ivanovskiy
05:23 AM Bug #4135: high dpi screens display in low dpi
Greg Shah wrote:
> Can you just scale the smaller images into larger ones on the Javascript side? It seems useless ...
Sergey Ivanovskiy

10/23/2019

05:21 PM Bug #4135: high dpi screens display in low dpi
Can you just scale the smaller images into larger ones on the Javascript side? It seems useless to have Java send mo... Greg Shah
04:51 PM Bug #4135: high dpi screens display in low dpi
Created a new task branch 4135a for these changes. It needs to add new functionality to the java client that should s... Sergey Ivanovskiy

10/21/2019

06:43 PM Bug #4135: high dpi screens display in low dpi
I fixed coordinates for drawing primitives and realized that for this task we need to support icons and images that a... Sergey Ivanovskiy
11:35 AM Bug #4135: high dpi screens display in low dpi
This approach should work properly but following his way I got drawing issues. Then I tested it via this standalone t... Sergey Ivanovskiy
11:18 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
@IVBDataObject@ and @IVBDataObjectFiles@ are COM interfaces used to implement Drag & Drop.
1. On server side I imp...
Marius Gligor

10/20/2019

11:28 AM Bug #4135: high dpi screens display in low dpi
I suppose to detect high resolution screens by this media query and use it to define scaling factor 2.... Sergey Ivanovskiy
11:08 AM Bug #4135: high dpi screens display in low dpi
Sergey Ivanovskiy wrote:
> It seems that for high resolution screens we should follow this example from https://deve...
Sergey Ivanovskiy

10/18/2019

05:37 PM Bug #4135: high dpi screens display in low dpi
It seems that for high resolution screens we should follow this example from https://developer.mozilla.org/en-US/docs... Sergey Ivanovskiy
04:31 PM Bug #4135: high dpi screens display in low dpi
Constantin, thanks, I will test changes with Chrome and then provide the patch for this issue. There is another visio... Sergey Ivanovskiy
01:21 PM Bug #4135: high dpi screens display in low dpi
From the customer:
> This is seen on all high resolution displays, both Mac, Ubuntu and Windows. Although almost a...
Greg Shah
12:44 PM Bug #4135: high dpi screens display in low dpi
Sergey, Chrome has a feature where, after you open the Developer Tools, you can test a site how it looks on different... Constantin Asofiei
11:56 AM Bug #4135: high dpi screens display in low dpi
> Please provide the display resolution parameters for which the low graphics quality has been observed.
The custo...
Greg Shah
11:18 AM Bug #4135: high dpi screens display in low dpi
Please provide the display resolution parameters for which the low graphics quality has been observed.
These parame...
Sergey Ivanovskiy
09:47 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Hynek Cihlar wrote:
> Marius Gligor wrote:
> > My question is: Should we implement these interfaces as FWD @ComObje...
Marius Gligor
09:26 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Marius Gligor wrote:
> My question is: Should we implement these interfaces as FWD @ComObject@ objects and accessed ...
Hynek Cihlar
08:39 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Some @OCX Progress Bar@ event handlers for Drag & Drop operations are using a parameter of type @COM-HANDLE@:
<pre...
Marius Gligor

10/15/2019

01:45 PM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
> I could remove the OCX_ prefix to make the definition even more generic.
Yes, this would be good.
Greg Shah
03:26 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Marius Gligor wrote:
> Progress bar OCX mouse events are generic, the mouse button is an input parameter, that's why...
Hynek Cihlar
02:28 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Hynek Cihlar wrote:
> Marius Gligor wrote:
> > 2. Next, I added Mouse Events support to Progress Bar widget. Here I...
Marius Gligor
05:37 AM Bug #4135 (WIP): high dpi screens display in low dpi
Sergey Ivanovskiy
05:35 AM Bug #4135: high dpi screens display in low dpi
It seems that canvas image smoothing (anti-aliasing) properties can cause this effect of low graphics resolution. In ... Sergey Ivanovskiy

10/14/2019

12:15 PM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
Marius Gligor wrote:
> 2. Next, I added Mouse Events support to Progress Bar widget. Here I found a conversion issue...
Hynek Cihlar
11:29 AM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
1. I implemented the drawing code for progress bar for available UI themes.
Without having the possibility to do a P...
Marius Gligor

10/12/2019

10:19 AM Feature #3940 (Closed): CREATE-RESULT-LIST-ENTRY() method support
Greg Shah

10/11/2019

12:02 PM Feature #3858: implement a widget that replaces the Microsoft ProgressBar OCX (VB 6.0 common cont...
I attached some snapshots for an early implementation of PROGRESS-BAR widget, Classic UI Theme. The corresponding uas... Marius Gligor

10/10/2019

04:01 PM Feature #3940 (Review): CREATE-RESULT-LIST-ENTRY() method support
3816a has been merged into the trunk as bzr revision 11337. Stanislav Lomany
02:13 PM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
Rebased task branch 3816a from P2J trunk revision 11336. Stanislav Lomany
09:25 AM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
Yes, go ahead and merge. Constantin Asofiei
09:24 AM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
Constantin: Are we OK to merge to trunk?
We are from my perspective.
Greg Shah
09:28 AM Feature #3811: more misc UI features
FYI, the @MANUAL-HIGHLIGHT@ entry in @rules/gaps/expressions.rules@ was not updated:... Greg Shah
09:26 AM Feature #3811 (Closed): more misc UI features
With 3811b, the last of the changes (@MANUAL-HIGHLIGHT@) is in trunk. This task is complete. Greg Shah
04:01 AM Feature #3811: more misc UI features
Branch 3811b has been merged to trunk at rev 11336 and archived as merged. Marius Gligor

10/09/2019

12:58 PM Feature #3811: more misc UI features
Marius Gligor wrote:
> In class @GuiWebSocket.java@ I found the following method:
>
> [...]
>
> What I don't u...
Constantin Asofiei
12:54 PM Feature #3811: more misc UI features
In class @GuiWebSocket.java@ I found the following method:... Marius Gligor
11:07 AM Feature #3811: more misc UI features
Marius Gligor wrote:
> Maybe a better solution is to add more description to javadoc of drawRadioButton method, just...
Constantin Asofiei
11:06 AM Feature #3811: more misc UI features
Marius, OK, I understand now - the issue was that for FWD, the radio-buttons are individual widgets, and we cache the... Constantin Asofiei
09:26 AM Feature #3811: more misc UI features
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Marius Gligor wrote:
> > > After setting the background col...
Marius Gligor
08:56 AM Feature #3811: more misc UI features
Constantin Asofiei wrote:
> Marius Gligor wrote:
> > After setting the background color, the radio button image and...
Eugenie Lyzenko
08:52 AM Feature #3811: more misc UI features
I just tested. I added a simple @System.out.println(gd);@ when @RadioSetGuiImpl@ and @RadioButtonGuiImpl@ widgets are... Marius Gligor
08:33 AM Feature #3811: more misc UI features
On Swing and Web GUI driver the bgcolor is set when radio-set is drawing and seems to be used when draw radio-button ... Marius Gligor
08:17 AM Feature #3811: more misc UI features
Marius Gligor wrote:
> After setting the background color, the radio button image and radio label are drawing. (plea...
Constantin Asofiei
08:06 AM Feature #3811: more misc UI features
Constantin Asofiei wrote:
> Marius Gligor wrote:
> > Constantin, using your hint I quickly fixed the bug. Many than...
Marius Gligor
07:45 AM Feature #3811: more misc UI features
Marius Gligor wrote:
> Constantin, using your hint I quickly fixed the bug. Many thanks!
> Indeed, the @AbstractGu...
Constantin Asofiei
07:29 AM Feature #3811: more misc UI features
In the mean time I did a very small change which improve how highlight selection looks like (see attached pictures).
...
Marius Gligor
07:03 AM Feature #3811: more misc UI features
Great! Please run back through the GUI testing (Hotel GUI and your testcases).
Constantin: Any concerns with the f...
Greg Shah
06:38 AM Feature #3811: more misc UI features
Constantin, using your hint I quickly fixed the bug. Many thanks!
Indeed, the @AbstractGuiDriver.setColor@ MUST be ...
Marius Gligor

10/08/2019

02:24 PM Feature #3811: more misc UI features
Marius Gligor wrote:
> When next draw occur, the background color became @RED@, but the cached draw is send to @JS@....
Constantin Asofiei
11:27 AM Feature #3811: more misc UI features
Today I created two new simple uast tests for @radio-set@ widget as follow:
1 @uast/manual-highlight/radioset2.p@ ...
Marius Gligor
01:15 PM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
Stanislav Lomany wrote:
> > Stanislav, a quick note about the SharedVariableManager.lookupTempTable(String legacyNam...
Constantin Asofiei
05:41 AM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
> Stanislav, a quick note about the SharedVariableManager.lookupTempTable(String legacyName). Please make sure the le... Stanislav Lomany
04:21 AM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
> Then we have two failing tests. I'm looking into it.
Never mind. Regression testing passed. I just got two ident...
Stanislav Lomany

10/07/2019

01:58 PM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
Then we have two failing tests. I'm looking into it. Stanislav Lomany
12:31 PM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
Stanislav Lomany wrote:
> What are the know failing regression tests except tc_job_002?
The 'clock violation approv...
Constantin Asofiei
11:07 AM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
What are the know failing regression tests except tc_job_002? Stanislav Lomany
06:50 AM Feature #3940: CREATE-RESULT-LIST-ENTRY() method support
Stanislav, a quick note about the @SharedVariableManager.lookupTempTable(String legacyName)@. Please make sure the l... Constantin Asofiei
 

Also available in: Atom