FWD » Core Development » User Interface

06/18/2020

07:08 PM Bug #4631: Widget scoped to wrong frame on hide

The overall approach seems close. The one thing that looks wrong is line 1884 (@<action>addDictionaryObject("frame_e... Greg Shah

11:23 AM Feature #3880: enhanced browse 3rd phase of improvements

In Web client the @gui/driver/web/GuiWebDriver.java@ uses specific @X@ scaling factor for every font in use. This sho... Eugenie Lyzenko

10:32 AM Feature #3880: enhanced browse 3rd phase of improvements

Put this under @/server/default/@ or @/server/<server_name>/@:... Stanislav Lomany

10:29 AM Feature #3880: enhanced browse 3rd phase of improvements

What is the "simple" (single boolean flag) directory configuration for enabling enhanced mode? Greg Shah

09:06 AM Feature #3880: enhanced browse 3rd phase of improvements

> The scale factor should be different for Web as well as for Swing client. So why does the font chooser always uses ... Stanislav Lomany

07:09 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > The big concern here is that the web gives different results from Swing. Based on your ... Hynek Cihlar

09:01 AM Feature #4164: implement misc UI features (frame options, misc attributes)

As part of this task, there were changes to the @ThinClient.getFrameCol()@ method.
The original code:... Greg Shah

06/17/2020

07:23 PM Feature #3880: enhanced browse 3rd phase of improvements

> The big concern here is that the web gives different results from Swing. Based on your notes, I still don't unders... Stanislav Lomany

04:10 PM Feature #3880: enhanced browse 3rd phase of improvements

The font chooser case is not very important. If that was not working, it would be less of a concern.
The big conc... Greg Shah

04:02 PM Feature #3880: enhanced browse 3rd phase of improvements

> If scaling only happens for Swing, then why are the metrics for web the same (and wrong)?
It's not quite that wa... Stanislav Lomany

11:30 AM Bug #4631: Widget scoped to wrong frame on hide

I have an update that I'd like reviewed. It correctly converted the testcase, as well as the customer procedure. Are ... Roger Borrello

06/16/2020

07:46 PM Bug #4631: Widget scoped to wrong frame on hide

Should the @descent-rules@ both add the scope at the appropriate time, and include the rules that had been in place i... Roger Borrello

07:31 PM Feature #3880: enhanced browse 3rd phase of improvements

Are the metrics calculated before the scaling? The thing I don't understand is that the Swing browse draws everythin... Greg Shah

06:19 PM Feature #3880: enhanced browse 3rd phase of improvements

> Do we have accurate metrics that differ between Swing and web?
The metrics are the same, actual text size diff... Stanislav Lomany

10:23 AM Feature #3880: enhanced browse 3rd phase of improvements

> Do you have an idea what we're are doing about Graphics2D or something else that could cause this difference? Web v... Greg Shah

05:46 AM Feature #3880: enhanced browse 3rd phase of improvements

Regarding the font size: I found that actually may be it's not the case that a web font is larger, it's the case that... Stanislav Lomany

06/15/2020

08:12 AM Bug #4631: Widget scoped to wrong frame on hide

#4208-447 starts discussion of this same bug. This should be addressed before merging 4231b to trunk.
Constantin i... Roger Borrello

06/14/2020

11:25 AM Feature #3880: enhanced browse 3rd phase of improvements

3880a has been merged into 4231b as rev 11604. 3880a has been archived. Stanislav Lomany

06/13/2020

03:17 PM Bug #4671: Widget drag doesn't work in web

One can drag a widget once, but not for the second time.
Reproduction: drag the button, then try to drag it again. Stanislav Lomany

03:08 PM Bug #4671 (New): Widget drag doesn't work in web

Stanislav Lomany

02:56 PM Feature #3880: enhanced browse 3rd phase of improvements

Fix for web issues (web column/row resize) committed into 4231b as rev 11603.
BTW there's one more minor web issue... Stanislav Lomany

06/11/2020

03:07 PM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > Why is the row height static? It should be calculated based on whatever is being used at... Greg Shah

03:06 PM Feature #3880: enhanced browse 3rd phase of improvements

> I mean like this. We can make a tray, but why lose a row? In this case we'll be losing a row only if there are no s... Greg Shah

03:06 PM Feature #3880: enhanced browse 3rd phase of improvements

> Why is the row height static? It should be calculated based on whatever is being used at the time.
Currently, t... Stanislav Lomany

03:04 PM Feature #3880: enhanced browse 3rd phase of improvements

Code Review Task Branch 3880a Revisions 11347 through 11353
1. I really like the refactoring of the TC dialog proc... Greg Shah

02:32 PM Feature #3880: enhanced browse 3rd phase of improvements

I mean like this. We can make a tray, but why lose a row? In this case we'll be losing a row only if there are no scr... Stanislav Lomany

01:38 PM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > Can you see any case which this does not cover?
>
> If there is a vertical scrollbar ... Greg Shah

01:35 PM Feature #3880: enhanced browse 3rd phase of improvements

> Can you see any case which this does not cover?
If there is a vertical scrollbar and NO horizontal scrollbar, we... Stanislav Lomany

06:41 AM Feature #3880: enhanced browse 3rd phase of improvements

We will use the bottom right corner of the browse. In enhanced mode (simple boolean flag), we will always provide th... Greg Shah

06:29 AM Feature #3880: enhanced browse 3rd phase of improvements

!example.png! Stanislav Lomany

06:25 AM Feature #3880: enhanced browse 3rd phase of improvements

Please show an example. Greg Shah

06:24 AM Feature #3880: enhanced browse 3rd phase of improvements

Yes. Stanislav Lomany

06:21 AM Feature #3880: enhanced browse 3rd phase of improvements

Is it possible to have a horizontal scrollbar without a vertical scrollbar? Greg Shah

05:58 AM Feature #3880: enhanced browse 3rd phase of improvements

> * Is there always a vertical scrollbar?
It can be turned off.
> * Aren't there cases where there are row marker... Stanislav Lomany

08:02 PM Feature #3880: enhanced browse 3rd phase of improvements

* Is there always a vertical scrollbar?
* Aren't there cases where there are row markers?
* Please show the same c... Greg Shah

06/10/2020

05:44 PM Feature #3880: enhanced browse 3rd phase of improvements

> Please post examples of the possible states that we can see for the the browse (with different options active).
!b... Stanislav Lomany

05:24 PM Feature #3880: enhanced browse 3rd phase of improvements

Why is the row height static? It should be calculated based on whatever is being used at the time. I guess this mea... Greg Shah

05:20 PM Feature #3880: enhanced browse 3rd phase of improvements

User changes font in web version, we set row height according to web font metrics, everything is looking nice. If the... Stanislav Lomany

05:14 PM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > I suppose that means you must determine what the minimum safe row height will be for tha... Greg Shah

04:53 PM Feature #3880: enhanced browse 3rd phase of improvements

> I suppose that means you must determine what the minimum safe row height will be for that font and implement it.
... Stanislav Lomany

04:46 PM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > Are you talking about item 3.2 from #3880-4?
>
> Yes.
This is a user override, so ... Greg Shah

04:38 PM Feature #3880: enhanced browse 3rd phase of improvements

> Are you talking about item 3.2 from #3880-4?
Yes. Stanislav Lomany

04:21 PM Feature #3880: enhanced browse 3rd phase of improvements

>> The upper left corner of the browse has no purpose, in enhanced mode it will be drawn as a gear icon instead of th... Greg Shah

03:33 PM Feature #3880: enhanced browse 3rd phase of improvements

> Your found difference is especially large. Normally we don't see a difference that big. The use of multiple W cha... Stanislav Lomany

03:29 PM Feature #3880: enhanced browse 3rd phase of improvements

> The upper left corner of the browse has no purpose, in enhanced mode it will be drawn as a gear icon instead of the... Stanislav Lomany

03:23 PM Feature #3880: enhanced browse 3rd phase of improvements

There is no way to get exactly the same results as the 4GL, even with the same exact fonts being used. We employ a r... Greg Shah

02:56 PM Feature #3880: enhanced browse 3rd phase of improvements

Guys, all (most?) of the fonts look bigger in a browser compared to a standalone app. The lager the font, the bigger ... Stanislav Lomany

03:29 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> Some thoughts:
> # @MouseHoverAction@ is registered using @GuiWebDriver.registerHoverable... Hynek Cihlar

06/09/2020

04:37 PM Feature #3880: enhanced browse 3rd phase of improvements

Some thoughts:
# @MouseHoverAction@ is registered using @GuiWebDriver.registerHoverableWidget@ on the JS side and do... Stanislav Lomany

06/06/2020

12:15 PM Bug #4135: high dpi screens display in low dpi

From the customer:
> The file HotelDemoDPR2.png is looking good. Text looks sharp.
>
> As mentioned earlier in ... Greg Shah

12:10 PM Feature #4661: add support for missing formats to image loading

The 4GL uses Windows OS features for its image support. This is the known list (at this time) of supported 4GL image... Greg Shah

11:57 AM Feature #4661 (Closed): add support for missing formats to image loading

Greg Shah

06/05/2020

11:34 AM Feature #3880: enhanced browse 3rd phase of improvements

> Thanks, I tested @browse-simple.p@ with 4231b and Firefox 76.0.1 on Ubuntu. It seems that the resizing column works... Stanislav Lomany

07:01 AM Feature #3880: enhanced browse 3rd phase of improvements

> and create a new bug issue related to resizing and work on these issues because it seems that they are not related ... Greg Shah

04:12 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> Sergey, it doesn't work. Should I explicitly create @MouseHoverAction@ for browse column? ... Hynek Cihlar

02:19 AM Feature #3880: enhanced browse 3rd phase of improvements

Thanks, I tested @browse-simple.p@ with 4231b and Firefox 76.0.1 on Ubuntu. It seems that the resizing column works p... Sergey Ivanovskiy

08:27 PM Feature #3880: enhanced browse 3rd phase of improvements

> What test case can help to reproduce these issues?
Is is attached: if you try to resize a row, you'll notice that ... Stanislav Lomany

06/04/2020

09:49 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> Sergey, it doesn't work. Should I explicitly create @MouseHoverAction@ for browse column? ... Sergey Ivanovskiy

09:09 AM Feature #3880: enhanced browse 3rd phase of improvements

Actually, area is defined in @MouseDirectManipulation@, but it doesn't work because of the problem noted above. So sh... Stanislav Lomany

09:00 AM Feature #3880: enhanced browse 3rd phase of improvements

Sergey, it doesn't work. Should I explicitly create @MouseHoverAction@ for browse column? How can I specify a hoverab... Stanislav Lomany

01:54 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> It is interesting that _column_ resize is implemented in @BrowseColumnGuiImpl.mouseMoved@ ... Sergey Ivanovskiy

06/03/2020

02:56 PM Feature #3880: enhanced browse 3rd phase of improvements

It is interesting that _column_ resize is implemented in @BrowseColumnGuiImpl.mouseMoved@ (it works), while _row_ res... Stanislav Lomany

01:27 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > MS Tree View doesn't expose @SEL... Hynek Cihlar

06/02/2020

02:20 PM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > MS Tree View doesn't expose @SELECTED-NODE@, but its node expose... Sergey Ivanovskiy

01:55 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> MS Tree View doesn't expose @SELECTED-NODE@, but its node exposes @SELECTED@ attribute. @... Hynek Cihlar

01:43 PM Feature #4170: add drag and drop support to treeview widget

MS Tree View doesn't expose @SELECTED-NODE@, but its node exposes @SELECTED@ attribute. @SELECTED-NODE@ is a FWD exte... Sergey Ivanovskiy

11:13 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > Sergey Ivanovskiy wrote:
> > > It seems only @DropHighLight@ is no... Hynek Cihlar

10:49 AM Feature #4170: add drag and drop support to treeview widget

Yes, I set it to 100%. Sergey Ivanovskiy

10:39 AM Feature #4170: add drag and drop support to treeview widget

Is this task ready for test status/100% completed? Greg Shah

10:34 AM Feature #4170: add drag and drop support to treeview widget

Greg Shah wrote:
> Sergey Ivanovskiy wrote:
> > It seems only @DropHighLight@ is not implemented but it can be impl... Sergey Ivanovskiy

10:17 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> It seems only @DropHighLight@ is not implemented but it can be implemented as @SELECTED-N... Greg Shah

10:09 AM Feature #4170: add drag and drop support to treeview widget

It seems only @DropHighLight@ is not implemented but it can be implemented as @SELECTED-NODE@ until new logic will no... Sergey Ivanovskiy

09:57 AM Feature #4170: add drag and drop support to treeview widget

This property ... Sergey Ivanovskiy

09:24 AM Feature #4170: add drag and drop support to treeview widget

Is there any remaining work for this task? Greg Shah

07:40 AM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > I don't know all requirements, the first assumption was that if ... Sergey Ivanovskiy

02:48 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> I don't know all requirements, the first assumption was that if expand icon was not set d... Hynek Cihlar

06/01/2020

02:11 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Committed revision 11575 and 115... Sergey Ivanovskiy

02:00 PM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Committed revision 11575 and 11574 (4231b) fixed the found issue... Sergey Ivanovskiy

12:35 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Hynek Cihlar wrote:
> > > > Ser... Hynek Cihlar

12:30 PM Feature #4170: add drag and drop support to treeview widget

I see that there are @setNodeIcon@ and @setExpandNodeIcon@ with the same parameter of @BaseDataType@. The original co... Sergey Ivanovskiy

12:25 PM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek Cihlar wrote:
> > > Sergey Ivanovskiy wrote:
> > > > Com... Sergey Ivanovskiy

11:47 AM Feature #4170: add drag and drop support to treeview widget

Eugenie Lyzenko wrote:
> >If so, Constantin made some updates in *4231b-11576* that fixed something that started in ... Hynek Cihlar

11:45 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Committed revision 11575 and 115... Hynek Cihlar

11:20 AM Feature #4170: add drag and drop support to treeview widget

Roger Borrello wrote:
> Eugenie Lyzenko wrote:
> > Guys,
> >
> > Starting with @11569@ the @4231b@ has still a c... Eugenie Lyzenko

11:15 AM Feature #4170: add drag and drop support to treeview widget

Eugenie Lyzenko wrote:
> Guys,
>
> Starting with @11569@ the @4231b@ has still a conversion regression for custom... Roger Borrello

09:39 AM Feature #4170: add drag and drop support to treeview widget

Guys,
Starting with @11569@ the @4231b@ has still a conversion regression for customer's application. Is somebody ... Eugenie Lyzenko

07:34 AM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Committed revision 11575 and 11574 (4231b) fixed the found issue... Sergey Ivanovskiy

02:18 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > The issue from #4170-167 was due... Hynek Cihlar

02:12 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Committed revision 11575 and 11574 (4231b) fixed the found issues.
Code review 4231b r... Hynek Cihlar

01:41 PM Feature #3880: enhanced browse 3rd phase of improvements

Constantin Asofiei wrote:
> I think the problem is global; I'm having issues with dragging a button in FWD, on both ... Sergey Ivanovskiy

01:11 PM Feature #3880: enhanced browse 3rd phase of improvements

Constantin Asofiei wrote:
> I think the problem is global; I'm having issues with dragging a button in FWD, on both ... Sergey Ivanovskiy

05/29/2020

03:10 PM Feature #3880: enhanced browse 3rd phase of improvements

> In Chrome, first drag works, after that it no longer works.
I can confirm the issue. After the dragging fix, it ... Stanislav Lomany

02:35 PM Feature #3880: enhanced browse 3rd phase of improvements

Guys, what FWD feature supports dragging files from OS so I can check that it works? Stanislav Lomany

01:27 PM Feature #3880: enhanced browse 3rd phase of improvements

Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > This looks like is Eugenie's, from trunk rev 11770:
> >
>... Hynek Cihlar

12:33 PM Feature #3880: enhanced browse 3rd phase of improvements

Greg Shah wrote:
> What about drag and drop between windows (across canvas instances)?
I'm not aware of any use c... Hynek Cihlar

10:31 AM Feature #3880: enhanced browse 3rd phase of improvements

Constantin Asofiei wrote:
> This looks like is Eugenie's, from trunk rev 11770:
> [...]
>
> Eugenie: do you reca... Eugenie Lyzenko

09:01 AM Feature #3880: enhanced browse 3rd phase of improvements

I think the problem is global; I'm having issues with dragging a button in FWD, on both Chrome and Firefox. See this... Constantin Asofiei

08:09 AM Feature #3880: enhanced browse 3rd phase of improvements

What about drag and drop between windows (across canvas instances)? Greg Shah

08:03 AM Feature #3880: enhanced browse 3rd phase of improvements

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek: can the body draggable setting affect the other cases of... Hynek Cihlar

08:01 AM Feature #3880: enhanced browse 3rd phase of improvements

Constantin Asofiei wrote:
> Hynek: can the body draggable setting affect the other cases of movable/resizeable widge... Hynek Cihlar

07:35 AM Feature #3880: enhanced browse 3rd phase of improvements

This looks like is Eugenie's, from trunk rev 11770:... Constantin Asofiei

06:08 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> OK, HTML @body@ was explicitly defined draggable for some reason. So, on every drag in fir... Hynek Cihlar

05:58 AM Feature #3880: enhanced browse 3rd phase of improvements

Sergey/Hynek/Constantin: Please review.
Sergey: the important parts are from #3880-44 to #3880-63. Greg Shah

05:17 AM Feature #3880: enhanced browse 3rd phase of improvements

OK, HTML @body@ was explicitly defined draggable for some reason. So, on every drag in firefox we were dragging @body... Stanislav Lomany

02:53 PM Feature #4170: add drag and drop support to treeview widget

Committed revision 11575 and 11574 (4231b) fixed the found issues.
Sergey Ivanovskiy

09:41 AM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > The issue from #4170-167 was due to @comhandle.resourceId@ usage... Sergey Ivanovskiy

04:56 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> The issue from #4170-167 was due to @comhandle.resourceId@ usages in @comhandle.compareTo... Hynek Cihlar

04:47 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Thank you for this review. Could you advise the proper place for @ErrorManager.ErrorReaso... Hynek Cihlar

04:47 AM Feature #4170: add drag and drop support to treeview widget

Working on the review fixes and javadocs, planning to commit ASAP. Sergey Ivanovskiy

04:43 AM Feature #4170: add drag and drop support to treeview widget

The issue from #4170-167 was due to @comhandle.resourceId@ usages in @comhandle.compareTo@ that is used from object @... Sergey Ivanovskiy

03:48 AM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > These changes with @treeview/test-image-list-1.w@ reproduced #41... Sergey Ivanovskiy

03:15 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> These changes with @treeview/test-image-list-1.w@ reproduced #4170-147.
Code review 41... Hynek Cihlar

05/28/2020

06:14 PM Feature #4170: add drag and drop support to treeview widget

Today I found this helpful article about MS Tree but some information was already discovered manually using 4GL code ... Sergey Ivanovskiy

05:59 PM Feature #4170: add drag and drop support to treeview widget

These changes with @treeview/test-image-list-1.w@ reproduced #4170-147. Sergey Ivanovskiy

05:49 PM Feature #4170: add drag and drop support to treeview widget

I delayed to commit my changes until the following issue was resolved. The same code ... Sergey Ivanovskiy

05/27/2020

02:00 PM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > Also, you should use 4231b because there were many improvements in the drag/drop code in... Hynek Cihlar

11:48 AM Feature #3880: enhanced browse 3rd phase of improvements

To make sure we're on the same page. That's how drag works for me in the latest firefox: https://youtu.be/4XY0TKhKFRY... Stanislav Lomany

10:38 AM Feature #3880: enhanced browse 3rd phase of improvements

> Also, you should use 4231b because there were many improvements in the drag/drop code in that branch.
Yes, in ch... Stanislav Lomany

09:02 AM Feature #3880: enhanced browse 3rd phase of improvements

I think we will be trying to clean it up and get it into trunk over the next two weeks. We have known issues for thi... Greg Shah

08:58 AM Feature #3880: enhanced browse 3rd phase of improvements

> If it is safe to do so, put 3880a into 4231b. You've tested your changes in both enhanced and non-enhanced modes?
... Stanislav Lomany

08:02 AM Feature #3880: enhanced browse 3rd phase of improvements

If it is safe to do so, put 3880a into 4231b. You've tested your changes in both enhanced and non-enhanced modes? Greg Shah

06:59 AM Feature #3880: enhanced browse 3rd phase of improvements

> Also, you should use 4231b because there were many improvements in the drag/drop code in that branch.
Maybe it i... Stanislav Lomany

05:55 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> Right. I start dragging, then dragging on canvas stops, HTML dragging starts and we have p... Constantin Asofiei

05:53 AM Feature #3880: enhanced browse 3rd phase of improvements

Right. I start dragging, then dragging on canvas stops, HTML dragging starts and we have picture like in #3880-44. Stanislav Lomany

05:48 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > This resize must happen on the canvas, and driven by the FWD JS driver...
>
> Right,... Constantin Asofiei

05:45 AM Feature #3880: enhanced browse 3rd phase of improvements

> This resize must happen on the canvas, and driven by the FWD JS driver...
Right, it should, but it happens in H... Stanislav Lomany

05/26/2020

06:41 PM Feature #3880: enhanced browse 3rd phase of improvements

Also, you should use 4231b because there were many improvements in the drag/drop code in that branch. Greg Shah

06:08 PM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav, you can see how @TREELIST@ column move and resize is implemented in @TreeListCaptionItem@. Hynek Cihlar

05:55 PM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav, if I'm not mistaken Hynek implemented in FWD the resize for legacy 4GL widgets (part of the 'direct manipu... Constantin Asofiei

05:38 PM Feature #3880: enhanced browse 3rd phase of improvements

> # In firefox, when I press mouse within a window, HTML drag start if I do a vertical mouse move.
It is not verti... Stanislav Lomany

01:50 PM Feature #3880: enhanced browse 3rd phase of improvements

> If you have any remaining questions, please post the list ASAP.
Guys, please consider mouse dragging:
# In chro... Stanislav Lomany

06:44 AM Bug #3690 (Test): BUTTON widget reaction on SPACEBAR and ENTER keys

Greg Shah

05:35 AM Bug #3690 (Review): BUTTON widget reaction on SPACEBAR and ENTER keys

Adrian Lungu

05/25/2020

03:33 PM Feature #4170: add drag and drop support to treeview widget

The following code doesn't warn about the same index and the list images count becomes 3.... Sergey Ivanovskiy

09:47 AM Feature #4170: add drag and drop support to treeview widget

In this example the same @OlePictureObject@ is added to image list widget with different keys and the result images h... Sergey Ivanovskiy

10:24 AM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs

Added missing history entry in 4231b/rev.11559. Adrian Lungu

09:30 AM Bug #4624 (Test): Fill-in: StringIndexOutOfBoundsException and other bugs

Greg Shah

08:23 AM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs

Greg Shah wrote:
> Did you review rev 11556 as well?
Yes. Constantin Asofiei

08:23 AM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs

Did you review rev 11556 as well? Greg Shah

08:17 AM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs

The changes make sense. Only issue is @WinKeyboardReader.java@ which is missing history entry. Constantin Asofiei

08:05 AM Bug #4624: Fill-in: StringIndexOutOfBoundsException and other bugs

Constantin: Please review. Greg Shah

07:44 AM Bug #4624 (Review): Fill-in: StringIndexOutOfBoundsException and other bugs

Problem 3 was solved in 4231b/rev. 11558. The bug was triggered by incorrect resizing of the text when explicit forma... Adrian Lungu

05/24/2020

05:31 PM Feature #3880: enhanced browse 3rd phase of improvements

You've been looking into this for a week. At this point, I'm guessing you have enough understanding about how the mo... Greg Shah

05/22/2020

12:42 PM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, I didn't understand what you meant by "If image removal i... Sergey Ivanovskiy

12:05 PM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Hynek, I didn't understand what you meant by "If image removal is not implemented yet, th... Hynek Cihlar

11:37 AM Feature #4170: add drag and drop support to treeview widget

Hynek, I didn't understand what you meant by "If image removal is not implemented yet, then the index caching is OK."... Sergey Ivanovskiy

11:28 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> > When one of the images (@ListImage@) is destroyed or removed the image index will have ... Hynek Cihlar

08:18 AM Feature #4170: add drag and drop support to treeview widget

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Please review rev 11550 (4231b) that implemented @LOAD-PICTURE@ ... Sergey Ivanovskiy

06:30 AM Feature #4170: add drag and drop support to treeview widget

Sergey Ivanovskiy wrote:
> Please review rev 11550 (4231b) that implemented @LOAD-PICTURE@ and @ADD@ with complete s... Hynek Cihlar

12:21 PM Bug #4624 (WIP): Fill-in: StringIndexOutOfBoundsException and other bugs

Solved the following issues:
# Prevented text sliding when deleting while the cursor is at the end
# Fixed bad care... Adrian Lungu

05/21/2020

06:28 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Also all panels in @CalendarPopup@ except the @daysInMonthPanel@ should not be widget fields, since they are referenc... Vladimir Tsichevski

05:33 PM Feature #4174: implement calendar control/dtpicker OCX replacement

I suppose declarations like the following should read _leading_ instead of _trailing_ since we mean something _before... Vladimir Tsichevski

01:35 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Fixed in rev 11555 (4231b). Sergey Ivanovskiy

12:32 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Vladimir Tsichevski wrote:
> Sergey Ivanovskiy wrote:
> > Committed revision 11553 (4231b) Fixed #4174-191, extract... Sergey Ivanovskiy

12:07 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Sergey Ivanovskiy wrote:
> Committed revision 11553 (4231b) Fixed #4174-191, extracted @CalendarPopup@, @CalendarMon... Vladimir Tsichevski

10:53 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Committed revision 11553 (4231b) Fixed #4174-191, extracted @CalendarPopup@, @CalendarMonthModel@, added @ButtonFacto... Sergey Ivanovskiy

06:20 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Planning to refactor CalendarGuiImpl in order that CalendarPopup can be used independently and to commit today. Sergey Ivanovskiy

03:39 AM Feature #4170: add drag and drop support to treeview widget

It seems that @OlePictureObject@ is exported by @olepro32.dll@ or @oleaut32.dll@, @https://www.nirsoft.net/utils/dll_... Sergey Ivanovskiy

03:02 AM Feature #4170: add drag and drop support to treeview widget

@LOAD-PICTURE@ should return @OlePictureObject@ according to Progress Docs. It needs to add this new com object to FW... Sergey Ivanovskiy

05/20/2020

06:32 PM Feature #4170: add drag and drop support to treeview widget

Working on the issue from #4170-135.
Sergey Ivanovskiy

06:29 PM Feature #4170: add drag and drop support to treeview widget

Please review rev 11550 (4231b) that implemented @LOAD-PICTURE@ and @ADD@ with complete set of parameters. I tested w... Sergey Ivanovskiy

04:26 AM Feature #4170: add drag and drop support to treeview widget

Planning to test and to commit this diff that should implement LOAD-PICTURE, ADD with icons according to #4170-115. Sergey Ivanovskiy

05:55 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Vladimir Tsichevski wrote:
> The following code looks suspicious (line 1168):
>
> [...]
>
> If the new value i... Sergey Ivanovskiy

05:45 PM Feature #4174: implement calendar control/dtpicker OCX replacement

The following code looks suspicious (line 1168):... Vladimir Tsichevski

05:31 PM Feature #4174: implement calendar control/dtpicker OCX replacement

Vladimir Tsichevski wrote:
> The argument of the following constructor is not used:
> [...]
>
> Meanwhile, there... Vladimir Tsichevski

05:21 PM Feature #4174: implement calendar control/dtpicker OCX replacement

The argument of the following constructor is not used:... Vladimir Tsichevski

11:15 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Constantin Asofiei wrote:
> Vladimir Tsichevski wrote:
> > Constantin Asofiei wrote:
> > > Vladimir, please try to... Vladimir Tsichevski

11:11 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
> > Vladimir, please try to set the calendar's parent via @c... Sergey Ivanovskiy

11:03 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
> > Vladimir, please try to set the calendar's parent via @c... Constantin Asofiei

09:16 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Constantin Asofiei wrote:
> Vladimir, please try to set the calendar's parent via @calendarWidget.setParent(this)@, ... Vladimir Tsichevski

09:37 AM Bug #4631: Widget scoped to wrong frame on hide

Added @uast/frames/frame_broken_hide.p@ testcase, which also exhibits runtime issues with a widget being passed in wh... Roger Borrello