Activity
From 06/06/2020 to 07/05/2020
07/03/2020
- 02:49 AM Feature #4730 (New): Implement support for custom fonts on individual nodes of a TREEVIEW (and TR...
06/30/2020
- 04:35 PM Feature #4661: add support for missing formats to image loading
- I don't think a testcase is really necessary, in that the customer application is already utilizing @gif@ images on b...
- 08:30 AM Feature #4661: add support for missing formats to image loading
- Greg Shah wrote:
> Roger: Prepare some simple 4GL samples that try to load @.gif@, @.png@ and @.svg@ from files. Yo... - 08:12 AM Feature #4661: add support for missing formats to image loading
- Roger: Prepare some simple 4GL samples that try to load @.gif@, @.png@ and @.svg@ from files. You can test this pure...
- 08:10 AM Feature #4661: add support for missing formats to image loading
- Can you make a summary of what Roger would have to do (e.g. something like "look at classes X, Y and Z, method A and ...
06/29/2020
- 06:33 PM Feature #4661: add support for missing formats to image loading
- Greg Shah wrote:
> Our SVG support can be seen in @com.goldencode.p2j.ui.client.gui.VectorGraphicsHelper@. I see th... - 06:26 PM Feature #4661: add support for missing formats to image loading
- Roger Borrello wrote:
> Is this the location to look for additional plug-ins? -> https://github.com/haraldk/TwelveMo... - 02:48 PM Feature #4661: add support for missing formats to image loading
- Our SVG support can be seen in @com.goldencode.p2j.ui.client.gui.VectorGraphicsHelper@. I see that we have the abili...
- 02:12 PM Feature #4661: add support for missing formats to image loading
- Is this the location to look for additional plug-ins? -> https://github.com/haraldk/TwelveMonkeys
It seems @gif@ i...
06/22/2020
- 04:30 PM Feature #4164: implement misc UI features (frame options, misc attributes)
- Code Review Task Branch 3821c Revision 11358
This seems better. Confirm it with testing. - 10:16 AM Feature #4164: implement misc UI features (frame options, misc attributes)
- This was implemented in @3821c-11358@. Please review, and let me know if there's a way to run an individual test for ...
- 08:20 AM Feature #4164: implement misc UI features (frame options, misc attributes)
- Roger Borrello wrote:
> If @ConfigHelper.getAssignedRow(frame.config())@ can return @BaseConfig.INV_COORD@ as well, ... - 08:16 AM Feature #4164: implement misc UI features (frame options, misc attributes)
- Greg Shah wrote:
> Code Review Task Branch 3821c Revision 11354
>
> This is incorrect. @ConfigHelper.getAssigned... - 06:50 AM Feature #4164: implement misc UI features (frame options, misc attributes)
- Code Review Task Branch 3821c Revision 11354
This is incorrect. @ConfigHelper.getAssignedColumn(frame.config())@ ... - 09:28 PM Feature #4164: implement misc UI features (frame options, misc attributes)
- Greg Shah wrote:
> As part of this task, there were changes to the @ThinClient.getFrameCol()@ method.
>
> I've ba... - 07:04 AM Feature #4170: add drag and drop support to treeview widget
- Is there any remaining work or testing needed for this task?
- 06:39 AM Bug #4631 (Test): Widget scoped to wrong frame on hide
- Code Review Task Branch 3821c Revision 11353
The changes are good. - 09:26 PM Bug #4631: Widget scoped to wrong frame on hide
- Greg Shah wrote:
> Was this with the version that had removed the @addDictionaryObject()@ which I asked about?
>
...
06/21/2020
- 07:28 PM Feature #3880: enhanced browse 3rd phase of improvements
- I assume that @ScrollPaneGuiImpl@ needs a change that gives more control over its positioning, sizing or over the dra...
- 07:26 PM Feature #3880: enhanced browse 3rd phase of improvements
- I don't think it makes sense to have an enhanced browse menu button inside a scrolling helper class.
- 07:06 PM Feature #3880: enhanced browse 3rd phase of improvements
- > Can't the scrollbars be sized and positioned so that they don't overlap the space for the gear icon?
Sorry, don'... - 07:00 PM Feature #3880: enhanced browse 3rd phase of improvements
- You can subclass it if that is the best way. But it seems like the gear icon will always be there in this mode, so w...
- 06:55 PM Feature #3880: enhanced browse 3rd phase of improvements
- > I don't know the answer here, but I wouldn't want a generic helper class to have a browse-specific feature.
If t... - 06:50 PM Feature #3880: enhanced browse 3rd phase of improvements
- We should not take up more space than the 4GL compatible version. Instead we "sacrifice" a row.
> X-1 rows, but ... - 10:46 AM Feature #3880: enhanced browse 3rd phase of improvements
- Greg, I have a question about the "tray" which should appear if there are no scrollbars and we want to find a place f...
06/20/2020
- 12:11 PM Bug #4589 (Closed): menu case sensitivity and conversion
- Task branch 4231b has been merged to trunk as revision 11347.
- 12:06 PM Bug #4074 (Closed): Mismatching ROW-ENTRY/LEAVE events
- Task branch 4231b has been merged to trunk as revision 11347.
- 12:04 PM Bug #3690 (Closed): BUTTON widget reaction on SPACEBAR and ENTER keys
- Task branch 4231b has been merged to trunk as revision 11347.
- 12:03 PM Bug #4624 (Closed): Fill-in: StringIndexOutOfBoundsException and other bugs
- Task branch 4231b has been merged to trunk as revision 11347.
- 12:02 PM Feature #2683: reverse proxy implementation
- Task branch 4231b has been merged to trunk as revision 11347.
- 12:00 PM Feature #4164: implement misc UI features (frame options, misc attributes)
- Task branch 4231b has been merged to trunk as revision 11347.
- 12:00 PM Feature #4393 (Closed): add TITLE-DCOLOR attribute support
- Task branch 4231b has been merged to trunk as revision 11347.
- 12:00 PM Feature #4394 (Closed): add some frame options and attributes
- Task branch 4231b has been merged to trunk as revision 11347.
- 11:52 AM Feature #3876: add support for "direct font control" at the widget level
- Task branch 4231b has been merged to trunk as revision 11347.
- 11:52 AM Feature #3880: enhanced browse 3rd phase of improvements
- Task branch 4231b has been merged to trunk as revision 11347.
- 11:43 AM Feature #3880: enhanced browse 3rd phase of improvements
- The generic (no user version) of the URL should continue to work as well.
- 11:42 AM Feature #3880: enhanced browse 3rd phase of improvements
- The idea is that the user would have the URL bookmarked which would map to the right user name. Then the login form ...
- 11:08 AM Feature #3880: enhanced browse 3rd phase of improvements
- Greg Shah wrote:
> Yes, but by doing it this way the local storage would be specific to the user instead of the mach... - 11:05 AM Feature #3880: enhanced browse 3rd phase of improvements
- Yes, but by doing it this way the local storage would be specific to the user instead of the machine. It isn't secur...
- 11:01 AM Feature #3880: enhanced browse 3rd phase of improvements
- Greg Shah wrote:
> Correct.
>
> A variant of this idea: if the initial URL had a user-account component (@https:/... - 10:57 AM Feature #3880: enhanced browse 3rd phase of improvements
- Correct.
A variant of this idea: if the initial URL had a user-account component (@https://<host>:<port>/gui/<os_u... - 10:41 AM Feature #3880: enhanced browse 3rd phase of improvements
- Hynek Cihlar wrote:
> Wouldn't the cookie be subject of CORS when it would be read on a different port (not mentioni... - 10:38 AM Feature #3880: enhanced browse 3rd phase of improvements
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > Does anyone see a better alternative?
... - 10:34 AM Feature #3880: enhanced browse 3rd phase of improvements
- > Crazy-lazy idea: we could identify the client using the available browser information (agent, resolution, OS, versi...
- 10:13 AM Feature #3880: enhanced browse 3rd phase of improvements
- Hynek Cihlar wrote:
> Greg Shah wrote:
> > Does anyone see a better alternative?
>
> Crazy-lazy idea: we could i... - 10:12 AM Feature #3880: enhanced browse 3rd phase of improvements
- Greg Shah wrote:
> Does anyone see a better alternative?
Crazy-lazy idea: we could identify the client using the ... - 09:08 AM Feature #3880: enhanced browse 3rd phase of improvements
- Stanislav Lomany wrote:
> What I see:
> # Start an app and save a configuration. In local storage browser I see tha... - 04:16 AM Feature #3880: enhanced browse 3rd phase of improvements
- I am using these settings for the web client:...
- 11:51 AM Feature #4174: implement calendar control/dtpicker OCX replacement
- Task branch 4231b has been merged to trunk as revision 11347.
- 11:50 AM Feature #4170: add drag and drop support to treeview widget
- Task branch 4231b has been merged to trunk as revision 11347.
- 11:50 AM Bug #4636: Make the Theme API independent on concrete implementation classes
- Task branch 4231b has been merged to trunk as revision 11347.
- 10:18 AM Bug #4631: Widget scoped to wrong frame on hide
- Was this with the version that had removed the @addDictionaryObject()@ which I asked about?
If so, does that same ...
06/19/2020
- 07:32 PM Feature #3880: enhanced browse 3rd phase of improvements
- Sure!
I just need to resolve this ports story for my local configuration. - 07:24 PM Feature #3880: enhanced browse 3rd phase of improvements
- I tested also with saving "All browses, Current User". The result after cold restart was all tables changes backgroun...
- 07:08 PM Feature #3880: enhanced browse 3rd phase of improvements
- I built FWD with these changes and applied them to Hotel GUI with @deploy.prepare@. Then cleaned all localStorage and...
- 07:00 PM Feature #3880: enhanced browse 3rd phase of improvements
- What I see:
# Start an app and save a configuration. In local storage browser I see that the configuration is saved ... - 06:56 PM Feature #3880: enhanced browse 3rd phase of improvements
- Sorry, I forgot to mention it! Please test it while saving configuration for "This Browse, Current User" (or "All bro...
- 06:51 PM Feature #3880: enhanced browse 3rd phase of improvements
- Stanislav Lomany wrote:
> > It seems that now the browse configuration is restored.
>
> For me configuration is ... - 06:49 PM Feature #3880: enhanced browse 3rd phase of improvements
- At least the cell's background color, height and font were persisted across the server restarts.
- 06:49 PM Feature #3880: enhanced browse 3rd phase of improvements
- > It seems that now the browse configuration is restored.
For me configuration is still not loaded after server r... - 06:43 PM Feature #3880: enhanced browse 3rd phase of improvements
- #3880-141 Thank you, I know:)
- 06:40 PM Feature #3880: enhanced browse 3rd phase of improvements
- Stanislav Lomany wrote:
> Well, I don't like new line symbol within a key and double quoting. But I'm not sure if th... - 05:51 PM Feature #3880: enhanced browse 3rd phase of improvements
- Well, I don't like new line symbol within a key and double quoting. But I'm not sure if that's an issue.
So, sorry, ... - 05:47 PM Feature #3880: enhanced browse 3rd phase of improvements
- Yes, it looks like an issue. How it can be happened?
- 05:42 PM Feature #3880: enhanced browse 3rd phase of improvements
- The first I checked that the @localStorage@ has the same key and value after the server has been restarted. I observe...
- 05:34 PM Feature #3880: enhanced browse 3rd phase of improvements
- > Planning to debug what was the issue.
I think I found the bug:... - 05:27 PM Feature #3880: enhanced browse 3rd phase of improvements
- User configurations can be "for all users" and user-specific. "For all users" are saved in the directory. User-specif...
- 05:24 PM Feature #3880: enhanced browse 3rd phase of improvements
- It is not obvious for me that the issue is the serialization/deserealization from the web @localStorage@. Planning to...
- 05:21 PM Feature #3880: enhanced browse 3rd phase of improvements
- In this case it seems that the browse configuration doesn't read after the user is logged out and it is saved on the ...
- 05:15 PM Feature #3880: enhanced browse 3rd phase of improvements
- > Yes, after the server has been restarted the configuration was not retrieved but it is not because of the different...
- 05:07 PM Feature #3880: enhanced browse 3rd phase of improvements
- Stanislav Lomany wrote:
> Sergey, does configurations survive server restart?
Yes, after the server has been restar... - 04:35 PM Feature #3880: enhanced browse 3rd phase of improvements
- Regarding exception. It is suppressed in @WebClientKeyValueStorage.getChunk@:...
- 04:32 PM Feature #3880: enhanced browse 3rd phase of improvements
- Sergey, does configurations survive server restart? It just crossed my mind that a dynamic port is assigned every tim...
- 04:28 PM Feature #3880: enhanced browse 3rd phase of improvements
- Also I tried to save the browse configuration with blue background color for the particular user and restore it after...
- 04:18 PM Feature #3880: enhanced browse 3rd phase of improvements
- I checked the Hotel Gui with the web client for Firefox. It seems that the enhanced browse configuration is stored. I...
- 02:57 PM Feature #3880: enhanced browse 3rd phase of improvements
- I didn't encounter this exception. Could you provide a testcase to reproduce? At the time of my changes the enhanced ...
- 11:57 AM Feature #3880: enhanced browse 3rd phase of improvements
- An enhanced browse configuration cannot be loaded from a web storage. I have to fix it before any other issue. If any...
- 05:55 PM Bug #4631: Widget scoped to wrong frame on hide
- Greg Shah wrote:
> The ChUI testing is on @devsrv01@.
After the complete conversion testing, there were no artifa... - 09:33 AM Bug #4631: Widget scoped to wrong frame on hide
- The ChUI testing is on @devsrv01@.
- 09:19 AM Bug #4631: Widget scoped to wrong frame on hide
- Greg Shah wrote:
> The overall approach seems close. The one thing that looks wrong is line 1884 (@<action>addDicti...
06/18/2020
- 07:08 PM Bug #4631: Widget scoped to wrong frame on hide
- The overall approach seems close. The one thing that looks wrong is line 1884 (@<action>addDictionaryObject("frame_e...
- 11:23 AM Feature #3880: enhanced browse 3rd phase of improvements
- In Web client the @gui/driver/web/GuiWebDriver.java@ uses specific @X@ scaling factor for every font in use. This sho...
- 10:32 AM Feature #3880: enhanced browse 3rd phase of improvements
- Put this under @/server/default/@ or @/server/<server_name>/@:...
- 10:29 AM Feature #3880: enhanced browse 3rd phase of improvements
- What is the "simple" (single boolean flag) directory configuration for enabling enhanced mode?
- 09:06 AM Feature #3880: enhanced browse 3rd phase of improvements
- > The scale factor should be different for Web as well as for Swing client. So why does the font chooser always uses ...
- 07:09 AM Feature #3880: enhanced browse 3rd phase of improvements
- Stanislav Lomany wrote:
> > The big concern here is that the web gives different results from Swing. Based on your ... - 09:01 AM Feature #4164: implement misc UI features (frame options, misc attributes)
- As part of this task, there were changes to the @ThinClient.getFrameCol()@ method.
The original code:...
06/17/2020
- 07:23 PM Feature #3880: enhanced browse 3rd phase of improvements
- > The big concern here is that the web gives different results from Swing. Based on your notes, I still don't unders...
- 04:10 PM Feature #3880: enhanced browse 3rd phase of improvements
- The font chooser case is not very important. If that was not working, it would be less of a concern.
The big conc... - 04:02 PM Feature #3880: enhanced browse 3rd phase of improvements
- > If scaling only happens for Swing, then why are the metrics for web the same (and wrong)?
It's not quite that wa... - 11:30 AM Bug #4631: Widget scoped to wrong frame on hide
- I have an update that I'd like reviewed. It correctly converted the testcase, as well as the customer procedure. Are ...
06/16/2020
- 07:46 PM Bug #4631: Widget scoped to wrong frame on hide
- Should the @descent-rules@ both add the scope at the appropriate time, and include the rules that had been in place i...
- 07:31 PM Feature #3880: enhanced browse 3rd phase of improvements
- Are the metrics calculated before the scaling? The thing I don't understand is that the Swing browse draws everythin...
- 06:19 PM Feature #3880: enhanced browse 3rd phase of improvements
- > Do we have accurate metrics that differ between Swing and web?
The metrics are the same, actual text size diff... - 10:23 AM Feature #3880: enhanced browse 3rd phase of improvements
- > Do you have an idea what we're are doing about Graphics2D or something else that could cause this difference? Web v...
- 05:46 AM Feature #3880: enhanced browse 3rd phase of improvements
- Regarding the font size: I found that actually may be it's not the case that a web font is larger, it's the case that...
06/15/2020
- 08:12 AM Bug #4631: Widget scoped to wrong frame on hide
- #4208-447 starts discussion of this same bug. This should be addressed before merging 4231b to trunk.
Constantin i...
06/14/2020
- 11:25 AM Feature #3880: enhanced browse 3rd phase of improvements
- 3880a has been merged into 4231b as rev 11604. 3880a has been archived.
06/13/2020
- 03:17 PM Bug #4671: Widget drag doesn't work in web
- One can drag a widget once, but not for the second time.
Reproduction: drag the button, then try to drag it again. - 03:08 PM Bug #4671 (New): Widget drag doesn't work in web
- 02:56 PM Feature #3880: enhanced browse 3rd phase of improvements
- Fix for web issues (web column/row resize) committed into 4231b as rev 11603.
BTW there's one more minor web issue...
06/11/2020
- 03:07 PM Feature #3880: enhanced browse 3rd phase of improvements
- Stanislav Lomany wrote:
> > Why is the row height static? It should be calculated based on whatever is being used at... - 03:06 PM Feature #3880: enhanced browse 3rd phase of improvements
- > I mean like this. We can make a tray, but why lose a row? In this case we'll be losing a row only if there are no s...
- 03:06 PM Feature #3880: enhanced browse 3rd phase of improvements
- > Why is the row height static? It should be calculated based on whatever is being used at the time.
Currently, t... - 03:04 PM Feature #3880: enhanced browse 3rd phase of improvements
- Code Review Task Branch 3880a Revisions 11347 through 11353
1. I really like the refactoring of the TC dialog proc... - 02:32 PM Feature #3880: enhanced browse 3rd phase of improvements
- I mean like this. We can make a tray, but why lose a row? In this case we'll be losing a row only if there are no scr...
- 01:38 PM Feature #3880: enhanced browse 3rd phase of improvements
- Stanislav Lomany wrote:
> > Can you see any case which this does not cover?
>
> If there is a vertical scrollbar ... - 01:35 PM Feature #3880: enhanced browse 3rd phase of improvements
- > Can you see any case which this does not cover?
If there is a vertical scrollbar and NO horizontal scrollbar, we... - 06:41 AM Feature #3880: enhanced browse 3rd phase of improvements
- We will use the bottom right corner of the browse. In enhanced mode (simple boolean flag), we will always provide th...
- 06:29 AM Feature #3880: enhanced browse 3rd phase of improvements
- !example.png!
- 06:25 AM Feature #3880: enhanced browse 3rd phase of improvements
- Please show an example.
- 06:24 AM Feature #3880: enhanced browse 3rd phase of improvements
- Yes.
- 06:21 AM Feature #3880: enhanced browse 3rd phase of improvements
- Is it possible to have a horizontal scrollbar without a vertical scrollbar?
- 05:58 AM Feature #3880: enhanced browse 3rd phase of improvements
- > * Is there always a vertical scrollbar?
It can be turned off.
> * Aren't there cases where there are row marker... - 08:02 PM Feature #3880: enhanced browse 3rd phase of improvements
- * Is there always a vertical scrollbar?
* Aren't there cases where there are row markers?
* Please show the same c...
06/10/2020
- 05:44 PM Feature #3880: enhanced browse 3rd phase of improvements
- > Please post examples of the possible states that we can see for the the browse (with different options active).
!b... - 05:24 PM Feature #3880: enhanced browse 3rd phase of improvements
- Why is the row height static? It should be calculated based on whatever is being used at the time. I guess this mea...
- 05:20 PM Feature #3880: enhanced browse 3rd phase of improvements
- User changes font in web version, we set row height according to web font metrics, everything is looking nice. If the...
- 05:14 PM Feature #3880: enhanced browse 3rd phase of improvements
- Stanislav Lomany wrote:
> > I suppose that means you must determine what the minimum safe row height will be for tha... - 04:53 PM Feature #3880: enhanced browse 3rd phase of improvements
- > I suppose that means you must determine what the minimum safe row height will be for that font and implement it.
... - 04:46 PM Feature #3880: enhanced browse 3rd phase of improvements
- Stanislav Lomany wrote:
> > Are you talking about item 3.2 from #3880-4?
>
> Yes.
This is a user override, so ... - 04:38 PM Feature #3880: enhanced browse 3rd phase of improvements
- > Are you talking about item 3.2 from #3880-4?
Yes. - 04:21 PM Feature #3880: enhanced browse 3rd phase of improvements
- >> The upper left corner of the browse has no purpose, in enhanced mode it will be drawn as a gear icon instead of th...
- 03:33 PM Feature #3880: enhanced browse 3rd phase of improvements
- > Your found difference is especially large. Normally we don't see a difference that big. The use of multiple W cha...
- 03:29 PM Feature #3880: enhanced browse 3rd phase of improvements
- > The upper left corner of the browse has no purpose, in enhanced mode it will be drawn as a gear icon instead of the...
- 03:23 PM Feature #3880: enhanced browse 3rd phase of improvements
- There is no way to get exactly the same results as the 4GL, even with the same exact fonts being used. We employ a r...
- 02:56 PM Feature #3880: enhanced browse 3rd phase of improvements
- Guys, all (most?) of the fonts look bigger in a browser compared to a standalone app. The lager the font, the bigger ...
- 03:29 AM Feature #3880: enhanced browse 3rd phase of improvements
- Stanislav Lomany wrote:
> Some thoughts:
> # @MouseHoverAction@ is registered using @GuiWebDriver.registerHoverable...
06/09/2020
- 04:37 PM Feature #3880: enhanced browse 3rd phase of improvements
- Some thoughts:
# @MouseHoverAction@ is registered using @GuiWebDriver.registerHoverableWidget@ on the JS side and do...
06/06/2020
- 12:15 PM Bug #4135: high dpi screens display in low dpi
- From the customer:
> The file HotelDemoDPR2.png is looking good. Text looks sharp.
>
> As mentioned earlier in ... - 12:10 PM Feature #4661: add support for missing formats to image loading
- The 4GL uses Windows OS features for its image support. This is the known list (at this time) of supported 4GL image...
- 11:57 AM Feature #4661 (Closed): add support for missing formats to image loading
Also available in: Atom