FWD » Core Development » User Interface

07/07/2020

12:27 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> Code Review Task Branch 3821c Revision 11358
>
> This seems better. Confirm it with testing.
... Roger Borrello

07/03/2020

02:49 AM Feature #4730 (New): Implement support for custom fonts on individual nodes of a TREEVIEW (and TR...

Hynek Cihlar

06/30/2020

04:35 PM Feature #4661: add support for missing formats to image loading

I don't think a testcase is really necessary, in that the customer application is already utilizing @gif@ images on b... Roger Borrello

08:30 AM Feature #4661: add support for missing formats to image loading

Greg Shah wrote:
> Roger: Prepare some simple 4GL samples that try to load @.gif@, @.png@ and @.svg@ from files. Yo... Roger Borrello

08:12 AM Feature #4661: add support for missing formats to image loading

Roger: Prepare some simple 4GL samples that try to load @.gif@, @.png@ and @.svg@ from files. You can test this pure... Greg Shah

08:10 AM Feature #4661: add support for missing formats to image loading

Can you make a summary of what Roger would have to do (e.g. something like "look at classes X, Y and Z, method A and ... Greg Shah

06/29/2020

06:33 PM Feature #4661: add support for missing formats to image loading

Greg Shah wrote:
> Our SVG support can be seen in @com.goldencode.p2j.ui.client.gui.VectorGraphicsHelper@. I see th... Eugenie Lyzenko

06:26 PM Feature #4661: add support for missing formats to image loading

Roger Borrello wrote:
> Is this the location to look for additional plug-ins? -> https://github.com/haraldk/TwelveMo... Eugenie Lyzenko

02:48 PM Feature #4661: add support for missing formats to image loading

Our SVG support can be seen in @com.goldencode.p2j.ui.client.gui.VectorGraphicsHelper@. I see that we have the abili... Greg Shah

02:12 PM Feature #4661: add support for missing formats to image loading

Is this the location to look for additional plug-ins? -> https://github.com/haraldk/TwelveMonkeys
It seems @gif@ i... Roger Borrello

06/22/2020

04:30 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Code Review Task Branch 3821c Revision 11358
This seems better. Confirm it with testing. Greg Shah

10:16 AM Feature #4164: implement misc UI features (frame options, misc attributes)

This was implemented in @3821c-11358@. Please review, and let me know if there's a way to run an individual test for ... Roger Borrello

08:20 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Roger Borrello wrote:
> If @ConfigHelper.getAssignedRow(frame.config())@ can return @BaseConfig.INV_COORD@ as well, ... Roger Borrello

08:16 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> Code Review Task Branch 3821c Revision 11354
>
> This is incorrect. @ConfigHelper.getAssigned... Roger Borrello

06:50 AM Feature #4164: implement misc UI features (frame options, misc attributes)

Code Review Task Branch 3821c Revision 11354
This is incorrect. @ConfigHelper.getAssignedColumn(frame.config())@ ... Greg Shah

09:28 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Greg Shah wrote:
> As part of this task, there were changes to the @ThinClient.getFrameCol()@ method.
>
> I've ba... Roger Borrello

07:04 AM Feature #4170: add drag and drop support to treeview widget

Is there any remaining work or testing needed for this task? Greg Shah

06:39 AM Bug #4631 (Test): Widget scoped to wrong frame on hide

Code Review Task Branch 3821c Revision 11353
The changes are good. Greg Shah

09:26 PM Bug #4631: Widget scoped to wrong frame on hide

Greg Shah wrote:
> Was this with the version that had removed the @addDictionaryObject()@ which I asked about?
>
... Roger Borrello

06/21/2020

07:28 PM Feature #3880: enhanced browse 3rd phase of improvements

I assume that @ScrollPaneGuiImpl@ needs a change that gives more control over its positioning, sizing or over the dra... Greg Shah

07:26 PM Feature #3880: enhanced browse 3rd phase of improvements

I don't think it makes sense to have an enhanced browse menu button inside a scrolling helper class. Greg Shah

07:06 PM Feature #3880: enhanced browse 3rd phase of improvements

> Can't the scrollbars be sized and positioned so that they don't overlap the space for the gear icon?
Sorry, don'... Stanislav Lomany

07:00 PM Feature #3880: enhanced browse 3rd phase of improvements

You can subclass it if that is the best way. But it seems like the gear icon will always be there in this mode, so w... Greg Shah

06:55 PM Feature #3880: enhanced browse 3rd phase of improvements

> I don't know the answer here, but I wouldn't want a generic helper class to have a browse-specific feature.
If t... Stanislav Lomany

06:50 PM Feature #3880: enhanced browse 3rd phase of improvements

We should not take up more space than the 4GL compatible version. Instead we "sacrifice" a row.
> X-1 rows, but ... Greg Shah

10:46 AM Feature #3880: enhanced browse 3rd phase of improvements

Greg, I have a question about the "tray" which should appear if there are no scrollbars and we want to find a place f... Stanislav Lomany

06/20/2020

12:11 PM Bug #4589 (Closed): menu case sensitivity and conversion

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

12:06 PM Bug #4074 (Closed): Mismatching ROW-ENTRY/LEAVE events

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

12:04 PM Bug #3690 (Closed): BUTTON widget reaction on SPACEBAR and ENTER keys

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

12:03 PM Bug #4624 (Closed): Fill-in: StringIndexOutOfBoundsException and other bugs

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

12:02 PM Feature #2683: reverse proxy implementation

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

12:00 PM Feature #4164: implement misc UI features (frame options, misc attributes)

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

12:00 PM Feature #4393 (Closed): add TITLE-DCOLOR attribute support

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

12:00 PM Feature #4394 (Closed): add some frame options and attributes

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

11:52 AM Feature #3876: add support for "direct font control" at the widget level

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

11:52 AM Feature #3880: enhanced browse 3rd phase of improvements

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

11:43 AM Feature #3880: enhanced browse 3rd phase of improvements

The generic (no user version) of the URL should continue to work as well. Greg Shah

11:42 AM Feature #3880: enhanced browse 3rd phase of improvements

The idea is that the user would have the URL bookmarked which would map to the right user name. Then the login form ... Greg Shah

11:08 AM Feature #3880: enhanced browse 3rd phase of improvements

Greg Shah wrote:
> Yes, but by doing it this way the local storage would be specific to the user instead of the mach... Hynek Cihlar

11:05 AM Feature #3880: enhanced browse 3rd phase of improvements

Yes, but by doing it this way the local storage would be specific to the user instead of the machine. It isn't secur... Greg Shah

11:01 AM Feature #3880: enhanced browse 3rd phase of improvements

Greg Shah wrote:
> Correct.
>
> A variant of this idea: if the initial URL had a user-account component (@https:/... Hynek Cihlar

10:57 AM Feature #3880: enhanced browse 3rd phase of improvements

Correct.
A variant of this idea: if the initial URL had a user-account component (@https://<host>:<port>/gui/<os_u... Greg Shah

10:41 AM Feature #3880: enhanced browse 3rd phase of improvements

Hynek Cihlar wrote:
> Wouldn't the cookie be subject of CORS when it would be read on a different port (not mentioni... Hynek Cihlar

10:38 AM Feature #3880: enhanced browse 3rd phase of improvements

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > Does anyone see a better alternative?
... Hynek Cihlar

10:34 AM Feature #3880: enhanced browse 3rd phase of improvements

> Crazy-lazy idea: we could identify the client using the available browser information (agent, resolution, OS, versi... Greg Shah

10:13 AM Feature #3880: enhanced browse 3rd phase of improvements

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Does anyone see a better alternative?
>
> Crazy-lazy idea: we could i... Constantin Asofiei

10:12 AM Feature #3880: enhanced browse 3rd phase of improvements

Greg Shah wrote:
> Does anyone see a better alternative?
Crazy-lazy idea: we could identify the client using the ... Hynek Cihlar

09:08 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> What I see:
> # Start an app and save a configuration. In local storage browser I see tha... Greg Shah

04:16 AM Feature #3880: enhanced browse 3rd phase of improvements

I am using these settings for the web client:... Sergey Ivanovskiy

11:51 AM Feature #4174: implement calendar control/dtpicker OCX replacement

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

11:50 AM Feature #4170: add drag and drop support to treeview widget

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

11:50 AM Bug #4636: Make the Theme API independent on concrete implementation classes

Task branch 4231b has been merged to trunk as revision 11347. Greg Shah

10:18 AM Bug #4631: Widget scoped to wrong frame on hide

Was this with the version that had removed the @addDictionaryObject()@ which I asked about?
If so, does that same ... Greg Shah

06/19/2020

07:32 PM Feature #3880: enhanced browse 3rd phase of improvements

Sure!
I just need to resolve this ports story for my local configuration. Stanislav Lomany

07:24 PM Feature #3880: enhanced browse 3rd phase of improvements

I tested also with saving "All browses, Current User". The result after cold restart was all tables changes backgroun... Sergey Ivanovskiy

07:08 PM Feature #3880: enhanced browse 3rd phase of improvements

I built FWD with these changes and applied them to Hotel GUI with @deploy.prepare@. Then cleaned all localStorage and... Sergey Ivanovskiy

07:00 PM Feature #3880: enhanced browse 3rd phase of improvements

What I see:
# Start an app and save a configuration. In local storage browser I see that the configuration is saved ... Stanislav Lomany

06:56 PM Feature #3880: enhanced browse 3rd phase of improvements

Sorry, I forgot to mention it! Please test it while saving configuration for "This Browse, Current User" (or "All bro... Stanislav Lomany

06:51 PM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > It seems that now the browse configuration is restored.
>
> For me configuration is ... Sergey Ivanovskiy

06:49 PM Feature #3880: enhanced browse 3rd phase of improvements

At least the cell's background color, height and font were persisted across the server restarts. Sergey Ivanovskiy

06:49 PM Feature #3880: enhanced browse 3rd phase of improvements

> It seems that now the browse configuration is restored.
For me configuration is still not loaded after server r... Stanislav Lomany

06:43 PM Feature #3880: enhanced browse 3rd phase of improvements

#3880-141 Thank you, I know:) Stanislav Lomany

06:40 PM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> Well, I don't like new line symbol within a key and double quoting. But I'm not sure if th... Sergey Ivanovskiy

05:51 PM Feature #3880: enhanced browse 3rd phase of improvements

Well, I don't like new line symbol within a key and double quoting. But I'm not sure if that's an issue.
So, sorry, ... Stanislav Lomany

05:47 PM Feature #3880: enhanced browse 3rd phase of improvements

Yes, it looks like an issue. How it can be happened? Sergey Ivanovskiy

05:42 PM Feature #3880: enhanced browse 3rd phase of improvements

The first I checked that the @localStorage@ has the same key and value after the server has been restarted. I observe... Sergey Ivanovskiy

05:34 PM Feature #3880: enhanced browse 3rd phase of improvements

> Planning to debug what was the issue.
I think I found the bug:... Stanislav Lomany

05:27 PM Feature #3880: enhanced browse 3rd phase of improvements

User configurations can be "for all users" and user-specific. "For all users" are saved in the directory. User-specif... Stanislav Lomany

05:24 PM Feature #3880: enhanced browse 3rd phase of improvements

It is not obvious for me that the issue is the serialization/deserealization from the web @localStorage@. Planning to... Sergey Ivanovskiy

05:21 PM Feature #3880: enhanced browse 3rd phase of improvements

In this case it seems that the browse configuration doesn't read after the user is logged out and it is saved on the ... Sergey Ivanovskiy

05:15 PM Feature #3880: enhanced browse 3rd phase of improvements

> Yes, after the server has been restarted the configuration was not retrieved but it is not because of the different... Stanislav Lomany

05:07 PM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> Sergey, does configurations survive server restart?
Yes, after the server has been restar... Sergey Ivanovskiy

04:35 PM Feature #3880: enhanced browse 3rd phase of improvements

Regarding exception. It is suppressed in @WebClientKeyValueStorage.getChunk@:... Stanislav Lomany

04:32 PM Feature #3880: enhanced browse 3rd phase of improvements

Sergey, does configurations survive server restart? It just crossed my mind that a dynamic port is assigned every tim... Stanislav Lomany

04:28 PM Feature #3880: enhanced browse 3rd phase of improvements

Also I tried to save the browse configuration with blue background color for the particular user and restore it after... Sergey Ivanovskiy

04:18 PM Feature #3880: enhanced browse 3rd phase of improvements

I checked the Hotel Gui with the web client for Firefox. It seems that the enhanced browse configuration is stored. I... Sergey Ivanovskiy

02:57 PM Feature #3880: enhanced browse 3rd phase of improvements

I didn't encounter this exception. Could you provide a testcase to reproduce? At the time of my changes the enhanced ... Sergey Ivanovskiy

11:57 AM Feature #3880: enhanced browse 3rd phase of improvements

An enhanced browse configuration cannot be loaded from a web storage. I have to fix it before any other issue. If any... Stanislav Lomany

05:55 PM Bug #4631: Widget scoped to wrong frame on hide

Greg Shah wrote:
> The ChUI testing is on @devsrv01@.
After the complete conversion testing, there were no artifa... Roger Borrello

09:33 AM Bug #4631: Widget scoped to wrong frame on hide

The ChUI testing is on @devsrv01@. Greg Shah

09:19 AM Bug #4631: Widget scoped to wrong frame on hide

Greg Shah wrote:
> The overall approach seems close. The one thing that looks wrong is line 1884 (@<action>addDicti... Roger Borrello

06/18/2020

07:08 PM Bug #4631: Widget scoped to wrong frame on hide

The overall approach seems close. The one thing that looks wrong is line 1884 (@<action>addDictionaryObject("frame_e... Greg Shah

11:23 AM Feature #3880: enhanced browse 3rd phase of improvements

In Web client the @gui/driver/web/GuiWebDriver.java@ uses specific @X@ scaling factor for every font in use. This sho... Eugenie Lyzenko

10:32 AM Feature #3880: enhanced browse 3rd phase of improvements

Put this under @/server/default/@ or @/server/<server_name>/@:... Stanislav Lomany

10:29 AM Feature #3880: enhanced browse 3rd phase of improvements

What is the "simple" (single boolean flag) directory configuration for enabling enhanced mode? Greg Shah

09:06 AM Feature #3880: enhanced browse 3rd phase of improvements

> The scale factor should be different for Web as well as for Swing client. So why does the font chooser always uses ... Stanislav Lomany

07:09 AM Feature #3880: enhanced browse 3rd phase of improvements

Stanislav Lomany wrote:
> > The big concern here is that the web gives different results from Swing. Based on your ... Hynek Cihlar

09:01 AM Feature #4164: implement misc UI features (frame options, misc attributes)

As part of this task, there were changes to the @ThinClient.getFrameCol()@ method.
The original code:... Greg Shah

06/17/2020

07:23 PM Feature #3880: enhanced browse 3rd phase of improvements

> The big concern here is that the web gives different results from Swing. Based on your notes, I still don't unders... Stanislav Lomany

04:10 PM Feature #3880: enhanced browse 3rd phase of improvements

The font chooser case is not very important. If that was not working, it would be less of a concern.
The big conc... Greg Shah

04:02 PM Feature #3880: enhanced browse 3rd phase of improvements

> If scaling only happens for Swing, then why are the metrics for web the same (and wrong)?
It's not quite that wa... Stanislav Lomany

11:30 AM Bug #4631: Widget scoped to wrong frame on hide

I have an update that I'd like reviewed. It correctly converted the testcase, as well as the customer procedure. Are ... Roger Borrello

06/16/2020

07:46 PM Bug #4631: Widget scoped to wrong frame on hide

Should the @descent-rules@ both add the scope at the appropriate time, and include the rules that had been in place i... Roger Borrello

07:31 PM Feature #3880: enhanced browse 3rd phase of improvements

Are the metrics calculated before the scaling? The thing I don't understand is that the Swing browse draws everythin... Greg Shah

06:19 PM Feature #3880: enhanced browse 3rd phase of improvements

> Do we have accurate metrics that differ between Swing and web?
The metrics are the same, actual text size diff... Stanislav Lomany

10:23 AM Feature #3880: enhanced browse 3rd phase of improvements

> Do you have an idea what we're are doing about Graphics2D or something else that could cause this difference? Web v... Greg Shah

05:46 AM Feature #3880: enhanced browse 3rd phase of improvements

Regarding the font size: I found that actually may be it's not the case that a web font is larger, it's the case that... Stanislav Lomany

06/15/2020

08:12 AM Bug #4631: Widget scoped to wrong frame on hide

#4208-447 starts discussion of this same bug. This should be addressed before merging 4231b to trunk.
Constantin i... Roger Borrello

06/14/2020

11:25 AM Feature #3880: enhanced browse 3rd phase of improvements

3880a has been merged into 4231b as rev 11604. 3880a has been archived. Stanislav Lomany