Project

General

Profile

Activity

From 03/21/2021 to 04/19/2021

04/16/2021

11:52 AM Bug #5240 (Closed): BROWSE:SELECT-ROW(1) error on client
Code Review Task Branch 3821c Revisin 12267
I'm OK with the changes.
Greg Shah
11:51 AM Bug #5240: BROWSE:SELECT-ROW(1) error on client
> That's just a convenient way to return control to server and write to server log. I'm not sure if ever use ErrorMan... Greg Shah

04/15/2021

04:30 PM Bug #5240: BROWSE:SELECT-ROW(1) error on client
> may be, it would be better to handle errors where they arise: use @ErrorManager.recordOrThrowError(382, ...)@ metho... Stanislav Lomany
07:36 AM Bug #5240: BROWSE:SELECT-ROW(1) error on client
Vladimir Tsichevski wrote:
> Stanislav Lomany wrote:
>
> > Vladimir, this is caused by your recent change where e...
Vladimir Tsichevski

04/12/2021

07:25 AM Bug #5254: FWD extension control must follow the lifetime of the counterpart 4GL OCX/ActiveX
Reproduced from #3952-4 (from Constantin and Ovidiu):
> After a discussion with Ovidiu and some inspection of @<cu...
Greg Shah
07:22 AM Bug #5254 (New): FWD extension control must follow the lifetime of the counterpart 4GL OCX/ActiveX
Greg Shah
04:21 AM Feature #5253: SPREADSHEET: Create documentation
This is a follow task of #3821, see points 12 and 13 in #3821-160. Hynek Cihlar
04:20 AM Feature #5253 (New): SPREADSHEET: Create documentation
Hynek Cihlar
04:17 AM Feature #5252: SPREADSHEET: Publish Keikai contribution sources
This is a follow task of #3821, see #3821-167. Hynek Cihlar
04:16 AM Feature #5252 (New): SPREADSHEET: Publish Keikai contribution sources
Hynek Cihlar

04/10/2021

08:25 AM Bug #5240: BROWSE:SELECT-ROW(1) error on client
Stanislav Lomany wrote:
> Vladimir, this is caused by your recent change where exception is caught in @GenericWidg...
Vladimir Tsichevski
03:29 AM Bug #5240 (Review): BROWSE:SELECT-ROW(1) error on client
> 2. Another difference: OE displays error 382 (FWD displays error 4078).
> FWD throws the correct error 382 first, ...
Stanislav Lomany

04/09/2021

04:28 PM Bug #5245: BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
I found the similar thread #3911-51 and below. #3911-27 Sergey Ivanovskiy
04:05 PM Bug #5245: BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
It seems that it was related to the customer's project testcases 1 and 2, when all data after successful input are cl... Sergey Ivanovskiy
02:50 PM Bug #5245 (WIP): BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
Sergey, if you remember the specific case why this was added in @BrowseColumnWidget@, please let me know. I get "?" i... Stanislav Lomany
09:47 AM Feature #4661 (Closed): add support for missing formats to image loading
Code Review Task Branch 3821c Revision 12265
The changes are good.
Greg Shah
09:34 AM Feature #4661: add support for missing formats to image loading
Greg Shah wrote:
> Eugenie: Please review 12263.
I have no objections except requirement to close opened scream y...
Eugenie Lyzenko
09:09 AM Feature #4661: add support for missing formats to image loading
Please review rev. 12265(3821c) that should fix found issues. Sergey Ivanovskiy
06:28 AM Feature #4661: add support for missing formats to image loading
Eugenie: Please review 12263. Greg Shah
06:27 AM Feature #4661: add support for missing formats to image loading
Code Review Task Branch 3821c Revision 12263
The changes are good.
The only issue I see is that the @ImageGuiIm...
Greg Shah
06:19 AM Feature #4661: add support for missing formats to image loading
Code Review Task Branch 3821c Revision 12261
The change is good.
Greg Shah
03:47 AM Feature #4661 (Review): add support for missing formats to image loading
Committed revision 12263 (3821c) added svg image loading support for image and button widgets. PNG and SVG are suppor... Sergey Ivanovskiy

04/08/2021

05:42 PM Feature #4661: add support for missing formats to image loading
Please review the committed revision 12261 (3821c) that fixed #4661-17. I checked that PNG is supported format but SV... Sergey Ivanovskiy
11:48 AM Feature #4661: add support for missing formats to image loading
OK. I understand what is the issue. The following rule expects @FILE name@ part that can be missed... Sergey Ivanovskiy
10:56 AM Feature #4661: add support for missing formats to image loading
The image phrase within button definition @IMAGE IMAGE-SIZE-PIXELS 50 by 50 FROM X 15 Y 10@ throws this exception whe... Sergey Ivanovskiy
04:11 PM Bug #5240 (WIP): BROWSE:SELECT-ROW(1) error on client
I wish all tasks would contain a solution inside, like this one:) The change is good, I'll take a look into #5245 and... Stanislav Lomany

04/07/2021

03:32 PM Feature #4661: add support for missing formats to image loading
Yes, I see this too. I just tested with 3821c rev 12255. Greg Shah
11:16 AM Feature #4661: add support for missing formats to image loading
I found that there is a regression of the conversion code (3821c) that makes this program fail conversion... Sergey Ivanovskiy
09:28 AM Feature #4661 (WIP): add support for missing formats to image loading
Sergey Ivanovskiy
09:27 AM Feature #4661: add support for missing formats to image loading
No, these formats are just listed in #4661-1. OK. I will check .png and .svg images for the button and image widgets. Sergey Ivanovskiy
08:05 AM Feature #4661: add support for missing formats to image loading
Do you know of a customer requirement for animated mouse cursors? At this time I don't know of any such requirement.... Greg Shah
07:32 AM Feature #4661: add support for missing formats to image loading
There can be another idea to wrap images containing animation images into new widget type and use this widget for mou... Sergey Ivanovskiy
04:37 AM Feature #4661: add support for missing formats to image loading
It seems that animated images can't be displayed by the web client due to it just displays static bitmap images of re... Sergey Ivanovskiy
11:46 AM Bug #5118: TREELIST widget issues
Greg Shah wrote:
> OK, leave the 101 and remove the "code".
Done in rev. 12253.
> Please propose a 4GL code edit...
Vladimir Tsichevski
11:24 AM Bug #5118: TREELIST widget issues
OK, leave the 101 and remove the "code". Please propose a 4GL code edit for setting the "code" value. We can send i... Greg Shah
11:16 AM Bug #5118: TREELIST widget issues
Greg Shah wrote:
> Is this customer specific? Shouldn't such values be handled by 4GL source file changes? I don't...
Vladimir Tsichevski
11:12 AM Bug #5118: TREELIST widget issues
Is this customer specific? Shouldn't such values be handled by 4GL source file changes? I don't see why a generic w... Greg Shah
11:05 AM Bug #5118: TREELIST widget issues
3821c, rev. 12253. The width and caption of the first default column changed to 101 and "code" to make it compatible ... Vladimir Tsichevski

04/06/2021

02:44 PM Feature #4661: add support for missing formats to image loading
Roger has shown that we already support @.gif@.
For now, the primary requirement of this task is that FWD should s...
Greg Shah
11:24 AM Bug #5245: BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
The @BrowseColumnWidget.getScreenValue()@ convert an unknown character value to an empty string.
This code:...
Vladimir Tsichevski
11:20 AM Bug #5245 (Review): BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
Vladimir Tsichevski
09:40 AM Bug #5241: NPE in LogicalTerminal.refreshBuffers
Greg Shah wrote:
> I don't object to that safety code, it makes sense to add.
>
> But I worry that there is a dee...
Vladimir Tsichevski
07:31 AM Bug #5241: NPE in LogicalTerminal.refreshBuffers
I don't object to that safety code, it makes sense to add.
But I worry that there is a deeper problem here which c...
Greg Shah

04/05/2021

07:25 PM Bug #5240: BROWSE:SELECT-ROW(1) error on client
As a workaround: the line 1726 in Browse:... Vladimir Tsichevski
05:05 PM Bug #5240: BROWSE:SELECT-ROW(1) error on client
1. The following code works as expected in OE, and causes the error number 4078 (@Unable to set attribute SCREEN-VALU... Vladimir Tsichevski
04:45 PM Bug #5240 (Closed): BROWSE:SELECT-ROW(1) error on client
Vladimir Tsichevski
07:18 PM Bug #5241: NPE in LogicalTerminal.refreshBuffers
# Convert, compile and run two procedures below.
# Exit the main window by pressing ESC twice.
The program bumps ...
Vladimir Tsichevski
06:58 PM Bug #5241 (New): NPE in LogicalTerminal.refreshBuffers
Vladimir Tsichevski
06:46 PM Bug #5231 (Closed): ChUI CHOOSE characters are too choosey
Greg Shah
06:44 PM Bug #5231 (Test): ChUI CHOOSE characters are too choosey
Code Review Task Branch 3821c Revision 12248
The changes are good.
Greg Shah
05:52 PM Bug #5231 (Review): ChUI CHOOSE characters are too choosey
Updated in @3821c_12248@. Please review. Roger Borrello

03/31/2021

07:46 PM Bug #5231: ChUI CHOOSE characters are too choosey
The documentation indicates @KEYCODE(RETURN)@ is returned when @AUTO-RETURN@ is set, and a match is found. Roger Borrello
03:27 PM Bug #5231 (WIP): ChUI CHOOSE characters are too choosey
Roger Borrello
03:27 PM Bug #5231: ChUI CHOOSE characters are too choosey
I am almost complete with revising @CHOOSE@ so that it can react to any characters that are being pressed. Previously... Roger Borrello
03:26 PM Bug #5231 (Closed): ChUI CHOOSE characters are too choosey
Roger Borrello
03:41 AM Feature #5223: SPREADSHEET: Implement formula circular references
SPREADSHEET widget currently doesn't support circular references in formulas. The reason for this is that Keikai back... Hynek Cihlar
03:37 AM Feature #5223 (New): SPREADSHEET: Implement formula circular references
Hynek Cihlar

03/30/2021

06:20 PM Feature #4174: implement calendar control/dtpicker OCX replacement
Constantin, I checked my old testcase and found that it had been broken. The issue is related to date time formats. Sergey Ivanovskiy

03/23/2021

02:40 PM Feature #4179 (Closed): create a standalone native launcher (Windows EXE and Linux/UNIX version) ...
Greg Shah
02:40 PM Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Code Review Task Branch 3821c Revisions 12167 and 12169
I'm good with the changes.
Greg Shah
02:36 PM Feature #4182 (Closed): KERNEL32:SLEEP() emulation
Greg Shah
02:35 PM Feature #4181 (Closed): GetComputerNameA emulation
Greg Shah
09:10 AM Bug #5118: TREELIST widget issues
Another difference:
In 4gl it is illegal to pass an unknown character value as the column caption:
!5118-unknow...
Vladimir Tsichevski

03/22/2021

06:42 PM Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Updates in @12167@. Created @launcher_xxx@ modules to support the launcher, removed JNI code from @desktop_xxx@ modules. Roger Borrello
03:31 PM Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Code Review Task Branch 3821c Revision 12165
1. I'm not a fan of this @zenity@ dependency, but I think writing the...
Greg Shah
02:26 PM Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Updates in @3821c_12165@ Roger Borrello
01:37 PM Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
It works for me. Greg Shah
01:00 PM Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Here are the 2 (Linux/Windows). I had to merge some text, since I don't have as much control over the @zenity@ tool:
...
Roger Borrello
12:14 PM Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
The error message is good.
In regard to the warning:
* The yellow warning icon is good.
* Please change the te...
Greg Shah
12:05 PM Feature #4179 (Review): create a standalone native launcher (Windows EXE and Linux/UNIX version) ...
Take a look at the demo video and below messages:
!4179_error_message.png!
!4179_warning_message.png!
Roger Borrello
08:13 AM Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
> Is language support a requirement?
Yes, but it can be deferred until another customer needs it.
> A warning m...
Greg Shah
10:34 PM Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Is language support a requirement? We need to have:
# A warning message about the danger of launching a resource
# ...
Roger Borrello
06:48 AM Bug #5214: Broken z-order for all driver widgets (including SPREADSHEET, HTML-BROWSER, etc.)
To replicate the issue, create a program with two legacy windows, display a HTML-BROWSER widget in one window and the... Hynek Cihlar
06:47 AM Bug #5214 (Closed): Broken z-order for all driver widgets (including SPREADSHEET, HTML-BROWSER, e...
Hynek Cihlar
 

Also available in: Atom