Project

General

Profile

Activity

From 04/06/2021 to 05/05/2021

05/04/2021

02:45 PM Feature #4164: implement misc UI features (frame options, misc attributes)
Yes. Greg Shah
02:28 PM Feature #4164: implement misc UI features (frame options, misc attributes)
I assume than implementation of @SCROLL-NOTIFY@ should include @SCROLL-HORIZONTAL@ and @SCROLL-VERTICAL@ events (they... Stanislav Lomany
12:17 PM Feature #4164: implement misc UI features (frame options, misc attributes)
@AUTO-INDENT@ committed 3821c rev 12364. Stanislav Lomany

04/30/2021

02:53 PM Bug #5300: 4GL quirk about assigning SCREEN-VALUE in an editable browse
Testcases are attached. 4GL allows to set @SCREEN-VALUE@ for a column (even for an non-ediable browse) and then save ... Stanislav Lomany
02:35 PM Bug #5300 (New): 4GL quirk about assigning SCREEN-VALUE in an editable browse
Stanislav Lomany

04/24/2021

06:15 PM Bug #5245: BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
For future reference: there's a chance that this fix may regress the customer's scenarios from #3911. Stanislav Lomany
06:14 PM Bug #5245 (Review): BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
Fixed in 3821c rev 12327. Stanislav Lomany

04/23/2021

05:59 PM Feature #4164: implement misc UI features (frame options, misc attributes)
Fixed in 3821c revision 12322. Stanislav Lomany
11:03 AM Feature #4164: implement misc UI features (frame options, misc attributes)
Code review 3821c revision 12317.
@Text.initialize@ assumes there is always a valid parent frame. This assumption ...
Hynek Cihlar
10:10 AM Feature #4164: implement misc UI features (frame options, misc attributes)
@USE-TEXT@ changes are committed 3821c rev 12317. Please review. Stanislav Lomany
03:10 PM Bug #5245: BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
Stanislav, I don't have a standalone testcase for this #3911 issue. The previous version of this application didn't s... Sergey Ivanovskiy
09:20 AM Bug #5280: TREEVIEW: Vertical rollover feature: assure TREEVIEW is compatible with MS Treeview co...
The problem:
There is a feature of existing @TREEVIEW@ implementation in FWD: if a @TREEVIEW@ is navigated with ke...
Vladimir Tsichevski
09:19 AM Bug #5280 (Test): TREEVIEW: Vertical rollover feature: assure TREEVIEW is compatible with MS Tree...
Vladimir Tsichevski

04/22/2021

12:58 PM Bug #5245: BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
Sergey, do you have the customer's app from #3911 available on your machine? Unfortunately the latest version of it i... Stanislav Lomany
09:26 AM Bug #3176: The first item in popup menu is drawn as selected right after menu is opened.
Sergey: Please test and confirm we can close this. Greg Shah
09:26 AM Bug #3148: UP and DOWN keys don't work with menus
Sergey: Please test and confirm we can close this. Greg Shah

04/21/2021

06:45 PM Bug #5274: Cannot select menu items with keyboard in system popup menus
To reproduce, run a GUI scenario that displays a legacy window. Right click on the window title bar, select a menu it... Hynek Cihlar
06:43 PM Bug #5274 (New): Cannot select menu items with keyboard in system popup menus
Hynek Cihlar
06:41 PM Bug #3148 (Feedback): UP and DOWN keys don't work with menus
Fixed as of 3821c revision 12307. Hynek Cihlar
06:39 PM Bug #3176 (Feedback): The first item in popup menu is drawn as selected right after menu is opened.
Fixed with 3821c revision 12307. Hynek Cihlar
03:16 PM Feature #4164: implement misc UI features (frame options, misc attributes)
Stanislav Lomany wrote:
> > I don't understand how @explicitViewAs@ flag is used during frame construction. AFAIK t...
Constantin Asofiei
03:16 PM Feature #4164: implement misc UI features (frame options, misc attributes)
Constantin Asofiei wrote:
> I don't understand how @explicitViewAs@ flag is used during frame construction. AFAIK t...
Constantin Asofiei
03:15 PM Feature #4164: implement misc UI features (frame options, misc attributes)
> I don't understand how @explicitViewAs@ flag is used during frame construction. AFAIK this flag is used only on cl... Stanislav Lomany
03:02 PM Feature #4164: implement misc UI features (frame options, misc attributes)
I don't understand how @explicitViewAs@ flag is used during frame construction. AFAIK this flag is used only on clie... Constantin Asofiei
02:18 PM Feature #4164: implement misc UI features (frame options, misc attributes)
Guys, regarding @USE-TEXT@: currently in FWD this option does two things during conversion:
# Sets @frame.setUseText...
Stanislav Lomany
05:32 AM Feature #4164: implement misc UI features (frame options, misc attributes)
Focus on clearing everything except @SCROLL@. That one will be worked last. Greg Shah

04/20/2021

06:21 PM Feature #4164: implement misc UI features (frame options, misc attributes)
My estimates:
@SCROLL@ - unfortunately, that looks very time-consuming to me.
@USE-TEXT@ - it works, but frame la...
Stanislav Lomany
07:59 AM Bug #2971: rework tooltip support to use OverlayWindow
Although the Swing client does need the overlay window approach, for the web client I think tooltips are an ideal exa... Greg Shah

04/16/2021

11:52 AM Bug #5240 (Closed): BROWSE:SELECT-ROW(1) error on client
Code Review Task Branch 3821c Revisin 12267
I'm OK with the changes.
Greg Shah
11:51 AM Bug #5240: BROWSE:SELECT-ROW(1) error on client
> That's just a convenient way to return control to server and write to server log. I'm not sure if ever use ErrorMan... Greg Shah

04/15/2021

04:30 PM Bug #5240: BROWSE:SELECT-ROW(1) error on client
> may be, it would be better to handle errors where they arise: use @ErrorManager.recordOrThrowError(382, ...)@ metho... Stanislav Lomany
07:36 AM Bug #5240: BROWSE:SELECT-ROW(1) error on client
Vladimir Tsichevski wrote:
> Stanislav Lomany wrote:
>
> > Vladimir, this is caused by your recent change where e...
Vladimir Tsichevski

04/12/2021

07:25 AM Bug #5254: FWD extension control must follow the lifetime of the counterpart 4GL OCX/ActiveX
Reproduced from #3952-4 (from Constantin and Ovidiu):
> After a discussion with Ovidiu and some inspection of @<cu...
Greg Shah
07:22 AM Bug #5254 (New): FWD extension control must follow the lifetime of the counterpart 4GL OCX/ActiveX
Greg Shah
04:21 AM Feature #5253: SPREADSHEET: Create documentation
This is a follow task of #3821, see points 12 and 13 in #3821-160. Hynek Cihlar
04:20 AM Feature #5253 (New): SPREADSHEET: Create documentation
Hynek Cihlar
04:17 AM Feature #5252: SPREADSHEET: Publish Keikai contribution sources
This is a follow task of #3821, see #3821-167. Hynek Cihlar
04:16 AM Feature #5252 (New): SPREADSHEET: Publish Keikai contribution sources
Hynek Cihlar

04/10/2021

08:25 AM Bug #5240: BROWSE:SELECT-ROW(1) error on client
Stanislav Lomany wrote:
> Vladimir, this is caused by your recent change where exception is caught in @GenericWidg...
Vladimir Tsichevski
03:29 AM Bug #5240 (Review): BROWSE:SELECT-ROW(1) error on client
> 2. Another difference: OE displays error 382 (FWD displays error 4078).
> FWD throws the correct error 382 first, ...
Stanislav Lomany

04/09/2021

04:28 PM Bug #5245: BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
I found the similar thread #3911-51 and below. #3911-27 Sergey Ivanovskiy
04:05 PM Bug #5245: BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
It seems that it was related to the customer's project testcases 1 and 2, when all data after successful input are cl... Sergey Ivanovskiy
02:50 PM Bug #5245 (WIP): BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
Sergey, if you remember the specific case why this was added in @BrowseColumnWidget@, please let me know. I get "?" i... Stanislav Lomany
09:47 AM Feature #4661 (Closed): add support for missing formats to image loading
Code Review Task Branch 3821c Revision 12265
The changes are good.
Greg Shah
09:34 AM Feature #4661: add support for missing formats to image loading
Greg Shah wrote:
> Eugenie: Please review 12263.
I have no objections except requirement to close opened scream y...
Eugenie Lyzenko
09:09 AM Feature #4661: add support for missing formats to image loading
Please review rev. 12265(3821c) that should fix found issues. Sergey Ivanovskiy
06:28 AM Feature #4661: add support for missing formats to image loading
Eugenie: Please review 12263. Greg Shah
06:27 AM Feature #4661: add support for missing formats to image loading
Code Review Task Branch 3821c Revision 12263
The changes are good.
The only issue I see is that the @ImageGuiIm...
Greg Shah
06:19 AM Feature #4661: add support for missing formats to image loading
Code Review Task Branch 3821c Revision 12261
The change is good.
Greg Shah
03:47 AM Feature #4661 (Review): add support for missing formats to image loading
Committed revision 12263 (3821c) added svg image loading support for image and button widgets. PNG and SVG are suppor... Sergey Ivanovskiy

04/08/2021

05:42 PM Feature #4661: add support for missing formats to image loading
Please review the committed revision 12261 (3821c) that fixed #4661-17. I checked that PNG is supported format but SV... Sergey Ivanovskiy
11:48 AM Feature #4661: add support for missing formats to image loading
OK. I understand what is the issue. The following rule expects @FILE name@ part that can be missed... Sergey Ivanovskiy
10:56 AM Feature #4661: add support for missing formats to image loading
The image phrase within button definition @IMAGE IMAGE-SIZE-PIXELS 50 by 50 FROM X 15 Y 10@ throws this exception whe... Sergey Ivanovskiy
04:11 PM Bug #5240 (WIP): BROWSE:SELECT-ROW(1) error on client
I wish all tasks would contain a solution inside, like this one:) The change is good, I'll take a look into #5245 and... Stanislav Lomany

04/07/2021

03:32 PM Feature #4661: add support for missing formats to image loading
Yes, I see this too. I just tested with 3821c rev 12255. Greg Shah
11:16 AM Feature #4661: add support for missing formats to image loading
I found that there is a regression of the conversion code (3821c) that makes this program fail conversion... Sergey Ivanovskiy
09:28 AM Feature #4661 (WIP): add support for missing formats to image loading
Sergey Ivanovskiy
09:27 AM Feature #4661: add support for missing formats to image loading
No, these formats are just listed in #4661-1. OK. I will check .png and .svg images for the button and image widgets. Sergey Ivanovskiy
08:05 AM Feature #4661: add support for missing formats to image loading
Do you know of a customer requirement for animated mouse cursors? At this time I don't know of any such requirement.... Greg Shah
07:32 AM Feature #4661: add support for missing formats to image loading
There can be another idea to wrap images containing animation images into new widget type and use this widget for mou... Sergey Ivanovskiy
04:37 AM Feature #4661: add support for missing formats to image loading
It seems that animated images can't be displayed by the web client due to it just displays static bitmap images of re... Sergey Ivanovskiy
11:46 AM Bug #5118: TREELIST widget issues
Greg Shah wrote:
> OK, leave the 101 and remove the "code".
Done in rev. 12253.
> Please propose a 4GL code edit...
Vladimir Tsichevski
11:24 AM Bug #5118: TREELIST widget issues
OK, leave the 101 and remove the "code". Please propose a 4GL code edit for setting the "code" value. We can send i... Greg Shah
11:16 AM Bug #5118: TREELIST widget issues
Greg Shah wrote:
> Is this customer specific? Shouldn't such values be handled by 4GL source file changes? I don't...
Vladimir Tsichevski
11:12 AM Bug #5118: TREELIST widget issues
Is this customer specific? Shouldn't such values be handled by 4GL source file changes? I don't see why a generic w... Greg Shah
11:05 AM Bug #5118: TREELIST widget issues
3821c, rev. 12253. The width and caption of the first default column changed to 101 and "code" to make it compatible ... Vladimir Tsichevski

04/06/2021

02:44 PM Feature #4661: add support for missing formats to image loading
Roger has shown that we already support @.gif@.
For now, the primary requirement of this task is that FWD should s...
Greg Shah
11:24 AM Bug #5245: BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
The @BrowseColumnWidget.getScreenValue()@ convert an unknown character value to an empty string.
This code:...
Vladimir Tsichevski
11:20 AM Bug #5245 (Review): BrowseColumnWidget.getScreenValue(): incorrect handling of an unknown value
Vladimir Tsichevski
09:40 AM Bug #5241: NPE in LogicalTerminal.refreshBuffers
Greg Shah wrote:
> I don't object to that safety code, it makes sense to add.
>
> But I worry that there is a dee...
Vladimir Tsichevski
07:31 AM Bug #5241: NPE in LogicalTerminal.refreshBuffers
I don't object to that safety code, it makes sense to add.
But I worry that there is a deeper problem here which c...
Greg Shah
 

Also available in: Atom