FWD » Core Development » User Interface

10/18/2022

09:23 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
> The line numbers match with 3821c revision 14284.
Thanks for that Hynek, some more clean-up... Marian Edu

07:01 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
> This is the call stack where the definition gets created. It comes from the authentication plu... Hynek Cihlar

07:00 AM Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> Hynek Cihlar wrote:
> > There is a regression in a customer ChUI application. The cause was the... Hynek Cihlar

06:44 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
> There is a regression in a customer ChUI application. The cause was the following removed from... Marian Edu

06:29 AM Feature #6764: Improve trigger selection for keyboard events.

There is a regression in a customer ChUI application. The cause was the following removed from one of the @EventDefin... Hynek Cihlar

10/16/2022

07:15 AM Feature #6764: Improve trigger selection for keyboard events.

> This looks suspicious and deserves attention. OTOH if it doesn't cause issues we can defer it. Looking in the histo... Greg Shah

10/15/2022

04:10 AM Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> Hynek Cihlar wrote:
> > Marian Edu wrote:
> > > The patch is good, thank you.
> >
> > I wil... Hynek Cihlar

10/14/2022

11:34 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
> Marian Edu wrote:
> > The patch is good, thank you.
>
> I will run some more regression te... Marian Edu

11:05 AM Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> The patch is good, thank you.
I will run some more regression tests before I check it in.
Hynek Cihlar

11:02 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
> There is a regression after all. The test case is as follows:
>
> [...]
>
> This causes ... Marian Edu

10:35 AM Feature #6764: Improve trigger selection for keyboard events.

There is a regression after all. The test case is as follows:... Hynek Cihlar

05:30 AM Feature #6764 (Closed): Improve trigger selection for keyboard events.

Greg Shah

05:30 AM Feature #6764 (Test): Improve trigger selection for keyboard events.

Greg Shah

05:30 AM Feature #6764 (Closed): Improve trigger selection for keyboard events.

Greg Shah

04:17 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
> Marian Edu wrote:
> > Greg Shah wrote:
> > > Is there anything left open in this task?
> > ... Hynek Cihlar

03:37 AM Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> Greg Shah wrote:
> > Is there anything left open in this task?
>
> I don't have anything lef... Hynek Cihlar

01:42 AM Feature #6764: Improve trigger selection for keyboard events.

Greg Shah wrote:
> Is there anything left open in this task?
I don't have anything left, all our tests in 4GL are... Marian Edu

08:15 PM Feature #6764: Improve trigger selection for keyboard events.

Is there anything left open in this task? Greg Shah

10/11/2022

10:59 AM Feature #6764: Improve trigger selection for keyboard events.

6764.04.patch checked in 3821c revision 14285. Hynek Cihlar

10:45 AM Feature #6764: Improve trigger selection for keyboard events.

Yes, sorry. Greg Shah

10:30 AM Feature #6764: Improve trigger selection for keyboard events.

Greg Shah wrote:
> Hynek: Please merge the changes into 3821a.
Will do, I assume you mean 3821c. Hynek Cihlar

10:04 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek: Please merge the changes into 3821a. Greg Shah

09:57 AM Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> Hynek Cihlar wrote:
> > move @specificWidget@ before @lookupEventHelper@.
> Actually that is l... Hynek Cihlar

06:54 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:

> In @EventDefinition.lookup@ the condition for "global anywhere" excludes resource check, wh... Marian Edu

03:53 AM Feature #6764: Improve trigger selection for keyboard events.

Code review @6764.03.patch@.
The changes look good, I didn't do any regression testing though. Just a few minor co... Hynek Cihlar

10/10/2022

04:14 PM Feature #6764: Improve trigger selection for keyboard events.

Hynek: Are you OK with the proposed patch? Greg Shah

10/05/2022

07:09 AM Feature #6764: Improve trigger selection for keyboard events.

> 6764.03.patch
I've tested misc related cases for the browse and found no regressions. I'm OK with the changes fo... Stanislav Lomany

10/04/2022

09:45 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek/Stanislav: Please review. Greg Shah

10/03/2022

07:40 AM Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> Marian Edu wrote:
>
> > Attached the new patch.
Marian Edu

02:50 AM Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> Attached the new patch.
Looks like attachments are not accepted, it gives an 'internal server... Marian Edu

02:48 AM Feature #6764: Improve trigger selection for keyboard events.

I did a bit of additional clean-up, resolve function key code in @lookupWorker@ and don't waste time looking up throu... Marian Edu

09/30/2022

04:12 AM Feature #6764: Improve trigger selection for keyboard events.

Stanislav Lomany wrote:
> > 6764.02.patch
>
> There's a browse-specific piece of code which was dropped, and this... Marian Edu

09/29/2022

02:41 PM Feature #6764: Improve trigger selection for keyboard events.

> 6764.02.patch
There's a browse-specific piece of code which was dropped, and this part is regressed.
Testcase a... Stanislav Lomany

09:55 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
> With this kind of specialized behavior it probably doesn't make sense to be placed in utils,... Marian Edu

09:02 AM Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> Hynek Cihlar wrote:
> > OK. What about the "frame/window propagation"?
>
> That is handled i... Hynek Cihlar

08:30 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
> OK. What about the "frame/window propagation"?
That is handled in @lookupWorker@, first wal... Marian Edu

08:14 AM Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> Hynek Cihlar wrote:
> > Code review 6764.01.patch.
> >
> > I'm only worried about the remove... Hynek Cihlar

08:11 AM Feature #6764: Improve trigger selection for keyboard events.

Stanislav: Please review. Greg Shah

07:07 AM Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
> Code review 6764.01.patch.
>
> I'm only worried about the removed browser-specific behavior... Marian Edu

02:56 AM Feature #6764: Improve trigger selection for keyboard events.

Code review 6764.01.patch.
It is very nice that the result is a lot cleaner. I didn't find any particular issue fr... Hynek Cihlar

09/28/2022

08:20 AM Feature #6764: Improve trigger selection for keyboard events.

Constantin/Hynek: Please review. Greg Shah

08:13 AM Feature #6764 (Review): Improve trigger selection for keyboard events.

Please review the patch and let me know if you see anything wrong or something I've missed - doing a smoke test on @<... Marian Edu

08:11 AM Feature #6764 (WIP): Improve trigger selection for keyboard events.

Since #6528 is already closed I'll use this task to upload the patch that tries to clean-up/improve the event lookup ... Marian Edu