Activity
From 04/21/2026 to 05/20/2026
05/20/2026
- 12:48 PM Bug #11326: Reduce memory consumption of FWD clients
- Teodor, very good and complete. There is only this I have a problem with:...
- 07:12 AM Bug #11326 (Internal Test): Reduce memory consumption of FWD clients
- Teodor, the changes look good. Please do some small testing just to double-check normal setup works without appcds e...
- 01:54 AM Bug #11326: Reduce memory consumption of FWD clients
- Committed revision *16566* on task branch *11326c*:
* Improved implementation for support of client types.
05/19/2026
- 06:15 AM Bug #10915 (Review): ugly dialogs
- Please review the last fixes rev. 16605 (10915a).
- 06:14 AM Bug #10915 (WIP): ugly dialogs
- 01:41 AM Bug #11170 (Review): The caret position is initially wrong for DECIMAL/INTEGER FILL-IN widgets
- *Hynek*: Please review 11170a/rev. 16564.
05/18/2026
- 08:16 AM Bug #11170: The caret position is initially wrong for DECIMAL/INTEGER FILL-IN widgets
- Some updates:
* Successfully implemented the first idea from #11170-10. The second one was bringing too much overhea... - 06:56 AM Bug #11326: Reduce memory consumption of FWD clients
- Roger, I have forgot to include the @docker/repo/entrypoint/docker-entrypoint_prepare.sh@.
These changes were includ... - 03:48 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> I was thinking to replace the current approach with one which uses the already existing code ... - 03:43 AM Bug #11326: Reduce memory consumption of FWD clients
- Thanks.
I have found some issues while parsing @directory.xml@ from #11472, and I would need to rethink everything a... - 03:32 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor, 11326c looks OK.
05/15/2026
- 07:39 AM Bug #10915: ugly dialogs
- Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, what was the reason that this code was placed at the top ... - 07:36 AM Bug #10915: ugly dialogs
- Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, what was the reason that this code was placed at the top ... - 07:17 AM Bug #10915: ugly dialogs
- Sergey Ivanovskiy wrote:
> Hynek, what was the reason that this code was placed at the top before logKeyEvent(evt, "... - 04:22 AM Bug #10915 (Feedback): ugly dialogs
- Hynek, we need to discuss #10915-178 before I finalized the code for the review.
- 07:28 AM Bug #11326 (Review): Reduce memory consumption of FWD clients
- These are the latest changes to integrate AppCDS.
Also committed revision *16565* to branch *11326c*, which adds *... - 05:15 AM Bug #11326: Reduce memory consumption of FWD clients
- *Constantin*, I have done the *lib.client* change in *deploy.prepare* task for *hotel_gui* (which takes from *p2j/dis...
- 03:46 AM Bug #11326: Reduce memory consumption of FWD clients
- In the last couple of days, I have worked on integrating client AppCDS building process into @hotel_gui@ project:
* ... - 03:45 AM Bug #11170: The caret position is initially wrong for DECIMAL/INTEGER FILL-IN widgets
- Suppose a numeric-based fill-in (int, int64 or decimal). In 4GL, if the widget is cleared, either by realizing it (wi...
05/14/2026
- 03:57 PM Bug #10915: ugly dialogs
- Committed rev 16603(10915a) should fix most found issues (those that can be fixed) except
* *[MAJOR]* _functional... - 12:03 PM Bug #10915: ugly dialogs
- Hynek, what was the reason that this code was placed at the top before logKeyEvent(evt, "keypress"); and guards?
<pr... - 07:41 AM Bug #10915: ugly dialogs
- Committed revision 16600 (10915a) fixed
*[MAJOR]* functional startupServer (EmbeddedWebServerImpl): When DOJO...
05/13/2026
- 07:05 AM Bug #10915: ugly dialogs
- I think that false options can be omitted so...
- 07:02 AM Bug #10915: ugly dialogs
- To remove the dialog title bar we need to set this option value @noTitle : true@...
- 06:54 AM Bug #10915: ugly dialogs
- Stefanel, thank you for help with this dialog checking! If we require Close dialog button (X) and the title, then
<... - 04:51 AM Bug #10915: ugly dialogs
- Sergey Ivanovskiy wrote:
> Stefanel, could you help with the test case to check the reauth dialog style from @p2j.ss... - 04:47 AM Bug #10915: ugly dialogs
- If it is important for the caller of @ModalDialog@ to wait until its method is completed, then @await@ construction s...
- 04:43 AM Bug #10915: ugly dialogs
- This one
*[MAJOR]* functional doRedirectToLogoutPage: In the window.fetch(logoutPage).catch(...) branch the new co... - 04:01 AM Bug #10915: ugly dialogs
- Yes, the current code looks suitable but there can be issues with ModalDialog usages that needs to be checked. Actual...
- 03:48 AM Bug #10915: ugly dialogs
- Sergey Ivanovskiy wrote:
> Stefanel, could you help with the test case to check the reauth dialog style from @p2j.ss...
05/12/2026
- 02:01 PM Bug #10915: ugly dialogs
- This one
* *[MAJOR]* _functional_ @p2j.mouse.js@.@processMouseMove@: @isDialogDisplayed()@ guard at line 362 fire... - 01:40 PM Bug #10915: ugly dialogs
- Yes, this one @restoreConnectionDialog.setTitle(p2j.i18n.gettext("Server Unavailable"));@ can be removed because the ...
- 01:08 PM Bug #10915: ugly dialogs
- *Code review 10915a revisions 16559..16591*
* *[MAJOR]* _functional_ @chooseFiles@: @onError@ reads @actionResultsDi... - 12:37 PM Bug #10915: ugly dialogs
- At the moment of writing the code this part was intentional:
*[MAJOR]* functional ModalDialog.close: Bypasses hide... - 12:35 PM Bug #10915: ugly dialogs
- h1. FWD Code Review — Curated Findings
h2. Summary
20 files modified (2957 line diff). The prior CRITICAL findi... - 11:36 AM Bug #10915: ugly dialogs
- Finally I realized that @onHide@ and @onClose@ listeners should be protected and do not send any key and mouse events...
- 11:19 AM Bug #10915: ugly dialogs
- The current rev 16593 has this report
h1. FWD Code Review — Curated Findings
h2. Summary
This diff spans 20 ... - 10:47 AM Bug #10915: ugly dialogs
- Stefanel, could you help with the test case to check the reauth dialog style from @p2j.sso_reauth.js@?
- 09:58 AM Bug #10915: ugly dialogs
- Committed revision 16592 (10915a) fixed most of minor issues and I run new code review to collect what was left or ig...
- 05:38 AM Bug #10915: ugly dialogs
- Committed revision 16591.(10915a). Fixed critical and major issues found in the AI review (#10915a-155).
- 04:38 AM Bug #10915: ugly dialogs
- No, this is related to the dojo code. ...
- 04:28 AM Bug #10915: ugly dialogs
- I tested repeatedly the direct upload web functionality and found that buttons do not trigger actions if Enter was pr...
- 08:46 AM Bug #11326: Reduce memory consumption of FWD clients
- -deleted-
05/11/2026
- 11:32 AM Bug #10915 (WIP): ugly dialogs
- Some of those issues can be fixed. So I will change to WIP.
- 11:20 AM Bug #10915: ugly dialogs
- Running fwd-code-review reported these issues:
h1. FWD Code Review — Curated Findings
h2. Summary
The diff m... - 09:47 AM Bug #10915: ugly dialogs
- Committed revision 16588 (10915a) minor changes found by the gcd-code-style review.
- 07:53 AM Bug #10915: ugly dialogs
- Each time AI assistant based on Claude Code finds new issues. I rebased this branch 10915a up to rev 16587.
- 08:06 AM Bug #11326: Reduce memory consumption of FWD clients
- Constantin Asofiei wrote:
> Teodor Gorghe wrote:
> > One idea which I have is getting this information from @direct... - 08:00 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> One idea which I have is getting this information from @directory.xml@.
Yes, we need this. ... - 07:25 AM Bug #11326: Reduce memory consumption of FWD clients
- I have managed to get @hotel_gui@ project up and running from a docker container and I have made some initial changes...
- 03:57 AM Bug #11459: Hotel GUI Spreadsheet does not open
- @Hotel_GUI@ *Spreadsheet* does open on local setup without any issue.
When using a setup which uses docker contain... - 03:51 AM Bug #11459 (New): Hotel GUI Spreadsheet does not open
05/07/2026
- 02:12 PM Bug #11326: Reduce memory consumption of FWD clients
- Branch 11326b was merged to trunk rev 16559 and archived.
- 02:08 PM Bug #11326: Reduce memory consumption of FWD clients
- Constantin Asofiei wrote:
> The patch is in note #11326-122 that's the only change separator instead of pathSeparato... - 01:49 PM Bug #11326: Reduce memory consumption of FWD clients
- The patch is in note #11326-122 that's the only change separator instead of pathSeparator
- 01:47 PM Bug #11326: Reduce memory consumption of FWD clients
- Constantin Asofiei wrote:
> Eugenie, please do some smoke-tests with 11326b rev 16559 (has the fix from #11326-123),... - 01:41 PM Bug #11326: Reduce memory consumption of FWD clients
- Eugenie, please do some smoke-tests with 11326b rev 16559 (has the fix from #11326-123), if is OK I'll merge it ASAP.
- 01:31 PM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> Moved this task to *WIP* because we need to migrate customer application setup to use @lib.cl... - 01:30 PM Bug #11326: Reduce memory consumption of FWD clients
- Teodor, Eugenie is right; there was a 'typo':...
- 01:00 PM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> Branch 11326a was merged into trunk as rev. 16557 and archived.
>
> Moved this task to *WI... - 11:38 AM Bug #11326 (WIP): Reduce memory consumption of FWD clients
- Branch 11326a was merged into trunk as rev. 16557 and archived.
Moved this task to *WIP* because we need to migrat... - 11:32 AM Bug #11326 (Merge Pending): Reduce memory consumption of FWD clients
- Please merge 11326a now.
- 11:31 AM Bug #11326: Reduce memory consumption of FWD clients
- I don't think (I have also tested with the @lib.client@).
- 11:29 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> I have added the comment.
Thank you. Any other testing required? - 11:28 AM Bug #11326: Reduce memory consumption of FWD clients
- I have added the comment.
- 11:20 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> The problem came from *spawn* JVM, which tried to load @EventDefinition@ (throws @ClassNotFou... - 11:18 AM Bug #11326: Reduce memory consumption of FWD clients
- The problem came from *spawn* JVM, which tried to load @EventDefinition@ (throws @ClassNotFoundException@)
@EventDef... - 11:08 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> There was just one regression related with @PayloadSerializer@, which was fixed in +11326a/16... - 10:19 AM Bug #11326: Reduce memory consumption of FWD clients
- Regression testing has passed (ETF and two other customer applications).
There was just one regression related wit...
05/06/2026
- 06:30 AM Bug #11326: Reduce memory consumption of FWD clients
- ChUI regression testing has passed.
I will continue testing ETF and the remaining customer apps. - 06:29 AM Bug #11326: Reduce memory consumption of FWD clients
- Smoke-testing a customer app with 11326a passed.
05/05/2026
- 04:54 AM Bug #11191 (Review): ChUI: COMBO-BOX raises error 4058 on valid SCREEN-VALUE assignment
- *Hynek*: Please review 11191a/rev. 16549.
- 01:40 AM Bug #10938 (Review): Date FILL-IN: Incorrect SCREEN-VALUE after widget enablement
- Commited the fix to 10938a/rev. 16518. Your testcase and the customer app regressions are now solved.
Speaking of ...
05/04/2026
- 03:24 AM Bug #11326: Reduce memory consumption of FWD clients
- Thanks.
I have committed the changes into +11326a/r16534+. - 03:19 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor, for @LstExporter@:
* please fix the 'module' header (now has @com.goldencode.bytecode.LstExporter.java@)
* ...
05/01/2026
- 08:22 AM Bug #10915 (Review): ugly dialogs
- 03:15 AM Bug #10915: ugly dialogs
- Sergey Ivanovskiy wrote:
> >*[MINOR]* performance @p2j.dialogs Set@: Now stores dialog ID strings rather than DOM no... - 02:37 AM Bug #10915: ugly dialogs
- Sergey Ivanovskiy wrote:
> >*[MINOR]* functional @ModalDialog@: @this.removeTrigger = removeTrigger;@ was removed bu...
04/30/2026
- 04:03 PM Bug #10915: ugly dialogs
- Committed revision 16570 (10915a) should fix the most issues except
>*[MINOR]* performance @ModalDialog.createDojoDi... - 02:44 PM Bug #10915: ugly dialogs
- >*[MINOR]* performance @p2j.dialogs Set@: Now stores dialog ID strings rather than DOM nodes. If two @ModalDialog@ in...
- 02:41 PM Bug #10915: ugly dialogs
- >*[MINOR]* functional @ModalDialog@: @this.removeTrigger = removeTrigger;@ was removed but @this.addTrigger@ remains....
- 09:33 AM Bug #10915: ugly dialogs
- Sergey Ivanovskiy wrote:
> >*[MAJOR]* functional @ModalDialog.doDialogLayout@: Interleaves DOM writes and reads in a... - 09:23 AM Bug #10915: ugly dialogs
- Sergey Ivanovskiy wrote:
> Hynek, what does this note *"This is the critical bug flagged in the Redmine summary as n... - 09:21 AM Bug #10915: ugly dialogs
- Sergey Ivanovskiy wrote:
> >*[MAJOR]* functional @onKeyDown@: Moving the @p2j.isDialogDisplayed()@ early-return to t... - 07:57 AM Bug #10915: ugly dialogs
- >*[MAJOR]* functional @ModalDialog.doDialogLayout@: Interleaves DOM writes and reads in a way that forces layout thra...
- 07:12 AM Bug #10915: ugly dialogs
- >@[MINOR]@ functional @ModalDialog.show@: When @show()@ is called while @isVisible()@ is already true, the new code c...
- 06:41 AM Bug #10915: ugly dialogs
- >*[MAJOR]* functional @chooseFiles@: The new @dojo.connect(u, "onProgress", ...)@ handler unconditionally calls @acti...
- 06:34 AM Bug #10915: ugly dialogs
- >*[MAJOR]* functional @onKeyDown@: Moving the @p2j.isDialogDisplayed()@ early-return to the start of @keydown@ skips ...
- 06:02 AM Bug #10915: ugly dialogs
- Hynek Cihlar wrote:
> *Code review 10915a revisions 16537..16564*
>
> * *[CRITICAL]* _functional_ @ModalDialog@.@... - 04:47 AM Bug #10938: Date FILL-IN: Incorrect SCREEN-VALUE after widget enablement
- Razvan-Nicolae Chichirau wrote:
> *Question*: Do you want to treat this bug here or have it resolved in another sepa... - 01:56 AM Bug #10938: Date FILL-IN: Incorrect SCREEN-VALUE after widget enablement
- Hynek, sorry, you are 100% right. The @ScreenBuffer.UNCHANGED@ check from @shouldDisplayBlanks()@ was added as a resu...
04/29/2026
- 01:29 PM Bug #10915: ugly dialogs
- *Code review 10915a revisions 16537..16564*
* *[CRITICAL]* _functional_ @ModalDialog@.@show@: Returns @this.operatio... - 08:49 AM Bug #11326: Reduce memory consumption of FWD clients
- Committed revision *16533* on task branch *11326a*:
- Added LstExporter
Uncommitted revision *1* on @~/secure/cod... - 07:27 AM Bug #11326: Reduce memory consumption of FWD clients
- Constantin Asofiei wrote:
> Teodor Gorghe wrote:
> > I don't see a reason why I should cache @cls.getComponentType(... - 06:58 AM Bug #11326: Reduce memory consumption of FWD clients
- OK, let's focus on getting the items in category 1 (+ the @.lst@ tool) into 11326a.
> Do we want this to be option... - 06:58 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> I don't see a reason why I should cache @cls.getComponentType()@.
>
> [...]
That's a meth... - 06:52 AM Bug #11326: Reduce memory consumption of FWD clients
- OK, the @cls.getDeclaredConstructor()@ I understand the reasoning why should be cached, but I don't see a reason why ...
- 06:07 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> Committed revision *16531* on task branch *11326a*:
> * *PayloadSerializer* changes to optim... - 05:29 AM Bug #11326: Reduce memory consumption of FWD clients
- Committed revision *16531* on task branch *11326a*:
* *PayloadSerializer* changes to optimize metaspace memory usage. - 05:16 AM Bug #11326: Reduce memory consumption of FWD clients
- Greg, we need to add to FWD the tool to generate the .lst file, because at the application's container image build (n...
- 03:00 AM Bug #11326: Reduce memory consumption of FWD clients
- Committed revision *1* on @~/secure/code/p2j_repo/tools/dev_helpers@:
- Added @bytecode@ project. - 01:56 AM Bug #11326: Reduce memory consumption of FWD clients
- 1. Low Risk AND Quick to Implement
* Changes from below are already in *11326a* and were reviewed by Constantin.
* ... - 02:05 AM Bug #10938 (WIP): Date FILL-IN: Incorrect SCREEN-VALUE after widget enablement
- *Code review 10938a revisions 16514..16517*
There is a regressin, please see the following 4GL sample:...
04/28/2026
- 11:04 AM Bug #11326: Reduce memory consumption of FWD clients
- There are a range of different ideas discussed in this task, which is pretty confusing to understand status.
Teodo... - 10:16 AM Bug #11294 (WIP): Widget is overlapped by another widget after the parent frame is made visible
- *Code review 11294a revisions 16527..16531*
* *[MAJOR]* _performance_ @GenericFrame@.@makeFrameVisible@: @hiddenIds.... - 08:42 AM Bug #11211 (Review): Improve source detection when dispatching mouse wheel events
- Hynek Cihlar wrote:
> * *[MAJOR]* _functional_ @SwingMouseHandler@.@mouseWheelMoved@: Behavioral change from the p... - 08:37 AM Feature #5784 (Closed): multi-factor authentication
- In #10809, a generic OpenID plugin was implemented. This was merged to trunk in revision 16407.
04/27/2026
- 02:06 PM Bug #10915: ugly dialogs
- Rebased rev. 16564 (10915a).
04/24/2026
- 09:06 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> Where should I put this class?
>
> I should put in FWD, or I should create a separate proj... - 08:03 AM Bug #11326: Reduce memory consumption of FWD clients
- Where should I put this class?
I should put in FWD, or I should create a separate project? - 07:51 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor, please mind the effort in #9939 to get a @fwd-client.jar@ archive that contains only the client required clas...
- 07:42 AM Bug #11326: Reduce memory consumption of FWD clients
- I have found a workaround for resolving internal JVM stuff:
* we generate a base JVM listing file by just running FW... - 06:31 AM Bug #11326: Reduce memory consumption of FWD clients
- I have done some adjustments on my bytecode analyzer, but there are some issues:
* the are some dependencies which l... - 03:03 AM Bug #11326: Reduce memory consumption of FWD clients
- These JVM signatures are extracted from dependencies and from p2j bytecode analysis.
We are planing to use static ... - 02:57 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> This is how a generated @.lst@ file looks like
That is standard JVM method signatures. How ... - 02:55 AM Bug #11326: Reduce memory consumption of FWD clients
- This is how a generated @.lst@ file looks like
- 01:33 AM Bug #11326: Reduce memory consumption of FWD clients
- Teodor Gorghe wrote:
> Example of @.lst@ file.
Thanks, so this can be generated programmatically and not via appcds. - 01:21 AM Bug #11326: Reduce memory consumption of FWD clients
- Example of @.lst@ file.
04/23/2026
- 12:00 PM Bug #11326: Reduce memory consumption of FWD clients
- Teodor, please, in this order:
* if 11326a passed testing, this can be merged to trunk (I assume we want this in 986... - 08:19 AM Bug #11326: Reduce memory consumption of FWD clients
- OK
- 06:43 AM Bug #11326: Reduce memory consumption of FWD clients
- Hi Greg,
Could we discuss this in this afternoon's meeting?
I think the discussion on sso and lyra will be quick?... - 06:56 AM Bug #11211 (Internal Test): Improve source detection when dispatching mouse wheel events
- *Code review 11211a revisions 16514..16516*
* *[CRITICAL]* _functional_ @TreeBodyGuiImpl@.@canHandleMouseWheel@: @Tr... - 03:34 AM Bug #11314 (Test): UP/DOWN key pressed after CTRL_LEFT /CTRL_RIGHT in a COMBO-BOX doesn't select ...
- 03:34 AM Bug #11314: UP/DOWN key pressed after CTRL_LEFT /CTRL_RIGHT in a COMBO-BOX doesn't select the cor...
- Branch *11314a* was merged into trunk as rev. *16532* and archived.
- 03:20 AM Bug #11314 (Merge Pending): UP/DOWN key pressed after CTRL_LEFT /CTRL_RIGHT in a COMBO-BOX doesn'...
- Please merge 11314a in trunk.
- 02:57 AM Bug #11314: UP/DOWN key pressed after CTRL_LEFT /CTRL_RIGHT in a COMBO-BOX doesn't select the cor...
- The testing phase is done.
This is ready to be merged. - 01:51 AM Bug #11314: UP/DOWN key pressed after CTRL_LEFT /CTRL_RIGHT in a COMBO-BOX doesn't select the cor...
- Delia, if your changes only modify GUI classes such as @EntryFieldGuiImpl@, there is no point in running ChUI regress...
04/22/2026
- 07:50 AM Bug #11294 (Review): Widget is overlapped by another widget after the parent frame is made visible
- Committed the new changes to *11294a rev. 16531*.
I've tried to de-duplicate the logic of moving the widget to the... - 04:28 AM Bug #11044 (WIP): FILL-IN with Unknown Value: Incorrect Key Input Handling
- *Code review 11044b revisions 16454..16461*
The condition @getText().equals("?")@ to check unknown value is not righ... - 04:19 AM Bug #10938 (Review): Date FILL-IN: Incorrect SCREEN-VALUE after widget enablement
- Hynek Cihlar wrote:
> * *[MINOR]* _style_ @ThinClient@.@viewWorker@: The new 6-arg overload parameters @int windowId...
04/21/2026
- 07:28 AM Bug #11314: UP/DOWN key pressed after CTRL_LEFT /CTRL_RIGHT in a COMBO-BOX doesn't select the cor...
- Rebased the branch and found that a line (a variable declaration) is duplicated in @EntryFieldGuiImpl@ class. So, I r...
- 06:17 AM Bug #11314: UP/DOWN key pressed after CTRL_LEFT /CTRL_RIGHT in a COMBO-BOX doesn't select the cor...
- Smoke testing is done for a Customer GUI app and for Hotel GUI. No regression found.
- 03:50 AM Bug #10938 (WIP): Date FILL-IN: Incorrect SCREEN-VALUE after widget enablement
- *Code review 10938a revisions 16514..16516*
* *[MAJOR]* _functional_ @ThinClient@.@enableDisable@: On the @preview &... - 03:10 AM Bug #11294 (WIP): Widget is overlapped by another widget after the parent frame is made visible
- *Code review 11294a revisions 16468..16471*
* *[MAJOR]* _functional_ @GenericFrame@.@makeFrameVisible@: The @hiddenI...
Also available in: Atom