FWD » Core Development » Conversion Tools

10/05/2022

05:48 PM Feature #6237: OEUnit support

Yes, I assumed as much. It is exactly why I suggested that we create a new thread to execute @ClientCore.start()@ in... Greg Shah

03:31 PM Feature #6237: OEUnit support

Greg Shah wrote:
> As part of my suggestion in #6237-61, I was assuming that the test engine client would "Define th... Vladimir Tsichevski

03:27 PM Feature #6237: OEUnit support

As part of my suggestion in #6237-61, I was assuming that the test engine client would "Define the lambda as a execut... Greg Shah

03:00 PM Feature #6237: OEUnit support

I see some problem here.
The JUnit5 testing life cycle assumes the program is being called from outside multiple t... Vladimir Tsichevski

10/04/2022

06:51 AM Feature #6237: OEUnit support

To pass test descriptors over network, we need to make them @Serializable@ or @Externalizable@. Original POS test des... Vladimir Tsichevski

10/03/2022

12:59 PM Feature #6237: OEUnit support

I have no objection to the bootstrap cfg approach. Greg Shah

12:09 PM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> I think, we can use the @BootstrapConfig@ to pass the test engine discover request data... Vladimir Tsichevski

10:20 AM Feature #6237: OEUnit support

I think, we can use the @BootstrapConfig@ to pass the test engine discover request data from test runner (e.g. Eclips... Vladimir Tsichevski

09:13 AM Feature #6237: OEUnit support

One more change required for the JUnin5 framework would able to discover the custom test engine.
See @6237-addon.d... Vladimir Tsichevski

09/30/2022

02:05 PM Feature #6237: OEUnit support

Greg Shah wrote:
> As list of pending changes as noted by Vladimir via email:
>
> [...]
>
> For changes 1 thro... Vladimir Tsichevski

09/29/2022

02:03 PM Feature #6237: OEUnit support

As list of pending changes as noted by Vladimir via email:... Greg Shah

11:46 AM Feature #6237: OEUnit support

Greg Shah wrote:
> > So we need to either disable the Jupiter engine somehow (which I failed to find out how), or us... Vladimir Tsichevski

08:10 AM Feature #6237: OEUnit support

> So we need to either disable the Jupiter engine somehow (which I failed to find out how), or use our own markup for... Greg Shah

05:09 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Vladimir Tsichevski wrote:
>
> > The little problem with Eclipse is that it always u... Vladimir Tsichevski

09/28/2022

12:23 PM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> The little problem with Eclipse is that it always uses some version of the "Jupiter" ... Vladimir Tsichevski

12:16 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Code Review uast-hints-unit-test-type.diff
>
> I don't see any purpose in having @ELEM_UNITTES... Vladimir Tsichevski

09/27/2022

02:14 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Please look in your directory and search on @RemoteErrorData@ to see the ACL you must have to ens... Vladimir Tsichevski

02:08 PM Feature #6237: OEUnit support

Greg Shah wrote:
> No, not yet. I'm hoping to open this up on Thursday.
>
> Before any commit happens, I will ne... Vladimir Tsichevski

02:07 PM Feature #6237: OEUnit support

No, not yet. I'm hoping to open this up on Thursday.
Before any commit happens, I will need to see the proposed d... Greg Shah

02:02 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Code Review strict-junit5.diff
>
> I have no objections except to note that history entries ar... Vladimir Tsichevski

01:45 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Code Review junit5-custom-engine.zip
>
> Overall, I don't have an objection to the code so far... Vladimir Tsichevski

01:42 PM Feature #6237: OEUnit support

Code Review uast-hints-unit-test-type.diff
I don't see any purpose in having @ELEM_UNITTESTTYPE@ and also the @UNI... Greg Shah

01:37 PM Feature #6237: OEUnit support

Code Review strict-junit5.diff
I have no objections except to note that history entries are needed. Greg Shah

01:36 PM Feature #6237: OEUnit support

Code Review junit5-custom-engine.zip
Overall, I don't have an objection to the code so far. I understand it is ea... Greg Shah

01:12 PM Feature #6237: OEUnit support

Please look in your directory and search on @RemoteErrorData@ to see the ACL you must have to ensure access to the ne... Greg Shah

12:58 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Please post your code here.
Done:
@6237-remote-object-problem.diff@ Vladimir Tsichevski

12:38 PM Feature #6237: OEUnit support

Please post your code here. Greg Shah

12:19 PM Feature #6237: OEUnit support

Greg Shah wrote:
> > And the implementation class @UnitTestServer@
>
> @UnitTestServer@ should not be in packag... Vladimir Tsichevski

09:38 AM Feature #6237: OEUnit support

> I mean, if we replace the execution of a method of main by execution of an arbitrary lambda function, the access to... Greg Shah

09:11 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> and I got the error:
>
> [...]
From experiments I learned that some existing re... Vladimir Tsichevski

09/26/2022

06:14 PM Feature #6237: OEUnit support

Greg Shah wrote:
> > If we just replace the call @main.standardEntry()@ by some lambda passed to the method as a par... Vladimir Tsichevski

01:25 PM Feature #6237: OEUnit support

> If we just replace the call @main.standardEntry()@ by some lambda passed to the method as a parameter, we at least ... Greg Shah

10:57 AM Feature #6237: OEUnit support

Question: currently a remote instance of @MainEntry@ is not only obtained inside the @ClientCore.start()@, but some m... Vladimir Tsichevski

08:09 AM Feature #6237: OEUnit support

Not exactly. The conversation thread starts when the session is created with the server. Everything else (steps 1, ... Greg Shah

07:45 AM Feature #6237: OEUnit support

Greg Shah wrote:
> Vladimir Tsichevski wrote:
> > Greg Shah wrote:
> >
> > > > Why do we need another thread?
>... Vladimir Tsichevski

07:16 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Greg Shah wrote:
>
> > > Why do we need another thread?
> >
> > It seems incorrec... Greg Shah

07:10 AM Feature #6237: OEUnit support

Greg Shah wrote:
>
> I've been assuming that the JUnit stuff is implicitly batch mode, but perhaps it is possibl... Marian Edu

06:49 AM Feature #6237: OEUnit support

Greg Shah wrote:
> > Why do we need another thread?
>
> It seems incorrect to "take over" the calling thread to... Vladimir Tsichevski

05:47 AM Feature #6237: OEUnit support

> Does that mean we will not use the StandardServer at all?
Maybe. At least @StandardServer.standardEntry()@ is n... Greg Shah

09/23/2022

03:17 PM Feature #6237: OEUnit support

Greg Shah wrote:
> I think the way to go is to create a FWD client in-process from the JUnit @TestEngine@ code:
>... Vladimir Tsichevski

08:55 AM Feature #6237: OEUnit support

Greg Shah wrote:
> There is no patch posted for the hints changes.
Strangely enough :-( Vladimir Tsichevski

08:28 AM Feature #6237: OEUnit support

There is no patch posted for the hints changes. Greg Shah

05:57 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Greg Shah wrote:
>
> > For now, just implement the multilevel configuration approach... Vladimir Tsichevski

09/21/2022

12:25 PM Feature #6237: OEUnit support

Greg Shah wrote:
> For now, just implement the multilevel configuration approach. If it gets to the point where w... Vladimir Tsichevski

12:24 PM Feature #6237: OEUnit support

I've created a custom JUnit5 testing engine (see @junit5-custom-engine.zip@).
This is the first version, kind of P... Vladimir Tsichevski

12:11 PM Feature #6237: OEUnit support

> If we can define this configuration parameter at any level, using also file and directory hints, then we do not nee... Greg Shah

11:55 AM Feature #6237: OEUnit support

Greg Shah wrote:
> I think we need to know on a per-file level which unit testing framework is used. This is not ha... Vladimir Tsichevski

11:28 AM Feature #6237: OEUnit support

I think we need to know on a per-file level which unit testing framework is used. This is not hard to do. As noted ... Greg Shah

11:15 AM Feature #6237: OEUnit support

Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > So, you propose to pre-scan *all* classes in conversion project ... Vladimir Tsichevski

08:59 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> So, you propose to pre-scan *all* classes in conversion project to find any @assertXXX@... Marian Edu

08:44 AM Feature #6237: OEUnit support

> you propose to pre-scan all classes in conversion project to find any assertXXX statement
This is pretty easy. ... Greg Shah

08:19 AM Feature #6237: OEUnit support

Marian Edu wrote:
> Vladimir Tsichevski wrote:
>
> > So, since neither of these methods is reliable
>
> I real... Vladimir Tsichevski

08:09 AM Feature #6237: OEUnit support

> adding implementation for OEUnit Assert in FWD would be the easier path.
We will provide the OEUnit Assert supp... Greg Shah

07:21 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> So, since neither of these methods is reliable
I really fail to see the issue here... Marian Edu

09/20/2022

07:35 AM Feature #6237: OEUnit support

> emit a warning and ignore the unit test annotations.
This one. Greg Shah

05:54 AM Feature #6237: OEUnit support

Marian Edu wrote:
> Vladimir Tsichevski wrote:
>
> > I think, our goal is to have neither original @OEUnit@ nor @... Vladimir Tsichevski

02:56 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> I think, our goal is to have neither original @OEUnit@ nor @ABLUnit@ in the @PROPATH@... Marian Edu

09/19/2022

02:52 PM Bug #6768 (Rejected): End of comment "butted" against double-quote fails to parse

It is already fixed in the latest version of FWD. Greg Shah

01:44 PM Bug #6768: End of comment "butted" against double-quote fails to parse

I updated @uast/comment_test0.p@ to include some additional tests:... Roger Borrello

12:27 PM Bug #6768: End of comment "butted" against double-quote fails to parse

If this isn't an issue in FWD v4, then we can close this. Greg Shah

11:17 AM Bug #6768: End of comment "butted" against double-quote fails to parse

It was reported that this yields a conversion error (with an older version of FWD):... Roger Borrello

10:28 AM Bug #6768 (Rejected): End of comment "butted" against double-quote fails to parse

Roger Borrello

02:22 PM Feature #6237: OEUnit support

Marian Edu wrote:
> Greg Shah wrote:
> > Define a global parameter (in @cfg/p2j.cfg.xml@) for @OEUnit@ vs @ABLUnit@... Vladimir Tsichevski

01:36 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Define a global parameter (in @cfg/p2j.cfg.xml@) for @OEUnit@ vs @ABLUnit@. Then add an override... Marian Edu

11:35 AM Feature #6237: OEUnit support

Greg Shah wrote:
> The code is going to be very specific to converted 4GL code so it should be @com.goldencode.p2j.t... Vladimir Tsichevski

09:26 AM Feature #6237: OEUnit support

The code is going to be very specific to converted 4GL code so it should be @com.goldencode.p2j.testengine@. Greg Shah

09:20 AM Feature #6237: OEUnit support

I am implementing a specialized JUnit5 test engine for FWD. The code works, and now I need some permanent Java packag... Vladimir Tsichevski

09/16/2022

01:59 PM Feature #6237: OEUnit support

> How global parameters in @cfg/p2j.cfg.xml@ do relate to uast hints?
They are read from @UastHints@ as the defau... Greg Shah

01:16 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Define a global parameter (in @cfg/p2j.cfg.xml@) for @OEUnit@ vs @ABLUnit@. Then add an override... Vladimir Tsichevski

11:58 AM Feature #6237: OEUnit support

Define a global parameter (in @cfg/p2j.cfg.xml@) for @OEUnit@ vs @ABLUnit@. Then add an override in the @UastHints@ ... Greg Shah

11:49 AM Feature #6237: OEUnit support

We have some difficulty if we are going to implement both @OEUnit@ and @ABLUnit@.
There is a difference in the usa... Vladimir Tsichevski

09:14 AM Feature #6237: OEUnit support

Marian Edu wrote:
> this is the only OEUnit I'm aware of - [[https://github.com/CameronWills/OEUnit]]
Yes, I m... Vladimir Tsichevski

01:55 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> So we need to answer the following questions:
>
> # Whether or not and how class-l... Marian Edu

09/15/2022

05:06 PM Feature #6237: OEUnit support

> # Whether or not and how class-level annotations (@@BeforeClass@, @@AfterClass@) are used in 4gl procedures?
Ass... Greg Shah

04:41 PM Feature #6237: OEUnit support

The latest problem reveals that we need to convert 4gl procedure annotation either.
So we need to answer the follo... Vladimir Tsichevski

09/14/2022

12:26 PM Feature #6237: OEUnit support

To add JUnit support to converted projects, the following patch has to be applied to @build.gradle@:... Vladimir Tsichevski

09/13/2022

02:22 PM Feature #6237: OEUnit support

Constantin Asofiei wrote:
> The code previously meant to allow @@LegacyService@ annotation in the 4GL code. Now i... Vladimir Tsichevski

01:43 PM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
> > legacy_services.rules is built to allow @LegacyService@ ... Constantin Asofiei

01:40 PM Feature #6237: OEUnit support

Constantin Asofiei wrote:
> legacy_services.rules is built to allow @LegacyService@ annotations written directly in ... Vladimir Tsichevski

01:16 PM Feature #6237: OEUnit support

legacy_services.rules is built to allow @LegacyService@ annotations written directly in FWD code - these must be kept... Constantin Asofiei

12:59 PM Feature #6237: OEUnit support

Constantin Asofiei wrote:
> Regarding 3821c/14239:
> * please format @annotations/unit_test_support.rules@ by inden... Vladimir Tsichevski

06:10 AM Feature #6237: OEUnit support

Regarding 3821c/14239:
* please format @annotations/unit_test_support.rules@ by indenting the nested @rules@ tags - ... Constantin Asofiei

09/12/2022

05:42 PM Feature #6237: OEUnit support

Conversion of 4gl annotations to JUnit5 Java annotations implemented in 3821c rev. 14239. Vladimir Tsichevski

09/08/2022

03:37 AM Feature #6237: OEUnit support

I always use the @String@ methods directly (@equals()@ or @equalsIgnoreCase()@). Even if we did implement string con... Greg Shah