FWD » Core Development » Conversion Tools

10/21/2022

04:12 PM Feature #6237: OEUnit support

For now, keep using the Java names. Greg Shah

12:57 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Vladimir Tsichevski wrote:
> > Question: shall we use legacy names as display names or converted... Vladimir Tsichevski

12:49 PM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Question: shall we use legacy names as display names or converted Java class and method... Greg Shah

12:46 PM Feature #6237: OEUnit support

The updates in @6237-182-r14314.diff@:
# Legacy procedures-based tests support added: conversion and runtime.
# T... Vladimir Tsichevski

12:22 PM Feature #6237: OEUnit support

Question: shall we use legacy names as display names or converted Java class and method names? Vladimir Tsichevski

10/20/2022

10:24 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> I think, the correct code is:
>
> [...]
Yes, the config needs to be marked 'persist... Constantin Asofiei

10:23 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
> > Vladimir, what exactly are you trying to achieve? Gener... Constantin Asofiei

10:13 AM Feature #6237: OEUnit support

Constantin Asofiei wrote:
> For example: @new InvokeConfig(<program>).setProcedureHandle(h).run(arguments);@.
I... Vladimir Tsichevski

09:00 AM Feature #6237: OEUnit support

Constantin Asofiei wrote:
> Vladimir, what exactly are you trying to achieve? Generate Java code? Write Java code b... Vladimir Tsichevski

06:35 AM Feature #6237: OEUnit support

Vladimir, what exactly are you trying to achieve? Generate Java code? Write Java code by hand?
Direct usage of @C... Constantin Asofiei

10/19/2022

05:40 PM Feature #6237: OEUnit support

I am implementing the procedure-based unit tests for @ABLUnit@, and I do not know the proper way to create procedure ... Vladimir Tsichevski

05:13 PM Feature #6237: OEUnit support

Unlike JUnit5, @OEUnit@ uses a single instance to run all instance-related test methods in the class (JUnit5 by defau... Vladimir Tsichevski

08:50 AM Feature #6237: OEUnit support

Issues #6237-156, #6237-163 and #6237-170 now fixed in @6237-173-r14306.diff@. The diff is against the FWD rev. 14306. Vladimir Tsichevski

08:35 AM Feature #6237: OEUnit support

Greg Shah wrote:
> > The first method is not possible, since there is no such place in the custom test engine code, ... Vladimir Tsichevski

08:00 AM Feature #6237: OEUnit support

> The first method is not possible, since there is no such place in the custom test engine code, where all root test ... Greg Shah

07:54 AM Support #6848: TRPL questions and issues

Please just read the @pkgname@ and @classname@ annotations from the root node of the AST. You should not be converti... Greg Shah

10/18/2022

05:14 PM Feature #6237: OEUnit support

Another problem to solve related to test method discovery:
# the user requests running a Java package as JUnit Tes... Vladimir Tsichevski

04:18 PM Support #6848: TRPL questions and issues

I need to convert legacy class names to converted Java class name (simple names and FQN). Which library method should... Vladimir Tsichevski

11:34 AM Support #6848: TRPL questions and issues

> I need to either find the place in the code, in which the prog.symbol can be converted to java symbol and fix it
... Greg Shah

11:32 AM Support #6848: TRPL questions and issues

Greg Shah wrote:
> The @SYMBOL@ you are referencing may be the @prog.symbol@ type. Notice this is in the @prog@ (fo... Vladimir Tsichevski

10:49 AM Support #6848: TRPL questions and issues

The @SYMBOL@ you are referencing may be the @prog.symbol@ type. Notice this is in the @prog@ (for @Progress@) namesp... Greg Shah

10:05 AM Support #6848: TRPL questions and issues

Greg Shah wrote:
> We wouldn't get very far in conversion if we couldn't emit symbols or data types. The authoritat... Vladimir Tsichevski

10/17/2022

07:22 PM Support #6848: TRPL questions and issues

We wouldn't get very far in conversion if we couldn't emit symbols or data types. The authoritative source of how Ja... Greg Shah

07:07 PM Support #6848: TRPL questions and issues

I need to create a Java annotation of the following type:... Vladimir Tsichevski

06:15 PM Support #6848: TRPL questions and issues

@dbref/collect_refs.xml@ is currently disabled code and was left there on purpose. It is intended to identify refere... Greg Shah

04:28 PM Support #6848: TRPL questions and issues

About the legacy annotation attribute values.
Annotations containing attributes can look like this:... Vladimir Tsichevski

03:57 PM Support #6848: TRPL questions and issues

I found, that to convert a Java array to @java.util.List@, the @createListFromObject@ library function can be used.
... Vladimir Tsichevski

03:29 PM Support #6848: TRPL questions and issues

Questions about the TRPL language should be posted and discussed here. Vladimir Tsichevski

03:27 PM Support #6848 (New): TRPL questions and issues

Vladimir Tsichevski

08:16 AM Feature #6237: OEUnit support

Greg Shah wrote:
> Think about it and try to estimate the changes that are needed.
OK Vladimir Tsichevski

07:52 AM Feature #6237: OEUnit support

Think about it and try to estimate the changes that are needed. Greg Shah

07:46 AM Feature #6237: OEUnit support

Greg Shah wrote:
> > We will need to support dynamic tests then: the tests which are created in runtime by executing... Vladimir Tsichevski

07:20 AM Feature #6237: OEUnit support

> We will need to support dynamic tests then: the tests which are created in runtime by executing customer 4gl code. ... Greg Shah

07:12 AM Feature #6237: OEUnit support

Greg Shah wrote:
> Vladimir Tsichevski wrote:
> > Greg Shah wrote:
> > > > I think, we will not support these, ins... Vladimir Tsichevski

07:05 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Greg Shah wrote:
> > > I think, we will not support these, instead the declarative app... Greg Shah

10/14/2022

03:32 PM Feature #6237: OEUnit support

Current implementation was developed in assumption that the @discover@ method of a test engine is called by the test ... Vladimir Tsichevski

02:43 PM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Test inheritance is implemented in @OEUnit@: not only the methods in the class are disc... Vladimir Tsichevski

01:46 PM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Annotations conversion bug found: wrong Java annotation generated: @@BeforeAll@ instead... Vladimir Tsichevski

01:34 PM Feature #6237: OEUnit support

Annotations conversion bug found: wrong Java annotation generated: @@BeforeAll@ instead of @@BeforeEach@ and @@After... Vladimir Tsichevski

11:47 AM Feature #6237: OEUnit support

Test inheritance is implemented in @OEUnit@: not only the methods in the class are discovered, but also methods in su... Vladimir Tsichevski

10:12 AM Feature #6237: OEUnit support

Greg Shah wrote:
> > I think, we will not support these, instead the declarative approach will be used, so the same ... Vladimir Tsichevski

10:11 AM Feature #6237: OEUnit support

> I think, we will not support these, instead the declarative approach will be used, so the same class will look like... Greg Shah

10:06 AM Feature #6237: OEUnit support

@OEUnit@ supports dynamic test suites, for example:... Vladimir Tsichevski

10/13/2022

04:18 PM Feature #6237: OEUnit support

Greg Shah wrote:
> The key question that must be answered about OEUnit and ABLUnit is whether each test or each te... Vladimir Tsichevski

03:45 PM Feature #6237: OEUnit support

In @OEUnit@ test methods annotated with @@Ignore@, are not executed, but a test result with the status @Ignored@ is g... Vladimir Tsichevski

02:48 PM Feature #6237: OEUnit support

@OEUnit@ runs the after tests methods even when the before test methods and tests methods sequence ended prematurely ... Vladimir Tsichevski

02:36 PM Feature #6237: OEUnit support

@OEUnit@ has two more annotations: @DataProvider@ and @Fixture@. We probably need learn their meaning and add the sup... Vladimir Tsichevski

02:32 PM Feature #6237: OEUnit support

At least, @OEUnit@ discovers test recursively (when a test class is a test suite, references classes may be test suit... Vladimir Tsichevski

08:29 AM Feature #6237: OEUnit support

> I suppose FWD expects that everything is executed in some top-level 4gl procedure. In our case we have no such proc... Greg Shah

10/12/2022

06:14 PM Feature #6237: OEUnit support

Now tests can be executed remotely. See @6237-remote.diff@.
Here it is how it looks when running the @Run as... > ... Vladimir Tsichevski

10/05/2022

05:48 PM Feature #6237: OEUnit support

Yes, I assumed as much. It is exactly why I suggested that we create a new thread to execute @ClientCore.start()@ in... Greg Shah

03:31 PM Feature #6237: OEUnit support

Greg Shah wrote:
> As part of my suggestion in #6237-61, I was assuming that the test engine client would "Define th... Vladimir Tsichevski

03:27 PM Feature #6237: OEUnit support

As part of my suggestion in #6237-61, I was assuming that the test engine client would "Define the lambda as a execut... Greg Shah

03:00 PM Feature #6237: OEUnit support

I see some problem here.
The JUnit5 testing life cycle assumes the program is being called from outside multiple t... Vladimir Tsichevski

10/04/2022

06:51 AM Feature #6237: OEUnit support

To pass test descriptors over network, we need to make them @Serializable@ or @Externalizable@. Original POS test des... Vladimir Tsichevski

10/03/2022

12:59 PM Feature #6237: OEUnit support

I have no objection to the bootstrap cfg approach. Greg Shah

12:09 PM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> I think, we can use the @BootstrapConfig@ to pass the test engine discover request data... Vladimir Tsichevski

10:20 AM Feature #6237: OEUnit support

I think, we can use the @BootstrapConfig@ to pass the test engine discover request data from test runner (e.g. Eclips... Vladimir Tsichevski

09:13 AM Feature #6237: OEUnit support

One more change required for the JUnin5 framework would able to discover the custom test engine.
See @6237-addon.d... Vladimir Tsichevski

09/30/2022

02:05 PM Feature #6237: OEUnit support

Greg Shah wrote:
> As list of pending changes as noted by Vladimir via email:
>
> [...]
>
> For changes 1 thro... Vladimir Tsichevski

09/29/2022

02:03 PM Feature #6237: OEUnit support

As list of pending changes as noted by Vladimir via email:... Greg Shah

11:46 AM Feature #6237: OEUnit support

Greg Shah wrote:
> > So we need to either disable the Jupiter engine somehow (which I failed to find out how), or us... Vladimir Tsichevski

08:10 AM Feature #6237: OEUnit support

> So we need to either disable the Jupiter engine somehow (which I failed to find out how), or use our own markup for... Greg Shah

05:09 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Vladimir Tsichevski wrote:
>
> > The little problem with Eclipse is that it always u... Vladimir Tsichevski

09/28/2022

12:23 PM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> The little problem with Eclipse is that it always uses some version of the "Jupiter" ... Vladimir Tsichevski

12:16 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Code Review uast-hints-unit-test-type.diff
>
> I don't see any purpose in having @ELEM_UNITTES... Vladimir Tsichevski

09/27/2022

02:14 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Please look in your directory and search on @RemoteErrorData@ to see the ACL you must have to ens... Vladimir Tsichevski

02:08 PM Feature #6237: OEUnit support

Greg Shah wrote:
> No, not yet. I'm hoping to open this up on Thursday.
>
> Before any commit happens, I will ne... Vladimir Tsichevski

02:07 PM Feature #6237: OEUnit support

No, not yet. I'm hoping to open this up on Thursday.
Before any commit happens, I will need to see the proposed d... Greg Shah

02:02 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Code Review strict-junit5.diff
>
> I have no objections except to note that history entries ar... Vladimir Tsichevski

01:45 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Code Review junit5-custom-engine.zip
>
> Overall, I don't have an objection to the code so far... Vladimir Tsichevski

01:42 PM Feature #6237: OEUnit support

Code Review uast-hints-unit-test-type.diff
I don't see any purpose in having @ELEM_UNITTESTTYPE@ and also the @UNI... Greg Shah

01:37 PM Feature #6237: OEUnit support

Code Review strict-junit5.diff
I have no objections except to note that history entries are needed. Greg Shah

01:36 PM Feature #6237: OEUnit support

Code Review junit5-custom-engine.zip
Overall, I don't have an objection to the code so far. I understand it is ea... Greg Shah

01:12 PM Feature #6237: OEUnit support

Please look in your directory and search on @RemoteErrorData@ to see the ACL you must have to ensure access to the ne... Greg Shah

12:58 PM Feature #6237: OEUnit support

Greg Shah wrote:
> Please post your code here.
Done:
@6237-remote-object-problem.diff@ Vladimir Tsichevski

12:38 PM Feature #6237: OEUnit support

Please post your code here. Greg Shah

12:19 PM Feature #6237: OEUnit support

Greg Shah wrote:
> > And the implementation class @UnitTestServer@
>
> @UnitTestServer@ should not be in packag... Vladimir Tsichevski

09:38 AM Feature #6237: OEUnit support

> I mean, if we replace the execution of a method of main by execution of an arbitrary lambda function, the access to... Greg Shah

09:11 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> and I got the error:
>
> [...]
From experiments I learned that some existing re... Vladimir Tsichevski

09/26/2022

06:14 PM Feature #6237: OEUnit support

Greg Shah wrote:
> > If we just replace the call @main.standardEntry()@ by some lambda passed to the method as a par... Vladimir Tsichevski

01:25 PM Feature #6237: OEUnit support

> If we just replace the call @main.standardEntry()@ by some lambda passed to the method as a parameter, we at least ... Greg Shah

10:57 AM Feature #6237: OEUnit support

Question: currently a remote instance of @MainEntry@ is not only obtained inside the @ClientCore.start()@, but some m... Vladimir Tsichevski

08:09 AM Feature #6237: OEUnit support

Not exactly. The conversation thread starts when the session is created with the server. Everything else (steps 1, ... Greg Shah

07:45 AM Feature #6237: OEUnit support

Greg Shah wrote:
> Vladimir Tsichevski wrote:
> > Greg Shah wrote:
> >
> > > > Why do we need another thread?
>... Vladimir Tsichevski

07:16 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Greg Shah wrote:
>
> > > Why do we need another thread?
> >
> > It seems incorrec... Greg Shah

07:10 AM Feature #6237: OEUnit support

Greg Shah wrote:
>
> I've been assuming that the JUnit stuff is implicitly batch mode, but perhaps it is possibl... Marian Edu

06:49 AM Feature #6237: OEUnit support

Greg Shah wrote:
> > Why do we need another thread?
>
> It seems incorrect to "take over" the calling thread to... Vladimir Tsichevski

05:47 AM Feature #6237: OEUnit support

> Does that mean we will not use the StandardServer at all?
Maybe. At least @StandardServer.standardEntry()@ is n... Greg Shah

09/23/2022

03:17 PM Feature #6237: OEUnit support

Greg Shah wrote:
> I think the way to go is to create a FWD client in-process from the JUnit @TestEngine@ code:
>... Vladimir Tsichevski

08:55 AM Feature #6237: OEUnit support

Greg Shah wrote:
> There is no patch posted for the hints changes.
Strangely enough :-( Vladimir Tsichevski

08:28 AM Feature #6237: OEUnit support

There is no patch posted for the hints changes. Greg Shah

05:57 AM Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Greg Shah wrote:
>
> > For now, just implement the multilevel configuration approach... Vladimir Tsichevski