FWD » Testing

03/17/2021

03:18 PM Feature #1888 (Closed): integrate the framework into the build

Greg Shah

03:14 PM Feature #1888: integrate the framework into the build

Greg Shah wrote:
> It looks good.
>
> Please add javadoc for @AbstractDateTest.createDate()@, @TestDateFormat.bef... Vladimir Tsichevski

02:57 PM Feature #1888: integrate the framework into the build

It looks good.
Please add javadoc for @AbstractDateTest.createDate()@, @TestDateFormat.beforeClass()@, @TestDateFo... Greg Shah

02:30 PM Feature #1888: integrate the framework into the build

Greg Shah wrote:
> Code Review Task Branch 3821c Revision 12130
>
> It is good. I really only see coding standar... Vladimir Tsichevski

11:13 AM Feature #1888: integrate the framework into the build

Code Review Task Branch 3821c Revision 12130
It is good. I really only see coding standards issues.
1. Please ... Greg Shah

09:56 AM Feature #1888 (Review): integrate the framework into the build

JUnit-based testing support was added in 3821c rev. 12130.
Also 139 tests in 13 containers for parsing/applying va... Vladimir Tsichevski

03/16/2021

11:26 AM Feature #1888: integrate the framework into the build

By generic, I mean that the code would be used in other projects outside of FWD. Greg Shah

11:26 AM Feature #1888: integrate the framework into the build

4GL (OE) related stuff is FWD-specific so that is NOT generic. Greg Shah

10:42 AM Feature #1888: integrate the framework into the build

Greg Shah wrote:
> ... For anything generic, please put the helpers in @com.goldencode.testing@.
By anything ge... Vladimir Tsichevski

10:39 AM Feature #1888: integrate the framework into the build

> We can use something like com.goldencode.p2j.tests as the base package name for that classes, OK?
For any test h... Greg Shah

10:35 AM Feature #1888: integrate the framework into the build

Greg Shah wrote:
> Please put the test classes into the same package as the classes they test, but with a @test@ bas... Vladimir Tsichevski

03/13/2021

12:08 PM Feature #1888: integrate the framework into the build

Greg Shah wrote:
> I know and accept that this different from the standard Maven layout, but we already deviate. ... Vladimir Tsichevski

11:22 AM Feature #1888: integrate the framework into the build

Please put the test classes into the same package as the classes they test, but with a @test@ base directory instead ... Greg Shah