Project

General

Profile

Activity

From 06/08/2025 to 07/07/2025

07/07/2025

10:05 AM Support #6859 (WIP): preprocessor tests
Stefan Vieru
09:58 AM Support #6859: preprocessor tests
Updated points 7 and 2 in r16037. Stefan Vieru
09:11 AM Support #6859: preprocessor tests
1. OE preprocessing does this, in documentation yes, it is said to be @;'@ -> @'@, but in OE @;'@ -> @`@, unless I'm ... Stefan Vieru
08:36 AM Support #6859: preprocessor tests
Code Review Task Branch 6859b Revisions 16029 through 16036
These changes will need to be tested with the full ran...
Greg Shah
04:45 AM Support #6859: preprocessor tests
I've rebased @6859b@ and created @r16036@.
I committed all the changes from preprocessor bug-fix branches (except #1...
Stefan Vieru

07/02/2025

05:45 AM Support #10238: migrate UDF tests to ABLUnit and expand coverage
See [[p2j:UDF Tests]]. Greg Shah
05:44 AM Support #10238 (New): migrate UDF tests to ABLUnit and expand coverage
Greg Shah

06/27/2025

07:46 AM Support #10113 (Pending): evaluate and test code coverage tooling
I have ran the conversion with one big GUI customer application. It took a bit longer (Maybe 20%) but it finished OK.... Florin Eugen Rotaru

06/25/2025

07:42 AM Support #6859: preprocessor tests
While analyzing conversion logs with this changes I cam across an issue and created the following testcase:
{{Coll...
Stefan Vieru

06/23/2025

08:39 AM Support #6859 (Review): preprocessor tests
Updated 6859b to r15984 (only minor history entry updates)
I think this is ready for a review, the testcases are on ...
Stefan Vieru

06/20/2025

10:50 AM Support #6859: preprocessor tests
Created @r15983@ in branch @6859b@
The changes are:
* added possibility of running the FWD driver with a directory ...
Stefan Vieru
08:25 AM Support #6860 (Test): lexer tests
Greg Shah
08:01 AM Support #6860: lexer tests
Branch 6860a was merged into trunk as rev. 15992 and archived. Florin Eugen Rotaru
07:45 AM Support #6860 (Merge Pending): lexer tests
You can merge 6860a to trunk now. Greg Shah
04:04 AM Support #6860: lexer tests
I've rebased branch 6860a to rev. 16007. I have tested Hotel GUI conversion and also ChUI regression (conversion only... Florin Eugen Rotaru

06/19/2025

10:59 AM Support #6859: preprocessor tests
I updated testcases with the latest tests, also moved them to @tests/conversion/preprocessor@.
Will have to adapt F...
Stefan Vieru
10:38 AM Support #10113: evaluate and test code coverage tooling
I have committed a the new @build_coverage.xml@ to Testcases. It now downloads the dependencies(only if they are miss... Florin Eugen Rotaru

06/17/2025

10:58 AM Feature #1889: rework the date.java internal tests as real unit tests
As a fallback, you can try creating a tunnel to 192.168.1.37 on our internal GCD network. That is the same system as... Greg Shah
09:20 AM Feature #1889: rework the date.java internal tests as real unit tests
Florin Eugen Rotaru wrote:
> Vladimir Tsichevski wrote:
>
> > Ran into another problem: I can’t access the testca...
Vladimir Tsichevski
03:09 AM Feature #1889: rework the date.java internal tests as real unit tests
Vladimir Tsichevski wrote:
> Ran into another problem: I can’t access the testcases repo myself due to a connectio...
Florin Eugen Rotaru
03:08 AM Feature #1889: rework the date.java internal tests as real unit tests
Greg Shah wrote:
> Florin: Do the tests all pass in both OE and FWD?
* In OE all tests PASS.
* In FWD:
** For...
Florin Eugen Rotaru
07:00 AM Support #10113: evaluate and test code coverage tooling
Greg Shah wrote:
> How about adding code to @build_coverage.xml@ to download and copy the jars if they are not there...
Florin Eugen Rotaru
06:59 AM Support #10113: evaluate and test code coverage tooling
How about adding code to @build_coverage.xml@ to download and copy the jars if they are not there? That way the depe... Greg Shah
06:54 AM Support #10113: evaluate and test code coverage tooling
Greg Shah wrote:
> > Shall the change to the @p2j@ mentioned in #10113-3 be merged?
>
> I don't want JaCoCo to be...
Florin Eugen Rotaru
06:42 AM Support #10113: evaluate and test code coverage tooling
> Shall the change to the @p2j@ mentioned in #10113-3 be merged?
I don't want JaCoCo to be a standard dependency o...
Greg Shah
03:34 AM Support #10113: evaluate and test code coverage tooling
Shall the change to the @p2j@ mentioned in #10113-3 be merged? Florin Eugen Rotaru

06/16/2025

07:18 PM Support #6860: lexer tests
> I've added tests and harness tests for the missing branches of the lexer rules according to the code coverage repo... Greg Shah
06:58 PM Support #6860 (Test): lexer tests
Greg Shah
06:58 PM Support #6860: lexer tests
Overall, the changes are very good. Have you made any changes to fill in code coverage gaps?
It is a little confu...
Greg Shah
04:08 PM Support #10113 (Internal Test): evaluate and test code coverage tooling
Overall, I'm OK with the approach. I like that it leaves the existing ant rules unchanged. The primary drawback is ... Greg Shah
09:02 AM Support #10113: evaluate and test code coverage tooling
Florin Eugen Rotaru wrote:
> Roger Borrello wrote:
> > If there are minor modifications, can they be extracted out ...
Roger Borrello
08:23 AM Support #10113: evaluate and test code coverage tooling
Should I devise such a script for all the remaining projects and post them here for review? Florin Eugen Rotaru
08:11 AM Support #10113: evaluate and test code coverage tooling
I've attached a @build_coverage.xml@ for the @testcases@ project. It's based on a @zfile_set.xml@. It needs a @p2j@ w... Florin Eugen Rotaru
02:33 PM Feature #1889: rework the date.java internal tests as real unit tests
> To support this an instruction should exists on where to put such sources, the rules on how the classes and directo... Greg Shah
02:28 PM Feature #1889 (Test): rework the date.java internal tests as real unit tests
Florin: Do the tests all pass in both OE and FWD? Greg Shah
12:20 PM Feature #1889: rework the date.java internal tests as real unit tests
Greg Shah wrote:
> > I’ve attached the following ABLUnit classes for testing date format validation and parsing:
> ...
Vladimir Tsichevski
11:29 AM Feature #1889: rework the date.java internal tests as real unit tests
> I’ve attached the following ABLUnit classes for testing date format validation and parsing:
Do any of these rela...
Greg Shah
11:00 AM Feature #1889: rework the date.java internal tests as real unit tests
I’ve attached the following ABLUnit classes for testing date format validation and parsing:
- @DateParseTestBase.c...
Vladimir Tsichevski
10:14 AM Feature #1889: rework the date.java internal tests as real unit tests
Greg Shah wrote:
> There are many date literals in the @date.java@ tests which are not present in the lexer testcase...
Florin Eugen Rotaru
08:34 AM Feature #1889: rework the date.java internal tests as real unit tests
There are many date literals in the @date.java@ tests which are not present in the lexer testcases. To be clear: all... Greg Shah
02:22 AM Feature #1889 (Review): rework the date.java internal tests as real unit tests
Florin Eugen Rotaru
06:14 AM Support #6859: preprocessor tests
I have updated @6859b@ with @r15982@
The change contains the new flags for each of the comment and string type.
Gre...
Stefan Vieru

06/13/2025

10:20 AM Support #6860: lexer tests
I made a new commit to *testcases*. I've added tests and harness tests for the missing branches of the lexer rules ac... Florin Eugen Rotaru
05:06 AM Support #10113: evaluate and test code coverage tooling
I suppose that can be solved if for each such case the @classpath@ passed to the @ConversionDriver@ is adapted to con... Florin Eugen Rotaru
04:44 AM Support #10113: evaluate and test code coverage tooling
Greg Shah wrote:
> With #9725 we are getting rid of the old ways of running conversion, so we should not spend time ...
Florin Eugen Rotaru

06/12/2025

11:14 AM Support #10113: evaluate and test code coverage tooling
With #9725 we are getting rid of the old ways of running conversion, so we should not spend time on those. Greg Shah
10:00 AM Support #10113: evaluate and test code coverage tooling
Roger Borrello wrote:
> # Can it be generalized to work for all (or almost all) of the applications we might see wit...
Roger Borrello
09:57 AM Support #10113: evaluate and test code coverage tooling
Florin Eugen Rotaru wrote:
> I have moved the Ant code in a separate @build_coverage.xml@. I have attached the file....
Roger Borrello
09:39 AM Support #10113: evaluate and test code coverage tooling
I have moved the Ant code in a separate @build_coverage.xml@. I have attached the file. Running @ant -f build_coverag... Florin Eugen Rotaru
08:41 AM Support #10113: evaluate and test code coverage tooling
Roger Borrello wrote:
> I can't say as I am familiar with what JaCoCo is doing, but it looks great!
>
> It still ...
Florin Eugen Rotaru
08:34 AM Support #10113: evaluate and test code coverage tooling
I can't say as I am familiar with what JaCoCo is doing, but it looks great!
It still seems a little intrusive to t...
Roger Borrello
06:44 AM Support #10113: evaluate and test code coverage tooling
Roger Borrello wrote:
> That looks like a great addition. Is there any significant time added to the build? Can you ...
Florin Eugen Rotaru

06/11/2025

10:29 AM Support #10113: evaluate and test code coverage tooling
That looks like a great addition. Is there any significant time added to the build? Can you post a sample report? Roger Borrello
08:04 AM Support #10113: evaluate and test code coverage tooling
Added Roger. Florin Eugen Rotaru
08:03 AM Support #10113 (Review): evaluate and test code coverage tooling
I have managed to add code coverage measuring for the @ant convert@ tag (I did it for the *Dataset* project).
Firs...
Florin Eugen Rotaru

06/10/2025

10:15 AM Support #10113 (WIP): evaluate and test code coverage tooling
Using *JaCoCo*, there are two ways to monitor the code coverage.
* First is wrapping the ant task which runs the *...
Florin Eugen Rotaru
05:29 AM Support #10113: evaluate and test code coverage tooling
The idea is to use existing tooling such as JaCoCo or JCov to calculate code coverage for an area of FWD code. For n... Greg Shah
05:23 AM Support #10113 (Pending): evaluate and test code coverage tooling
Greg Shah
 

Also available in: Atom