Activity

From 02/28/2023 to 03/29/2023

03/29/2023

09:12 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Constantin, I think it is good to go... for 3rd time. 3rd time should be the lucky one. Galya B
09:10 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Ok, that's straight weird. Every third run of the same procedure (without deleting the output to files) writes the fi... Galya B
09:00 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: I've found a weird behavior just now. If the @output to@ file is already existing, the text goes to @outputToFile@ in... Galya B
08:56 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Constantin Asofiei wrote:
> Did you test the batch client with a program using @OUTPUT TO somefile.txt@?
Yes. I'v... Galya B
08:36 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Galya, try this for appserver connect @-AppService app_server -S 21200 -H localhost -sessionModel Session-free -Direc... Constantin Asofiei
06:06 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Otherwise chui (terminal / swing) and batch work fine - generate the file and output any other display text. Galya B
05:46 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Constantin Asofiei wrote:
> Galya: please do some tests in batch/appserver/ChUI, with code like this:
> [...]
If... Galya B
02:19 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Galya Bogdanova wrote:
> Lol. My... Is this the overwrite message warning for... I haven't set this myself.
If some... Constantin Asofiei

03/28/2023

11:48 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: ... Galya B
11:45 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: I didn't receive notification for the notes from my last comment, so let me get up to date... Galya B
11:42 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Constantin Asofiei wrote:
> Please prepare these changes in 5701c, and check if the @filesys.c@ native code can be a... Galya B
11:08 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Greg, I think you are right. This may affect the redirected terminal in both ChUI and batch processes.
For batch ... Constantin Asofiei
11:07 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Greg Shah wrote:
> The 4GL knows when its STDIO is redirected and it changes its behavior based on that. I think we... Eugenie Lyzenko
10:57 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: The 4GL knows when its STDIO is redirected and it changes its behavior based on that. I think we implemented the @Ja... Greg Shah
10:47 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Constantin Asofiei wrote:
> Please prepare these changes in 5701c, and check if the @filesys.c@ native code can be a... Galya B
10:42 AM Bug #5701 (WIP): logfile names for -O outputToFile use the spawner pid instead of the Java (FWD c...: Galya Bogdanova wrote:
> Even better if @IS_OUTPUT_REDIRECTED@ is moved to @FileChecker@.
Please prepare these chan... Constantin Asofiei
10:41 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Even better if @IS_OUTPUT_REDIRECTED@ is moved to @FileChecker@. Galya B
10:39 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Constantin Asofiei wrote:
> This patch seems to solve the issue:
> [...]
>
> But I don't know if this is the cor... Galya B
10:37 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Constantin, this is troublesome. With #5701 stdout is not redirected in the native code, but programmatically in Java... Galya B
10:37 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: This patch seems to solve the issue:... Constantin Asofiei
10:33 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Galya Bogdanova wrote:
> Constantin Asofiei wrote:
> > This can be seen with appservers, where there is a @MESSAGE ... Constantin Asofiei
10:29 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Constantin Asofiei wrote:
> This can be seen with appservers, where there is a @MESSAGE "Message" VIEW-AS ALERT-BOX... Galya B
10:26 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Galya, there is a regression in trunk revs 14506/14507.
This can be seen with appservers, where there is a @MESS... Constantin Asofiei
04:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: The Session/Thread/User combo context came as ported from LogHelper where it was used only for some logs. I tried to ... Galya B
04:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: A few remarks about the identification of to who a log message belongs:
* @SERVER, Session:00000007, Thread:0000001F... Constantin Asofiei

03/23/2023

12:53 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Constantin Asofiei wrote:
> Correct, FWD doesn't have a broker in OE terms. The broker is used only for remote laun... Greg Shah
10:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: I'm posting sample log files for format review.
First a few explanations:
- I've set up the infrastructure for lo... Galya B
06:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Correct, FWD doesn't have a broker in OE terms. The broker is used only for remote launching; Greg, I think any log ... Constantin Asofiei
03:19 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Constantin Asofiei wrote:
> Please describe what broker log content you refer to. You mean the case when the appser... Galya B

03/22/2023

02:55 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya Bogdanova wrote:
> Broker log content also needs to be replicated from OE 1:1 which it's not currently.
Pleas... Constantin Asofiei
09:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: > > > Also that way I won't have to rename CentralLogger to SideLogger.
> >
> > I don't see why this is needed reg... Greg Shah
09:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Constantin, you asked before about the appserver/broker logs and what is happening with them.
With #5753 there wil... Galya B
08:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg Shah wrote:
> > Also that way I won't have to rename CentralLogger to SideLogger.
>
> I don't see why this i... Galya B
08:57 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: > This Status, API, IDE thing - isn't it like any cloud logging + IDE plugin? Any cloud logging has an API and a Java... Greg Shah
03:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: This Status, API, IDE thing - isn't it like any cloud logging + IDE plugin? Any cloud logging has an API and a Java l... Galya B

03/21/2023

10:03 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: > Replace all CentralLogger references only in the seven conversion / tool directories and don't care about dependenc... Greg Shah
10:03 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: > > It should hide the runtime vs devtime decision from the caller.
> Are the two distinguishable? Is there a differ... Greg Shah
04:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg Shah wrote:
> Anything in these directories is conversion or dev tool related:
> ... Galya B
03:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg Shah wrote:
> It should hide the runtime vs devtime decision from the caller.
Are the two distinguishable? Is ... Galya B

03/20/2023

12:10 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Anything in these directories is conversion or dev tool related:... Greg Shah
11:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: @Preprocessor@ is not in @com.goldencode.p2j.convert@. So let me get back to my initial question.
Greg Shah wrote:... Galya B
10:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Call it @Status@. Greg Shah
10:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: The interface and implementations should live inside @com.goldencode.p2j.convert@. Greg Shah
10:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Use the minimum necessary to replace the current calls. Greg Shah
10:52 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg Shah wrote:
> No, I don't think so. The two APIs may look similar now but they will not look that way later.
... Galya B
10:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: > > Think about the case of IDE integration which needs to show a list of errors and link back to the location of the... Greg Shah
10:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: @CentralLogger@ is just an interface. Its various implementations may or may not have anything in common.
As far as ... Galya B
10:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg Shah wrote:
> Think about the case of IDE integration which needs to show a list of errors and link back to the... Galya B
10:39 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: The API is not really about logging. It is about recording the details of the conversion/tools processing in a manne... Greg Shah
10:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg Shah wrote:
> Anything that ever gets used at conversion time would use this API instead of direct usage of @Ce... Galya B
10:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya Bogdanova wrote:
> I'm not able to determine in depth which files are part only of the conversion tool and whi... Greg Shah
10:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: > But that's the issue, it already does,
What do you mean by "it already does"? In your changes?
> since bein... Greg Shah
10:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: I'm not able to determine in depth which files are part only of the conversion tool and which are shared with other r... Galya B
10:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg Shah wrote:
> I prefer that the API be the main entry point for the tooling and @CentralLogger@ only used in on... Galya B
10:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya Bogdanova wrote:
> I guess the API will be backed by a new DB table?
Not at this time. For now, the conver... Greg Shah
10:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: I prefer that the API be the main entry point for the tooling and @CentralLogger@ only used in one implementation of ... Greg Shah
10:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: I guess the API will be backed by a new DB table? Galya B
10:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: We can mark the tools entry points to run CentralLogger with a new mode that writes to the API and we'll have to repl... Galya B
10:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: I think we should implement a version of the #7180 API and switch all the conversion-tooling to use it. We can insta... Greg Shah
10:19 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg Shah wrote:
> It is completely common code.
Then my changes - replacing System.err will change the output in b... Galya B
10:17 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya Bogdanova wrote:
> If runtime conversion and tools conversion don't share any classes, then minding my own ref... Greg Shah
10:17 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: > Do we need exceptions in the GWT front-end of admin/client saved in the central log file or leave them show up only... Greg Shah
10:15 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: If runtime conversion and tools conversion don't share any classes, then minding my own refactoring will be easy. Oth... Galya B
10:14 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya Bogdanova wrote:
> About the interactive tools - I've marked in the [[internal-documentation:Logs#section-42|t... Greg Shah
10:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg Shah wrote:
> Please note that the conversion output for running the tools outside of runtime is the more impor... Galya B
10:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya Bogdanova wrote:
> Also @ext/sheet/build.gradle@ uses compile time the fwd build folder @../../build/classes@,... Greg Shah
10:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya Bogdanova wrote:
> @com.goldencode.p2j.preproc.Preprocessor@ supports cmd line options for writing out, err an... Greg Shah
08:44 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Attention! %{color:red}⚠% Replacing @System.err@ in the project will affect the content of the @-err@ and @-war... Galya B
03:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Do we need exceptions in the GWT front-end of admin/client saved in the central log file or leave them show up only i... Galya B

03/16/2023

11:46 AM Bug #5701 (Closed): logfile names for -O outputToFile use the spawner pid instead of the Java (FW...: Feedback status is for when the task is blocked needing information from the Author and/or a customer. Leave it in T... Greg Shah
11:42 AM Bug #5701 (Feedback): logfile names for -O outputToFile use the spawner pid instead of the Java (...: Galya B
04:58 AM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: 5701b is merged to trunk under r14506 -and works fine, but there are regression issues with the previous revision r14... Galya B

03/14/2023

06:24 PM Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...: Please rebase 5701b from trunk rev 14505. Then if it passes your basic tests, you can merge to trunk. Greg Shah

03/13/2023

12:16 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: There is a problem: There are 100 entry points in the code. Most of them have System.out and System.err. If System.er... Galya B
11:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: About the interactive tools - I've marked in the [[internal-documentation:Logs#section-42|table]] the classes using S... Galya B
09:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Also @ext/sheet/build.gradle@ uses compile time the fwd build folder @../../build/classes@, so I guess p2j.jar is in ... Galya B

03/10/2023

10:35 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: @com.goldencode.p2j.preproc.Preprocessor@ supports cmd line options for writing out, err and warn to separate files. ... Galya B
08:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Thank you for the responses. Then I'll leave it for later and will post an example before starting. Galya B
07:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Yes, you can make changes to the ANTLR code but please post an example here first and we will review before you go to... Greg Shah
06:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya, these classes are generated by ANTLR - the changes need to be in their @.g@ part (@text.g@, @fql.g@, @progress... Constantin Asofiei
05:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Now that we've decided that the new logger can be used pretty much everywhere, what do we do with the ignored classes... Galya B
03:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: I updated the wiki [[internal-documentation:Logs]] to help us better distinguish between different logs in OE and FWD... Galya B
01:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Also let's keep OE logging and FWD logging as separate topics. OE logging is #3853 that waits for review. I've notice... Galya B
01:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: About the client/server entry points - ClientDriver is the only one that will trigger client mode and ServerDriver is... Galya B

03/09/2023

02:24 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: For now, let's just focus on the single common log per appserver with the properly formatted headers. I thought we h... Greg Shah
01:47 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg Shah wrote:
> > for appservers, there is a single log file where all agents of that appserver are adding the me... Constantin Asofiei
01:40 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: > for appservers, there is a single log file where all agents of that appserver are adding the messages
This sound... Greg Shah
01:32 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg, for appservers, there is a single log file where all agents of that appserver are adding the messages. Current... Constantin Asofiei
01:11 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: > I think your only concern is the ClientDriver (which starts the FWD client), where the logging as far as I understa... Greg Shah
12:55 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya Bogdanova wrote:
> Constantin, please check if I got it right:
>
> * ReportWebServer - I saw it has p2j.jar... Constantin Asofiei
10:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Constantin, please check if I got it right:
* ReportWebServer - I saw it has p2j.jar in the classpath in deploy/se... Galya B

03/06/2023

06:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: The new logger is very simplified and has no external dependencies. I even removed the dependency on @java.util.loggi... Galya B
06:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Greg Shah wrote:
> > We are deprecating this - Greg, if we introduce other jar dependencies to p2jpl.jar, then this ... Constantin Asofiei
06:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: > Otherwise, the standalone tool list (and build scripts) still work with the full p2j.jar, and any other jar depende... Greg Shah
06:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: > We are deprecating this - Greg, if we introduce other jar dependencies to p2jpl.jar, then this will break fast. I'm... Greg Shah
06:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya Bogdanova wrote:
> Constantin, sorry for the time taken.
No problem. Please remove the @NIOSslSocket-no-more... Constantin Asofiei
05:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: -Oops, there is one @return@ to be removed in @finish@ that prevents the flag @IS_LOGGER_WORK_FINISHED@ to be set to ... Galya B
05:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: The deadlock for NIO sockets is on the @NativeSecureConnection@ side:
* this part blocks for a response from the ser... Constantin Asofiei
05:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: There are two bugs here:
* NIO sockets are dead-locking, as you mentioned before.
* without NIO sockets, the Native... Constantin Asofiei
05:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Actually there are several threads related to logging, but the loggers themselves are not on separate threads. The th... Galya B
05:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Some other notes:
* the logger service runs in its own thread(s), as I see; please name these threads so they can be... Constantin Asofiei
05:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Fix for the NPE in r14508. The breakpoint in the NPE class helped. By the way the default location for the log file i... Galya B
04:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Constantin Asofiei wrote:
> Hard to spot unless you have breakpoints in @java.lang.NullPointerException@ constructor... Galya B
04:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: There is a NPE when 'nothing is configured':... Constantin Asofiei
04:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Constantin Asofiei wrote:
> Galya, how do I configure the loggers to log to STDOUT, for the FWD server? This should... Galya B
04:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya, how do I configure the loggers to log to STDOUT, for the FWD server? This should be the default way. Constantin Asofiei
02:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Galya, I've looked at your table and split the 'main' classes into this:
* used for standalone testing, not FWD runt... Constantin Asofiei

03/03/2023

04:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Server writes @authModeReq@ to socket:
!server-writes-authmodereq.png!
Client doesn't receive packets and hangs:
... Galya B

03/02/2023

09:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: I'm introducing a change to @NIOSslSocket#readFully()@ to fix an indefinite loop. Please check the attached file.
... Galya B

02/28/2023

10:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: And about the rest of the classes with main methods: Can I try to move all tools to a separate package, so that we kn... Galya B
10:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: It seems that some of the main methods are used by Harness for tests.
1. Can we get them out to the test directory... Galya B
07:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: Also @System.err@ can be found in ignored classes:... Galya B
06:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration: ⚠ Which entry points are NOT used with p2j classpath?
List of all entry points in [[internal-documentation... Galya B

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » Runtime Infrastructure

Activity

Activity

03/29/2023

03/28/2023

03/23/2023

03/22/2023

03/21/2023

03/20/2023

03/16/2023

03/14/2023

03/13/2023

03/10/2023

03/09/2023

03/06/2023

03/03/2023

03/02/2023

02/28/2023