Project

General

Profile

Activity

From 04/18/2023 to 05/17/2023

05/17/2023

05:25 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I think I am happy with my new configuration. With this, I can cover ChUI and GUI:... Roger Borrello
05:02 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
FYI, tokens work fine. My entry for ChUI clients is:... Roger Borrello
04:28 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> Roger Borrello wrote:
> > Where does the @%as@ value come from?
>
> It looks like everyw...
Roger Borrello
04:15 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> Where does the @%as@ value come from?
It looks like everywhere @LoggingUtil.resolveLogFil...
Roger Borrello
02:57 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Roger, I got you! You're running multiple servers at the same time and still asking why the...
Roger Borrello
11:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Eugenie,
> This log is in fwd_server_*.log I guess:
> [...]
> Let's figure out why FINE ...
Eugenie Lyzenko
11:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > > ** ServerDriver special modes for status checking, shutdown processing, batch program launch
...
Constantin Asofiei
10:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > ** ServerDriver special modes for status checking, shutdown processing, batch program launch
> Gold mine! It cli...
Greg Shah
10:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Truth being told, @%m%g.log@ is not a prod config. It can work only for Hotel GUI and that is only if you don't do th... Galya B
10:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Conversion tools don't use sessions. Sessions are used by:
> [...]
> ** ServerDriver special m...
Galya B
09:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> I mean how do tools configure a session?
Conversion tools don't use sessions. Sessions are used by:
* FWD cl...
Greg Shah
09:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Eugenie,
This log is in fwd_server_*.log I guess:...
Galya B
09:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Galya: regarding log rotation. I have a config where the server log name is @server.log...
Galya B
09:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> i.e. why is the default logger used with RemoteObject?
A separate JVM connects via the app...
Constantin Asofiei
09:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
i.e. why is the default logger used with RemoteObject? Galya B
08:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I mean how do tools configure a session? Galya B
08:57 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Do we have RemoteObjects used by tools? Galya B
08:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
By the way the fix is up. Galya B
08:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> The problem is not that logs are filtered or not - the problem is @RemoteObject$RemoteAc...
Galya B
08:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Constantin, that being said, it's still not a critical bug. Logs are still properly filtere...
Constantin Asofiei
08:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin, that being said, it's still not a critical bug. Logs are still properly filtered out in @publish(LogRecor... Galya B
08:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> See this test:
> [...]
> It prints @true@.
Aaaaah, that is because I developed withou...
Galya B
08:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> I don't understand the problem. isLoggable should return true before the logging configs ki...
Constantin Asofiei
08:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, I want multithreaded Redmine tasks! How do I keep 3 conversations sensible in one timeline. Galya B
08:18 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Eugenie Lyzenko wrote:
> > Can you please clarify the new style log entries like this:
> ...
Eugenie Lyzenko
08:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Eugenie Lyzenko wrote:
> Can you please clarify the new style log entries like this:
The problem I guess is that yo...
Galya B
08:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Eugenie Lyzenko wrote:
> Can you please clarify the new style log entries like this:
>
> [...]
>
> Is it expec...
Galya B
08:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> > the problem in #5703-417 is still present; there is something wrong with this stack:
...
Galya B
08:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya,
Can you please clarify the new style log entries like this:...
Eugenie Lyzenko
07:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> the problem in #5703-417 is still present; there is something wrong with this stack:
because the isLoggable(Level)...
Constantin Asofiei
07:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Greg Shah wrote:
> > > Hynek: please review the @ext/sheet/build.gradle@ change
> >
> >...
Constantin Asofiei
07:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Roger Borrello wrote:
> > The wrapper needs to know what the server logfile name is, witho...
Roger Borrello
07:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > If there is any other way to deploy the war without the main classpath, that is something to co...
Galya B
07:39 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> If there is any other way to deploy the war without the main classpath, that is something to consider.
Not that ...
Greg Shah
07:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Also Eugenie tested it. Me too. If there is any other way to deploy the war without the main classpath, that is somet... Galya B
07:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > Hynek: please review the @ext/sheet/build.gradle@ change
>
> Hynek is not available until Fr...
Galya B
07:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Hynek: please review the @ext/sheet/build.gradle@ change
Hynek is not available until Friday. We need to make t...
Greg Shah
07:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
5703b r14577.
> * @src/com/goldencode/p2j/util/logging/CentralLoggerClientStandalone.java@ has just whitespace chang...
Galya B
06:47 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, review for 5703b rev 14576:
* @src/com/goldencode/p2j/util/logging/CentralLoggerClientStandalone.java@ has ju...
Constantin Asofiei
06:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Can someone approve 5703b, cause it has important fixes that need to be merged and then we can improve on rotation in... Galya B
06:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> I agree with Roger, that seems like a bug in the J2SE code. It is certainly not intuitive, when ...
Galya B
06:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Roger Borrello wrote:
> > The wrapper needs to know what the server logfile name is, witho...
Greg Shah
03:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
* 5703b r14576 server and client default log file names separated. Server default without pid.
* Tested.
* *Rea...
Galya B
03:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
What is the limitation in the wrapper of having no logic? Can it not find the last updated @server*.log@ file and par... Galya B
02:47 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> The wrapper needs to know what the server logfile name is, without having to make any logica...
Galya B
02:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> The wrapper needs to know what the server logfile name is, without having to make any logica...
Galya B

05/16/2023

05:36 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Eugenie Lyzenko wrote:
> > Sorry, this is another issue I guess. Because location is diffe...
Eugenie Lyzenko
04:41 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Roger Borrello wrote:
> > After a few retries, I see the most recent file is now @server0....
Roger Borrello
04:18 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Eugenie Lyzenko wrote:
> Sorry, this is another issue I guess. Because location is different. Happen when I tried to...
Galya B
04:11 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Eugenie Lyzenko wrote:
> > Confirm fixed areas. Please consider to resolve #7143-174 issue...
Eugenie Lyzenko
04:02 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger, a clarification: LOG-MANAGER logs are configured with @clientlog@ and don't support @%g@. There is default onl... Galya B
03:57 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Eugenie Lyzenko wrote:
> Confirm fixed areas. Please consider to resolve #7143-174 issue. It is still active.
This ...
Galya B
03:49 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> 5703b r14574:
> * should fix all issues described by Eugenie - #7143-173, #7143-168, #7143...
Eugenie Lyzenko
03:46 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> After a few retries, I see the most recent file is now @server0.log.1@, and the @server0.log...
Galya B
03:31 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Galya, please use Hotel GUI and do a before and after comparison of the conversion log a...
Galya B
03:20 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Hi Galya... I certainly do like the cleaner logging process, and will test my customers application on *5703b* so as ... Roger Borrello
02:54 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Eugenie, removing @slf4j-api@ from all dependencies in sheet should be enough to fix the is...
Galya B
02:44 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Eugenie, removing @slf4j-api@ from all dependencies in sheet should be enough to fix the issue. Galya B
02:39 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
5703b r14574:
* should fix all issues described by Eugenie - #7143-173, #7143-168, #7143-169;
* adds @setServer@ to...
Galya B
01:12 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> We can always add @bc.setServer(true);@ without the @if@, since this code is in @ServerDriv...
Roger Borrello
12:51 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
We can always add @bc.setServer(true);@ without the @if@, since this code is in @ServerDriver@, but I've never seen t... Galya B
12:45 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> I made appropriate updates to @directory.xml@ as directed for my application.
>
> I belie...
Roger Borrello
11:05 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The exact call is indeed part of jetty, but I was trying to debug the part around setting a context class loader in @... Galya B
11:03 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> I try to debug the sheet war. I have both the server and client debuggers connected, but th...
Eugenie Lyzenko
10:15 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I try to debug the sheet war. I have both the server and client debuggers connected, but the breakpoint in @SheetCont... Galya B
10:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> I can't debug @SheetControllerImpl@ that is part of the war. Debugging doesn't hit the brea...
Constantin Asofiei
10:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
It's deployed as @org.eclipse.jetty.webapp.WebAppContext@ in @SpreadsheetDriverWidget@ and the war is set to the cont... Galya B
10:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I can't debug @SheetControllerImpl@ that is part of the war. Debugging doesn't hit the breakpoints. Galya B
09:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > > Do we always use @fwd_sheet.war@ from a web process spawned by the ...
Greg Shah
09:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > Do we always use @fwd_sheet.war@ from a web process spawned by the server or as a separate tool...
Eugenie Lyzenko
09:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Do we always use @fwd_sheet.war@ from a web process spawned by the server or as a separate tool as well?
Neither...
Greg Shah
09:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Do we always use @fwd_sheet.war@ from a web process spawned by the server or as a separate tool as well? Galya B
09:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
There are two classloaders, loading probably the same implementation of slf4j twice and considering it different. In ... Galya B
08:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I'll be debugging for a while the sheet project bug with loading slf4j. It is related to some dependencies using @org... Galya B
07:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> The easiest is to simply not include pid ever in server log file name using a placeholder.
No, allowing the pid ...
Greg Shah
06:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The easiest is to simply not include pid ever in server log file name using a placeholder. Do you want to keep it as ... Galya B
06:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The client side is better with it so let's consider options for not having a single cfg entry for both names. Greg Shah
06:50 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Let's remove the pid from the default server log file name so that by default we are not trying t...
Galya B
06:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Let's remove the pid from the default server log file name so that by default we are not trying to load the native li... Greg Shah
06:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> @logging.properties@ won't do
I agree with this, we don't use props files. We use good defaults and allow optio...
Greg Shah
05:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, please use Hotel GUI and do a before and after comparison of the conversion log and db import logs. There are... Constantin Asofiei
05:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Regression: add a bogus jar to the classpath (just at the beginning) and this is shown w...
Galya B
05:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> DB import shows lots of INFO statements like:
> ...
Galya B
04:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Galya, we have some priorities to fix:
> * default any logger (including the ones init...
Galya B
04:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, we have some priorities to fix:
* default any logger (including the ones initialized from directory.xml) to ...
Constantin Asofiei
04:19 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Especially because in @CentralLoggerFallback@ we have that notion of System.out being Level.INFO and below:... Galya B
04:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> I don't mean to not allow logging levels via some command line argument (or maybe a logg...
Galya B
04:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Constantin Asofiei wrote:
> > Please consider a default logging level of WARNING. You can...
Constantin Asofiei
04:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Please consider a default logging level of WARNING. You can make it globally - if even ...
Galya B
03:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Regression: @RemoteObject@ can be used from standalone JVMs (i.e. JavaOpenClient). The ...
Galya B
03:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, for the standalone tools - this includes conversion, import, standalone JVMs (not FWD server/client) using FWD... Constantin Asofiei
03:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> DB import shows lots of INFO statements like:
> [...]
>
> These need to be lowered.
...
Galya B
02:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> Is tilde (@~@) supported in the filename so that the configuration can cover all users?
The...
Galya B

05/15/2023

02:22 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Regression: add a bogus jar to the classpath (just at the beginning) and this is shown when starting the FWD server; ... Constantin Asofiei
02:20 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Regression: @RemoteObject@ can be used from standalone JVMs (i.e. JavaOpenClient). The logging defaults to 'FINE' (f... Constantin Asofiei
02:01 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya,
Do you have any ideas how to resolve #7143-168, #7143-169 issues/regressions?
Eugenie Lyzenko
02:00 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
DB import shows lots of INFO statements like:... Constantin Asofiei
11:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I made appropriate updates to @directory.xml@ as directed for my application.
I believe there is a regression in t...
Roger Borrello
07:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Roger Borrello wrote:
> Is tilde (@~@) supported in the filename so that the configuration can cover all users?
N...
Greg Shah
11:26 AM Bug #7354: do not log keystore/truststore passwords when dumping arguments during spawning
Further info: it was also detected at the client log. Search for 'password' in the client log output below.... Tijs Wickardt
10:58 AM Bug #7354: do not log keystore/truststore passwords when dumping arguments during spawning
In #6879, it was noted that our log output should not contain passwords for keystores/truststores:... Greg Shah
10:55 AM Bug #7354 (New): do not log keystore/truststore passwords when dumping arguments during spawning
Greg Shah

05/12/2023

05:10 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Is tilde (@~@) supported in the filename so that the configuration can cover all users? Roger Borrello
10:28 AM Bug #5703 (Test): rationalize, standardize and simplify the client-side log file name configuration
Greg Shah
10:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
5703a has been merged to trunk, the branch is archived and an email is sent. Galya B
10:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
@System.err@ and @t.printStackTrace@ being replaced followed a certain logic:
* Exceptions are either WARNING or SEV...
Galya B
08:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
OK, thank you. Constantin Asofiei
08:35 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Previously the code worked because the field's type was outside of FWD or converted app'...
Galya B
08:17 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> is @com.goldencode.trpl@ obsolete? I don't see it anywhere being used.
It is experimental and not in use yet. Y...
Greg Shah
08:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, no, do something else: in @ControlFlowOps.initializeLegacyClass@, there is this code:... Constantin Asofiei
08:09 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The static CentralLogger fields in the Json* classes lead to @java.lang.IllegalStateException: Field private static f... Galya B
08:05 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin, here it is, I am finally able to reproduce it on the client's project:... Galya B
07:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
TODO: add @TransformDriver@ cmd line arg parsing to set the level of logging. Ref #7180. Galya B
04:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Hotel Gui throws @build.xml:538: Warning: Could not find file adm_windows.json to copy.@ on @ant jar deploy.prepare@.... Galya B
03:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Note: Decide what to do with @com.goldencode.trace@, @LoggingAspect@ and @LogExecution@. Galya B
03:39 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Even if @com.goldencode.trpl@ is not used, I guess @ConversionStatus@ will be more appropriate, so changing it. Galya B
03:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Is @com.goldencode.expr@ also a conversion package?
Yes
Constantin Asofiei
03:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Is @com.goldencode.expr@ also a conversion package? Galya B
03:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Question: @uast@ was identified as conversion package, where @ConversionStatus@ should be u...
Constantin Asofiei
03:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Question: @uast@ was identified as conversion package, where @ConversionStatus@ should be used, but there is also @co... Galya B
02:17 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Here a few notes for future logging improvements and things to consider. I've just noticed we have:
* @SQLStatementL...
Galya B

05/11/2023

12:12 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya: Starting tomorrow morning, trunk will be frozen for the day (or until you merge whichever is *shortest*). If ... Greg Shah
11:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> > * @CentralLoggerServer.initialize@ - in @processIdSupplier@ lambda, enclose the code in ...
Constantin Asofiei
11:32 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Review for 5703a/14630:
> * @CentralLoggerServer.isLogicalTerminalInitialized@ and @Cen...
Galya B
11:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Review for 5703a/14630:
* @CentralLoggerServer.isLogicalTerminalInitialized@ and @CentralLogger.invalidateLoggerTree...
Constantin Asofiei
10:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
This is lovely. I can confirm that now we can configure logging everywhere in every way we like. :D
Default loggin...
Galya B
08:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The epic config:... Galya B
06:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Also it means that there is no default @fwd_server...log@ file ever, because the default constant that is a fallback ... Galya B
06:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Client sessions, even when processed on the server-side, should support the same substitutions as...
Galya B
05:57 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Client sessions, even when processed on the server-side, should support the same substitutions as if the processing h... Greg Shah
05:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I'm asking about the logic of what is the expected behavior of the configs. Galya B
05:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Move @ClientParameters@ processing earlier in @ClientCore.initialize()@.
Don't worry about the...
Galya B
05:50 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Move @ClientParameters@ processing earlier in @ClientCore.initialize()@. Greg Shah
05:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > Both server and client paths support date time, the default Formatter specifiers and the custom...
Galya B
05:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> We'll be adding now the file path and rotation size and count if resolved for the account or from server/default/lo... Greg Shah
05:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > * If @server/default/logging@ is supposed to be fallback for...
Galya B
05:24 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Soooo for serverSide logging, the client should send the configs to the server to overwrite directory.xml? Galya B
02:50 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> I think the logging levels are global (can't be set for each account). Everything else ...
Galya B
02:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> * I'm not sure if Greg wants all logging configs to be available for each account. There is...
Constantin Asofiei
02:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> @runtime/<account>/logging@ can this be used by the server account?
If you are referring f...
Constantin Asofiei
02:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
@runtime/<account>/logging@ can this be used by the server account? Galya B
01:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> My biggest concern would be if @serverSide@ is @false@ and the client should write to a pat...
Constantin Asofiei
01:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Greg I think proposes for the log config lookup, in case of the FWD client logs, to be d...
Galya B

05/10/2023

12:27 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin: Thanks for explaining it. You did better than me. :) Greg Shah
10:52 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, some notes related to client logs.
In appserver case, for OE/legacy output, FWD must allow to send all thes...
Constantin Asofiei
08:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> As with nearly everything we configure, we expect there to be the following:
>
> * A directory...
Galya B
08:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> What I found difficult with the current way is that each agent creates its own file, and...
Galya B
08:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > > (This should be expected, just to keep it in mind) The appserver client now creates a separate log file, while ... Greg Shah
08:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, then I'll be waiting for your feedback on what client log file configs we want (#5703-360, #5703-361, #5703-362... Galya B
08:05 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I was wrong about the appserver. Actually we had that as another log file from stderr (currently on trunk it's @%type... Galya B
07:52 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > (This should be expected, just to keep it in mind) The appserver client now creates a separate ...
Galya B
07:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> (This should be expected, just to keep it in mind) The appserver client now creates a separate log file, while I be... Greg Shah
05:05 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Also it needs to be path for client-side logging and a name for server-side logging. Another funky aspect. Galya B
05:03 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
There is a hard-coded default now for clients @fwd_client_" + SORTABLE_DATETIME_FORMAT + "_" + "%uos_%pid_%uf_%g.log@... Galya B
04:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I'm very confused from the whole logging epic. If you check how the Global Lifecycle section in [[internal-documentat... Galya B
04:24 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> I don't understand - are you saying that you don't see the log messages until the appser...
Galya B
04:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Galya Bogdanova wrote:
> > (This should be expected, just to keep it in mind) The appserve...
Constantin Asofiei
04:14 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> (This should be expected, just to keep it in mind) The appserver client now creates a separ...
Galya B
04:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
A few more classes (e.g. @SSL@, @BlockingSSL@) had to exclude @SecurityManager@ context. Now the tests pass for @net:... Galya B
08:06 AM Feature #1848: make logging settings controllable dynamically at runtime
Client levels invalidation needs more work, check #5703-356 point 2. Galya B
08:04 AM Feature #1848: make logging settings controllable dynamically at runtime
Greg Shah wrote:
> For performance reasons we often cache the result of @isLoggable()@. This should be maintained. ...
Galya B

05/09/2023

10:05 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
If I remember correctly this deadlock appeared only with rpc calls and it's slightly difficult to test it now, becaus... Galya B
07:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Set @net:socket:nio=false@ at:
* server.sh for FWD server startup
* client.sh or other script to launch individual ...
Constantin Asofiei
07:35 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Galya, I think just some tests to see that appserver/batch/UI client work OK, in both ni...
Galya B
06:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, I think just some tests to see that appserver/batch/UI client work OK, in both nio and non-nio SSL, should be ... Constantin Asofiei
07:14 AM Bug #7291: LOG-MANAGER to log on client-side
> but if it's a disconnect or an unexpected exception on the server, the queue on the server will be lost
Underst...
Greg Shah
05:21 AM Bug #7291: LOG-MANAGER to log on client-side
At the moment LOG-MANAGER logs all messages with the client pid. Do we want to differentiate between server source an... Galya B
02:11 AM Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> I do think we might want to use state sync to avoid round trips to the client.
With state sync t...
Galya B

05/08/2023

02:38 PM Bug #7291: LOG-MANAGER to log on client-side
> I guess we want to use OS resource 'filesystem' and hide the details of where the operations are executed. So the c... Greg Shah
07:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> What do you think is the proper level of trace and LoggingNetSocket? I think the lowest FINEST is probably better s... Greg Shah
04:50 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Code review requests applied with 5703a r14625 and r14626:
* @NIONetSocket@ checks for loggable before each log st...
Galya B
02:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
There are some inconsistencies with the logging in the Socket classes.... Galya B

05/05/2023

11:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Review for 5703a rev 14623:
* @NIONetSocket@ - please add the @if (isFineLoggable)@ condition to the previous @trace...
Constantin Asofiei
11:24 AM Bug #7291: LOG-MANAGER to log on client-side
With option B. syncing the errors of the LOG-MANAGER itself between the server and the client, will also have to be r... Galya B
11:15 AM Bug #7291: LOG-MANAGER to log on client-side
The other option would be to not use #4065 and filesystem OS resource.
The code in LOG-MANAGER remains the same. W...
Galya B
11:05 AM Bug #7291: LOG-MANAGER to log on client-side
So how to make LOG-MANAGER distributed?
- The server has the attribute getters, setters, receives logs from differen...
Galya B
10:46 AM Bug #7291: LOG-MANAGER to log on client-side
Constantin Asofiei wrote:
> As a side note, we still have the FWD client logs, which will also be on server-side, i...
Galya B
10:40 AM Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> > Now lets confirm the other side of the matter. Do I understand correctly that when the context-...
Constantin Asofiei
10:36 AM Bug #7291: LOG-MANAGER to log on client-side
A note: appserver clients will be an exception to any rule, no client-side writing for them, because it needs to be o... Galya B
10:25 AM Bug #7291: LOG-MANAGER to log on client-side
All the logging tasks are trying to make distributed structures that are naturally singleton / monolith. Distributed ... Galya B
10:17 AM Bug #7291: LOG-MANAGER to log on client-side
I make it sound way too easy. I will have to rework a lot.
* Currently LegacyLogManagerImpl keeps a reference to the...
Galya B
09:31 AM Bug #7291: LOG-MANAGER to log on client-side
> Now lets confirm the other side of the matter. Do I understand correctly that when the context-local @OSResourceMan... Greg Shah
08:54 AM Bug #7291: LOG-MANAGER to log on client-side
Now lets confirm the other side of the matter. Do I understand correctly that when the context-local @OSResourceManag... Galya B
08:48 AM Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> Option 4 although it is unlikely that OE is ever involved on the same system. It is more likely ...
Galya B
08:32 AM Bug #7291: LOG-MANAGER to log on client-side
Option 4 although it is unlikely that OE is ever involved on the same system. It is more likely that the installatio... Greg Shah
08:25 AM Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> In regard to locking, if we have to use OS level locks to get the right behavior with multiple pr...
Galya B
08:23 AM Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> I wouldn't say "standalone". These are just clients not launched by the spawner. Logging behavi...
Galya B
08:22 AM Bug #7291: LOG-MANAGER to log on client-side
Galya Bogdanova wrote:
> Greg Shah wrote:
> > What do you mean by "standalone clients"?
> Not web/appserver/schedu...
Greg Shah
08:21 AM Bug #7291: LOG-MANAGER to log on client-side
> > It is context-local. That is what I mean when I say "for a given session". Using context-local is how we make s... Greg Shah
08:20 AM Bug #7291: LOG-MANAGER to log on client-side
> > I need a clarification on @OSResourceManager.isServerSideFileSystem@. @filesystem@ is enabled by being included i... Greg Shah
08:19 AM Bug #7291: LOG-MANAGER to log on client-side
> Also in the context of logging it matters if it's a remote client (on a different host) or not. I spoke about synch... Greg Shah
08:16 AM Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> It is context-local. That is what I mean when I say "for a given session". Using context-local ...
Galya B
08:15 AM Bug #7291: LOG-MANAGER to log on client-side
> > If for a given session, server-side filesystem support is enabled, then all filesystem usage will be on the serve... Greg Shah
08:13 AM Bug #7291: LOG-MANAGER to log on client-side
Galya Bogdanova wrote:
> I need a clarification on @OSResourceManager.isServerSideFileSystem@. @filesystem@ is enabl...
Galya B
08:12 AM Bug #7291: LOG-MANAGER to log on client-side
Also in the context of logging it matters if it's a remote client (on a different host) or not. I spoke about synchro... Galya B
08:11 AM Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> If for a given session, server-side filesystem support is enabled, then all filesystem usage will...
Galya B
08:10 AM Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> What do you mean by "standalone clients"?
Not web/appserver/scheduled batch/single running on th...
Galya B
08:08 AM Bug #7291: LOG-MANAGER to log on client-side
> I need a clarification on @OSResourceManager.isServerSideFileSystem@. @filesystem@ is enabled by being included in ... Greg Shah
08:05 AM Bug #7291: LOG-MANAGER to log on client-side
> If remote clients' file systems are accessible through the OS Resources as expected from #4065, then LOG-MANAGER ca... Greg Shah
07:57 AM Bug #7291: LOG-MANAGER to log on client-side
I need a clarification on @OSResourceManager.isServerSideFileSystem@. @filesystem@ is enabled by being included in th... Galya B
03:08 AM Bug #7291 (WIP): LOG-MANAGER to log on client-side
Galya B

05/04/2023

08:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I'll have to rebase to test with the customer project according to #7143#note-137, so I'll be waiting for the final r... Galya B
07:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Are you saying that it fails differently each time you run @ant deploy.all@ with the current vers...
Galya B
07:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> I'm trying to run hotel-gui with 5703a, but I'm getting different exceptions. On @ant deplo...
Greg Shah
04:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
With a certain customer project I got another one, when running the server:... Galya B
03:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I'm trying to run hotel-gui with 5703a, but I'm getting different exceptions. On @ant deploy.all@:... Galya B
07:19 AM Bug #7291: LOG-MANAGER to log on client-side
If remote clients' file systems are accessible through the OS Resources as expected from #4065, then LOG-MANAGER can ... Galya B

04/28/2023

01:32 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
As requested in #4065-104 support optional (configurable) shorter versions of package names. Check how other logging ... Galya B

04/27/2023

08:26 AM Feature #1848: make logging settings controllable dynamically at runtime
> A note: With #5703 all levels can be changed dynamically. To not lose logs, when the level is lowered, @isLoggable(... Greg Shah
05:23 AM Feature #1848: make logging settings controllable dynamically at runtime
A note: With #5703 all levels can be changed dynamically. To not lose logs, when the level is lowered, @isLoggable()@... Galya B
05:09 AM Feature #1848: make logging settings controllable dynamically at runtime
A note: For dynamic levels to apply to all child packages and classes, all loggers should have fully qualified names ... Galya B

04/26/2023

09:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I've completed all that was on my mind with this task. Today I added some final touch-ups to the yesterday's changes ... Galya B
09:03 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Actually I was working on @SecurityManager@ two months ago #5703#note-28. I just want to double check.
* Its custom ...
Galya B

04/25/2023

10:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Since the only security issue here is related to log file output, I think the danger is quite limited. Rather than h... Greg Shah
07:39 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
"Using Expressions in Access Rights":/artifacts/javadoc/latest/api/com/goldencode/p2j/security/package-summary.html#U... Greg Shah
02:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Can someone give me an example of @access rights expressions@ (refs com.goldencode.p2j.security.VariablePool)? @getRe... Galya B

04/24/2023

01:10 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
In regard to the @AdminServerImpl@ use of @LOG.setLevel(Level.FINER);@, I think it should be deleted. There is no re... Greg Shah
10:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Good Greg Shah
09:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Also when server-side enabled I have to fix it to produce separate files by generating them dynamically based on some... Galya B
09:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
OK, may I then implement these requirements so:
* there is a directory.xml flag @logging/serverSide@ by default fals...
Galya B
09:46 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > When we are configured for server-side logging, it no longer makes sense for there to be a separate FWD client lo... Greg Shah
08:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> When we are configured for server-side logging, it no longer makes sense for there to be a separa...
Galya B
08:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Why do we need to write client logs from the server for FWD logs - client logs are generated on the client and serv... Greg Shah
08:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Let's put LOG-MANAGER aside and discuss it in #7291.
Why do we need to write client logs from the server for FWD l...
Galya B
08:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > Permissions are always an issue in client scenarios, remote or local. The client must have proper permissions fo... Greg Shah
05:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Since there is no merging of client and server files in any of the supported cases, I want to present a well-rounded ... Galya B
04:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
May I be excused to have the audacity to summarize the requested changes as:
* the same number of files in compariso...
Galya B
04:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I'm reading #4065 and the code. I believe the core concept is the only one relevant here. If I understand properly, c... Galya B
01:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Permissions are always an issue in client scenarios, remote or local. The client must have prope...
Galya B

04/21/2023

11:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> I remember there was a mention of client permissions in the context of remote clients. What...
Greg Shah
10:50 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I remember there was a mention of client permissions in the context of remote clients. What about local clients, isn'... Galya B
10:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The two cases are exclusively server-side and only occur at the very initialization of the logger. The SM case is dr... Greg Shah
10:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Neither of these is dynamic. One is hard coded in the source and the other is read from the dire...
Galya B
10:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > Where is it used today?
> On trunk @AdminServerImpl -> LOG.setLevel(Level.FINER);@ and and @SecurityManager -> L...
Greg Shah
10:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The question is do we keep it part of the interface of the logger. Galya B
10:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Tomorrow it might be used somewhere else, if not disabled. Galya B
10:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Where is it used today?
On trunk @AdminServerImpl -> LOG.setLevel(Level.FINER);@ and and @Securi...
Galya B
09:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Where is it used today? Greg Shah
09:39 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I would recommend disabling @setLevel@ for now, if we're not clear how this should work out. It's messy even with one... Galya B
09:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Unexpected behavior - isn't it a definition of a bug. If it's not defined, it will be unexpected -> bug. Galya B
09:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Is there a reason to change it right now?
Yes, the logger is now distributed. I need to know wha...
Galya B
09:35 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Is there a reason to change it right now? Greg Shah
09:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > > What do you mean by dynamic logging levels?
> > @LOG.setLevel()@ called programmatically.
>...
Galya B
09:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> And what do we do with the dynamic levels that can be set server-side and client-side in the code at any time?
W...
Greg Shah
09:33 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > What do you mean by dynamic logging levels?
> @LOG.setLevel()@ called programmatically.
Leave this alone unle...
Greg Shah
09:32 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
And what do we do with the dynamic levels that can be set server-side and client-side in the code at any time? Galya B
09:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > I don't know that we care about per-context logging levels EXCEPT for the @LOG-MANAGER@ stuff. In the FWD logging... Greg Shah
09:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> I don't know that we care about per-context logging levels EXCEPT for the @LOG-MANAGER@ stuff. In...
Galya B
09:11 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> What do you mean by dynamic logging levels?
@LOG.setLevel()@ called programmatically.
Galya B
09:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Greg Shah wrote:
> > > disable dynamic levels on the client
> >
> > No, I don't think w...
Greg Shah
09:10 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
At this time we assume that the same logging levels will apply to all contexts. Even in the future where we have imp... Greg Shah
09:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > disable dynamic levels on the client
>
> No, I don't think we need to do that.
So allow d...
Galya B
09:05 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > So any static initializers setting levels will work once for the lifespan of the server JVM and...
Galya B
08:58 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> It's not the same, because you can set multiple logging levels in the client configs and then change them programma... Greg Shah
08:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
OK, so implement context-local CentralLogger, configured by directory.xml, but with initial overrides from client.xml... Galya B
08:36 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > The client.xml logging level configs will override the server ones? But the server ones are dyn...
Galya B
08:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > The idea is that there are 2 modes for logging: server-side and client-side.
>
> How do I know if the client i...
Greg Shah
08:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Actually if it was a new software (more web oriented) that was developed, I would suggest if customers want to use re... Galya B
08:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Greg Shah wrote:
> > The idea is that there are 2 modes for logging: server-side and clien...
Galya B
07:52 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> The idea is that there are 2 modes for logging: server-side and client-side.
How do I know if ...
Galya B
07:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Do I remove all client to server log writes?
No. The idea is that there are 2 modes for logging: server-side an...
Greg Shah
03:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Since we just removed the client-side configurations for logging I guess I have to introduc...
Galya B
02:56 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, I'll wait for your confirmation.
Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > I feel I still don...
Galya B
02:55 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Galya Bogdanova wrote:
> > The current design is that client and server logging levels are indep...
Galya B
02:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> I feel I still don't understand something:
>
> 1. What do I use state sync for, when the...
Constantin Asofiei
01:51 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> * server-side logging is configured
> ** this would be configured similar to the rest of #4065
...
Galya B
01:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I feel I still don't understand something:
1. What do I use state sync for, when the client and server loggers are...
Galya B
08:15 AM Bug #7291: LOG-MANAGER to log on client-side
Just document the file locking restriction for now. Greg Shah
07:57 AM Bug #7291: LOG-MANAGER to log on client-side
Greg Shah wrote:
> Client side logging is much less likely to have more than one process writing to the same file. ...
Galya B
07:43 AM Bug #7291: LOG-MANAGER to log on client-side
Create the minimum API which will be a new remote service exported from the client side. This will provide the remot... Greg Shah
02:39 AM Bug #7291: LOG-MANAGER to log on client-side
*Initial state and facts on @LOG-MANAGER@ (@LegacyLogManagerImpl@):*
* lives server-side;
* receives some logs fr...
Galya B
01:57 AM Bug #7291 (Closed): LOG-MANAGER to log on client-side
Galya B

04/20/2023

11:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > by default, FWD client logs to its own log files
>
> Do we ever need the client logs mixed i...
Constantin Asofiei
11:32 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Please address these items before the code can be merged to trunk:
* Split client logging into its own log file in...
Greg Shah
11:29 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
In regard to all the communications noted in #5703-280, I never intended to have the client logging go into the serve... Greg Shah
11:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, just to summarize, there are a few types of logging done in FWD:
# LOG-MANAGER logging
** this is the legacy ...
Constantin Asofiei
10:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
*On 7th Feb*
1. #5703#note-23
Greg Shah said:
> 1. I don't think we want a separate client and server logging ...
Galya B
09:49 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> If I remember correctly the whole point of the task was to reduce the number of log files b...
Greg Shah
09:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
If I remember correctly the whole point of the task was to reduce the number of log files by merging them. I initiall... Galya B
09:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> you wanted to have all client logs mixed in.
I don't recall wanting that.
Greg Shah
09:40 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Is it separate from the "server log"? If so, I think it is OK. This is the replacement for the ...
Galya B
09:35 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Is it separate from the "server log"? If so, I think it is OK. This is the replacement for the old @stderr@ output ... Greg Shah
09:23 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
This is what I mean. Actually the file name is misleading - it's client-side generated log, server-side saved to a file. Galya B
09:20 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
If you are talking about the output redirect, that would remain on the client side. Greg Shah
09:09 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Since this is related to @LOG-MANAGER@
What about FWD logging for these remote clients?
Galya B
08:45 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Since this is related to @LOG-MANAGER@ and we just implemented support for @LOG-MANAGER@ to target a separate file, w... Greg Shah
08:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
The issue is related to @LOG-MANAGER@ where the 4GL code (or via command line) the customer can specify a client-side... Greg Shah
02:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
#5703#note-27
Greg Shah wrote:
> The equivalent system in OE is a single process. For this reason, we cannot caus...
Galya B
02:25 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
#5703#note-40
Greg Shah wrote:
> Whether it is recursion or deadlock, the state synch approach should work.
Fr...
Galya B
02:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
@Status report 01/13/2023@
Galya Bogdanova wrote:
> I'll need a few days to analyze what types of 4GL errors and ...
Galya B
01:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
(related to @LOG-MANAGER@) On 17th January I've sent you an email named @Status report 01/17/2023@ with an attachment... Galya B
01:38 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Galya Bogdanova wrote:
> > Greg, you make me worried extremely. Let me repeat what I've said (ho...
Galya B

04/19/2023

02:04 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Greg, you make me worried extremely. Let me repeat what I've said (hoping it's received on ...
Greg Shah
12:55 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, @System.loadLibrary("p2j");@ in @ServerDriver.main@ will force any installation to require the p2j library add... Constantin Asofiei
12:23 PM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
It's done and done in r14601. Please confirm it's done.
65 revisions later and 508 files updated, let's do it!
Galya B
11:48 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
-Constantin, what do I do with that last blocker:- Fixed it.... Galya B
11:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Actually even before that, since it needs to be done only on the ServerDriver. Galya B
11:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> If you have to implement the pid and it the library is not loaded, then do a late load of the nat...
Galya B
11:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, you make me worried extremely. Let me repeat what I've said (hoping it's received on the other end many time al... Galya B
11:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Greg, what do we do with the pid?
If you have to implement the pid and it the library is...
Greg Shah
11:03 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Also please understand that there is no @CentralLogerClient@ and @CentralLoggerServer@, but only @CentralLogger@. T... Greg Shah
10:13 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, what do we do with the pid? Galya B
10:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Ok, r14598 removed workingDir from LOG-MANAGER as well. Now all is going to be dumped by default in the server launch... Galya B
10:09 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> What should be the default folder for @LegacyLogManager@?
If the logging directory is not ...
Constantin Asofiei
10:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> The questions is how to know if in @CommonDriver#process@ on line 533 the library can be ac...
Constantin Asofiei
09:59 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Greg Shah wrote:
> > We might want to have an explicit step in the @StandardServer.boot...
Galya B
09:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> We might want to have an explicit step in the @StandardServer.bootstrap()@ process.
>
> Hynek/...
Constantin Asofiei
09:22 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
...and appserver logs go to work dir, which is probably quite a server. Galya B
09:18 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Also please understand that there is no @CentralLogerClient@ and @CentralLoggerServer@, but only @CentralLogger@. The... Galya B
09:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> Galya Bogdanova wrote:
> > In OE logs go to work dir. In directory.xml you can configur...
Galya B
09:00 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Greg Shah wrote:
> > > Where is @System.loadLibrary("p2j")@ called server-side, so that th...
Greg Shah
08:43 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > Where is @System.loadLibrary("p2j")@ called server-side, so that the native lib can be used to ...
Galya B
08:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Where is @System.loadLibrary("p2j")@ called server-side, so that the native lib can be used to access process id (r... Greg Shah
08:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> If you think it's worth it to handle file writes and rotation manually for the sake of improved formatting of rotat... Greg Shah
08:16 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
*Changes in r14597:*
* Client @CentralLogger@ initialized after @LogicalTerminal#init()@ completion on the server an...
Galya B
05:57 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Any of above-mentioned specifiers will be available for customers to define in the name of the log file. Galya B
05:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg, if a formatted rotation number is needed for CentralLogger files, then a custom FileHandler (the core of the cu... Galya B
03:08 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Is it alright in general for @ThinClient.getChanges()@ to be executed before @LogicalTerminal.init()@? I mean do we n... Galya B

04/18/2023

11:31 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Nice! I stand corrected. Greg Shah
11:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> I suspect your winner is not my winner. ;)
You underestimate my estimation. :)
Galya B
11:28 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I suspect your winner is not my winner. ;)
Options 1 and 2 are performance killers so we cannot use them.
Optio...
Greg Shah
11:24 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
P.S. We'll also have to disable @setLevel()@ on clients. Galya B
11:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg,
I think we need to consider a few aspects with this global server-side logging level. With last minute chang...
Galya B
11:07 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin, I reverted the loggers in the Json* classes to static, because I cannot reproduce the problem now, but I'... Galya B
11:04 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Let's confirm: After @LogicalTerminal.init()@ is called *on the client*, then it's safe to ...
Constantin Asofiei
10:54 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> > Have you considered moving to another programming language - an event-driven, functional one - ...
Galya B
10:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> Do you want separate levels for clients at all or one global level for all processes is enough?
A global level ...
Greg Shah
10:42 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> This is similar to my listener idea. Design it with a static flag and then change the flag in th...
Galya B
10:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Or if I got it wrong and @LogicalTerminal.init()@ should be called on the server, then how do I push the init state t... Galya B
10:35 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Let's confirm: After @LogicalTerminal.init()@ is called *on the client*, then it's safe to send logs to be handled in... Galya B
10:30 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Another note, this code in @CentralLoggerClient@:... Constantin Asofiei
10:26 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> Yes, I guess. There was no right synchronizer registered. The logs were not processed by @L...
Constantin Asofiei
10:21 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
P.S. OE doesn't allow it (just by the way, again) - the freedom of deciding if you want and how you want a rotation n... Galya B
10:19 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> I'm looking for the position in the filename to be controllable, not the number itself.
How will...
Galya B
10:15 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> I don't understand you. Do you want separate levels for clients at all or one global level ...
Galya B
10:14 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> Galya Bogdanova wrote:
> > The current design is that client and server logging levels are indep...
Galya B
10:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> What do you mean by "the separate spawner process"? I'm OK with implementing the flexible format...
Galya B
10:06 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> > 2. Constantin Asofiei wrote:
> > > @p2j.net.Protocol.applyChanges@ - this code:
> > ...
Galya B
09:37 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> The current design is that client and server logging levels are independent, so that the cl...
Greg Shah
09:34 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> We can implement more flexible formatter for log records in a future task, when the separate spawner process is rem... Greg Shah
09:27 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> why not calculate the real logging level (in a different field), cache it on the first isLoggable call, and invalid... Greg Shah
07:41 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
1. Constantin Asofiei wrote:
> > p2j.main.StandardServer.boostrap - there is some commented ...
Constantin Asofiei
06:24 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
*Changes in r14595:*
* JavaDoc added for @ClientCore.isNativeLayerInitialized@ and @NetResource.LOG@.
* Wrong log...
Galya B
05:12 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> So, why not calculate the real logging level (in a different field), cache it on the fir...
Galya B
04:09 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
@!IS_LOGGER_WORK_FINISHED.get()@ is a simple boolean check, while @isLoggable(level)@ is more complex method, no reas... Galya B
04:02 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya, I agree that string literals are kept on the constant pool, and do not pose a garbage-collection problem, but ... Constantin Asofiei
04:01 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Constantin Asofiei wrote:
> You can add the client-specific code to @ClientDriver.start@ and leave here only this he...
Galya B
03:53 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Discussion from email:
On 4/18/23 10:37, Galya Bogdanova wrote:
> Constantin,
>
> I'm not asking about concaten...
Constantin Asofiei
03:47 AM Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Galya Bogdanova wrote:
> 2. Constantin Asofiei wrote:
> > @clientConfig/workingDir@ is for FWD clients. There is no...
Constantin Asofiei
 

Also available in: Atom