Project

General

Profile

Activity

From 07/16/2024 to 08/14/2024

08/14/2024

07:18 AM Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
Constantin: Please review. Greg Shah
02:55 AM Bug #8383 (Review): Some JsonObject methods create a LOG-MANAGER record in silent
I was testing a wrong branch. The duplicate issue wasn't related to #8799.
So 8383a still in review. r15381 after ...
Galya B

08/13/2024

10:58 AM Bug #8383 (WIP): Some JsonObject methods create a LOG-MANAGER record in silent
8383a rebased on trunk r15377. The 5 months of review broke the fix on rebase. So starting from start. Galya B

08/08/2024

10:45 AM Feature #7279 (Test): Enhance CentralLogger to support configurable LogFormatter
7279b was merged to trunk as rev. 15374 and archived. Galya B
10:40 AM Feature #7279 (Merge Pending): Enhance CentralLogger to support configurable LogFormatter
This can merge to trunk now. Greg Shah
09:47 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Galya B wrote:
> 7279b r15374.
Thanks, I'm OK with the changes.
Constantin Asofiei
09:38 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
7279b r15374. Galya B
09:25 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
> I'm not sure. Why do we need initialize, it doesn't say anything about the need of this method.
No, the javadoc fo...
Constantin Asofiei
09:12 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Or @initializeWithServerContext@. Galya B
09:09 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
What about @initializeOnServerMain@? \* Edited \* Galya B
09:08 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Constantin Asofiei wrote:
> Review for 7279b 15373:
> * please rename @readDirectory@ to @initialize@
I'm not sure...
Galya B
09:06 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Review for 7279b 15373:
* please rename @readDirectory@ to @initialize@
* please move this code to another @serverH...
Constantin Asofiei
05:50 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
@SsoAuthenticator.authenticate@ is called on Jetty threads and in hotel_gui that's where the db configs are read from... Galya B

08/05/2024

09:57 AM Feature #7279 (Test): Enhance CentralLogger to support configurable LogFormatter
7279a was merged to trunk as rev. 15368 and archived. Galya B
09:47 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Galya B wrote:
> Tested with customer app. When do I merge?
This can be merged to trunk now.
Constantin Asofiei
09:03 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Tested with customer app. When do I merge? Galya B
05:34 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Galya B wrote:
> > * if you haven't already, please configure a large app with slf4j and test if the appservers and ...
Constantin Asofiei
04:55 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Constantin Asofiei wrote:
> * what happens with the spawner errors, if slf4j is enabled at the FWD server? I ask bec...
Galya B
03:13 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Review for 7279a/15370; I don't have objections to the code, just some general questions/requests:
* what happens wi...
Constantin Asofiei
01:15 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Constantin, how is the review going? Galya B

07/30/2024

09:48 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Notes that can help with the review:
* The logging initialization has been moved after @SecurityManager@ is created ...
Galya B
04:32 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
I had to rework a few more places on top of the configs to remove all dependencies on directory. Now web works.
r1...
Galya B
02:31 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Greg Shah wrote:
> > I tried to bind directory before each request handling, but it didn't work too. @DirectoryServi...
Galya B

07/29/2024

04:17 PM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Galya B wrote:
> @DirectoryService.clwa@, that is used to check for bound, is @ContextLocal@, so I guess the directo...
Greg Shah
08:00 AM Feature #7279 (Review): Enhance CentralLogger to support configurable LogFormatter
7279a r15367 is ready for review, if we don't mind the fact it breaks web clients... I need some help to understand w... Galya B
04:53 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
@DirectoryService.clwa@, that is used to check for bound, is @ContextLocal@, so I guess the directory service needs t... Galya B

07/26/2024

10:49 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Normally it won't fail unless you're reading when not bound or you pass a null nodeid. Greg Shah
09:31 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Any ideas what can cause @DirectoryService.lockRO@ to return @false@? I got myself a stumbling block somehow, but I d... Galya B
06:10 AM Bug #8281 (Closed): Use CacheManager for DynamicQueryHelper and DynamicValidationHelper
Greg Shah
03:27 AM Bug #8281: Use CacheManager for DynamicQueryHelper and DynamicValidationHelper
This can be closed. Alexandru Lungu

07/24/2024

04:54 AM Feature #9002: Improve landlord database connection resiliency and add transactions when updating it
Currently, the connection for the landlord database is only made once, during server startup. If something that deter... Radu Apetrii
04:43 AM Feature #9002 (Closed): Improve landlord database connection resiliency and add transactions when...
Radu Apetrii

07/19/2024

08:57 AM Feature #8989: Add support for multiple dialects for the multi-tenant landlord database
At the moment of writing this, the landlord database for multi-tenancy is only supported with H2. There are a few ite... Radu Apetrii
08:40 AM Feature #8989 (Test): Add support for multiple dialects for the multi-tenant landlord database
Radu Apetrii

07/17/2024

12:57 PM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
I forgot the engine itself might need to be debugged, so it makes sense to use the FWD logs. As for the progress test... Galya B
12:56 PM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
@FWDTestEngine@ is our implementation of ABLUnit/OEUnit 4GL unit testing. The 4GL test code in such unit tests is ju... Greg Shah
12:54 PM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
4GL tests will not write directly to @CentralLogger@ if that is what you are asking. They may write to @LOG-MANAGER@... Greg Shah
12:31 PM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Actually the @log-it@ thing is not related. I was thinking about the @LOG-MANAGER@ that had to be used. Anyways, the ... Galya B
12:29 PM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
The original OE tests themselves have the @log-it@ custom logging functionality and I'm not sure how that's migrated,... Galya B
12:25 PM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Galya B wrote:
> Do we use @CentralLogger@ logs for the tests run by @FWDTestEngine@?
I would hope so.
Greg Shah
12:24 PM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Do we use @CentralLogger@ logs for the tests run by @FWDTestEngine@? Galya B
10:43 AM Feature #8976: Admin REST API for interacting with tenant authentication tables
> For achieving this, do we need to add another handler (like TenantHandler, RestHandler, SoapHandler), or can it be ... Greg Shah
10:19 AM Feature #8976: Admin REST API for interacting with tenant authentication tables
Marian Edu wrote:
> I’m sure both are used outside of the ‘multi tenant’ environment, both authentication system and...
Radu Apetrii
10:07 AM Feature #8976: Admin REST API for interacting with tenant authentication tables
Greg Shah wrote:
> Marian: Please comment.
I’m sure both are used outside of the ‘multi tenant’ environment, both...
Marian Edu
07:23 AM Feature #8976: Admin REST API for interacting with tenant authentication tables
> > I thought these tables were also used outside of multi-tenant. If so, then we want the API to be independent.
>...
Greg Shah
07:16 AM Feature #8976: Admin REST API for interacting with tenant authentication tables
Greg Shah wrote:
> I thought these tables were also used outside of multi-tenant. If so, then we want the API to be...
Radu Apetrii
07:07 AM Feature #8976: Admin REST API for interacting with tenant authentication tables
I thought these tables were also used outside of multi-tenant. If so, then we want the API to be independent. Greg Shah
06:24 AM Feature #8976: Admin REST API for interacting with tenant authentication tables
Greg/Constantin: Is it OK if the work is done in @TenantHandler@ from 6229b? Considering that these tables are tenant... Radu Apetrii
06:19 AM Feature #8976: Admin REST API for interacting with tenant authentication tables
The point of this task is to implement admin REST APIs for interacting with the tenant authentication tables: @sec_au... Radu Apetrii
06:12 AM Feature #8976 (Test): Admin REST API for interacting with tenant authentication tables
Radu Apetrii

07/16/2024

05:55 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
Galya B wrote:
> I found a partial solution to the problem of pre-init logs and crash files that have to be migrated...
Galya B
04:52 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter
I found a partial solution to the problem of pre-init logs and crash files that have to be migrated to slf4j. The fla... Galya B
 

Also available in: Atom