FWD » Core Development » Runtime Infrastructure

08/19/2024

08:46 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Tijs Wickardt wrote:
> Roger: I presume no changes to existing @install_spawner.sh@ in testcases is needed (because ... Roger Borrello

07:28 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Yes, if not customized the default @install_spawner.sh@ calls @postbuild.sh@ from the trunk branch that is already mo... Galya B

07:27 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Thank you Galya, it must be a customer thing then. I'll look into it.
Roger: I presume no changes to existing @insta... Tijs Wickardt

07:14 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

If someone has modified the included @p2j@ @postbuild.sh@ they will have an issue and they need to fix it, but with v... Galya B

07:12 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Tijs Wickardt wrote:
> Galya B wrote:
> > This is mentioned in the merge notification in #8828-113.
> Thanks.
> T... Galya B

06:56 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Galya B wrote:
> This is mentioned in the merge notification in #8828-113.
Thanks.
That leaves:
# Do other GCD de... Tijs Wickardt

06:38 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Tijs Wickardt wrote:
> A customer detected that the [[p2j:Testcases]] project seems broken by this change.
> After ... Galya B

06:11 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Galya, note that the customer didn't pinpoint this task to be the cause. This was an assumption.
The problem is pres... Tijs Wickardt

05:51 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

A customer detected that the [[p2j:Testcases]] project seems broken by this change.
After manually copying and resta... Tijs Wickardt

08/14/2024

07:18 AM Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent

Constantin: Please review. Greg Shah

02:55 AM Bug #8383 (Review): Some JsonObject methods create a LOG-MANAGER record in silent

I was testing a wrong branch. The duplicate issue wasn't related to #8799.
So 8383a still in review. r15381 after ... Galya B

08/13/2024

10:58 AM Bug #8383 (WIP): Some JsonObject methods create a LOG-MANAGER record in silent

8383a rebased on trunk r15377. The 5 months of review broke the fix on rebase. So starting from start. Galya B

08/08/2024

10:45 AM Feature #7279 (Test): Enhance CentralLogger to support configurable LogFormatter

7279b was merged to trunk as rev. 15374 and archived. Galya B

10:40 AM Feature #7279 (Merge Pending): Enhance CentralLogger to support configurable LogFormatter

This can merge to trunk now. Greg Shah

09:47 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Galya B wrote:
> 7279b r15374.
Thanks, I'm OK with the changes. Constantin Asofiei

09:38 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

7279b r15374. Galya B

09:25 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

> I'm not sure. Why do we need initialize, it doesn't say anything about the need of this method.
No, the javadoc fo... Constantin Asofiei

09:12 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Or @initializeWithServerContext@. Galya B

09:09 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

What about @initializeOnServerMain@? \* Edited \* Galya B

09:08 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Constantin Asofiei wrote:
> Review for 7279b 15373:
> * please rename @readDirectory@ to @initialize@
I'm not sure... Galya B

09:06 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Review for 7279b 15373:
* please rename @readDirectory@ to @initialize@
* please move this code to another @serverH... Constantin Asofiei

05:50 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

@SsoAuthenticator.authenticate@ is called on Jetty threads and in hotel_gui that's where the db configs are read from... Galya B

08/05/2024

09:57 AM Feature #7279 (Test): Enhance CentralLogger to support configurable LogFormatter

7279a was merged to trunk as rev. 15368 and archived. Galya B

09:47 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Galya B wrote:
> Tested with customer app. When do I merge?
This can be merged to trunk now. Constantin Asofiei

09:03 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Tested with customer app. When do I merge? Galya B

05:34 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Galya B wrote:
> > * if you haven't already, please configure a large app with slf4j and test if the appservers and ... Constantin Asofiei

04:55 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Constantin Asofiei wrote:
> * what happens with the spawner errors, if slf4j is enabled at the FWD server? I ask bec... Galya B

03:13 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Review for 7279a/15370; I don't have objections to the code, just some general questions/requests:
* what happens wi... Constantin Asofiei

01:15 AM Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Constantin, how is the review going? Galya B