General

Profile

Eduard Soltan's activity

From 03/28/2025 to 04/26/2025

04/26/2025

02:55 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
Ovidiu Maxiniuc wrote:
> Review of 8904a/r15892.
>
> Generally, I am OK with the changes. And this is a large cha...
Eduard Soltan

04/25/2025

09:31 AM Base Language Bug #8944: FINALLY block transaction processing
Artur Școlnic wrote:
> The patch from #9803-46 solved the initial problem this task was opened for, considering that...
Eduard Soltan
04:53 AM Base Language Bug #8944: FINALLY block transaction processing
I have added a fix for transaction management in 4602a, rev. 15880. Eduard Soltan
02:50 AM Base Language Bug #8944: FINALLY block transaction processing
According to note #8944-26 and my observation in FWD.
Transaction is opened in @TM.PushScope@, through @TxWrapper.sc...
Eduard Soltan
08:14 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
Constantin Asofiei wrote:
> The only concern is the usage of @isIgnore()@ in @ErrorManager.handleStopException@ - do...
Eduard Soltan

04/24/2025

03:26 PM Base Language Feature #8904 (Review): implement -catchStop and the integration/conversion of STOP conditions in...
Eduard Soltan
03:25 PM Base Language Feature #8904 (WIP): implement -catchStop and the integration/conversion of STOP conditions into ...
Committed the handling of StopConditionException through ErrorManager.
Conversion of large GUI app and another cus...
Eduard Soltan

04/23/2025

08:18 AM Base Language Feature #6292: nested catch blocks
Greg Shah wrote:
> With 9470a merged to trunk as revision 15867, is this task complete?
Yes, I think so.
Eduard Soltan
05:35 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
Constantin Asofiei wrote:
> Eduard Soltan wrote:
> > Committed on 8904a, rev. 15888.
>
> I assume there was a re...
Eduard Soltan
04:00 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
Committed on 8904a, rev. 15888. Eduard Soltan
03:32 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
No, I can't inherit from any of this classes.
It gives the following error, for all subclasses of Progress.Lang.Sto...
Eduard Soltan
02:43 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
Constantin Asofiei wrote:
> Eduard, is it possible to have application-defined @Stop@ sub-classes? I think the conve...
Eduard Soltan

04/22/2025

01:54 PM Base Language Bug #8944: FINALLY block transaction processing
Constantin Asofiei wrote:
> Eduard, in 4GL there is an implicit FULL transaction created when EXLCUSIVE-LOCK is used...
Eduard Soltan
01:00 PM Base Language Bug #8944: FINALLY block transaction processing
Greg Shah wrote:
> If the @FINALLY@ is more deeply nested (the full transaction is in a more enclosing block, not in...
Eduard Soltan
07:23 AM Base Language Bug #8944: FINALLY block transaction processing
Artur Școlnic wrote:
> Isn't a new transaction for the finally block expected?
I created the a test cases to look...
Eduard Soltan
05:16 AM Base Language Bug #8944: FINALLY block transaction processing
Artur Școlnic wrote:
> As far as I know, a full transaction is started by a block only if a transaction is not alrea...
Eduard Soltan

04/17/2025

09:50 AM Base Language Bug #8944: FINALLY block transaction processing
I will take a look at this one, since there CATCH blocks also need transaction support. And there is a good chances t... Eduard Soltan

04/16/2025

10:59 AM Base Language Bug #9910: Incorrect Error Handling for ROUTINE-LEVEL ON ERROR UNDO, THROW in FWD ABLUnit Tests
Got you. I think that these tests are pretty similar.... Eduard Soltan
09:16 AM Base Language Bug #9910: Incorrect Error Handling for ROUTINE-LEVEL ON ERROR UNDO, THROW in FWD ABLUnit Tests
This is the unit test result I get with trunk rev. 15859:... Eduard Soltan
10:33 AM Base Language Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody
Andrei Plugaru wrote:
> The solution is already in @9753a/15849@. Constantin, please review it when you are availabl...
Eduard Soltan
09:40 AM Base Language Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody
Perhaps a more simple approach with a flag in set in @DeferredLegacyErrorException@ and @LegacyErrorException@, and v... Eduard Soltan
09:38 AM Base Language Bug #9893: LegacyErrorException is not rethrown in processForBody/processBody
I know this one, @ValidationError@ error from @batchAssign@ is propagated as a LegacyError, but another @ValidationEr... Eduard Soltan
08:53 AM Base Language Bug #4602 (WIP): fixes for OO 4GL and structured error handling
Eduard Soltan
07:32 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
Also there is the following test case which is not handled in fwd:... Eduard Soltan
07:18 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
Committed on 4602a, rev. 15763. Added history entries and java docs. Eduard Soltan
06:18 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
A little break down of the things performed on 4602a:
1) Added support for catch blocks in iteration blocks. Basic...
Eduard Soltan

04/14/2025

05:27 AM Conversion Tools Bug #7255 (Test): FWD resolves a OO file not included in conversion, if it exists on disk and on ...
Eduard Soltan
05:26 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
7255a was merged to trunk rev. 15852 and archived. Eduard Soltan

04/11/2025

07:03 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
Committed on UAST testcases project under @uast/error_handling2/4GLTestsGenerator/@ the Java sources used to generate... Eduard Soltan
06:13 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
Greg Shah wrote:
> > 1) @undo, retry@ statment in repetive blocks like @repeat_to@, @repeat_to_while@, @do_to@, @do_...
Eduard Soltan
03:58 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Fixed review issue. Committed on 7255a, rev. 15830. Eduard Soltan
01:54 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
Conversion and runtime testing for CHUI and CTRL-C tests went successfully. ✅
GUI application conversion and unit te...
Eduard Soltan

04/10/2025

09:09 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Committed on 7255a, rev. 15829.
Refactor the @addAdditionalFiles@ and @removeFiles@ methods, to get as a parameter...
Eduard Soltan
07:55 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
Committed the testcases to old testcases project under @uast/error_handling2@. Eduard Soltan
05:45 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
I have committed on the 8904a. Fix for review issues and a fix for a issues that encountered in the conversion of tes... Eduard Soltan

04/09/2025

06:40 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
Fixed review issues and rebased to latest trunk. Eduard Soltan

04/08/2025

09:09 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
Constantin Asofiei wrote:
> Review for 8904a rev 15846:
> * @Queue.java@
> ** this *must not* be aware of the exce...
Eduard Soltan
04:29 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
Managed to find and solve (hopefully) the problem input-output parameter updates in the caller with different flow-of... Eduard Soltan
01:55 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
>
> Otherwise, please get the #9457 app setup (see #9457-39), and test the #9420 scenari...
Eduard Soltan
01:35 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Greg Shah wrote:
>
> My only concern is that the changes are likely to have an impact on performance. @SR.findFil...
Eduard Soltan

04/07/2025

08:58 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
Marian Edu wrote:
>
> Eduard, not sure what is the difference here - I assume in FWD the variables are updated (al...
Eduard Soltan
01:53 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
The problem that I am facing right now. I have some tests with control-of-flow statement and error throwings directly... Eduard Soltan
01:20 AM Base Language Bug #4602: fixes for OO 4GL and structured error handling
I have generated a test suite with errors or control-of-flow condition being thrown in different blocks (do, repeat, ... Eduard Soltan

04/04/2025

03:22 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> * the way the static fields are now in @ScanDriver@, this does not support multi-threadi...
Eduard Soltan
02:41 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> * shouldn't this code 'break' the loop? Because otherwise you remove the @referenceFi...
Eduard Soltan

04/03/2025

10:00 AM Conversion Tools Bug #7255 (Review): FWD resolves a OO file not included in conversion, if it exists on disk and o...
Eduard Soltan
08:27 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Committed on 7255a, rev. 15825. Eduard Soltan
04:44 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> > * if oo.Bar is in both src1 and src2, PROPATH has both src1/ and src2/, and both src...
Eduard Soltan

04/02/2025

12:37 PM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Ok, after this discussion lets recap a bit to not create any more confusion.
* if oo.Bar exists only once in PROPA...
Eduard Soltan
11:22 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Eduard Soltan wrote:
> I think that is the source of confusion. As in the current version of trunk, for duplicate ...
Eduard Soltan
11:17 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> Eduard Soltan wrote:
> > And in @findFile@ there is no way I will even know that there ...
Eduard Soltan
11:10 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> So if you have @src1/oo/Bar.cls@ and @src2/oo/Bar.cls@ in conversion list, and only @src...
Eduard Soltan
10:21 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> Eduard Soltan wrote:
>
> >
> > In @SymbolResolver.findFile@, if the propath entry i...
Eduard Soltan
09:44 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> PROPATH always has precedence. It doesn't matter if multiple .cls with the same basenam...
Eduard Soltan
08:08 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> To summarize the rules we need to follow:
> * if oo.Bar exists only once in PROPATH, bu...
Eduard Soltan
07:14 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> * if a skeleton class is in abl/ folder and included in conversion, and is also in PROPA...
Eduard Soltan
07:05 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> To summarize the rules we need to follow:
> * if oo.Bar exists only once in PROPATH, bu...
Eduard Soltan
05:13 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
I am wondering what will happen if I have a usage of normal 4gl procedure like @run proc1.p@. Eduard Soltan
05:10 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> OK, now remove from conversion list @oo.Bar@ and check what happens - it should be added...
Eduard Soltan
04:51 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> Yes, this I think is from hierarchy. But you can also have @def var l1 as oo.Bar@, not ...
Eduard Soltan
04:40 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin, regarding the parsing of the reference files.
I have a @oo.Foo.cls@ class the inherits from @oo.Bar.cl...
Eduard Soltan

04/01/2025

03:24 AM Base Language Bug #9819: SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST
9819a was merged to trunk rev. 15831 and archived. Eduard Soltan

03/31/2025

07:25 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> Are you modifying the PROPATH maps in FWD? I don't want to do this, just check at resol...
Eduard Soltan
05:34 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Eduard Soltan wrote:
>
> But I was think about something more general.
>
> I have a @src/oo/Foo.cls@ class whic...
Eduard Soltan
06:18 AM Database Bug #9763: xml-node-name buffer option
Testing performed with *rev. 15835*:
- unit tests of a large customer application ✅
- harness ✅
- Chui regressio...
Eduard Soltan

03/30/2025

04:16 AM Base Language Bug #9819: SESSION:FIRST-ASYNC-REQUEST and SESSION:LAST-ASYNC-REQUEST
I had a problem with my workstation and had to redo the conversion. I performed the conversion with 9818a of a large ... Eduard Soltan

03/29/2025

01:57 AM Database Bug #9763: xml-node-name buffer option
Ovidiu Maxiniuc wrote:
> > [...]
> I see @READ-json@, I was expecting a @read-xml@ based on the changes in @XmlIm...
Eduard Soltan

03/28/2025

04:44 PM Database Bug #9763: xml-node-name buffer option
I have made the modification in @TempTableBuilder@.
But also made some changes in @XmlExport@ and @XmlExport@ to m...
Eduard Soltan
03:33 PM Database Bug #9763: xml-node-name buffer option
Committed on 9763b, rev. 15832.
Sure thing, I added the method in @TempTableBuilder@, and the attributes will be set...
Eduard Soltan
03:03 PM Database Bug #9763: xml-node-name buffer option
Ovidiu Maxiniuc wrote:
> Not in @AbstractTempTable@, just in @TempTableBuilder@.
But this implies to override all...
Eduard Soltan
02:14 PM Database Bug #9763: xml-node-name buffer option
Ovidiu Maxiniuc wrote:
> Only in this particular case (@AbstractTempTable._dynamic()@ returns @true@), the attribut...
Eduard Soltan
02:06 PM Database Bug #9763: xml-node-name buffer option
Eduard Soltan wrote:
> The problem is that @TempTableBuilder@ does not initialize the @defaultBuffer@. Hence setting...
Eduard Soltan
01:45 PM Database Bug #9763: xml-node-name buffer option
There is a regression in at @dataset ddt1:read-xml@, when has no buffer set.
In @XmlImport.importDataset@ it go on...
Eduard Soltan
07:19 AM Database Bug #9763: xml-node-name buffer option
The unit tests and smoke tests of a large GUI application went fine.✅
Also got some news that unit test of a very ...
Eduard Soltan
03:10 AM Database Bug #9763: xml-node-name buffer option
Ovidiu, why do we use @if (buffer.getSerializeName().toStringMessage().equalsIgnoreCase(name)@ in XmlImport.importDat... Eduard Soltan
09:50 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> If is included, then yes, go ahead and resolve it from that PROAPTH location. The probl...
Eduard Soltan
09:22 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> Eduard Soltan wrote:
> > This name duplication with 4gl buildin classes, or with custom...
Eduard Soltan
09:03 AM Conversion Tools Bug #7255: FWD resolves a OO file not included in conversion, if it exists on disk and on PROPATH
Constantin Asofiei wrote:
> Greg Shah wrote:
> > In regard to the change itself, I wonder if we should put an addit...
Eduard Soltan
 

Also available in: Atom