Ovidiu Maxiniuc's activity
From 04/27/2025 to 05/26/2025
05/26/2025
- 05:37 PM Database Feature #9456: implement SQL Server dialect and helpers
- With my latest changes from 9456a, I was able to convert and import the @hotel@ database into a MS SQL Server instanc...
- 03:58 PM Database Bug #10049 (Internal Test): UDF configuration regression in Persistence.java
- OK, then I am putting this to the test.
This area is accessed each time a @Persistence@ object is initialized. The... - 01:34 PM Database Bug #10049 (Review): UDF configuration regression in Persistence.java
- Constantin, please review the fix since it is a bit different (I rewrote 4 lines to be more human readable) than what...
- 01:32 PM Database Bug #10049 (Internal Test): UDF configuration regression in Persistence.java
- Constantin noticed a flaw in the configuration of UDF (SQL native vs deprecated Java). Just by chance, I identified t...
- 01:17 PM Database Bug #10049 (Test): UDF configuration regression in Persistence.java
- 11:14 AM Database Feature #7504: Export data tool from FWD into .d files
- I'm also on Idea and I see 35 of them. Maybe you have a filter of some kind?
I cannot export this list so I attached... - 07:56 AM Database Feature #7504: Export data tool from FWD into .d files
- +Review of 7504b / r15907+
I think there might be some issues with current changes from @raw@ class. The problem i... - 10:55 AM Database Bug #9763: xml-node-name buffer option
- I had one more quick look over 9763b, r15949.
In @BufferImpl.java@, I think there is a rebase error, @** 139 ES 2... - 08:03 AM Database Bug #9763: xml-node-name buffer option
- Do you mean 9763b? The current revision is 15835. Is it possible you pushed to different branch?
05/23/2025
- 04:06 PM Database Feature #9543: implement missing BUFFER attributes
- I think the update is safe.
But, before the merge into trunk, please add the following changes (no code affected, ... - 03:02 PM Database Feature #7504: Export data tool from FWD into .d files
- +Review of 7504b / r15906+
Good job. Just some minor issues:
* @Record.java@:2099: a space is required after @if@...
05/22/2025
- 02:48 PM Database Feature #7504: Export data tool from FWD into .d files
- +Review of 7504b / r15905+
It seems pretty advanced to me. None of the next issues are really serious, but they sh...
05/21/2025
- 06:08 PM Runtime Infrastructure Feature #9002 (Test): Improve landlord database connection resiliency and add transactions when u...
- No, my intention was to set it on Test.
- 04:21 PM Runtime Infrastructure Feature #9002: Improve landlord database connection resiliency and add transactions when updating it
- It's not the case. Although there are a lot of changes in the @TenantManager@ (the only altered file), there are only...
- 09:58 AM Runtime Infrastructure Feature #9002 (Internal Test): Improve landlord database connection resiliency and add transactio...
- Of course, I did the usual harness test before the merge operation.
- 09:56 AM Runtime Infrastructure Feature #9002: Improve landlord database connection resiliency and add transactions when updating it
- Branch 9002a was merged to trunk rev 15927 and archived.
- 06:02 PM Base Language Feature #9955 (Internal Test): Implement ClientPrincipal:TENANT-ID and ClientPrincipal:TENANT-NAME
- Thank you, Radu. Related to reported issues:
* I did a quick test and in that case the timestamp is silently ignored... - 05:27 AM Database Feature #7504: Export data tool from FWD into .d files
- Yes.
That's the *size of the payload*. In other words, *the offset at which the the footer starts* (the file offset ...
05/20/2025
- 11:37 AM Database Feature #7020: always use "expanded" extent fields
- Cool. I presumed that, but needed a confirmation.
- 09:39 AM Database Feature #7020: always use "expanded" extent fields
- Nice catch!
The changes in 7020d, r15920 are good.
If I am not mistaken, in the case of the GUI project with harn...
05/19/2025
- 03:28 PM Runtime Infrastructure Feature #9002 (Internal Test): Improve landlord database connection resiliency and add transactio...
- Radu, thank you for spotting the 1st bullet. I moved the @setAutoCommit()@ so that it applies to the returned connect...
05/16/2025
- 06:31 PM Database Bug #9969: Parsing query string error with \r character.
- After upgrading to trunk 15913 (including 15910), the antlr build target results in a lot (30+) of nondeterminism err...
- 12:47 PM Database Feature #7020: always use "expanded" extent fields
- +Review of 7020d r15919+
I see nothing wrong with the new code. In fact, I slightly remember writing code similar ... - 10:08 PM Base Language Feature #9955 (Review): Implement ClientPrincipal:TENANT-ID and ClientPrincipal:TENANT-NAME
- Please review.
- 10:07 PM Base Language Feature #9955 (WIP): Implement ClientPrincipal:TENANT-ID and ClientPrincipal:TENANT-NAME
- Committed revision 15907 into 9955a with improved support. All above issues were addressed.
The only remaining issue...
05/15/2025
- 06:32 PM Database Feature #9543 (Internal Test): implement missing BUFFER attributes
- I looked at the changes of this last revision. I think they should work. A couple of notes:
* the @isBufferCopyDesti... - 05:38 PM Database Feature #9546: investigate and implement field options, if missing
- First, a disclaimer: there is little information about these attributes, including on progress.com. The statements be...
- 11:23 AM Database Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- I am sorry for the trouble.
The SQL statements stand in notes 6 (for PgSQL) and 8 (for H2). I adjusted them by dro... - 08:45 PM Base Language Feature #9955: Implement ClientPrincipal:TENANT-ID and ClientPrincipal:TENANT-NAME
- I created task branch 9955a and committed the initial implementation.
The initial commit contains:
* full support f... - 08:35 PM Runtime Infrastructure Feature #9002: Improve landlord database connection resiliency and add transactions when updating it
- Radu,
I have updated 9002a with latest changes. Some of them are already in trunk, some pieces of code had to update... - 08:34 PM Database Feature #9456: implement SQL Server dialect and helpers
- A few weeks ago I created task branch 9456a for holding changes which would bring SQL Server dialect closer to all ot...
- 08:33 PM Database Feature #9455: port native user defined functions to SQL Server
- The goal of this task is to track the porting of native UDF functions for Microsoft SQL Server.
I already did par...
05/14/2025
- 04:25 PM Database Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- The @breakAfterAcquireFailure@ is no longer settable. It is always active (that is, its value is @true@).
For more d... - 02:59 PM Database Feature #7504: Export data tool from FWD into .d files
- Isn't the @dumpName@ attribute of @@Table@ DMO annotation useful (4GL @DUMP-NAME@ attribute) and neither the field na...
- 10:51 AM Database Feature #7504: Export data tool from FWD into .d files
- Lorian Sandu wrote:
> When importing the database, we don't store the original name of the file at the dmo level, th... - 06:34 AM Database Feature #9543: implement missing BUFFER attributes
- Review of 9543b, r15893.
* @RecordBuffer.java@:
** line 2019: the field is missing the javadoc;
** lines 3650, 4...
05/13/2025
- 07:05 PM Database Feature #9831 (Test): add admin API to set c3p0 configuration for individual tenant databases
- Branch 9831a was merged to trunk rev. 15905 and archived.
- 05:54 PM Database Feature #7504: Export data tool from FWD into .d files
- Lorian, I think you are on the right track:
* indeed, @DmoMeta.getFields()@ will give you the correct order of field...
05/12/2025
- 06:27 PM Database Feature #9976: eliminating DMO usage in inter-program linkage
- Greg,
I am not sure I got all detail, in spite of being focused on the 1st not for some time now. It's clear we will... - 03:57 PM Database Bug #9969: Parsing query string error with \r character.
- +Review of 9969a/r15902.+
* @UnicodeTranslationException@: missing javadocs for both the class and the constructor... - 08:03 AM Database Feature #9543: implement missing BUFFER attributes
- +Review of 9543b, r15892.+
I think you are on the right track, but there are a couple of issues which should be ad...
05/09/2025
- 07:21 PM Runtime Infrastructure Feature #8863: Add tenantName logic related to sec_authentication_domain in FWD
- I double checked all three bullets and all of them are working as expected.
This task can be closed. - 08:04 AM Database Bug #9950 (WIP): Upgrade the metadata schema to a newer version
- I noticed the following changes in the currently supported meta files (from DDL PoV):
* 10 (mandatory) columns added...
05/07/2025
- 04:20 PM Database Feature #9831 (Internal Test): add admin API to set c3p0 configuration for individual tenant data...
- > Meanwhile, I am putting the branch to the test using the the hotel, webGUI navigation and harness smoke-tests of a ...
- 01:57 PM Database Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- The @breakAfterAcquireFailure@ was removed from REST API and @landlord@ database.
The issues from note #9831-15 (th...
05/06/2025
- 10:07 AM Database Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- Radu,
I rebased and did a quick review of my own code, this revealed some small issues which were fixed.
You can ... - 07:55 AM Database Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- Added Radu as reviewer.
05/05/2025
- 04:19 PM Database Feature #7020 (Internal Test): always use "expanded" extent fields
- Branch 7020c (now r15866) is rebased but does not seem to have changes from the last time I reviewed it (old r15824)....
- 03:58 PM Runtime Infrastructure Feature #9002: Improve landlord database connection resiliency and add transactions when updating it
- Thank you, Radu for the attempt.
The explanation is that r15880 of 9002a is 'built' on top of 9831a (which is also i... - 03:52 PM Database Bug #9937: buffer argument with different DMO than the parameter
- Yes, I am aware, as you quoted me, _"[...] which declare the @new shared@ tables and *simple TT*."_ I was merely expr...
- 01:29 PM Database Bug #9937: buffer argument with different DMO than the parameter
- I think we have discussed about an idea similar to Eduard's, some time ago.
Currently, the DMO of a @shared@ temp-...
04/30/2025
- 07:59 PM Runtime Infrastructure Feature #9002 (Review): Improve landlord database connection resiliency and add transactions when...
- Committed revision 15880 to 9002a.
Now the complex operations on landlord database are performed in transactions.
... - 02:13 PM Runtime Infrastructure Feature #9002: Improve landlord database connection resiliency and add transactions when updating it
- The initial commit contains only the _"connection resiliency"_ part of the task: now the tenant manager will try to r...
- 02:29 PM Runtime Infrastructure Feature #8863 (WIP): Add tenantName logic related to sec_authentication_domain in FWD
- In the meet today, I affirmed that the first and last bullet are already implemented, just need to be tested/confirme...
- 02:15 PM Database Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
- Eric, please review.
I will rebase the branch since it is a bit behind the main trunk.
04/29/2025
- 07:54 PM Runtime Infrastructure Feature #9002 (WIP): Improve landlord database connection resiliency and add transactions when up...
- Created 9002a. Committed revision 15879.
04/28/2025
- 04:58 PM Base Language Feature #8904 (Internal Test): implement -catchStop and the integration/conversion of STOP condit...
- I have no observation related to this revision.
- 10:38 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...
- *Review of 8904a/r15902*
* @ConnectionManager.getTimeOut()@: why moving the connect options from @opts@ to @option... - 04:51 PM Database Bug #9950: Upgrade the metadata schema to a newer version
- One of the latest customer projects uses a newer schema (@standard.df@) of the _meta database than the one we have. I...
- 04:36 PM Database Bug #9950 (Test): Upgrade the metadata schema to a newer version
Also available in: Atom