General

Profile

Constantin Asofiei's activity

From 05/28/2025 to 06/26/2025

06/26/2025

02:06 PM Database Bug #6767: Possible name clashes in DMO classes
The conversion with 6767c gives me this:... Constantin Asofiei
12:35 PM Database Bug #6767: Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
> I updated @methodText@ from @getNextSibling@ to @nextSibling@. However, this change did...
Constantin Asofiei

06/25/2025

10:00 AM Conversion Tools Bug #10208: do not convert the schema in incremental mode if it hasn't changed
Greg Shah wrote:
> Can we just disable M0 in incremental mode?
The problem with is that for #9457 app, front-end sc...
Constantin Asofiei
03:23 AM Base Language Bug #9996 (Merge Pending): Object references should be decremented at the nearest block instead o...
9538d can be merged now. Constantin Asofiei

06/24/2025

03:45 PM Database Bug #10198: analyze FIND statements which use only a small number of fields
In a customer application, there are patterns where FIND is used to get a record, and from that record only its recid... Constantin Asofiei
03:35 PM Database Bug #10198 (New): analyze FIND statements which use only a small number of fields
Constantin Asofiei
03:33 PM Database Support #6709: track nested FIND inside a related FOR loop
This needs to be brought back into focus. What we need is a mode (when activated) which will track FIND queries, at ... Constantin Asofiei

06/23/2025

02:58 AM Conversion Tools Bug #10185: ADE conversion and runtime
Please check also:
* @DATASET-HANDLE@ argument type
* the handle array is an instance or static var in a .cls (not ...
Constantin Asofiei
02:51 AM Runtime Infrastructure Bug #10174 (Internal Test): Method/Procedure call overwrites procedure return value
I'm OK with the change. Constantin Asofiei

06/20/2025

05:21 AM Database Feature #9455: port native user defined functions to SQL Server
What if you call a PROCEDURE from a FUNCTION? Constantin Asofiei

06/18/2025

01:48 PM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
Greg Shah wrote:
> What is left to do?
Only if we get more dependencies after using a more real application/sample....
Constantin Asofiei
07:04 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
Greg Shah wrote:
> Yes, that is understood. Includes from the ADE code can be used in customer 4GL code. For websp...
Constantin Asofiei
06:54 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
*Greg* - even if we bring the webspeed files in FWD, the application converted .p's or .htm's can be dependent on inc... Constantin Asofiei
09:39 AM Runtime Infrastructure Bug #10174: Method/Procedure call overwrites procedure return value
Teodor, is this about the @FINALLY@ block? You can test this without OO. Constantin Asofiei
07:28 AM Runtime Infrastructure Feature #7080 (Merge Pending): expose all admin APIs via REST
Managed to run Hotel GUI in web and it works. Please merge 7080a now. Constantin Asofiei
06:20 AM Base Language Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality
I got the sample working with the web-speed files in FWD.
*Greg* - https://localhost:7443/scripts/cgiip.exe/WSer...
Constantin Asofiei

06/17/2025

03:12 PM Base Language Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality
*Radu* - the name_map.xml for the FWD changes to include web-disp.p and associated programs has the programs register... Constantin Asofiei
09:16 AM Runtime Infrastructure Bug #10071 (Merge Pending): Method code too large - ReflectASM
Go ahead and merge now. Constantin Asofiei
07:54 AM Runtime Infrastructure Bug #10136 (Merge Pending): SESSION:TEMP-DIRECTORY missing directory
Please merge 10136a now. Constantin Asofiei
04:38 AM Database Bug #10080 (Merge Pending): Temp-table records are leaking in can-find statements
Go ahead and merge now. Constantin Asofiei
03:45 AM Database Bug #10080: Temp-table records are leaking in can-find statements
Can this be queued for merge? Constantin Asofiei
03:44 AM Base Language Bug #10148 (Merge Pending): ENUM class GETENUM NullPointerException when using poly types
Please merge 10148a now. Constantin Asofiei

06/13/2025

03:24 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST
Ovidiu Maxiniuc wrote:
> That's good news.
>
> In parallel I did test it with both smoke-test/harness and GUI na...
Constantin Asofiei
02:04 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST
Ovidiu, I've retested web_apis with 7080a and these:
* Admin Console
* REST ADMIN
* SOAP/REST with and without lo...
Constantin Asofiei
02:24 PM Runtime Infrastructure Bug #10136: SESSION:TEMP-DIRECTORY missing directory
Greg Shah wrote:
> I don't object to your idea, but I'm also OK with always having the @tmp{random-digits}@ segregat...
Constantin Asofiei
01:28 PM Runtime Infrastructure Bug #10136: SESSION:TEMP-DIRECTORY missing directory
Teodor: please post your findings about what Greg mentioned.
Greg: my points about the temp dir are this:
* for G...
Constantin Asofiei
02:20 PM Database Bug #6767: Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
> We should distinguish these cases within the conversion rules, perhaps using conditiona...
Constantin Asofiei
01:40 PM Database Bug #6767: Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
> We need to update the conversion rules, as the correct method names are now @privateDat...
Constantin Asofiei
01:32 PM Base Language Bug #10148: ENUM class GETENUM NullPointerException when using poly types
Where you do @wa.staticReferents.put(cls, cls);@, do also @wa.referents2static.put(cls, cls);@ . This is missing now. Constantin Asofiei
03:46 AM Runtime Infrastructure Bug #10071 (Merge Pending): Method code too large - ReflectASM
Please merge after 9447a. Constantin Asofiei
03:43 AM Base Language Feature #9447 (Merge Pending): XML support feature improvements and testing
Please merge 9447a now. Constantin Asofiei
02:29 AM Conversion Tools Feature #6256: improved profile support
Greg Shah wrote:
> > There is a problem when the 'exclude' filter is used to not add files to conversion. During pr...
Constantin Asofiei

06/12/2025

12:02 PM Database Bug #6767: Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
> > Review of 6767c rev 15980.
> > * @AbstractTempTable@
>...
Constantin Asofiei
05:05 AM Database Bug #6767: Possible name clashes in DMO classes
Review of 6767c rev 15980.
* @AbstractTempTable@
** line 2938 - please add back @defBuffer.bufferManager@ instead o...
Constantin Asofiei
08:06 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
Radu Apetrii wrote:
> Am I allowed to change the converted Java code from @web-util@ or @web-disp@, or should I trea...
Constantin Asofiei
05:08 AM Base Language Feature #9447: XML support feature improvements and testing
Did testing passed? Constantin Asofiei
05:07 AM Runtime Infrastructure Bug #10071 (Internal Test): Method code too large - ReflectASM
Teodor Gorghe wrote:
> Committed revision *15954* on task branch *10071a*.
> - replaced RuntimeException with Invoc...
Constantin Asofiei
04:03 AM Runtime Infrastructure Bug #10136: SESSION:TEMP-DIRECTORY missing directory
The @fwd{random-digits}@ folder is used to isolate Web clients (like GUI or ChUI), which on the original env, were ru... Constantin Asofiei

06/11/2025

07:47 AM Database Feature #7020: always use "expanded" extent fields
Is @expand-extents=true@ now the default and we need to configure projects which can't use this mode explicitly in p2... Constantin Asofiei

06/10/2025

03:07 PM Database Bug #6767: Possible name clashes in DMO classes
> And this refactor can be done automatically (with CTRL+SHIFT+G) in Eclipse, although each one needs to be done 'by ... Constantin Asofiei
01:17 PM Database Bug #6767: Possible name clashes in DMO classes
Vladimir, did you use some script to 'sed' the changes? As Eric mentioned, there are lots of unintended changes. The... Constantin Asofiei
05:24 AM Base Language Bug #10110 (Review): add ClientPrincipal support for FWD OpenClient
I've created 10110a from trunk rev 15977.
Rev 15978 adds support for a client-principal for the OpenClient request...
Constantin Asofiei
04:24 AM Base Language Bug #10110 (New): add ClientPrincipal support for FWD OpenClient
Constantin Asofiei
02:49 AM Base Language Feature #9447: XML support feature improvements and testing
Constantin Asofiei wrote:
> Teodor, please do run ETF with this.
>
> Also, ask Stefanel, Lorian, Serban to help w...
Constantin Asofiei
02:49 AM Database Feature #9440 (Merge Pending): get-codepage() function should work with CLOB fields
Please rebase and merge 9440a now. Constantin Asofiei

06/06/2025

10:20 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
Greg, we still have to bring the ADE converted source code into FWD. So, I assume for webspeed we will have a @com.g... Constantin Asofiei
09:38 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
Greg Shah wrote:
> If so, I guess Jetty will close it and we don't have to. Is that the idea? I don't want us to l...
Constantin Asofiei
09:19 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
Radu Apetrii wrote:
> One more question. I'm looking at the two outputs:
What is the RAW response in Postman? Or cu...
Constantin Asofiei
08:40 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > Lets make the WEB stream do nothing on flush or close - does th...
Constantin Asofiei
08:30 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
Lets make the WEB stream do nothing on flush or close - does this solve it? Constantin Asofiei
06:41 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
What does @StreamFactory.openWebStream(true)@ do with the @GenericOutputStream.close()@ - it actually closes somethin... Constantin Asofiei
06:13 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > What's happening if flush is not executed? Maybe override this...
Constantin Asofiei
04:45 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
What's happening if flush is not executed? Maybe override this when you open the WEB stream? Constantin Asofiei
03:41 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
Hmm... in FWD we emit @true@ for @CompilerOps.error()@. Change it to @FALSE@ for now. Constantin Asofiei

06/05/2025

03:29 AM Runtime Infrastructure Bug #10071: Method code too large - ReflectASM
I don't think you need to use the @catch@ block, @Utils.invoke@ already throws it?... Constantin Asofiei
03:25 AM Base Language Feature #9955: Implement ClientPrincipal:TENANT-ID and ClientPrincipal:TENANT-NAME
Ovidiu, you are missing @@Override@ for the ClientPrincipal added methods. Also, do @TENANT-ID()@ and @TENANT-NAME()... Constantin Asofiei
03:21 AM Base Language Feature #9447: XML support feature improvements and testing
Teodor, please do run ETF with this.
Also, ask Stefanel, Lorian, Serban to help with the other apps.
Constantin Asofiei
03:20 AM Database Feature #9440: get-codepage() function should work with CLOB fields
Teodor Gorghe wrote:
> Ok, thanks.
> Related to this task, I noticed that the task status become "Internal Test".
...
Constantin Asofiei
03:17 AM Base Language Feature #9437 (Merge Pending): enhancements for Progress.Lang.Class
Can be merged after 9879a Constantin Asofiei
01:51 AM Database Bug #10080: Temp-table records are leaking in can-find statements
Eduard, please see #10088-57 - is this task fixing the CAN-FIND sub-select, so that now it correctly has the _multipl... Constantin Asofiei

06/04/2025

03:40 AM Base Language Feature #9437 (Internal Test): enhancements for Progress.Lang.Class
Please put 9437a into test. Constantin Asofiei
03:29 AM Base Language Feature #9447: XML support feature improvements and testing
I missed this in @SaxReaderImpl@ - @public void setEntityExpansionLimit(integer limit)@ - missing javadoc
Constantin Asofiei
03:28 AM Base Language Feature #9447 (Internal Test): XML support feature improvements and testing
I'm ok with rev 15963. Lets get this into testing. Constantin Asofiei

06/03/2025

08:05 AM Base Language Feature #9437: enhancements for Progress.Lang.Class
Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Review for 9437a rev 15978:
>
> > ** @_getVariables@ - why ...
Constantin Asofiei
06:57 AM Base Language Feature #9437: enhancements for Progress.Lang.Class
Review for 9437a rev 15978:
* @LegacySignature.java@ and @variable_definitions.rules@ - rename @data_type@ to @dataT...
Constantin Asofiei
03:24 AM Base Language Feature #9437: enhancements for Progress.Lang.Class
Eduard Soltan wrote:
> Fixed review issues in rev. *15966*.
I don't see this commit.
Constantin Asofiei
06:20 AM Base Language Bug #9996 (Internal Test): Object references should be decremented at the nearest block instead o...
Dănuț Filimon wrote:
> Constantin, please review.
I'm OK with the changes.
I think we need rebase and after that...
Constantin Asofiei
06:09 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
Do you have some other p2j.jar somewhere? This should not happen. Constantin Asofiei
04:57 AM Base Language Bug #10004: NativeInvoker fails if an argument is of type integerConstant
Artur Școlnic wrote:
> I have some issues running library_calls tests,
We need to run those. What problems do you ...
Constantin Asofiei
04:06 AM Base Language Feature #9447: XML support feature improvements and testing
Review of 9447a rev 15963:
* @SaxReaderImpl.java@
** remove '017' and replace it with spaces, each branch must have...
Constantin Asofiei
03:20 AM Runtime Infrastructure Bug #10071: Method code too large - ReflectASM
Does @Utils.invoke@ need to make @method.setAccessible(true)@? The test is declaring a @PROCEDURE proc0 PRIVATE@. and... Constantin Asofiei

06/02/2025

10:53 AM Conversion Tools Feature #6256: improved profile support
@includeRemap@ is from:... Constantin Asofiei
09:46 AM Conversion Tools Feature #6256: improved profile support
Constantin Asofiei wrote:
> > * paths: ?
This is the PROPATH for the profile.
Constantin Asofiei
09:45 AM Conversion Tools Feature #6256: improved profile support
Dănuț Filimon wrote:
> I updated https://proj.goldencode.com/projects/p2j/wiki/Chapter_6_Project_Setup#Profiles, but...
Constantin Asofiei
09:37 AM Conversion Tools Feature #6256: improved profile support
Dănuț Filimon wrote:
> Dănuț Filimon wrote:
> > I also want to add the following scenario:
> > * When there is a *...
Constantin Asofiei
08:06 AM Base Language Bug #10004 (Internal Test): NativeInvoker fails if an argument is of type integerConstant
Please update %done. Constantin Asofiei
07:40 AM Database Feature #9440 (Internal Test): get-codepage() function should work with CLOB fields
I'm OK with the changes. Constantin Asofiei
07:02 AM Base Language Feature #9437: enhancements for Progress.Lang.Class
Review of 9437a rev 15965:
* @base_structure@ - replace @WidgetPoolAnnotation@ with @LegacyWidgetPool@
* @variable_...
Constantin Asofiei
06:47 AM Base Language Feature #9447: XML support feature improvements and testing
Teodor, please rebase the branch - you need to do it on devsrv01. Constantin Asofiei
05:54 AM Base Language Feature #9436 (WIP): add built-in OO classes
Branch 9436b was merged to trunk rev 15955 and archived. Constantin Asofiei
04:22 AM Base Language Feature #9436 (Merge Pending): add built-in OO classes
I'll merge 9436b after 10007a . Constantin Asofiei

05/30/2025

01:33 PM Database Feature #9456: implement SQL Server dialect and helpers
MSSQL has this syntax - see https://stackoverflow.com/questions/767657/how-do-i-create-a-unique-constraint-that-also-... Constantin Asofiei
08:28 AM Runtime Infrastructure Bug #10071: Method code too large - ReflectASM
If the stack trace matches the one in #10068, then first step is to bypass this (so @Method.invoke@ is used if Reflec... Constantin Asofiei
07:26 AM Runtime Infrastructure Bug #10071: Method code too large - ReflectASM
Teodor Gorghe wrote:
> Created branch *10071a*. I am currently searching for a simple test case.
Create a .p with 1...
Constantin Asofiei

05/29/2025

10:15 AM Conversion Tools Feature #6256: improved profile support
Greg Shah wrote:
> > When a profile is used using the -p option and we also use ListType.FILESET (-z), it should beh...
Constantin Asofiei
09:27 AM Base Language Feature #9448: compatibility test security features
Please post what the Java code is on line 173. Constantin Asofiei
03:01 AM Base Language Feature #6161 (Merge Pending): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-P...
Please merge to trunk now. Constantin Asofiei

05/28/2025

10:00 AM Base Language Feature #9516: include pre-converted webspeed runtime code in FWD
Radu:
* @WEB-CONTEXT:GET-CONFIG-VALUE(srvrAppMode)@ - this is the agent's appserver mode (like @Stateless)
* @WEB-C...
Constantin Asofiei
08:50 AM Database Bug #10049 (Merge Pending): UDF configuration regression in Persistence.java
Please merge 10049a now. Constantin Asofiei
07:17 AM Base Language Feature #9447: XML support feature improvements and testing
Teodor Gorghe wrote:
> The @-entityExpansionLimit@ should be at client part?
Yes, if you want to set it at the boot...
Constantin Asofiei
07:14 AM Runtime Infrastructure Bug #9740: Client running in batch mode stops with a crash on Windows
Hi, I think this was not a clean build (@Compiling 452 source files@ suggests this). Please do a clean (or manually ... Constantin Asofiei
05:08 AM Base Language Feature #9437: enhancements for Progress.Lang.Class
I think @if (ref instanceof LegacyEnum)@ needs to be extended to @if (ref instanceof LegacyEnum || !ref.isTracked()@). Constantin Asofiei
04:59 AM Conversion Tools Feature #6256: improved profile support
No, @X@ directive works only with @./abl/@ paths - there can't be relative paths.
> During pre-scan phase, the fil...
Constantin Asofiei
04:14 AM Base Language Support #9445: compatibility test FIX-CODEPAGE
Paul, what is the status on this? Constantin Asofiei
03:15 AM Base Language Feature #9436: add built-in OO classes
Paul Bodale wrote:
> I've ordered the history entries based on the date is this what are you referring to?
Yes, the...
Constantin Asofiei
03:05 AM Base Language Feature #9436: add built-in OO classes
Thanks, Paul. Some history entries were 'mixed up' during rebase - please do a @bzr diff -r 15941 --using meld@ and ... Constantin Asofiei
03:00 AM Database Bug #9763 (Merge Pending): xml-node-name buffer option
Eduard, you can merge 9763b now. Constantin Asofiei
 

Also available in: Atom