Golden Code Redmine

07/24/2025

07:52 AM Database Feature #10094 (Test): RECIDs from different tenants of same logical database should not overlap

Branch 10094a was merged into trunk as r16066 and was archived. Ovidiu Maxiniuc

07/23/2025

06:55 PM Database Feature #10094: RECIDs from different tenants of same logical database should not overlap

Both aforementioned regression tests passed. Ovidiu Maxiniuc

05:31 PM Database Feature #10094: RECIDs from different tenants of same logical database should not overlap

The only untested part is the very last commit (related to @setval@ for sequences). It passed my local tests, but I h... Ovidiu Maxiniuc

01:34 PM Database Feature #10094: RECIDs from different tenants of same logical database should not overlap

Carson, you are right. this is the exact issue the last commit will fix. It is a regression introduced in the last we... Ovidiu Maxiniuc

12:12 PM Database Feature #10094 (Review): RECIDs from different tenants of same logical database should not overlap

10094a was rebased. Additionally, it contains the fix for set sequence value for PGSQL dialect, as discussed in stand... Ovidiu Maxiniuc

04:53 AM Database Feature #9456: implement SQL Server dialect and helpers

I have fixed syntax for set sequence value in PostgreSQL dialect in 9457c/16098. I think we need to get this patch in... Ovidiu Maxiniuc

07/22/2025

01:36 PM Database Feature #10094: RECIDs from different tenants of same logical database should not overlap

Eric,
Yesterday I've updated the branch 10094a according to suggestions in the review from #note-26. It was also r... Ovidiu Maxiniuc

11:28 AM Database Feature #10310: move tenant database from one multitenant cluster to another

Just to be sure I understand the goal of this new FWD tool: the idea is to balance the load of FWD servers by migrati... Ovidiu Maxiniuc

10:43 AM Database Bug #6923: inner transaction block reverts too much

I have reviewed the changes in 6923a/r16049. I think the code will work. Thank you for adding comments with the chang... Ovidiu Maxiniuc

07/21/2025

06:55 AM Database Feature #9456 (WIP): implement SQL Server dialect and helpers

Ovidiu Maxiniuc

06:48 AM Database Feature #9456: implement SQL Server dialect and helpers

I have created 9456b from trunk 16062 for subsequent changes. Ovidiu Maxiniuc

06:46 AM Database Feature #9456: implement SQL Server dialect and helpers

Branch 9456a was merged into trunk as 16062 then it was archived. Ovidiu Maxiniuc

05:47 AM Database Feature #9456: implement SQL Server dialect and helpers

I peeked at r16089. There are some updates which do not seem logical (although they will work with the default CI col... Ovidiu Maxiniuc

07/18/2025

10:24 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

Octavian Adrian Gavril wrote:
> In the current conversion version, I understand that each file generates a DMO for e... Ovidiu Maxiniuc

08:16 PM Database Feature #9456: implement SQL Server dialect and helpers

I added missing javadoc and reverted blank changes.
The support for boolean data type should be working correctly no... Ovidiu Maxiniuc

07/17/2025

05:03 PM Database Feature #10094: RECIDs from different tenants of same logical database should not overlap

I used branch 10094a to test the import process on a large ST database and performed a smoke-test on it. No problems ... Ovidiu Maxiniuc

10:21 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

Octavian Adrian Gavril wrote:
> It's definitely something wrong how @TemplateWorker.graftAt@ works during DMOs gener... Ovidiu Maxiniuc

10:12 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

Octavian Adrian Gavril wrote:
> When temp-table DMOs are generated, I'm observing an issue where some @.jast@ files ... Ovidiu Maxiniuc

07/16/2025

06:19 AM Database Feature #9456: implement SQL Server dialect and helpers

No. @bzr@ added it without my knowledge. I never use @add@ during rebase. I think it was confused because the file wa... Ovidiu Maxiniuc

05:50 AM Database Feature #9456: implement SQL Server dialect and helpers

Branch 9456a was rebase to trunk r16048. Current revision is 16078. Ovidiu Maxiniuc

07/15/2025

06:02 PM Database Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...

I think so.
*Constantin* can you queue this branch for merging? Ovidiu Maxiniuc

06:18 AM Database Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...

OK. If there's just a single warning and the tests showed no regressions then I do not see a reason to delay the merg... Ovidiu Maxiniuc

04:37 PM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...

I had a quick peek at 1752a / r15902. I understand that it is still WIP.
IMHO, we should not parallelise the @Impo... Ovidiu Maxiniuc

02:52 PM Database Feature #7504: Export data tool from FWD into .d files

I took a look at 7504c / 16047.
I think the code is handle the expanded extents correctly. However, I ask you agre... Ovidiu Maxiniuc

01:48 PM Database Feature #9456: implement SQL Server dialect and helpers

Thank you for noticing this issue.
The @SQLServerHelper@ class has more issues than this. It creates a list of DDL... Ovidiu Maxiniuc

12:27 PM Database Bug #10171: Word Index/CONTAINS support for MS SQL Server.

At a first quick look, the code seems OK. I will do a more thoroughly review soon. Ovidiu Maxiniuc

11:34 AM Database Feature #7020 (Internal Test): always use "expanded" extent fields

I have reviewed 7020f/r16040. I think the code is good.
In particular, I see a lot of changes in @rename_word_tables... Ovidiu Maxiniuc

07/14/2025

03:35 PM Database Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...

I understand that your test have a good coverage of the affected code.
Related to node type change. If the node is... Ovidiu Maxiniuc

02:25 PM Database Feature #9455: port native user defined functions to SQL Server

I think the cause for this exception is the absence from @build.properties@ of the definition for @db.import_threads@... Ovidiu Maxiniuc

02:16 PM Database Feature #7504: Export data tool from FWD into .d files

Yes, branch 7504b can be queued for merging into trunk. Ovidiu Maxiniuc

07/11/2025

09:31 AM Database Feature #10094: RECIDs from different tenants of same logical database should not overlap

Constantin Asofiei wrote:
> Why the @if (restInBucket++ == 0)@? Just to get the first result?
Sorry for the C/C++ ... Ovidiu Maxiniuc

06:14 AM Database Feature #9456: implement SQL Server dialect and helpers

Constantin Asofiei wrote:
> Ovidiu, first results on conversion: @nulls last@ is added on indexes for H2 dialect (th... Ovidiu Maxiniuc

07/10/2025

06:09 PM Database Feature #10094: RECIDs from different tenants of same logical database should not overlap

Constantin Asofiei wrote:
> Ovidiu, are there any changes required in existing scripts (non-tenant and multi-tenant)... Ovidiu Maxiniuc

03:51 PM Database Feature #9456: implement SQL Server dialect and helpers

This is not intentional. I wonder why I did not notice it. It is a regression. Thank you for reporting it. I'm fixing... Ovidiu Maxiniuc

11:58 AM Database Feature #9456 (Review): implement SQL Server dialect and helpers

Ovidiu Maxiniuc

11:58 AM Database Feature #9456: implement SQL Server dialect and helpers

Branch 9456a was rebased to trunk/16032. Pushed up to revision 16060.
It is ready for review.
Note: I have some... Ovidiu Maxiniuc

07/08/2025

07:43 PM Database Feature #10270: implement some temp-tables using the persistent database instance when they are j...

I think this might be useful, but the heuristic could be difficult to implement because of dynamic queries. What I me... Ovidiu Maxiniuc

07:31 PM Database Bug #10111 (Internal Test): All statements are logged to a single text file for P2JQueryLogger an...

I think the changes in 15984 are OK. Can we move to 100% done? Ovidiu Maxiniuc

06:44 PM Database Feature #9456: implement SQL Server dialect and helpers

As discussed during technical meet from Monday I tried executing the import from within the guest OS. That required m... Ovidiu Maxiniuc

01:05 PM Database Feature #9456: implement SQL Server dialect and helpers

9456a seems stable now after the fixes for word tables.
The customer's 'small' database imports without any issue.... Ovidiu Maxiniuc

06:34 PM Database Support #10222: Is cross-session dirty share available through Fast Find Cache even if disabled?

Alexandru Lungu wrote:
> Of course, I am looking further for *Ovidiu*'s input on this matter.
I had a look over 102... Ovidiu Maxiniuc

04:39 PM Database Bug #10171: Word Index/CONTAINS support for MS SQL Server.

I have just noticed a warning when the word indexes are created:... Ovidiu Maxiniuc

08:24 AM Database Bug #10171 (WIP): Word Index/CONTAINS support for MS SQL Server.

Stefanel Pezamosca wrote:
> Hmm, another case of "IntelliJ knows better".
It tries to help based on your configurat... Ovidiu Maxiniuc

09:35 AM Database Feature #9455: port native user defined functions to SQL Server

Branch 9456a was rebased after 7020a was merged in. The denormalisation of extent fields was replaced with expanded c... Ovidiu Maxiniuc

07/07/2025

04:07 PM Database Bug #10171: Word Index/CONTAINS support for MS SQL Server.

I did not do a thorough review, only a few observations:
* please stick to JDK8 for the moment. @List<E> of(E... ele... Ovidiu Maxiniuc

02:50 PM Database Feature #9455: port native user defined functions to SQL Server

See my note #9991-52. The import of the smaller database was (pretty much) successful.
There are some issues with t... Ovidiu Maxiniuc

10:12 AM Database Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...

+Review of 10111a/r15983+
First, why in revno: 15983 the files: @src/com/goldencode/p2j/persist/BaseLoggingConfigu... Ovidiu Maxiniuc

07/04/2025

11:45 AM Database Bug #9078: emit FindQuery as (reused) variables

The 9078b/16012 seems OK. Ovidiu Maxiniuc

07:45 AM Database Feature #7020: always use "expanded" extent fields

Rename the file so that we know the dialect. We will eventually group them by dialects if the number of files in the ... Ovidiu Maxiniuc

07:16 AM Database Feature #7020: always use "expanded" extent fields

I have reviewed revisions 16043..16046 (LE) of 7020d. I see nothing wrong with the code.
The new file @migrate_wor... Ovidiu Maxiniuc

07/01/2025

07:42 PM Database Feature #9455: port native user defined functions to SQL Server

Yes, I think so. That's a good idea. Although, at a quick look they are not very extensive, but it's better than noth... Ovidiu Maxiniuc

03:41 PM Database Bug #10171: Word Index/CONTAINS support for MS SQL Server.

Yes, please. Use 9456a. Ovidiu Maxiniuc

06/30/2025

10:12 AM Database Bug #10171: Word Index/CONTAINS support for MS SQL Server.

Yes, there are a few changes in the UDFs for word tables. To check their existence the right type is @IF@ not @FN@ an... Ovidiu Maxiniuc

09:59 AM Database Feature #9455: port native user defined functions to SQL Server

Eduard,
Do you have any pending changes to 9456a as part of this task?
The reason to ask is that I have some o... Ovidiu Maxiniuc

09:54 AM Database Bug #9078: emit FindQuery as (reused) variables

I looked at the fix in 16011. The changes are correct. Ovidiu Maxiniuc

06/27/2025

12:43 PM Database Bug #10181 (Test): Date shifted one day earlier when importing data

Branch 10181a was merged into trunk on behalf of Lorian (ls) as rev. 16010 and archived. Ovidiu Maxiniuc

08:42 AM Database Feature #9456: implement SQL Server dialect and helpers

As reported previously, I encountered some issues while fixing the FWD support for logical/boolean expressions in MSS... Ovidiu Maxiniuc

07:29 AM Database Bug #9078: emit FindQuery as (reused) variables

I think @downPath(this, prog.kw_find, prog.record_phrase)@ will cover all @FIND@ statements. For example, a @FIND FIR... Ovidiu Maxiniuc

06/26/2025

07:10 PM Database Feature #9455: port native user defined functions to SQL Server

Sorry, I did these changes unintentionally. I do not have an explanation for them 😕. Ovidiu Maxiniuc

07:02 PM Database Feature #9455: port native user defined functions to SQL Server

Eduard,
I looked a bit over the UDFs you wrote. There is a bit of work still to be done. Please see my 5 notes blo... Ovidiu Maxiniuc

08:11 AM Database Feature #9455: port native user defined functions to SQL Server

Eduard Soltan wrote:
> Committed on 9456a, rev. *16006*.
Thank you, I am grabbing the changes right now.
> Add m... Ovidiu Maxiniuc

04:35 PM Database Bug #9078: emit FindQuery as (reused) variables

I looked at 9078b / r16008.
The code looks pretty much solid. But it's difficult to spot all possible issues only ... Ovidiu Maxiniuc