Golden Code Redmine

04/22/2026

04:40 AM Runtime Infrastructure Feature #10451: GUI interaction event logging

Paula Păstrăguș wrote:
> From my POV, this feature is meant strictly for a testing environment, not for production u... Hynek Cihlar

04:35 AM Runtime Infrastructure Feature #10451: GUI interaction event logging

Logging the keyboard events (and the types keys) is a potential security issue (consider passwords entered by the end... Hynek Cihlar

04:28 AM User Interface Bug #11044 (WIP): FILL-IN with Unknown Value: Incorrect Key Input Handling

*Code review 11044b revisions 16454..16461*
The condition @getText().equals("?")@ to check unknown value is not righ... Hynek Cihlar

04/21/2026

03:50 AM User Interface Bug #10938 (WIP): Date FILL-IN: Incorrect SCREEN-VALUE after widget enablement

*Code review 10938a revisions 16514..16516*
* *[MAJOR]* _functional_ @ThinClient@.@enableDisable@: On the @preview &... Hynek Cihlar

03:10 AM User Interface Bug #11294 (WIP): Widget is overlapped by another widget after the parent frame is made visible

*Code review 11294a revisions 16468..16471*
* *[MAJOR]* _functional_ @GenericFrame@.@makeFrameVisible@: The @hiddenI... Hynek Cihlar

04/17/2026

07:46 AM User Interface Bug #11314 (Internal Test): UP/DOWN key pressed after CTRL_LEFT /CTRL_RIGHT in a COMBO-BOX doesn'...

Please regression test the changes, also include ChUI regression tests. Hynek Cihlar

06:09 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Constantin Asofiei wrote:
> Stefanel Pezamosca wrote:
> > > Otherwise, does this affect SSO (OIDC integration)? Ste... Hynek Cihlar

04/14/2026

04:28 AM User Interface Bug #10915 (WIP): ugly dialogs

*Code review 10915a revisions 16534..16536*
* *[CRITICAL]* _functional_ @show@: Returns @this.operationGuard@ instea... Hynek Cihlar

04/13/2026

02:34 AM User Interface Bug #10915 (WIP): ugly dialogs

*Code review 10915a revisions 16509..16534*
* *[MAJOR]* _functional_ @p2j.js@.@createOpenPopupDialog@: The guard cha... Hynek Cihlar

01:19 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> Modern Dojo (v2+) https://dojo.io/ is a complete reboot of the framework, not compatible ... Hynek Cihlar

04/11/2026

01:36 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> I don't know if it makes sense to consider Modern Dojo (v2+) for FWD web client.
What ... Hynek Cihlar

04/10/2026

01:06 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> Do not worry. It is a human error not an agentic one. :)
Human errors are precious the... Hynek Cihlar

11:57 AM Documentation Support #9709 (WIP): Needed: Basic example of configuring separate client and server

*Code review 9709d revisions 16505..16527*
* *[CRITICAL]* _security_ @WebTokensService@.@validateWebTokenValue@ (lin... Hynek Cihlar

07:32 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> This line looks like 106 characters length @add("documentType", () -> decodeUrlEncodedPar... Hynek Cihlar

05:50 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> > Instead of exposing the full @WebTokenService@ rather create a new method on the ui dri... Hynek Cihlar

05:13 AM Documentation Support #9709 (WIP): Needed: Basic example of configuring separate client and server

*Code review 9709d revisions 16505..16526*
* *[CRITICAL]* _functional_ @WebTokensService@.@validateWebTokenValue@: T... Hynek Cihlar

06:10 AM User Interface Bug #11044 (WIP): FILL-IN with Unknown Value: Incorrect Key Input Handling

*Code review 11044b revisions 16454..16458*
* *[CRITICAL]* _functional_ @FillIn@.@processKeyEvent@: In the @KA_CLEAR... Hynek Cihlar

05:38 AM User Interface Bug #7657: 8-bit character entry problem in ChUI

*Code review 7657a revisions 15878..15906*
Before I go into any comments for the code changes I'd like to raise a co... Hynek Cihlar

03:36 AM Runtime Infrastructure Bug #11271: server-side streams and files with frames/redirected terminal

Greg Shah wrote:
> Is the testcase from #11271-7 a common pattern? Should we just complete the implementation of a ... Hynek Cihlar

03:32 AM Runtime Infrastructure Feature #11371: full server-side support of FWD clients

The initial work on running client-side UI in server context was implemented in 9055a. It added very limited set of u... Hynek Cihlar

02:50 AM Runtime Infrastructure Feature #10451 (WIP): GUI interaction event logging

*Code review 10451a revisions 16134..16138*
* *[MAJOR]* _functional_ @ButtonListGuiImpl.Item@.@toString@: @textWidge... Hynek Cihlar

02:36 AM User Interface Bug #10938 (WIP): Date FILL-IN: Incorrect SCREEN-VALUE after widget enablement

*Code review 10938a revisions 16469..16470*
* *[CRITICAL]* _functional_ @AbstractWidget@.@widgetRealized@: @ComboBox... Hynek Cihlar

04/09/2026

12:27 PM User Interface Bug #10706 (WIP): Date FILL-IN: Unintended VALUE-CHANGED Event Triggered by BACKSPACE

*Code review 10706a revisions 16368..16371*
* *[MAJOR]* _style_ @FillIn@.header: History entry 236 line exceeds the ... Hynek Cihlar

12:05 PM User Interface Bug #11211 (WIP): Improve source detection when dispatching mouse wheel events

*Code review 11211a revisions 16437..16438*
* *[CRITICAL]* _functional_ @EntryFieldGuiImpl@.@mouseActions@: The over... Hynek Cihlar

04/08/2026

03:11 PM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> This is not what this review state. @unregistry@ and @destroyRecursive@ is not the same a... Hynek Cihlar

05:35 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > Hynek Cihlar wrote:
> > > > * *... Hynek Cihlar

05:27 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> I think that this methodology to apply AI helpers to review should be together with tests... Hynek Cihlar

05:12 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > * *[MAJOR]* _functional_ @p2j.js@.@close@: After @destroyRecursi... Hynek Cihlar

05:08 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> Hynek, all sequence of generated reasoning can be look like truth. You should give a proo... Hynek Cihlar

04:55 AM User Interface Bug #10915: ugly dialogs

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey, the review is generated by AI and currated by myself. I ... Hynek Cihlar

04:48 AM User Interface Bug #10915: ugly dialogs

Sergey, the review is generated by AI and currated by myself. I always check the AI outputs. I looked in the code and... Hynek Cihlar

03:51 AM User Interface Bug #10915 (WIP): ugly dialogs

* *[MAJOR]* _functional_ @p2j.js@.@close@: After @destroyRecursive(false)@ is called on @that.dojoDialog@, the next s... Hynek Cihlar

03:43 AM User Interface Bug #11294 (WIP): Widget is overlapped by another widget after the parent frame is made visible

* *[MAJOR]* _functional_ @GenericFrame@.@setChildrenVisible@: @findHiddenWidgets@ is called unconditionally regardles... Hynek Cihlar

04/07/2026

08:52 AM User Interface Bug #11343 (WIP): Alert-box suddenly disppears when a specific item is selected from a drop-down ...

Code review 11343a.
* *[MAJOR]* _design_ @ComboBox@/@ThinClient@ alert-box handling: The patch treats the symptom,... Hynek Cihlar

04/03/2026

02:51 PM Conversion Tools Feature #6319: IntelliJ plugin

Greg, I share your concerns. IntelliJ is indeed a superior Java IDE - the debugger alone is light years ahead of VSCo... Hynek Cihlar

12:35 PM User Interface Feature #11349: ensure that the web client works on iOS devices (both iPad and iPhone)

We already did some preliminary work on mobile browsers support, see #9172. Below are the items needed to be addresse... Hynek Cihlar

04/02/2026

05:08 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Code review 9709d.
*[MAJOR]* _performance_ @WebTokensService@.@validateWebTokenValue@: A new @Jwts.parser()@ build... Hynek Cihlar

04/01/2026

01:30 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> The web service worker idea needs to setup via the browser extension if I correctly inter... Hynek Cihlar

12:13 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server

**@OPENPOPUP@ not in scope in p2j.socket.js - runtime ReferenceError.** The @createOpenPopupDialog@ function was move... Hynek Cihlar

06:15 AM Runtime Infrastructure Bug #11271: server-side streams and files with frames/redirected terminal

Constantin Asofiei wrote:
> Hynek, you were correct to fix the 'nextId' on 'store'.
Actually this one was spotted... Hynek Cihlar

03/31/2026

07:03 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> Hynek, thank you! You helped me to get out of panic mindset and to switch into logically-... Hynek Cihlar

05:24 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> Yes, the web client is spawned successfully and even @AuthHandler@ works accordingly but ... Hynek Cihlar

04:32 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> @io.jsonwebtoken:jjwt-impl:0.13.0@ uses @com.fasterxml.jackson.core:jackson-databind:2.12... Hynek Cihlar

03/30/2026

03:50 PM User Interface Bug #11314: UP/DOWN key pressed after CTRL_LEFT /CTRL_RIGHT in a COMBO-BOX doesn't select the cor...

Code review 11314a. The changes look good.
Just another point, @CTRL+SHIFT+LEFT@/@RIGHT@ are not excluded from th... Hynek Cihlar

03:45 PM User Interface Bug #11294 (WIP): Widget is overlapped by another widget after the parent frame is made visible

With the changes @makeFrameVisible@ duplicates the logic already in @setChildrenVisible@. Can these be deduplicated?
... Hynek Cihlar

03:35 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> I commented out changes and still got 500 code for web client js. It looks like the build... Hynek Cihlar

12:41 PM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> I got this exception
> as a root cause that looks independent from my changes.
Reve... Hynek Cihlar

08:21 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey, I can't run Hotel GUI with 9709d. An unknown client spawning issue. I reinstalled spawner but that didn't hel... Hynek Cihlar

08:23 AM User Interface Bug #10875 (Internal Test): COMBO-BOX: Ctrl-UP and Ctrl-DOWN keys do nothing

Code review 10875a. The changes look good. Please regression test the changes, also include ChUI regression tests. Hynek Cihlar

03/25/2026

08:10 AM Runtime Infrastructure Bug #11271: server-side streams and files with frames/redirected terminal

Code review 11271b.
@FileStream.restoreStateAndOpen@ always reopens with @append=true@. What if the original strea... Hynek Cihlar

05:29 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> Hynek Cihlar wrote:
> > Sergey Ivanovskiy wrote:
> > > @9709d@ cannot. Embedded reports... Hynek Cihlar

03:57 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> @9709d@ cannot. Embedded reports that should be opened in new tabs are not authorized bec... Hynek Cihlar

03/24/2026

05:39 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Committed revision 16488 (9709d) fixed incorrect prefix. I can t... Hynek Cihlar

05:33 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Sergey Ivanovskiy wrote:
> Committed revision 16488 (9709d) fixed incorrect prefix. I can test only the existed conf... Hynek Cihlar

03:28 AM Documentation Support #9709: Needed: Basic example of configuring separate client and server

Code review 9709d.
*Cookie name prefix (`AuthHandler.java:194` in diff)*: The cookie name is changed to @"--Host-A... Hynek Cihlar

05:22 AM User Interface Bug #11314 (WIP): UP/DOWN key pressed after CTRL_LEFT /CTRL_RIGHT in a COMBO-BOX doesn't select t...

Code review 11314a.
The history entry @028@ description reads: _"Don't clear the list selection if for CTRL + LEFT... Hynek Cihlar

05:14 AM User Interface Bug #11170 (WIP): The caret position is initially wrong for DECIMAL/INTEGER FILL-IN widgets

Code review 11170.
# *@ThinClient@ dependency creates layer violation, NPE risk, and inconsistency*: The @getIniti... Hynek Cihlar

04:46 AM User Interface Bug #10875 (WIP): COMBO-BOX: Ctrl-UP and Ctrl-DOWN keys do nothing

Code review 10875a.
*DefaultList history header format error.* The new history entry reads @* 016 DMM 20260320@ b... Hynek Cihlar