Project

General

Profile

Bug #10045

The embedded Hotel Gui application is broken

Added by Sergey Ivanovskiy about 1 year ago. Updated about 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
Due date:
% Done:

0%

billable:
No
vendor_id:
case_num:
version_reported:
version_resolved:
reviewer:
Hynek Cihlar
production:
No
env_name:
topics:

directory.xml Magnifier (91.6 KB) Paula Păstrăguș, 05/23/2025 05:38 AM

import.db.log Magnifier (25.4 KB) Sergey Ivanovskiy, 05/26/2025 06:01 AM

History

#1 Updated by Sergey Ivanovskiy about 1 year ago

Found for rev 15919 of trunk that the embedded application was broken:

#2 Updated by Greg Shah about 1 year ago

  • Project changed from FWD to User Interface

#3 Updated by Paula Păstrăguș about 1 year ago

Sergey, this was also mentioned in #4205-14. It relates to an edge aspect of the embedded mode, specifically tied to a standalone server, which is currently broken as you observed.

However, if you want to test the embedded mode, just use /embedded, instead of /gui.

#4 Updated by Sergey Ivanovskiy about 1 year ago

The embedded web application is not working now due to the corresponding code was broken. Do you mean that the embedded web application should be accessed by this path https://192.168.1.37:7443/embedded?

#5 Updated by Sergey Ivanovskiy about 1 year ago

The java doc for EmbeddedWebHandler said about the embedded content must be present but this content is not compiled now and some handlers defined in EmbeddedWebHandler does not have physical resources because they were removed from the repository.

         new DojoToolkitHandler(TARGET_EMBEDDED),
         new WebResourceHandler(TARGET_EMBEDDED, "/bootstrap", "META-INF/resources/webjars/bootstrap/3.4.1"),
         new WebResourceHandler(TARGET_EMBEDDED, "/d3", "META-INF/resources/webjars/d3/4.13.0/build"),
         new WebResourceHandler(TARGET_EMBEDDED, "/fonts", "fonts"),
         new WebResourceHandler(TARGET_EMBEDDED, "/jquery", "META-INF/resources/webjars/jquery/3.7.1"),
         new WebResourceHandler(TARGET_EMBEDDED, "/jquery-ui", "META-INF/resources/webjars/jquery-ui/1.13.2"),
         new WebResourceHandler(TARGET_EMBEDDED, "/material-components-web", "material-components-web"),
         new WebResourceHandler(TARGET_EMBEDDED, "/material-design-icons", "material-design-icons"),
         new WebResourceHandler(TARGET_EMBEDDED, "/tabulator", "tabulator-master-2.12.0")

I think that this part is broken now at least my local test shows that the embedded https://192.168.1.37:7443/embedded is not accessible.

#6 Updated by Paula Păstrăguș about 1 year ago

Sergey Ivanovskiy wrote:

The embedded web application is not working now due to the corresponding code was broken. Do you mean that the embedded web application should be accessed by this path https://192.168.1.37:7443/embedded?

Yes

#7 Updated by Sergey Ivanovskiy about 1 year ago

Paula, if you have running embedded web application, then please post steps to setup it and then this issue can be closed.

#8 Updated by Paula Păstrăguș about 1 year ago

Hm, I didn’t do anything special to make embedded work. First, make sure to update your hotel_gui project to the latest revision: 385, you might be working with an outdated version. After that, try accessing /embedded again.

#9 Updated by Sergey Ivanovskiy about 1 year ago

Paula Păstrăguș wrote:

Hm, I didn’t do anything special to make embedded work. First, make sure to update your hotel_gui project to the latest revision: 385, you might be working with an outdated version. After that, try accessing /embedded again.

Please post directory.xml here. I used the current version of hotel_gui.

#10 Updated by Paula Păstrăguș about 1 year ago

#11 Updated by Greg Shah about 1 year ago

I have just tested the following:

1. Build trunk rev 15932 using ./gradlew core sheet:war.

2. bzr co ~/secure/code/p2j_repo/samples/hotel_gui to get rev 385 locally

3. Inside hotel_gui/:

ln -s <path_to>/trunk p2j
./prepare_hotel.sh
ant deploy.all

At this point everything is OK. I don't see the compilation issue reported in #10045-1.

Sergey: Please try the steps above to see if you still have the same compilation issue.

4. Continuing:

./install_spawner.sh
cd deploy/server/
./server.sh

So far, everything is OK. The server starts.

4. Access https://localhost:7443/embedded or https://localhost:7443/gui

Here I get failures. Strange things:

  • Instead of the normal client logs in deploy/logs/, I see a deploy/client/fwd_client_base_crash_20250523_072450.log for each attempt to spawn. These are huge and are full of FINE and FINER nonsense from the jetty code. We need to disable all this logging. It must be killing our performance.
  • At the end of the log are a couple of stack traces. 
    25/05/23 07:24:49.960-0400 |   FINER | com.goldencode.p2j.net.Queue [Queue.disable()] | PID:18895, ThreadName:main | Queue is stopping.
java.lang.RuntimeException: Only a stack trace, not a real exception!
        at com.goldencode.p2j.net.Queue.disable(Queue.java:582)
        at com.goldencode.p2j.net.SessionManager.endSession(SessionManager.java:1402)
        at com.goldencode.p2j.net.BaseSession.terminate(BaseSession.java:243)
        at com.goldencode.p2j.main.ClientCore.processTemporaryClient(ClientCore.java:806)
        at com.goldencode.p2j.main.ClientCore.start(ClientCore.java:457)
        at com.goldencode.p2j.main.ClientDriver.start(ClientDriver.java:287)
        at com.goldencode.p2j.main.CommonDriver.process(CommonDriver.java:522)
        at com.goldencode.p2j.main.ClientDriver.process(ClientDriver.java:171)
        at com.goldencode.p2j.main.ClientDriver.main(ClientDriver.java:330)

And then later:

25/05/23 07:24:50.069-0400 |  SEVERE | com.goldencode.p2j.main.ClientCore | PID:18895, ThreadName:main | The client stopped working throwing an unexpected exception:
java.nio.channels.ClosedByInterruptException
        at java.nio.channels.spi.AbstractInterruptibleChannel.end(AbstractInterruptibleChannel.java:202)
        at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:658)
        at com.goldencode.p2j.net.SessionManager.connect(SessionManager.java:1259)
        at com.goldencode.p2j.net.SessionManager.createQueue(SessionManager.java:1175)
        at com.goldencode.p2j.net.LeafSessionManager.connectDirect(LeafSessionManager.java:256)
        at com.goldencode.p2j.net.SessionManager.connectDirect(SessionManager.java:709)
        at com.goldencode.p2j.main.ClientCore.initialize(ClientCore.java:304)
        at com.goldencode.p2j.main.ClientCore.start(ClientCore.java:469)
        at com.goldencode.p2j.main.ClientDriver.start(ClientDriver.java:287)
        at com.goldencode.p2j.main.CommonDriver.process(CommonDriver.java:522)
        at com.goldencode.p2j.main.ClientDriver.process(ClientDriver.java:171)
        at com.goldencode.p2j.main.ClientDriver.main(ClientDriver.java:330)
25/05/23 07:24:50.070-0400 |  SEVERE | com.goldencode.p2j.main.CommonDriver | PID:18895, ThreadName:main | System exits with code -13 caused by:
java.lang.NullPointerException
        at com.goldencode.p2j.main.ClientCore.start(ClientCore.java:472)
        at com.goldencode.p2j.main.ClientDriver.start(ClientDriver.java:287)
        at com.goldencode.p2j.main.CommonDriver.process(CommonDriver.java:522)
        at com.goldencode.p2j.main.ClientDriver.process(ClientDriver.java:171)
        at com.goldencode.p2j.main.ClientDriver.main(ClientDriver.java:330)

SO we are spawning but then hitting some problem early in the ClientCore.start() where it calls running = is.main.standardEntry(spawnedClientUuid);.

I am running on Java 8.

Alex: Is this the same issue you identified in #7143-1518?

#12 Updated by Sergey Ivanovskiy about 1 year ago

OK. I compared Paula directory with the local directory and did not find any setup issues except I used PostgreSQL database to run Hotel GUI.
Now there are issues while running the database import ant import.db.

#13 Updated by Sergey Ivanovskiy about 1 year ago

Greg, I followed your setup and was not able to login into the Hotel Gui web client application when using this oss plugin

          <node-attribute name="ssoplugin" value="com.goldencode.hotel.HotelGuiSsoAuthenticator"/>
          <node-attribute name="ssopluginoption" value="bogus"/>

but was able to log into the embedded web application. If these settings are removed, then the web client is accessed except the embedded Hotel Gui application.

#14 Updated by Sergey Ivanovskiy about 1 year ago

Although I was able to use the embedded Hotel GUI application but should not the old embedded Hotel Gui application be removed within this task because its code does not compile any more? Please look at embedded/readme.txt

#15 Updated by Sergey Ivanovskiy about 1 year ago

Sergey Ivanovskiy wrote:

Greg, I followed your setup and was not able to login into the Hotel Gui web client application when using this oss plugin
[...]
but was able to log into the embedded web application. If these settings are removed, then the web client is accessed except the embedded Hotel Gui application.

The web client is also accessed via the same plugin so there are no issues except #10045-14.

#16 Updated by Greg Shah about 1 year ago

Sergey Ivanovskiy wrote:

Although I was able to use the embedded Hotel GUI application but should not the old embedded Hotel Gui application be removed within this task because its code does not compile any more? Please look at embedded/readme.txt

I think this is expected. I would like to drop it, but Constantin has pointed out that future customers might have a scenario where the embedded server is separated from the FWD JVM. For now, perhaps we can just put something in to make it more clear that this is not to be used.

Also available in: Atom PDF