Project

General

Profile

Feature #10265

schema-only conversion

Added by Greg Shah about 1 year ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Dănuț Filimon
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
trunk/16227
reviewer:
Greg Shah
production:
No
env_name:
topics:

Related issues

Related to Database - Feature #9455: port native user defined functions to SQL Server Internal Test

History

#1 Updated by Greg Shah about 1 year ago

  • Related to Feature #9455: port native user defined functions to SQL Server added

#2 Updated by Greg Shah about 1 year ago

As of trunk rev 16028, one cannot convert schemata without including at least one program. In #9455-25, this technique is described.

This task is meant to eliminate the need for this "trick". One should be able to run schema conversion without any programs specified.

#3 Updated by Greg Shah 11 months ago

  • Assignee set to Dănuț Filimon

#4 Updated by Dănuț Filimon 11 months ago

  • Status changed from New to WIP

Created task branch 10265a from trunk/16138.

#5 Updated by Dănuț Filimon 11 months ago

Committed 10265a/16139. Schema conversion will be executed during normal/incremental conversion, even if all files are unchanged. (refs: #10265)

#6 Updated by Dănuț Filimon 11 months ago

  • Status changed from WIP to Review
  • % Done changed from 0 to 100
  • reviewer Greg Shah added

Greg, please review.

#7 Updated by Greg Shah 11 months ago

Code Review Task Branch 10265a Revision 16139

I don't think this change is the right approach.

  • The point of this task is that during a full or incremental conversion, the current driver will not run the middle() if there isn't at least one 4GL source file processed in front(). That is not OK. You should be able to specify no files in the conversion list and m0 and still get the converted schema.
  • In incremental mode we would not want to run the schema conversion unconditionally. If m0 is present but there are no changes, then don't do anything.
  • All the code from schema() duplicates the implementation that is already there. Code duplication is not wanted and should not be needed here. The existing code should be able to run without major refactoring or duplication.

#8 Updated by Greg Shah 11 months ago

  • % Done changed from 100 to 0
  • Status changed from Review to WIP

#9 Updated by Dănuț Filimon 11 months ago

  • Status changed from WIP to Review
  • % Done changed from 0 to 100

I committed 10265a/16140 for review.

#10 Updated by Dănuț Filimon 10 months ago

Rebased 10265a to latest trunk/16212, the branch is now at revision 16214.

#11 Updated by Greg Shah 9 months ago

Code Review Task Branch 10265a Revision 16214

This is good. The only change that may be needed is to output something when we have a quick return in back() (source.size() == 0). Perhaps we should have some output that states that there are "No source files to process.".

#12 Updated by Dănuț Filimon 9 months ago

  • Status changed from Review to Internal Test

Greg Shah wrote:

Code Review Task Branch 10265a Revision 16214

This is good. The only change that may be needed is to output something when we have a quick return in back() (source.size() == 0). Perhaps we should have some output that states that there are "No source files to process.".

Committed 10265a/16215, added a message when there are no source files to process.

#13 Updated by Greg Shah 9 months ago

Code Review Task Branch 10265a Revision 16215

It looks good.

#14 Updated by Dănuț Filimon 9 months ago

Tested conversion and incremental with ETF, ChUI and 3 other customer applications. No issues found.

#15 Updated by Dănuț Filimon 9 months ago

  • Status changed from Internal Test to Merge Pending

#16 Updated by Dănuț Filimon 9 months ago

  • Status changed from Merge Pending to Test
  • version_resolved set to trunk/16227

Branch 10265a was merged into trunk as rev. 16227 and archived.

#17 Updated by Greg Shah 3 months ago

  • Status changed from Test to Closed

Also available in: Atom PDF