Project

General

Profile

Feature #1599

Feature #1596: complete big decimal implementation

shift EXP implementation (MathOps.pow()) to BigDecimal

Added by Greg Shah over 11 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Hynek Cihlar
Target version:
FWD - Cleanup and Stablization for Server Features
Start date:
01/28/2014
Due date:
01/31/2014
% Done:

100%

Estimated time:
6.00 h
billable:
No
vendor_id:
GCD

hc_upd20140219a.zip (12.1 KB) Hynek Cihlar, 02/19/2014 02:52 PM

hc_upd20140220a.zip (12.4 KB) Hynek Cihlar, 02/20/2014 03:58 AM

hc_upd20140227a.zip (12.5 KB) Hynek Cihlar, 02/27/2014 03:06 PM

hc_upd20140305a.zip (78.1 KB) Hynek Cihlar, 03/07/2014 01:13 AM

History

#1 Updated by Greg Shah over 11 years ago

  • Target version set to Milestone 7

#2 Updated by Greg Shah almost 11 years ago

  • Target version changed from Milestone 7 to Milestone 11

#3 Updated by Greg Shah almost 11 years ago

  • Assignee set to Ovidiu Maxiniuc
  • Start date changed from 10/19/2012 to 08/08/2013
  • Due date set to 08/08/2013

#4 Updated by Greg Shah over 10 years ago

  • Due date changed from 08/08/2013 to 01/31/2014
  • Start date changed from 08/08/2013 to 01/28/2014
  • Assignee changed from Ovidiu Maxiniuc to Hynek Cihlar

#5 Updated by Hynek Cihlar about 10 years ago

The title of the issue mentions pow and exp. MathOps contains only pow method, but that is already using BigDecimal.pow. Please, clarify.

#6 Updated by Greg Shah about 10 years ago

There are 3 other versions of pow() and these all resolve down to using Math.pow() and double. These need to be fixed to use the same correct worker pow(NumberType, NumberType).

#7 Updated by Hynek Cihlar about 10 years ago

Please review the attached changes. Testcases checked in to testcases/uast/math/exp.p.

#8 Updated by Greg Shah about 10 years ago

Code Review 0219a

The code looks good. My only comments relate to some coding standards:

1. Lines 608 and 614 are missing line breaks between the } and the keyword.

2. The private methods should be grouped at the bottom of the class with other private methods.

Upload the resulting update and go ahead with runtime regression testing.

#9 Updated by Hynek Cihlar about 10 years ago

I also moved the log private methods down to the private methods section. The attached changes are submitted for regression testing.

#10 Updated by Greg Shah about 10 years ago

Code Review 0220a

Everything looks good. If it passes runtime regression testing, you can check it in and distribute it.

#11 Updated by Hynek Cihlar about 10 years ago

  • Status changed from New to WIP

#12 Updated by Hynek Cihlar about 10 years ago

0220a regression tested and checked in to bzr revision 10481.

#13 Updated by Hynek Cihlar about 10 years ago

  • % Done changed from 0 to 100

#14 Updated by Greg Shah about 10 years ago

  • Status changed from WIP to Closed

#15 Updated by Hynek Cihlar about 10 years ago

Fixed error handling issue in MathOps.pow(BigDecimal, BigDecimal). Regression test is in progress.

#16 Updated by Greg Shah about 10 years ago

Code Review 0227a

It looks fine. Assuming it passes testing, you can check it in and distribute it.

#17 Updated by Hynek Cihlar about 10 years ago

I also added a javadoc fix of the method pow(BigDecimal, BigDecimal). The changes were regression tested and checked in to bzr revision 10486.

#18 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 11 to Cleanup and Stablization for Server Features

Also available in: Atom PDF