Project

General

Profile

Feature #1725

replace unnecessary use of FieldReference in message and messageBox calls

Added by Eric Faulhaber over 13 years ago. Updated over 9 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
4.00 h
billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
production:
No
env_name:
topics:

Related issues

Related to Conversion Tools - Feature #1724: replace "new FieldReference(dmo, propertyName)" in business logic with less verbose alternative New

History

#1 Updated by Eric Faulhaber over 13 years ago

The point of the FieldReference class is to allow deferred access to a DMO property value. The conversion currently misuses this class in calls to LogicalTerminal's message() and messageBox() methods. For instance, given a DMO customer:

message(concat(new character("CUSTOMER ACCOUNT "), valueOf((integer) new FieldReference(customer, "accountNumber").getValue())));

should be simplified to:

message(concat(new character("CUSTOMER ACCOUNT "), valueOf(customer.getAccountNumber())));

since there is no need to defer access to the accountNumber property value in this case.

It may be that the message() or concat() call could be simplified further, but the scope of this task is the conversion of the DMO property access in this circumstance.

#2 Updated by Greg Shah over 13 years ago

  • Target version set to Code Improvements

#3 Updated by Greg Shah over 9 years ago

  • Target version deleted (Code Improvements)

Also available in: Atom PDF