FWD » Core Development » Conversion Tools

Avoid emitting unnecessary, top-level instance variables for function parameters, which are later hidden by block-level, local variables of the same name. Avoid initializing the top-level variables in the init() method of the inner subclass of Block which is emitted inside the method which represents the converted function, so long as those top-level instance variables are never needed. There is some scenario where these are needed (not sure what that is at the time of writing), but in other cases, they are declared and initialized, but never subsequently read.

The testcase uast/query-test-for-scrolling.p, for instance, has a function updateRecords(input valOld as int, input valNew as int). The valOld parameter generates both an instance variable in the top-level class QueryTestForScrolling, as well as an instance variable in the anonymous inner subclass of Block within the updateRecords() method. In the init() method of that inner class, QueryTestForScrolling.this.valOld is initialized to the value of the anonymous inner class' valOld variable, but then the top-level valOld is never accessed. Both the top-level class' valOld instance variable, and the initialization of it in the inner class' init() method (and in fact the entire init() method, since this is all that is done there) could be eliminated as a code cleanup optimization.