Project

General

Profile

Bug #2094

OUTER-JOIN record phrase option not honored

Added by Eric Faulhaber about 11 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Start date:
03/24/2013
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

ca_upd20130324f.zip (20 KB) Constantin Asofiei, 03/24/2013 03:47 PM

History

#1 Updated by Eric Faulhaber about 11 years ago

  • Assignee set to Ovidiu Maxiniuc

The following:

define query q1 for person, pers-addr.
open query q1
  for each person where person.emp-num > 0,
  first pers-addr where person.site-id = pers-addr.site-id outer-join no-lock.

converts to (relevant portion only):

query0.assign(new CompoundQuery(true, false));
query0.addComponent(new AdaptiveQuery(person, "person.empNum > 0", null, "person.siteId asc, person.empNum asc"));
RecordBuffer.prepare(persAddr);
query0.addComponent(new RandomAccessQuery(persAddr, "? = persAddr.siteId", null, "persAddr.siteId asc, persAddr.empNum asc", new Object[]
{
   new FieldReference(person, "siteId")
}, LockType.NONE), QueryConstants.FIRST);

There should be a third parameter -- true -- emitted to the second query0.addComponent call, after QueryConstants.FIRST, indicating that this query component should be joined via a LEFT OUTER JOIN.

#2 Updated by Constantin Asofiei about 11 years ago

  • Assignee changed from Ovidiu Maxiniuc to Constantin Asofiei

#3 Updated by Constantin Asofiei about 11 years ago

  • File ca_upd20130324e.zip added

This update adds support for the OUTER-JOIN clause for a record phrase. The LEFT OUTER-JOIN will not emit anything. It is going through conversion regression testing now.

LE: LEFT OUTER-JOIN is the same as OUTER-JOIN and will need to convert the same.

#4 Updated by Constantin Asofiei about 11 years ago

  • File deleted (ca_upd20130324e.zip)

#5 Updated by Constantin Asofiei about 11 years ago

Properly handles the OUTER-JOIN and LEFT OUTER-JOIN to convert the same.

#6 Updated by Constantin Asofiei about 11 years ago

  • % Done changed from 0 to 70
  • Status changed from New to WIP
  • Start date set to 03/24/2013

#7 Updated by Eric Faulhaber about 11 years ago

Change looks good to me. Please check in and distribute if/when it passes conversion regression testing.

#8 Updated by Constantin Asofiei about 11 years ago

  • Status changed from WIP to Review

Passed conversion regression testing, committed to bzr revision 10328. I'll do a separate server folder conversion with this change tomorrow.

#9 Updated by Eric Faulhaber about 11 years ago

BTW, location of the original problem is pmplan/gapptfn5.p.cache, line 700.

#10 Updated by Eric Faulhaber about 11 years ago

  • % Done changed from 70 to 100
  • Status changed from Review to Closed

#11 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 4 to Conversion Support for Server Features

Also available in: Atom PDF