FWD » Core Development » Database

During testing I have found one bug not related directly with issue.

RecordBuffer, line 4032:

if (!propsMap.containsKey(prop1))

should be

if (!propsMap.containsKey(new DatumAccess(prop1, null)))

As result buffer-compare gives wrong result both for method and statement variants.

Test case

def var cresult as char.
def var lresult as logical.

def temp-table tt1
  field f1 as int
  field f2 as int
  field f3 as int.
def temp-table tt2
  field f1 as int
  field f2 as int
  field f3 as int.

def buffer btt1 for tt1.
def buffer btt2 for tt2.

def var h1 as handle.
def var h2 as handle.

h1 = buffer tt1:handle.
h2 = buffer tt2:handle.

create btt1.
assign btt1.f1 = 1
       btt1.f2 = 2
       btt1.f3 = 3.

create btt2.
assign btt2.f1 = 1
       btt2.f2 = 42
       btt2.f3 = 16.

buffer-compare btt1 except f3 to btt2  save cresult.
message "Result 1:" string(cresult).

h1:FIND-FIRST().
h2:FIND-FIRST().

lresult = h1:BUFFER-COMPARE(h2, "casesensitive", "f3").
message "Result 2:" string(lresult).

Result:

Result 1: 
Result 2: yes

expected:

Result 1: f2
Result 2: no

Should I fix it in separate update or along with this issue?

Please include the fix with your update for this issue.

One more not related bug found with compare with BINARY both for statement (method works properly):

def var c-result as char.
def var l-result as logical.

def temp-table tt1
  field f1 as character
  field f2 as character
  field f3 as character
  field f4 as character.
def temp-table tt2
  field f1 as character
  field f2 as character
  field f3 as character.

def buffer btt1 for tt1.
def buffer btt2 for tt2.

def var h1 as handle.
def var h2 as handle.

h1 = buffer tt1:handle.
h2 = buffer tt2:handle.

create btt1.
assign btt1.f1 = "aa" 
       btt1.f2 = "bb" 
       btt1.f3 = "cc" 
       btt1.f4 = "dd".

create btt2.
assign btt2.f1 = "aA" 
       btt2.f2 = "bb" 
       btt2.f3 = "cc".

h1:FIND-FIRST().
h2:FIND-FIRST().

buffer-compare btt1 except f3 f4 to btt2 binary save c-result.
message "Result binary statement:" string(c-result).

Results:

Result binary statement:

Expected:

Result binary statement: f1

The reason is that conversion generates wrong method in BINARY case:

            RecordBuffer.compare(btt1, new String[]
            {
               "f3",
               "f4" 
            }, true, btt2, true, cResult);
            message(new Object[]
            {
               "Result case-sensitive statement:",
               valueOf(cResult)
            });
            RecordBuffer.compare(btt1, new String[]
            {
               "f3",
               "f4" 
            }, true, btt2, cResult);
            message(new Object[]
            {
               "Result binary statement:",
               valueOf(cResult)
            });

Should be the same as in CASE-SENSITIVE case.

Fixed with replacement in database_access.rules:

      <!-- handle case-sensitive option within buffer compare statement -->
      <rule>type == prog.kw_case_sen and parent.type == prog.kw_buf_comp
         <action>createJavaAst(java.bool_true, "", closestPeerId)</action>
      </rule>

replaced with

      <!-- handle case-sensitive and binary options within buffer compare statement -->
      <rule>(type == prog.kw_case_sen or
             type == prog.kw_binary) and
            parent.type == prog.kw_buf_comp
         <action>createJavaAst(java.bool_true, "", closestPeerId)</action>
      </rule>

Code review 20140409a:

The update looks good. Please regression test.

Regression 20140410_105536 completed. 3 tests failed:

1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in actual at page # 1.'
2. tc_dc_slot_029 FAILED failure in step 8: 'timeout before the specific screen buffer became available (Mismatched data at line 4, column 9. Expected '' (0x0000 at relative Y 4, relative X 9) and found '1' (0x0031 at relative Y 4, relative X 9).)'
3. tc_job_clock_002 FAILED failure in step 20: 'timeout before the specific screen buffer became available (Mismatched data at line 5, column 18. Expected '' (0x0000 at relative Y 5, relative X 18) and found '┌' (0x250C at relative Y 5, relative X 18).)'

Will start regression one more time.

Regression 20140411_102011 completed. 3 tests failed:

1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in actual at page # 1.'
2. gso_441 FAILED failure in step 67: 'timeout before the specific screen buffer became available (Mismatched data at line 0, column 1. Expected 'M' (0x004D at relative Y 0, relative X 1) and found '' (0x0000 at relative Y 0, relative X 1).)'
3. tc_job_clock_002 FAILED failure in step 20: 'timeout before the specific screen buffer became available (Mismatched data at line 5, column 18. Expected '' (0x0000 at relative Y 5, relative X 18) and found '┌' (0x250C at relative Y 5, relative X 18).)'

tc_job_clock_002 failed again, Will start regression one more time.

Regression 20140413_095429 completed. 6 tests failed, including

tc_job_002
tc_job_clock_002

Will start regression one more time.

Since tc_job_clock_002 has failed each time, have you checked the server.log to see if there is a real regression? Have you tried running the test manually?

tc_job_clock_002 test fails each time because of timeout error:

failure in step 20: 'timeout before the specific screen buffer became available (Mismatched data at line 5, column 18. Expected '' (0x0000 at relative Y 5, relative X 18) and found '┌' (0x250C at relative Y 5, relative X 18).)'

Is it possible to execute regression of this test separately?

Server.log contains

java.lang.RuntimeException: com.goldencode.p2j.cfg.ConfigurationException: Error loading p2j.cfg.xml configuration
...
Caused by: com.goldencode.p2j.cfg.ConfigurationException: Cannot find resource cfg/p2j.cfg.xml
        at com.goldencode.p2j.cfg.Configuration.getInstance(Configuration.java:492)
        at com.goldencode.p2j.cfg.Configuration.getSchemaConfig(Configuration.java:228)
        at com.goldencode.p2j.persist.ConversionPool.initialize(ConversionPool.java:80)
        at com.goldencode.p2j.main.StandardServer.bootstrap(StandardServer.java:723)
        at com.goldencode.p2j.main.ServerDriver.start(ServerDriver.java:428)
        at com.goldencode.p2j.main.CommonDriver.process(CommonDriver.java:423)
        at com.goldencode.p2j.main.ServerDriver.process(ServerDriver.java:155)
        at com.goldencode.p2j.main.ServerDriver.main(ServerDriver.java:772)

but all other tests excepting 6 are passed.

Also I noticed the following error on console, not sure if it happened previous times:

 Non-testing errors (CONNECT_FAILURE) occured during test execution: 
     [exec] com.jcraft.jsch.JSchException: channel is not opened. 
     [exec]         at com.jcraft.jsch.Channel.sendChannelOpen(Channel.java:670) 
     [exec]         at com.jcraft.jsch.Channel.connect(Channel.java:151) 
     [exec]         at com.goldencode.harness.transport.SSH2Transport.connect(SSH2Transport.java:79) 
     [exec]         at com.goldencode.harness.transport.TransportManager.connect(TransportManager.java:69) 
     [exec]         at com.goldencode.harness.Driver.<init>(Driver.java:83) 
     [exec]         at com.goldencode.harness.TestSet.run(TestSet.java:257) 
     [exec]         at java.lang.Thread.run(Thread.java:744) 
     [exec] 
     [exec] Running test plan... ** CTRL-C part has failed! 
     [exec] ** Running main part... 
     [exec] 
     [exec] Running test plan... ESC M : R is 8, tm is 8, bm is 19 
     [exec] ESC M : R is 8, tm is 8, bm is 19 
     [exec] ESC M : R is 0, tm is 0, bm is 3 
     ...

Regression 20140415_154604 completed. 3 tests failed:

1. tc_job_002 FAILED failure in step 40: 'Unexpected EOF in actual at page # 1.'
2. gso_17 FAILED failure in step 79: 'Mismatched data at absolute row 13, relative row -1, page # -1, page size -1, last page false, column index 3. Expected '3' (0x33) and found '1' (0x31).'
3. gso_430 FAILED failure in step 9: 'timeout before the specific screen buffer became available (Mismatched data at line 18, column 0. Expected '┌' (0x250C at relative Y 18, relative X 0) and found '' (0x0000 at relative Y 18, relative X 0).)'

So, regression seems passed.

Update vmn_upd20140409a.zip passed regression and distributed. Bzr revision is 10511.