Project

General

Profile

Bug #2741

Bug #2677: fix drawing and functional differences between P2J GUI and 4GL GUI

SELECTION-LIST sizing issues

Added by Greg Shah over 8 years ago. Updated over 7 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Start date:
Due date:
% Done:

0%

billable:
No
vendor_id:
GCD
case_num:

auto_resize_selection_list_p2j_20151014.jpg - Selection-list resize issue fix (40.8 KB) Eugenie Lyzenko, 10/14/2015 03:29 PM

editor_background_p2j_20151014.jpg - P2J editor sample (40.5 KB) Eugenie Lyzenko, 10/14/2015 06:08 PM

editor_background_p2j_20151015.jpg - P2J editor+rectangle sample (40.4 KB) Eugenie Lyzenko, 10/15/2015 08:54 AM


Related issues

Related to User Interface - Feature #2567: add misc widget support part 2: more options, attributes and methods Closed 04/30/2015

History

#1 Updated by Greg Shah over 8 years ago

See #2567-322 for the details.

#2 Updated by Igor Skornyakov over 8 years ago

After 2574b rebase:
1. COMBO-BOX redraw on the FORMAT change is incorrect in the GUI mode.
2. EDITOR ignores BGCOLOR attribute in the GUI mode
3. FILL-IN redraw on the FORMAT change is incorrect in the GUI mode.
4. SELECTION-LIST redraw on the FONT change is still incorrect (see #2741). Moreover intitial draw is now incorrect as well.
5. TEXT redraw on the FORMAT change is incorrect in the GUI mode.
6. TOGGLE-BOX doesn't resize on the FONT change.

#3 Updated by Greg Shah over 8 years ago

  • Assignee changed from Igor Skornyakov to Eugenie Lyzenko

#4 Updated by Eugenie Lyzenko over 8 years ago

The fix committed in 1811s. The screen is attached.

#5 Updated by Greg Shah over 8 years ago

I assume revision 10966 in 1811s fixes item 4 above. Does it fix any of the other items?

If not, please do fix those as well.

#6 Updated by Eugenie Lyzenko over 8 years ago

Greg Shah wrote:

I assume revision 10966 in 1811s fixes item 4 above.

Yes.

Does it fix any of the other items?

No, I did not consider the other items for now.

If not, please do fix those as well.

OK.

#7 Updated by Greg Shah over 8 years ago

Is it quick to fix items 1, 3, 5 and 6? If not, those can be deferred and Igor will work them after #2038.

Item 2 should be worked now for sure.

#8 Updated by Eugenie Lyzenko over 8 years ago

Is it quick to fix items 1, 3, 5 and 6?

It is difficult to exactly estimate. I think it can take a day to complete(24 hours).

So what is the priority plan?

#9 Updated by Greg Shah over 8 years ago

Only work on item 2. Then move to other assigned tasks.

#10 Updated by Eugenie Lyzenko over 8 years ago

Do you mean: 2. EDITOR ignores BGCOLOR attribute in the GUI mode? Take a look at the picture. Is it now OK?

#11 Updated by Greg Shah over 8 years ago

Do you mean: 2. EDITOR ignores BGCOLOR attribute in the GUI mode?

Yes.

Take a look at the picture. Is it now OK?

There is no editor in that picture, so I can't tell. I think you need a different testcase to see.

#12 Updated by Eugenie Lyzenko over 8 years ago

Greg Shah wrote:

Take a look at the picture. Is it now OK?

There is no editor in that picture, so I can't tell. I think you need a different testcase to see.

OK. The testcase was used to present the picture: auto_resize/are.p:

...
DEFINE VARIABLE f1 AS CHAR FORMAT "X(10)"  NO-UNDO INITIAL "ABCDEFG" 
VIEW-AS EDITOR
  INNER-CHARS 10 INNER-LINES 3
  TOOLTIP "EDITOR".

DEF FRAME fr1 
    f1  BGCOLOR 1 FGCOLOR 15
  WITH TITLE "fr1" AT COLUMN 1 ROW 1 SIZE 40 BY 10.
...

#13 Updated by Greg Shah over 8 years ago

And is BGCOLOR 1 the same blue color shown there? I guess you can test that by using color 1 on a rectangle.

#14 Updated by Eugenie Lyzenko over 8 years ago

The modified code:

...
DEFINE VARIABLE f1 AS CHAR FORMAT "X(10)"  NO-UNDO INITIAL "ABCDEFG" 
VIEW-AS EDITOR
  INNER-CHARS 10 INNER-LINES 3
  TOOLTIP "EDITOR".

define rectangle r size 4 by 2.

DEF FRAME fr1 
    f1  BGCOLOR 1 FGCOLOR 15 skip r FGCOLOR 1 BGCOLOR 1 
  WITH TITLE "fr1" AT COLUMN 1 ROW 1 SIZE 40 BY 10.

...

On the screen the colors are the same dark blue (0,0,128).

#15 Updated by Greg Shah over 8 years ago

OK, then item 2 is considered fixed.

Igor will handle the rest of the items later.

#16 Updated by Greg Shah over 8 years ago

  • Assignee changed from Eugenie Lyzenko to Igor Skornyakov

#17 Updated by Greg Shah about 8 years ago

  • Target version changed from Milestone 12 to Milestone 16

#18 Updated by Greg Shah about 8 years ago

  • Assignee deleted (Igor Skornyakov)

#19 Updated by Greg Shah almost 8 years ago

Item 4 in note 2 needs to be resolved in this task.

In addition, there is a report of the selection-list border drawing being incorrect in #3075-6. Resolve that problem too.

#20 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 16 to Cleanup and Stabilization for GUI

Also available in: Atom PDF