Project

General

Profile

Bug #2749

Bug #2677: fix drawing and functional differences between P2J GUI and 4GL GUI

widget keeps drawing with focus highlight when a different from gets selected

Added by Greg Shah over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eugenie Lyzenko
Target version:
FWD - GUI Support for a Complex ADM2 App
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

evl_upd20151130a.diff Magnifier - Fix for issue (1.28 KB) Eugenie Lyzenko, 11/30/2015 09:38 AM

combo_box_unfocused_issue_fix_20151130.jpg - The fixed demo screen (52.3 KB) Eugenie Lyzenko, 11/30/2015 09:38 AM

movie-ratings-dynamic.p_clipped_image_regression_fix_20151130.jpg - Fix for image clip (105 KB) Eugenie Lyzenko, 11/30/2015 04:10 PM

History

#1 Updated by Greg Shah over 8 years ago

Please see #2726-7 (and note 8)

At initial startup the focus in on the chcb widget in the 1st frame. Then when the user clicks on the 2nd frame, the focus shifts to the "this is a button" button. In P2J, the chcb widget is still drawn with a focus highlight.

#2 Updated by Greg Shah over 8 years ago

  • Assignee set to Eugenie Lyzenko

#3 Updated by Greg Shah over 8 years ago

  • Assignee changed from Eugenie Lyzenko to Hynek Cihlar
  • Status changed from New to WIP

#4 Updated by Greg Shah over 8 years ago

  • Assignee changed from Hynek Cihlar to Eugenie Lyzenko

Sorry, wrong task.

#5 Updated by Eugenie Lyzenko over 8 years ago

The investigation results. The frames inside test properly receive the gaining/loosing focus. This is the painting issue. When adding repaint() on loosing focus the issue is fixing. Looking for solution to have smart repaint for only widgets that need to be repainted.

#6 Updated by Eugenie Lyzenko over 8 years ago

The fix is based on the fact when combo-box is losing the focus the widget look is different. It is possible to fix the issue by two ways:
1. Handle the frame loosing focus event. Detect the currently focused widget and repaint it. If it is the combo - it will be properly repainted.
2. Because the combo-box already implements FocusListener interface we can implement single method onFocusLost() in combo-box GUI implementation to properly repaint the widget when required.

I prefer to use 2-nd approach. The respective diff file is attached. Please review and let me know if I can commit the change into 2677b.

#7 Updated by Eugenie Lyzenko over 8 years ago

The fix for issue and fix for clipped image in movie-ratings-dynamic.p has been committed in bzr as 10979 for review. This is the content of the evl_upd20151130a.zip.

#8 Updated by Greg Shah over 8 years ago

  • % Done changed from 0 to 100
  • Status changed from WIP to Closed

#9 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 12 to GUI Support for a Complex ADM2 App

Also available in: Atom PDF