Project

General

Profile

Bug #2768

Bug #2677: fix drawing and functional differences between P2J GUI and 4GL GUI

combo-box displays the item value instead of its label

Added by Sergey Ivanovskiy over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eugenie Lyzenko
Target version:
FWD - GUI Support for a Complex ADM2 App
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

demo_widget_regression.png (17.8 KB) Sergey Ivanovskiy, 10/20/2015 10:40 AM

History

#1 Updated by Sergey Ivanovskiy over 8 years ago

1) Run ./demo/movie-ratings-dynamic.p
2) Go through the login web page, press a space bar. The final screen has the "Select movie" combobox that displays "1" instead of its label "Titanic".
The logic is provided by these stetements
movie:LIST-ITEM-PAIRS = "Titanic,1,Pulp Fiction,2".
movie:SCREEN-VALUE = "1".

#2 Updated by Greg Shah over 8 years ago

  • Subject changed from Combobox displays the item value instead of its label. to combo-box displays the item value instead of its label
  • Assignee set to Eugenie Lyzenko
  • Target version set to Milestone 12
  • Start date deleted (10/20/2015)

#3 Updated by Eugenie Lyzenko over 8 years ago

Sergey, I need some clarification.

Do you have the working application(demo/movie-ratings-dynamic.p) at this time? Can you comment this mods in FillInGuiImpl?

...
   protected int nativeWidth()
   {
      if (config.fixedWidth)
      {
         return config.widthPixels;
      }
      else if (config.fontChanged)
      {
         int fmtLength = getCurrentFormat().getScreenWidth();
         config.fontChanged = false;
...

Is this from change:

...
** 021 SBI 20151014 ...
...

right?

What were you planning to do if getCurrentFormat() == null? On the early initialization stages this is the exactly the case that stops using this demo(NPE generation).

#4 Updated by Sergey Ivanovskiy over 8 years ago

Do you have the working application(demo/movie-ratings-dynamic.p) at this time? Can you comment this mods in FillInGuiImpl?

At the time of testing it should work for branch 1811s rev 10995, I am not sure may be I have tested another version. But for rev 11005
the example is failed.

Is this from change:

protected int nativeWidth()
   {
      if (config.fixedWidth)
      {
         return config.widthPixels;
      }
      else if (config.fontChanged)
      {
         int fmtLength = getCurrentFormat().getScreenWidth();
         config.fontChanged = false;

right?

These are not all my changes, I have added only this one "Added to notify the client the current selection is changed." It needs to look at the committed branch history to identify when it has been changed.

#5 Updated by Sergey Ivanovskiy over 8 years ago

I have checked this example works with the described issue for the branch 1811s rev 10995. The target changes are due to rev. 10999.

#6 Updated by Eugenie Lyzenko over 8 years ago

These are not all my changes, I have added only this one "Added to notify the client the current selection is changed."

Sorry, I was confused by the history log entry.

#7 Updated by Greg Shah over 8 years ago

Igor: did you make changes in 2032a that are related to the list-items issue above?

Constantin: is the nativeWidth() change yours?

#8 Updated by Constantin Asofiei over 8 years ago

Greg Shah wrote:

Constantin: is the nativeWidth() change yours?

Yes, the nativreWidth() change is mine, for fill-in's auto-resize via font attribute change fix.

#9 Updated by Igor Skornyakov over 8 years ago

Greg Shah wrote:

Igor: did you make changes in 2032a that are related to the list-items issue above?

Sorry, I've never worked with 2032. And I do not remember that I've made any list-items related changes in at least last 3 months.

#10 Updated by Greg Shah over 8 years ago

Sorry, I meant 2038a not 2032a. I must be mis-remembering a change there.

#11 Updated by Igor Skornyakov over 8 years ago

Greg Shah wrote:

Sorry, I meant 2038a not 2032a. I must be mis-remembering a change there.

I see. I have made no list-items related changes in 2038a.

#12 Updated by Constantin Asofiei over 8 years ago

Eugenie Lyzenko wrote:

Sergey, I need some clarification.

Do you have the working application(demo/movie-ratings-dynamic.p) at this time? Can you comment this mods in FillInGuiImpl?
[...]

Is this from change:
[...]
right?

What were you planning to do if getCurrentFormat() == null? On the early initialization stages this is the exactly the case that stops using this demo(NPE generation).

I've fixed this NPE in 1811s rev 110115 - fontChanged must not be set if widget's font is set via frame's definition.

#13 Updated by Eugenie Lyzenko over 8 years ago

Constantin Asofiei wrote:

I've fixed this NPE in 1811s rev 110115 - fontChanged must not be set if widget's font is set via frame's definition.

OK. Thanks. I have removed my patches from FillInGuiImpl related to this bug.

#14 Updated by Eugenie Lyzenko over 8 years ago

Task branch 1811s for review updated to revision 11020.

This includes the combo-box initial value display issue fix.

#15 Updated by Greg Shah over 8 years ago

  • Status changed from New to Closed

#16 Updated by Greg Shah over 8 years ago

  • % Done changed from 0 to 100

#17 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 12 to GUI Support for a Complex ADM2 App

Also available in: Atom PDF