Project

General

Profile

Activity

From 09/23/2015 to 10/22/2015

10/22/2015

07:16 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811s Revision 11025
The code is pretty clean. I have checked in some minor formatting an...
Greg Shah
02:12 PM Feature #1811: implement the AJAX client driver
The key processing for alert-box seems broken right now (rev 11020). Tab does not switch buttons. Space does not se... Greg Shah
01:39 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, can you please review 1811s 11018? This is a small ...
Hynek Cihlar
01:14 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin, can you please review 1811s 11018? This is a small change in widget focusing and r...
Constantin Asofiei
12:10 PM Feature #1811: implement the AJAX client driver
Constantin, can you please review 1811s 11018? This is a small change in widget focusing and resolves buttons focus i... Hynek Cihlar
06:25 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> There seems to be a new regression. PAUSE as the first instruction doesn't cause the main wind...
Constantin Asofiei
06:20 AM Feature #1811: implement the AJAX client driver
There seems to be a new regression. PAUSE as the first instruction doesn't cause the main window to be shown. Tested ... Hynek Cihlar
06:06 PM Bug #2758: toggle-box selection highlight color depends on the widget's text color and background...
It looks to me that the dotted highlight is always drawn in black, no matter what the FGCOLOR or BGCOLOR.
So the r...
Greg Shah
05:20 PM Bug #2758: toggle-box selection highlight color depends on the widget's text color and background...
I've set fgColor and bgColor in a random order. Here are screen shots: !highlight_both1.png! !highlight_both2.png! Vadim Gindin
04:02 PM Bug #2758: toggle-box selection highlight color depends on the widget's text color and background...
> It looks like there are to same rectangles: the first is just black and solid and the second - is dotted and colore... Greg Shah
03:02 PM Bug #2758: toggle-box selection highlight color depends on the widget's text color and background...
Lets assume we have the following procedure:... Vadim Gindin
07:44 AM Bug #2758: toggle-box selection highlight color depends on the widget's text color and background...
@XOR (192,192,192)@ does not suit. It seems @XOR bgColor@ is good. I'm testing Vadim Gindin
06:01 PM Bug #2775: alert-box key processing is disabled when no main window is visible
Greg Shah wrote:
> The problem is documented in #2773-9
>
> Recreate it with @simpler_alert_box.p@. If there is ...
Hynek Cihlar
05:54 PM Bug #2775: alert-box key processing is disabled when no main window is visible
The problem is documented in #2773-9
Recreate it with @simpler_alert_box.p@. If there is a visible owner window, ...
Greg Shah
05:52 PM Bug #2775 (Closed): alert-box key processing is disabled when no main window is visible
Greg Shah
05:56 PM Bug #2773: simpler_alert_box.p fails in web GUI client
Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > Sergey Ivanovskiy wrote:
> > > Please look at ./demo/demo...
Greg Shah
05:55 PM Bug #2773: simpler_alert_box.p fails in web GUI client
I'm separating the missing key events in Swing issue into #2775. Greg Shah
05:12 PM Bug #2773: simpler_alert_box.p fails in web GUI client
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > Please look at ./demo/demo_widgets.p. There is the definit...
Sergey Ivanovskiy
05:09 PM Bug #2773: simpler_alert_box.p fails in web GUI client
Sergey Ivanovskiy wrote:
> Please look at ./demo/demo_widgets.p. There is the definite issue with fill-in! SPACEs ar...
Constantin Asofiei
04:32 PM Bug #2773: simpler_alert_box.p fails in web GUI client
Please look at ./demo/demo_widgets.p. There is the definite issue with fill-in! SPACEs are accepted only in the middl... Sergey Ivanovskiy
04:10 PM Bug #2773: simpler_alert_box.p fails in web GUI client
Hynek Cihlar wrote:
> Alright, mystery solved. The key input is really stuck when there is no main window. I always ...
Hynek Cihlar
03:48 PM Bug #2773: simpler_alert_box.p fails in web GUI client
Sergey Ivanovskiy wrote:
> Constantin, could you help how to eliminate this message on the server side for ./simpler...
Constantin Asofiei
03:44 PM Bug #2773: simpler_alert_box.p fails in web GUI client
Constantin, could you help how to eliminate this message on the server side for ./simpler_alert_box.p... Sergey Ivanovskiy
03:23 PM Bug #2773: simpler_alert_box.p fails in web GUI client
Hynek Cihlar wrote:
> Greg Shah wrote:
> > > In Swing ALERT-BOX processes mouse and key ok.
> >
> > In 11023 mou...
Hynek Cihlar
03:13 PM Bug #2773: simpler_alert_box.p fails in web GUI client
Greg Shah wrote:
> > In Swing ALERT-BOX processes mouse and key ok.
>
> In 11023 mouse works OK. But keys do not...
Hynek Cihlar
03:12 PM Bug #2773: simpler_alert_box.p fails in web GUI client
It seems that SPACE (32) key is eaten by some widgets on the java side. Sergey Ivanovskiy
02:56 PM Bug #2773: simpler_alert_box.p fails in web GUI client
There is this exception on the js side:... Sergey Ivanovskiy
02:54 PM Bug #2773: simpler_alert_box.p fails in web GUI client
> In Swing ALERT-BOX processes mouse and key ok.
In 11023 mouse works OK. But keys do not. Perhaps you have some...
Greg Shah
02:53 PM Bug #2773: simpler_alert_box.p fails in web GUI client
It is checked into the testcases project. But here is the code:... Greg Shah
02:51 PM Bug #2773: simpler_alert_box.p fails in web GUI client
> In Swing ALERT-BOX processes mouse and key ok. Can you post simpler_alert_box.p?
It needs to update testcases proj...
Sergey Ivanovskiy
02:49 PM Bug #2773: simpler_alert_box.p fails in web GUI client
In Swing ALERT-BOX processes mouse and key ok. Can you post simpler_alert_box.p? Hynek Cihlar
02:28 PM Bug #2773: simpler_alert_box.p fails in web GUI client
Run @./simpler_alert_box.p@ in the web GUI. You get this:
!simpler_alert_box_broken_in_p2j_web_gui_20151022.png!
...
Greg Shah
02:25 PM Bug #2773 (Closed): simpler_alert_box.p fails in web GUI client
Greg Shah
05:36 PM Bug #2764: MESSAGE UPDATE in GUI doesn't honor numeric format string
You are right, the integer variable is properly initialized as unknown and passed to the client side without change. ... Eugenie Lyzenko
04:49 PM Bug #2764: MESSAGE UPDATE in GUI doesn't honor numeric format string
> Either we are not storing the unknown value properly in the screen buffer. Or if it is properly in the screen buffe... Greg Shah
03:50 PM Bug #2764: MESSAGE UPDATE in GUI doesn't honor numeric format string
> Because it is possible the conversion level rule changes can be required to implement this(to generate setUnknown()... Greg Shah
02:58 PM Bug #2764: MESSAGE UPDATE in GUI doesn't honor numeric format string
Greg Shah wrote:
> It looks good. Let me know when you have the unknown value fix.
I'm thinking about this issue...
Eugenie Lyzenko
02:32 PM Bug #2764: MESSAGE UPDATE in GUI doesn't honor numeric format string
It looks good. Let me know when you have the unknown value fix. Greg Shah
12:46 PM Bug #2764: MESSAGE UPDATE in GUI doesn't honor numeric format string
Task branch @1811s@ for review updated to revision @11020@.
This message update fix. Now the digit value displays ...
Eugenie Lyzenko
05:01 PM Bug #2742: Problems when using the SIZE option
Vadim Gindin wrote:
> The last one issue is remained: location of check mark. Eugenie, how did you find, that it is ...
Eugenie Lyzenko
04:41 PM Bug #2742: Problems when using the SIZE option
The last one issue is remained: location of check mark. Eugenie, how did you find, that it is wrong? Vadim Gindin
04:28 PM Bug #2742: Problems when using the SIZE option
I've updated branch to the latest revision and It seems SIZE problem is solved by on of latest commits: !size.png!
Vadim Gindin
03:25 PM Bug #2742: Problems when using the SIZE option
Vadim Gindin wrote:
> Eugenie Lyzenko wrote:
> > ..
> > - disable text behind color is wrong it must be light shad...
Eugenie Lyzenko
03:20 PM Bug #2742: Problems when using the SIZE option
Eugenie Lyzenko wrote:
> ..
> - disable text behind color is wrong it must be light shadow(implemented as white in ...
Vadim Gindin
02:46 PM Bug #2742: Problems when using the SIZE option
This is certainly a kind of regression because in @1811s@ branch version 10991(as of 20151019) everything was OK as y... Eugenie Lyzenko
02:25 PM Bug #2742: Problems when using the SIZE option
Here is the current situation.
# Disabled font is fixed and check mark 1pix shift is also done.
# SIZE problem is st...
Vadim Gindin
04:04 PM Bug #2704: large fill-in drawing differences
OK, let's fix the test to match the behavior that is believed to be correct based on 4GL testing. Greg Shah
03:17 PM Bug #2704: large fill-in drawing differences
Greg Shah wrote:
> Eugenie: was all of the GSO 491 behavior captured on the 4GL or was some of it based on P2J?
T...
Eugenie Lyzenko
02:47 PM Bug #2704: large fill-in drawing differences
The ThinClient revisions which introduced these are:... Constantin Asofiei
02:35 PM Bug #2704: large fill-in drawing differences
Eugenie: was all of the GSO 491 behavior captured on the 4GL or was some of it based on P2J? Greg Shah
02:30 PM Bug #2704: large fill-in drawing differences
Constantin Asofiei wrote:
> Greg Shah wrote:
> > What is the plan to fix the issue in note 7? SENSITIVE is definit...
Constantin Asofiei
02:17 PM Bug #2772 (Closed): the ask-gui.p testcase doesn't show the message update dialog.
Greg Shah
12:18 PM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
> Sergey, just a minor thing. In @FrameWindowGuiImpl.show()@, @super.doLayout()@ should be @doLayout()@.
Committed r...
Sergey Ivanovskiy
12:04 PM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Sergey Ivanovskiy wrote:
> Thanks Constantin and Hynek, committed revision 11016 (branch 1811) should fix the issue....
Hynek Cihlar
11:40 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Thanks Constantin and Hynek, committed revision 11016 (branch 1811) should fix the issue. Committed revision 11017 ad... Sergey Ivanovskiy
11:38 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Sergey Ivanovskiy wrote:
> Constantin, look at this, @BorderPanel@ extends @AbstractContainer@ and it already has @d...
Constantin Asofiei
11:14 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Constantin, look at this, @BorderPanel@ extends @AbstractContainer@ and it already has @doLayout@.... Sergey Ivanovskiy
11:06 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Sergey Ivanovskiy wrote:
> But if we comment this code
> [...]
> then we fix the issue.
Try creating a @BorderedP...
Constantin Asofiei
11:04 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
But if we comment this code... Sergey Ivanovskiy
10:59 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
It doesn't help because of this stack trace... Sergey Ivanovskiy
10:31 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > > Hynek, do you think is OK to move the @doLayout()@ calls from...
Hynek Cihlar
10:29 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Hynek Cihlar wrote:
> > Hynek, do you think is OK to move the @doLayout()@ calls from @FrameWindowGuiImpl.draw()@ t...
Constantin Asofiei
10:26 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > > > If we call @doLayout@ inside @draw@ it leads to resize e...
Hynek Cihlar
10:10 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Sergey Ivanovskiy wrote:
> > > If we call @doLayout@ inside @draw@ it leads to resize events are inside drawing circ...
Constantin Asofiei
10:01 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
> > If we call @doLayout@ inside @draw@ it leads to resize events are inside drawing circles!
> Are you referring to...
Sergey Ivanovskiy
09:51 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Sergey Ivanovskiy wrote:
> If we call @doLayout@ inside @draw@ it leads to resize events are inside drawing circles!...
Constantin Asofiei
09:47 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
If we call @doLayout@ inside @draw@ it leads to resize events are inside drawing circles! Sergey Ivanovskiy
09:36 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
> Please ignore note 12.
Debugging this method...
Sergey Ivanovskiy
07:46 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Please ignore note 12. Hynek Cihlar
07:14 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
> How come the title is drawn? Do we have any logic that assumes window title is always visible?
@WindowTitleBar@ is...
Sergey Ivanovskiy
06:59 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Sergey Ivanovskiy wrote:
> I have some troubles, the JS client can't handle correctly resizes requests in the middle...
Hynek Cihlar
06:55 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
I have some troubles, the JS client can't handle correctly resizes requests in the middle of the drawings. It leads t... Sergey Ivanovskiy
05:23 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Sergey Ivanovskiy wrote:
> Please, help to explain in general words the implementation of @draw@ function of @FrameW...
Hynek Cihlar
05:20 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Committed revision 11012 only changes to accept negative window ids and to log drawing circles.
Please, help to expl...
Sergey Ivanovskiy
03:12 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
> Have you compared the JS logs to the Swing logs? Since Swing is working, you should be able to see which operation... Sergey Ivanovskiy
01:47 PM Bug #2768 (Closed): combo-box displays the item value instead of its label
Greg Shah
12:44 PM Bug #2768: combo-box displays the item value instead of its label
Task branch @1811s@ for review updated to revision @11020@.
This includes the combo-box initial value display issu...
Eugenie Lyzenko
12:44 PM Bug #2768: combo-box displays the item value instead of its label
Constantin Asofiei wrote:
> I've fixed this NPE in 1811s rev 110115 - fontChanged must not be set if widget's font i...
Eugenie Lyzenko
10:46 AM Bug #2768: combo-box displays the item value instead of its label
Eugenie Lyzenko wrote:
> Sergey, I need some clarification.
>
> Do you have the working application(@demo/movie-r...
Constantin Asofiei
09:22 AM Bug #2770: alert-box visual differences
OK, this is very close now.
P2J Swing:
!simpler_alert_box_in_p2j_swing_20151022.png!
There are still slight ...
Greg Shah
06:25 AM Bug #2770: alert-box visual differences
1811s revision 11014 fixes an unhandled exception when alert-box closed through the window caption button. Hynek Cihlar
08:56 AM Bug #2763 (Closed): 3D drawing of window borders is regressed in 1811s revision 10994
Greg Shah
08:08 AM Feature #2564: implement GUI BROWSE widget
I was wrong. There are actually two scrolling modes: 1. when the number rows is estimated 2. when we exactly know how... Stanislav Lomany
05:06 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Good morning! How do you think, if we control scrolling using @Visible dimension@ and @Scro...
Hynek Cihlar
04:34 AM Feature #2564: implement GUI BROWSE widget
Good morning! How do you think, if we control scrolling using @Visible dimension@ and @Scroll dimension@, are we able... Stanislav Lomany
04:28 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Thumb size is @scale(Travel size * DOWN / Estimated rows)@, minimum @8@.
> Thumb positio...
Hynek Cihlar
03:40 AM Feature #2564: implement GUI BROWSE widget
Thumb size is @scale(Travel size * DOWN / Estimated rows)@, minimum @8@.
Thumb position is @min(Travel size - Thumb ...
Stanislav Lomany
06:16 AM Bug #2745: fill-in sizing differences
1811s rev 11007 and 11013 fix two regression in reports, related to ConfigHelper.setModified. runtime testing is in ... Constantin Asofiei
05:19 AM Feature #1801: add some frame options
Rebased task branch 2038a from P2J trunk revision 10961 (new branch revision 10961).
Igor Skornyakov

10/21/2015

06:00 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
Hynek Cihlar wrote:
> Greg Shah wrote:
> > There is one regression caused by 11004. Try @simpler_alert_box.p@ and ...
Hynek Cihlar
05:59 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
Greg Shah wrote:
> There is one regression caused by 11004. Try @simpler_alert_box.p@ and after selecting one of th...
Hynek Cihlar
05:58 PM Bug #2770: alert-box visual differences
The differences resolved in 1811s revision 11011.
The checkin also adds proper handling of window caption close b...
Hynek Cihlar
05:51 PM Feature #2564: implement GUI BROWSE widget
Practice showed that I set that bracket wrong - scrollbars are disabled. Will address in the nearest update. Stanislav Lomany
02:21 PM Feature #2564: implement GUI BROWSE widget
2564c merged into 1811s as rev 11008. Stanislav Lomany
01:43 PM Feature #2564: implement GUI BROWSE widget
Use bzr merge so that the history is maintained properly. Greg Shah
01:38 PM Feature #2564: implement GUI BROWSE widget
There are some conflicting files with trunk, so I would rather merge to 1811s. Should it be merged with "bzr merge" o... Stanislav Lomany
01:27 PM Feature #2564: implement GUI BROWSE widget
I was assuming you would merge it into 1811s.
But since you have already passed regression testing, I guess it is ...
Greg Shah
01:25 PM Feature #2564: implement GUI BROWSE widget
Should I merge it into trunk? Stanislav Lomany
01:21 PM Feature #2564: implement GUI BROWSE widget
OK, go ahead with the merge. When you are done, I will rebase 1811s. Greg Shah
01:20 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> > I think the easiest would be to merge to 1811s and deal with the scroll issues later.
>...
Hynek Cihlar
01:12 PM Feature #2564: implement GUI BROWSE widget
> I think the easiest would be to merge to 1811s and deal with the scroll issues later.
Do you mean 10958 or 10959?
Stanislav Lomany
01:08 PM Feature #2564: implement GUI BROWSE widget
My vote goes for this: 1. Commit 10958. 2. Check thumb size behavior found by Hynek. 3. Discuss the future changes wi... Stanislav Lomany
01:06 PM Feature #2564: implement GUI BROWSE widget
Greg Shah wrote:
> I don't want to leave 10959 in a partial state. If we can make changes (ignoring the thumb size ...
Hynek Cihlar
12:49 PM Feature #2564: implement GUI BROWSE widget
I don't want to leave 10959 in a partial state. If we can make changes (ignoring the thumb size issues) to address t... Greg Shah
12:41 PM Feature #2564: implement GUI BROWSE widget
> When running uast/browse/gui/brws-size-chars.p with no changes the scroll bar should be disabled
I'm aware of that...
Stanislav Lomany
12:34 PM Feature #2564: implement GUI BROWSE widget
Greg Shah wrote:
> Some thoughts/questions:
>
> 1. What is the status of your concerns from note 116? It is not ...
Hynek Cihlar
12:15 PM Feature #2564: implement GUI BROWSE widget
Some thoughts/questions:
1. What is the status of your concerns from note 116? It is not clear to me which of you...
Greg Shah
12:04 PM Feature #2564: implement GUI BROWSE widget
Stanislav I am testing 10959 of 2564c and found some differences between P2J and 4GL.
When running uast/browse/gui/b...
Hynek Cihlar
07:18 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> I suggest to save time to both of us. There is the single testcase that works as in 4GL. I...
Hynek Cihlar
06:36 AM Feature #2564: implement GUI BROWSE widget
Testcase: @uast/browse/gui/brws-size-chars.p@
My font table: @uast/browse/gui/fonts-table.txt@
Screenshot how it look...
Stanislav Lomany
06:11 AM Feature #2564: implement GUI BROWSE widget
I suggest to save time to both of us. There is the single testcase that works as in 4GL. I'll check it the current co... Stanislav Lomany
05:37 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> > You shouldn't override @getVisibleDimension()@, @NativeScrollContainer.getVisibleDimensi...
Hynek Cihlar
05:17 AM Feature #2564: implement GUI BROWSE widget
> You shouldn't override @getVisibleDimension()@, @NativeScrollContainer.getVisibleDimension()@ already takes care of... Stanislav Lomany
04:53 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Guys, here is basic implementation for vertical scrolling. Let me know your thouhgts.
>
...
Hynek Cihlar
04:27 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Scroll step is height to be scrolled / number of rows in this height.
This is effective...
Hynek Cihlar
05:40 PM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Have you compared the JS logs to the Swing logs? Since Swing is working, you should be able to see which operation g... Greg Shah
04:55 PM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Checked that the icon if it would be defined for @ModalWindow@... Sergey Ivanovskiy
11:59 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Sergey Ivanovskiy wrote:
> If we permit negative numbers for window ids, then the message update dialog appears and ...
Constantin Asofiei
11:51 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
If we permit negative numbers for window ids, then the message update dialog appears and looks like in the attached s... Sergey Ivanovskiy
11:28 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
> Please note that on the Java side this seems to be related to the use of @Window.tinyInput()@. I think this is the... Sergey Ivanovskiy
10:49 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
Please note that on the Java side this seems to be related to the use of @Window.tinyInput()@. I think this is the s... Greg Shah
10:47 AM Bug #2772: the ask-gui.p testcase doesn't show the message update dialog.
The JS web client doesn't display "Try another program?: yes/No" dialog and the browser console produces... Sergey Ivanovskiy
10:41 AM Bug #2772 (Closed): the ask-gui.p testcase doesn't show the message update dialog.
Sergey Ivanovskiy
04:28 PM Bug #2764: MESSAGE UPDATE in GUI doesn't honor numeric format string
Some investigations for GUI fill-in issue. There are several issues/deviations from 4GL here.
1. GUI fill-in does no...
Eugenie Lyzenko
04:23 PM Feature #1811: implement the AJAX client driver
Done (rev 11010). Stanislav Lomany
03:55 PM Feature #1811: implement the AJAX client driver
Rebased task branch 1811s from P2J trunk revision 10949. The current revision in 1811s is now 11009.
*DO NOT pull ...
Greg Shah
10:43 AM Feature #1801: add some frame options
Greg Shah wrote:
> > I've never worked with Data Dictionary and the database layer
>
> Please do not waste any t...
Igor Skornyakov
10:34 AM Feature #1801: add some frame options
> I've never worked with Data Dictionary and the database layer
Please do not waste any time on this. These feat...
Greg Shah
09:58 AM Feature #1801: add some frame options
Greg Shah wrote:
> > In a meantime I'm working on the rest of the list (NO-VALIDATE, NO-HELP, and NO-AUTO-VALIDATE)....
Igor Skornyakov
09:44 AM Feature #1801: add some frame options
> In a meantime I'm working on the rest of the list (NO-VALIDATE, NO-HELP, and NO-AUTO-VALIDATE).
If you can clear...
Greg Shah
09:43 AM Feature #1801: add some frame options
Greg Shah wrote:
> Code Review Task Branch 2038a Revision 10959
>
> The changes are good, except for some formatt...
Igor Skornyakov
09:29 AM Feature #1801: add some frame options
Code Review Task Branch 2038a Revision 10959
The changes are good, except for some formatting AND the name of @Zer...
Greg Shah
06:41 AM Feature #1801: add some frame options
Fixed formatting.
Committed to the task branch 2038a revno 10959.
Igor Skornyakov
06:38 AM Feature #1801: add some frame options
The next in my list is the @TREE-D@ support. The conversion (including getters/setters) is done. Should I implement 3... Igor Skornyakov
06:33 AM Feature #1801: add some frame options
The spacing issue mentioned in the previous not is fixed.
Committed to the task branch 2038a revno 10957.
Igor Skornyakov
06:19 AM Feature #1801: add some frame options
Implemented @NO-UNDERLINE@ runtime support.
Committed to the task branch 2038a revno 10957.
It works OK in the ...
Igor Skornyakov
04:12 AM Feature #1801: add some frame options
Greg Shah wrote:
> 1. Please javadoc @void addWidget(GenericWidget<?> widget)@ in @GenericFrame@. Also add a blank ...
Igor Skornyakov
09:52 AM Bug #2768: combo-box displays the item value instead of its label
Greg Shah wrote:
> Sorry, I meant 2038a not 2032a. I must be mis-remembering a change there.
I see. I have made ...
Igor Skornyakov
09:46 AM Bug #2768: combo-box displays the item value instead of its label
Sorry, I meant 2038a not 2032a. I must be mis-remembering a change there. Greg Shah
09:38 AM Bug #2768: combo-box displays the item value instead of its label
Greg Shah wrote:
> Igor: did you make changes in 2032a that are related to the list-items issue above?
Sorry, I...
Igor Skornyakov
09:32 AM Bug #2768: combo-box displays the item value instead of its label
Greg Shah wrote:
> Constantin: is the @nativeWidth()@ change yours?
Yes, the @nativreWidth()@ change is mine, for f...
Constantin Asofiei
09:15 AM Bug #2768: combo-box displays the item value instead of its label
Igor: did you make changes in 2032a that are related to the list-items issue above?
Constantin: is the @nativeWidt...
Greg Shah
08:52 AM Bug #2768: combo-box displays the item value instead of its label
>These are not all my changes, I have added only this one "Added to notify the client the current selection is change... Eugenie Lyzenko
06:46 AM Bug #2768: combo-box displays the item value instead of its label
I have checked this example works with the described issue for the branch 1811s rev 10995. The target changes are due... Sergey Ivanovskiy
06:13 AM Bug #2768: combo-box displays the item value instead of its label
> Do you have the working application(@demo/movie-ratings-dynamic.p@) at this time? Can you comment this mods in @Fil... Sergey Ivanovskiy
09:54 PM Bug #2768: combo-box displays the item value instead of its label
Sergey, I need some clarification.
Do you have the working application(@demo/movie-ratings-dynamic.p@) at this tim...
Eugenie Lyzenko
09:08 AM Bug #2771 (Closed): the upper part of the image button border is cleared
Greg Shah
09:07 AM Bug #2771: the upper part of the image button border is cleared
Rev 11004 fixes this bug. Sergey Ivanovskiy
08:24 AM Bug #2771: the upper part of the image button border is cleared
On the current version 11005 the bug isn't reproduced, but I can't identify changes related to this issue that may fi... Sergey Ivanovskiy
09:06 AM Bug #2751 (Closed): dragging the scrollbar thumb buttons does not work
Greg Shah
08:57 PM Bug #2751: dragging the scrollbar thumb buttons does not work
Task branch @1811s@ for review updated to revision @11005@.
This is the fix for drop-down painting regression, scr...
Eugenie Lyzenko

10/20/2015

07:46 PM Feature #2564: implement GUI BROWSE widget
Guys, here is basic implementation for vertical scrolling. Let me know your thouhgts.
First, I wrote this function...
Stanislav Lomany
05:52 PM Feature #2564: implement GUI BROWSE widget
"height to be scrolled" is actually @max@. Stanislav Lomany
05:50 PM Feature #2564: implement GUI BROWSE widget
Scroll step is height to be scrolled / number of rows in this height. Stanislav Lomany
04:49 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Thumb size is affected by @Scroll dimension@ and @Visible dimension@. And they are linked ...
Hynek Cihlar
04:37 PM Feature #2564: implement GUI BROWSE widget
Thumb size is affected by @Scroll dimension@ and @Visible dimension@. And they are linked in this equation:
@Scroll ...
Stanislav Lomany
04:17 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> It it will be constant then we will not be able to affect thumb size.
Thumb size is not...
Hynek Cihlar
04:12 PM Feature #2564: implement GUI BROWSE widget
It it will be constant then we will not be able to affect thumb size. Stanislav Lomany
04:05 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> @Scroll dimension@ = @Visible dimension@ * @Number of rows@ / @DOWN@.
> @Scroll step@ = (...
Hynek Cihlar
03:49 PM Feature #2564: implement GUI BROWSE widget
@Scroll dimension@ = @Visible dimension@ * @Number of rows@ / @DOWN@.
@Scroll step@ = (@Scroll dimension@ - @Visible...
Stanislav Lomany
01:52 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> OK, we have:
> @Scroll dimension@
> @Visible dimension@ - fixed value
> @Max@ = @Scrol...
Hynek Cihlar
01:46 PM Feature #2564: implement GUI BROWSE widget
OK, we have:
@Scroll dimension@
@Visible dimension@ - fixed value
@Max@ = @Scroll dimension@ - @Visible dimension...
Stanislav Lomany
01:40 PM Feature #2564: implement GUI BROWSE widget
> Since scrollbar changes are GUI-only, I successfully ran regression testing (conversion and runtime).
Excellent!...
Greg Shah
01:18 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Can I update @max@ value with @setMax()@ when it is nesseccary?
You shouldn't do this d...
Hynek Cihlar
01:11 PM Feature #2564: implement GUI BROWSE widget
Since scrollbar changes are GUI-only, I successfully ran regression testing (conversion and runtime). Stanislav Lomany
12:36 PM Feature #2564: implement GUI BROWSE widget
Can I update @max@ value with @setMax()@ when it is nesseccary? Stanislav Lomany
08:48 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> > Also, scrolling the scrollbars shouldn't be done by calling setPosition() on the scroll ...
Hynek Cihlar
08:30 AM Feature #2564: implement GUI BROWSE widget
> Also, scrolling the scrollbars shouldn't be done by calling setPosition() on the scroll bar references.
How sho...
Stanislav Lomany
06:30 PM Feature #1801: add some frame options
Code Review Task Branch 2038a Revision 10954
Overall, the changes are good.
1. Please javadoc @void addWidget(G...
Greg Shah
05:21 PM Feature #1801: add some frame options
Created test @testcases/uast/background/bgnd1.p@ to check customer use cases.
Committed to revbo 1386.
Fixed @BA...
Igor Skornyakov
03:03 PM Feature #1801: add some frame options
I can see two different scenarios of using the @BACKGROUND@ attribute in the customer code.
1. Modification of the...
Igor Skornyakov
02:15 PM Feature #1801: add some frame options
Greg Shah wrote:
> Code Review Task Branch 2038a Revision 10950
>
> 1. The @is_form_background@ function is not n...
Igor Skornyakov
01:28 PM Feature #1801: add some frame options
Code Review Task Branch 2038a Revision 10950
1. The @is_form_background@ function is not needed in @frame_scoping....
Greg Shah
11:38 AM Feature #1801: add some frame options
I've implemented the "server-side only field-group" support for the @BACKGROUND@ attribute and it seems working.
C...
Igor Skornyakov
11:07 AM Feature #1801: add some frame options
> Should I implement the `right` approach or try to find a workaround where background widgets will not be the parts ... Greg Shah
10:51 AM Feature #1801: add some frame options
I have a question regarding a @BACKGROUND@ attribute support. The 4GL returns a (handle of a) @FIELD-GROUP@ as a resu... Igor Skornyakov
09:25 AM Feature #1801: add some frame options
Fixed conversion for the background widgets.
Committed to the task branch 2038a revno 10949.
Igor Skornyakov
08:33 AM Feature #1801: add some frame options
Greg Shah wrote:
> Correct, it isn't passed as a parameter.
>
> Look at @is_form_header@ which processes for a @f...
Igor Skornyakov
08:32 AM Feature #1801: add some frame options
Correct, it isn't passed as a parameter.
Look at @is_form_header@ which processes for a @form_item@ and looks back...
Greg Shah
08:25 AM Feature #1801: add some frame options
Greg Shah wrote:
> > The task branch is already exists. Should I just checkout it?
>
> I don't think it has anyth...
Igor Skornyakov
08:11 AM Feature #1801: add some frame options
> The task branch is already exists. Should I just checkout it?
I don't think it has anything useful. And it is p...
Greg Shah
07:59 AM Feature #1801: add some frame options
Greg Shah wrote:
> Please do the following:
>
> 1. Create a task branch 2038a. Commit your current work there.
...
Igor Skornyakov
07:41 AM Feature #1801: add some frame options
Please do the following:
1. Create a task branch 2038a. Commit your current work there.
2. Commit your testcases...
Greg Shah
06:05 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
There is one regression caused by 11004. Try @simpler_alert_box.p@ and after selecting one of the buttons, try to di... Greg Shah
05:07 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
1811s revision 11004 fixes the disappearing 3D border. It also adds 3D border to ALERT-BOX and DIALOG-BOX. Hynek Cihlar
05:00 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> It should be called before or else the 3D border would be drawn o...
Eugenie Lyzenko
04:53 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Eugenie, @WindowGuiImpl.draw()@ calls @super.draw()@ twice. Fir...
Eugenie Lyzenko
04:44 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Eugenie, @WindowGuiImpl.draw()@ calls @super.draw()@ twice. Fir...
Hynek Cihlar
04:38 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
Hynek Cihlar wrote:
> Eugenie, @WindowGuiImpl.draw()@ calls @super.draw()@ twice. First before @drawBorder()@ and se...
Constantin Asofiei
04:34 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
Eugenie, @WindowGuiImpl.draw()@ calls @super.draw()@ twice. First before @drawBorder()@ and second time after @drawBo... Hynek Cihlar
04:58 PM Bug #2771: the upper part of the image button border is cleared
If we run gui_btn_test5.p and then click on "Enable on/off" button or press and hold "Quit" button, then the upper pa... Sergey Ivanovskiy
04:56 PM Bug #2771 (Closed): the upper part of the image button border is cleared
Sergey Ivanovskiy
04:32 PM Bug #2770: alert-box visual differences
I did run this with updated text metrics, so the sizing problem shouldn't be due to that. Greg Shah
04:31 PM Bug #2770: alert-box visual differences
The P2J version of alert-box has 3 visual differences as compared to the Progress version.
Progress:
!simpler_a...
Greg Shah
04:25 PM Bug #2770 (Closed): alert-box visual differences
Greg Shah
04:23 PM Bug #2756 (Closed): UPDATE statement in GUI dies on GO and leaves the restarted app in an unkilla...
Fixed by 1811s revision 11002. Greg Shah
12:56 PM Bug #2756: UPDATE statement in GUI dies on GO and leaves the restarted app in an unkillable/unres...
The failure now seems to occur in the alert-box button creation. This is the same as the latest problem in #2729. D... Greg Shah
08:16 AM Bug #2756: UPDATE statement in GUI dies on GO and leaves the restarted app in an unkillable/unres...
This problem still exists in both the trunk 10948 (after 2560a was merged) and in 1811s rev 10995 (after rebase from ... Greg Shah
04:21 PM Bug #2729 (Closed): alert-box usage is broken
Greg Shah
01:17 PM Bug #2729: alert-box usage is broken
Greg Shah wrote:
> OK, this is now the result. It is the same as #2756 and #1811-1546
>
> [...]
Fixed in 1811...
Hynek Cihlar
12:56 PM Bug #2729: alert-box usage is broken
OK, this is now the result. It is the same as #2756 and #1811-1546... Greg Shah
12:02 PM Bug #2729: alert-box usage is broken
Hynek Cihlar wrote:
> Greg Shah wrote:
> > They should always be loaded from the jar itself. We won't expect users...
Hynek Cihlar
03:50 PM Bug #2557: Fix MENUBAR layouting in a window
OK, please pause work on this task. Greg Shah
03:36 PM Bug #2557: Fix MENUBAR layouting in a window
This is only for GUI. It just wasn't documented in this task earlier. Vadim Gindin
03:35 PM Bug #2557: Fix MENUBAR layouting in a window
> The new issue: when MENUBAR dynamically is assigned (from button's trigger) menu items are not displayed.
This o...
Greg Shah
03:32 PM Bug #2557: Fix MENUBAR layouting in a window
For GUI there is only one issue - "hiding bogus message":... Vadim Gindin
09:17 AM Bug #2557: Fix MENUBAR layouting in a window
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I forgot to add that my question is about CHUI.
> ChUI is tric...
Vadim Gindin
09:10 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim: this ChUI work can wait. Document your findings and any code changes that are not safe to check in.
Please...
Greg Shah
08:45 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> I forgot to add that my question is about CHUI.
ChUI is tricky - as I recall, menubar and all...
Constantin Asofiei
07:50 AM Bug #2557: Fix MENUBAR layouting in a window
I've set contentPane's height to workspace height minus menubar height. Now status line is not displaced but the cont... Vadim Gindin
07:40 AM Bug #2557: Fix MENUBAR layouting in a window
I forgot to add that my question is about CHUI. Vadim Gindin
07:10 AM Bug #2557: Fix MENUBAR layouting in a window
Vadim Gindin wrote:
> I'm working on heights adjustment of window content when it contains MENUBAR (including dynami...
Constantin Asofiei
07:08 AM Bug #2557: Fix MENUBAR layouting in a window
I'm working on heights adjustment of window content when it contains MENUBAR (including dynamic attachment). When win... Vadim Gindin
03:32 PM Bug #2769: the cursor moves roughly if press and hold the right or left arrow on to position it i...
This is a bug that is specific to the GUI web client. Greg Shah
02:49 PM Bug #2769: the cursor moves roughly if press and hold the right or left arrow on to position it i...
For this example ./demo/demo_widgets.p, if we focus text editor component, then press left or right buttons to move t... Sergey Ivanovskiy
02:48 PM Bug #2769 (New): the cursor moves roughly if press and hold the right or left arrow on to positio...
Sergey Ivanovskiy
01:53 PM Bug #2713: Incorrect labels in case of the overlapping widgets.
Yes, this is not critical right now. Greg Shah
01:51 PM Bug #2713: Incorrect labels in case of the overlapping widgets.
The issue is more complex than just z-order. When computing the top-label layout for a case when widgets intersect (... Constantin Asofiei
07:13 AM Bug #2713 (WIP): Incorrect labels in case of the overlapping widgets.
Constantin Asofiei
01:46 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > By main window I meant the main window the widget is ultimately...
Hynek Cihlar
01:25 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> By main window I meant the main window the widget is ultimately attached to. I.e. through the ...
Constantin Asofiei
01:15 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> There is a new regression on GUI ALERT-BOX, it abends before it is displayed.
Fixed in revi...
Hynek Cihlar
10:20 AM Feature #1811: implement the AJAX client driver
There is a new regression on GUI ALERT-BOX, it abends before it is displayed.
The cause is in @Button.ctor()@ call...
Hynek Cihlar
09:59 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, I have a bit of a problem with batch-drawing modal ...
Hynek Cihlar
09:15 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin, I have a bit of a problem with batch-drawing modal windows. In @ModalWindow.draw()...
Constantin Asofiei
09:08 AM Feature #1811: implement the AJAX client driver
Constantin, I have a bit of a problem with batch-drawing modal windows. In @ModalWindow.draw()@ I need to enable batc... Hynek Cihlar
12:04 PM Bug #2742: Problems when using the SIZE option
Greg Shah wrote:
> Vadim: how quickly can these issues be addressed?
During the day.
Vadim Gindin
10:17 AM Bug #2742: Problems when using the SIZE option
Vadim: how quickly can these issues be addressed? Greg Shah
11:13 AM Bug #2751: dragging the scrollbar thumb buttons does not work
The investigation shows this is not related to scrollbar thumb button drag enabled functionality. Because if I disabl... Eugenie Lyzenko
08:26 AM Bug #2751: dragging the scrollbar thumb buttons does not work
Another issue: when you make the combo-box drop-down appear, the scrollbars on the editor no longer paint properly. Greg Shah
08:25 AM Bug #2751: dragging the scrollbar thumb buttons does not work
There is one "regression" caused by this change. When you drag the thumb button in the combo-box drop-down, the edit... Greg Shah
08:11 AM Bug #2751: dragging the scrollbar thumb buttons does not work
Eugenie Lyzenko wrote:
> Task branch @1811s@ for review updated to revision @10997@.
>
> This is the fix for scro...
Hynek Cihlar
10:40 AM Bug #2768: combo-box displays the item value instead of its label
1) Run ./demo/movie-ratings-dynamic.p
2) Go through the login web page, press a space bar. The final screen has the "...
Sergey Ivanovskiy
10:36 AM Bug #2768 (Closed): combo-box displays the item value instead of its label
Sergey Ivanovskiy
10:20 AM Bug #2758: toggle-box selection highlight color depends on the widget's text color and background...
This can now be fixed using the XOR support that exists in the 1811s rev 10995 and later. Changes should go into 1811s. Greg Shah
10:12 AM Bug #2767 (Rejected): implement INPUT-VALUE attribute properly for all widget types
Greg Shah
10:09 AM Bug #2766: implement a text metrics server process
Please read the #2745 notes carefully. This describes a scenario where @AUTO-RESIZE@ allows a widget to change size ... Greg Shah
09:54 AM Bug #2766 (New): implement a text metrics server process
Greg Shah
09:53 AM Bug #2701 (Closed): default font text sizing issue
The font replacement work will be done in a separate task #2765. Greg Shah
09:49 AM Bug #2765: find proper freely licensed replacements for the MS Windows OS fonts
Details on the original implementation are in #1794.
Improvements in the default font environment were done in #27...
Greg Shah
09:47 AM Bug #2765 (Closed): find proper freely licensed replacements for the MS Windows OS fonts
Greg Shah
08:29 AM Feature #2038: conversion and runtime support for frame options, attributes and methods
Created task branch 2038a from P2J trunk revision 10948 Igor Skornyakov
08:28 AM Feature #2038: conversion and runtime support for frame options, attributes and methods
Arhived task branch 2038a as dead. Igor Skornyakov
07:11 AM Bug #2745: fill-in sizing differences
1811s rev 10999 contains the fix for fill-in auto-resize.
I'm putting this rev through runtime testing, there is a...
Constantin Asofiei

10/19/2015

07:49 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> > @viewport.getScrollWidget()@ returns @ScrollableWidget@ or indirectly @ColumnSetContaine...
Hynek Cihlar
07:41 PM Feature #2564: implement GUI BROWSE widget
> @viewport.getScrollWidget()@ returns @ScrollableWidget@ or indirectly @ColumnSetContainer@ which is completely unde... Stanislav Lomany
07:30 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> First issue: why not add @handleScrollRequest@ method to @ScrollListener@?
I would rath...
Hynek Cihlar
06:59 PM Feature #2564: implement GUI BROWSE widget
First issue: why not add @handleScrollRequest@ method to @ScrollListener@?
Second issue: I'm not sure that your so...
Stanislav Lomany
06:30 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> > I see. I believe it should be enough to override @NativeScrollContainer.getScrollDimensi...
Hynek Cihlar
06:11 PM Feature #2564: implement GUI BROWSE widget
> I see. I believe it should be enough to override @NativeScrollContainer.getScrollDimension()@ and return the actual... Stanislav Lomany
05:48 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> >Can you explain why is the "non-trimmed" scrolling needed and the use case behind this?
...
Hynek Cihlar
05:27 PM Feature #2564: implement GUI BROWSE widget
>Can you explain why is the "non-trimmed" scrolling needed and the use case behind this?
It is used for scrolling row...
Stanislav Lomany
04:56 PM Feature #2564: implement GUI BROWSE widget
Code Review Task Branch 2564c Revision 10958.
This version is a great improvement from the last version I saw. I h...
Hynek Cihlar
04:02 PM Feature #2564: implement GUI BROWSE widget
Code Review Task Branch 2564c Revision 10958
I don't see any problems.
Hynek: would you please review the scrol...
Greg Shah
03:44 PM Feature #2564: implement GUI BROWSE widget
Rebased task branch 2564c from P2J trunk revision 10948.
Please review this branch rev 10958. No regressions after r...
Stanislav Lomany
02:40 PM Feature #2564: implement GUI BROWSE widget
I had to fix minor issue which seemed important to me. I'm finishing comments and let you know when rebase is done. Stanislav Lomany
02:39 PM Feature #2564: implement GUI BROWSE widget
What is the status on the rebase and the final code? Greg Shah
12:02 PM Feature #2564: implement GUI BROWSE widget
OK. I'm writing comments and will rebase and check the behavior after that. Stanislav Lomany
11:19 AM Feature #2564: implement GUI BROWSE widget
2560a is going to be merged to trunk in the next 20 minutes. When that happens, please make sure you rebase before y... Greg Shah
09:24 AM Feature #2564: implement GUI BROWSE widget
> How much time do I have?
We need to merge to trunk today, so that means code review and testing in 3 hours.
Greg Shah
08:42 AM Feature #2564: implement GUI BROWSE widget
Finished horizontal scrolling and column's width. Right now I'm trying to make browse layout more correctly - once in... Stanislav Lomany
08:10 AM Feature #2564: implement GUI BROWSE widget
Please summarize the status of 2564c. Based on the code that is there, it seems you are done or almost done with the... Greg Shah
06:49 PM Bug #2751: dragging the scrollbar thumb buttons does not work
Task branch @1811s@ for review updated to revision @10997@.
This is the fix for scroll-bar thumb dragging issue.
Eugenie Lyzenko
05:55 PM Bug #2751: dragging the scrollbar thumb buttons does not work
Commit the changes to 1811s and let Hynek review it. Greg Shah
03:50 PM Bug #2751: dragging the scrollbar thumb buttons does not work
The fix is ready to be committed. The root cause the condition @MouseEvent.getButton() != MouseEvent.NOBUTTON@ is alw... Eugenie Lyzenko
06:11 PM Bug #2762 (Closed): over-drawing problem with combo-box drop-down dismissal
It is still resolved in 1811s rev 10995 (post-rebase). Greg Shah
03:44 PM Bug #2762: over-drawing problem with combo-box drop-down dismissal
The current @1811s@ build(before rebase with @10948@ trunk) shows correct painting for this issue. Looks like the iss... Eugenie Lyzenko
06:06 PM Bug #2714 (Closed): demo/calc.p is broken
Greg Shah
06:05 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
Greg Shah wrote:
> Interestingly, this affect only seems to occur while @tinyInput()@ is running. But it causes bot...
Hynek Cihlar
06:00 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
Interestingly, this affect only seems to occur while @tinyInput()@ is running. But it causes both the dialog box and... Greg Shah
05:44 PM Bug #2763: 3D drawing of window borders is regressed in 1811s revision 10994
After rebase to trunk 10948 (the new dialog box support), 1811s (revision 10994) shows a regression where the 3D bord... Greg Shah
05:43 PM Bug #2763 (Closed): 3D drawing of window borders is regressed in 1811s revision 10994
Greg Shah
06:03 PM Bug #2729: alert-box usage is broken
Greg Shah wrote:
> They should always be loaded from the jar itself. We won't expect users to distribute our icons ...
Hynek Cihlar
05:54 PM Bug #2729: alert-box usage is broken
They should always be loaded from the jar itself. We won't expect users to distribute our icons in the file system. ... Greg Shah
05:52 PM Bug #2729: alert-box usage is broken
Greg Shah wrote:
> Something is wrong. I cannot recreate your success.
>
> Using the trunk rev 10948 (which has ...
Hynek Cihlar
05:37 PM Bug #2729: alert-box usage is broken
Something is wrong. I cannot recreate your success.
Using the trunk rev 10948 (which has the alert-box fixes) I t...
Greg Shah
11:44 AM Bug #2729: alert-box usage is broken
Alert-box has been fixed with task branch 2560a and checked in to trunk as revision 10948. Hynek Cihlar
05:51 PM Feature #1811: implement the AJAX client driver
OK, people can update from 1811s now. It is "unlocked". Please note there is at least 1 regression (see #2763), the... Greg Shah
05:36 PM Feature #1811: implement the AJAX client driver
Resolved rebase conflicts in revision 10995. Hynek Cihlar
04:40 PM Feature #1811: implement the AJAX client driver
> I will create 1811t and do the changes there.
There is no need.
When I said "review in a new branch", I reall...
Greg Shah
04:31 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> I will create 1811t and do the changes there.
I will need to branch from 1811s, but since @...
Hynek Cihlar
04:16 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Rebased task branch 1811s from P2J trunk revision 10948. The current revision in 1811s is now 1099...
Hynek Cihlar
02:27 PM Feature #1811: implement the AJAX client driver
Rebased task branch 1811s from P2J trunk revision 10948. The current revision in 1811s is now 10994.
*DO NOT pull ...
Greg Shah
10:41 AM Feature #1811: implement the AJAX client driver
Please review #2701-4 Greg Shah
10:38 AM Feature #1811: implement the AJAX client driver
> Make sure your font environment is correct. Capture and apply the text metrics if necessary.
Greg, please help ho...
Sergey Ivanovskiy
09:45 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Fixed misspelled names committed revision 10990.
I'm OK with the changes, good work.
Constantin Asofiei
09:11 AM Feature #1811: implement the AJAX client driver
Sergey: for 1811s, it is time to re-test the GUI testscases that we are using for our manual GUI regression testing. ... Greg Shah
08:55 AM Feature #1811: implement the AJAX client driver
Fixed misspelled names committed revision 10990. Sergey Ivanovskiy
08:43 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> > Constantin, Greg, I found a regression if the window is opened we can't drag the task bar. It i...
Sergey Ivanovskiy
08:41 AM Feature #1811: implement the AJAX client driver
> > Constantin, there is the bug it is easy to decrease the window size but it is difficult to increase it again. It ... Sergey Ivanovskiy
05:48 PM Bug #2702 (Closed): MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX...
Greg Shah
05:48 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
This partially works in the trunk rev 10948. The window title for the dialog doesn't display properly. Please note ... Greg Shah
11:43 AM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Support for GUI tiny input has been delivered together with task branch 2560a and checked in to trunk as revision 10948. Hynek Cihlar
05:48 PM Bug #2764: MESSAGE UPDATE in GUI doesn't honor numeric format string
Starting in trunk 10948 or 1811s 10994, run @message-update6.p@.
Enter "Y" to the first prompt. At the second pro...
Greg Shah
05:45 PM Bug #2764 (Closed): MESSAGE UPDATE in GUI doesn't honor numeric format string
Greg Shah
01:49 PM Bug #2745: fill-in sizing differences
Greg Shah wrote:
> Thank you Guy, well done.
>
> > I think this is it, if AUTO-RESIZE is ON, changing the FONT wi...
Constantin Asofiei
01:36 PM Bug #2745: fill-in sizing differences
Thank you Guy, well done.
> I think this is it, if AUTO-RESIZE is ON, changing the FONT will adjust the width so t...
Greg Shah
12:43 PM Bug #2745: fill-in sizing differences
I hate to admit it, but it wasn't on my list either.
I was trying to test another idea, hence the long string, but...
Guy M
12:36 PM Bug #2745: fill-in sizing differences
Guy Mills wrote:
> So it seems that the size changes to accommodate the contents. And the default contents are mayb...
Constantin Asofiei
12:28 PM Bug #2745: fill-in sizing differences
Check this out:... Guy M
12:18 PM Bug #2745: fill-in sizing differences
Scrap that last theory.
I did my test wrong. If I explicitly set the font to ? it also resizes.
Now I see your...
Guy M
12:12 PM Bug #2745: fill-in sizing differences
Constantin Asofiei wrote:
> If you have any ideas about this, please let me know.
...well, if you set AUTO-RESIZ...
Guy M
11:37 AM Bug #2745: fill-in sizing differences
Guy Mills wrote:
> This update includes 2 parts:
> 1) My investigation of OpenEdge FONT attribute
> 2) My organi...
Constantin Asofiei
10:49 AM Bug #2745: fill-in sizing differences
This update includes 2 parts:
1) My investigation of OpenEdge FONT attribute
2) My organization's usage of the FO...
Guy M
10:15 AM Bug #2745: fill-in sizing differences
Guy: would you mind reviewing the history of this task and sharing any insight you may have?
Constantin is finding...
Greg Shah
10:12 AM Bug #2745: fill-in sizing differences
Constantin Asofiei wrote:
> The theory at this time is that 4GL tries to not allow the widget to "leak" outside of i...
Constantin Asofiei
09:25 AM Bug #2745: fill-in sizing differences
Greg Shah wrote:
> Considering that they try to keep tight and consistent control over their font usage, I imagine t...
Constantin Asofiei
09:22 AM Bug #2745: fill-in sizing differences
It is definitely used from @FRAME@. But it is also used with regular widgets accessed through a @HANDLE@ or @WIDGET-... Greg Shah
09:13 AM Bug #2745: fill-in sizing differences
Greg Shah wrote:
> > do you know if the GUI project uses the FONT attribute? I have a feeling this is another headac...
Constantin Asofiei
09:13 AM Bug #2745: fill-in sizing differences
> do you know if the GUI project uses the FONT attribute? I have a feeling this is another headache to figure out.
...
Greg Shah
08:59 AM Bug #2745: fill-in sizing differences
I assumed that it was using the DEFAULT-FONT to compute the width, but this is not the case.
What looked more pl...
Constantin Asofiei
07:07 AM Bug #2745: fill-in sizing differences
This one is tricky: setting @FONT=10@ via attribute and @FONT 10@ as widget/frame option produce different fill-in wi... Constantin Asofiei
06:37 AM Bug #2745 (WIP): fill-in sizing differences
Constantin Asofiei
12:01 PM Feature #2560: implement GUI DIALOG-BOX support
Ok, I will check the known issues after 1811s is rebased. Hynek Cihlar
11:59 AM Feature #2560: implement GUI DIALOG-BOX support
Any additions or changes will be done in 1811s (or if they are ready after we need to go into testing for 1811s, then... Greg Shah
11:55 AM Feature #2560: implement GUI DIALOG-BOX support
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > > There are frame layout issues which affect ...
Hynek Cihlar
11:54 AM Feature #2560: implement GUI DIALOG-BOX support
Hynek Cihlar wrote:
> Greg Shah wrote:
> > > There are frame layout issues which affect tiny input as well as dialo...
Hynek Cihlar
11:51 AM Feature #2560: implement GUI DIALOG-BOX support
Greg Shah wrote:
> > There are frame layout issues which affect tiny input as well as dialog-box. There have been ch...
Hynek Cihlar
11:42 AM Feature #2560: implement GUI DIALOG-BOX support
> There are frame layout issues which affect tiny input as well as dialog-box. There have been changes in #1811/1811s... Greg Shah
11:40 AM Feature #2560: implement GUI DIALOG-BOX support
#2560a checked in to trunk as revision 10948. Hynek Cihlar
11:23 AM Feature #2560: implement GUI DIALOG-BOX support
In your commit message, make sure to also reference #2702 and #2729 (e.g. using @Refs #2560, #2702, #2729.@). Greg Shah
11:17 AM Feature #2560: implement GUI DIALOG-BOX support
OK, please merge to trunk now. Greg Shah
11:14 AM Feature #2560: implement GUI DIALOG-BOX support
Greg Shah wrote:
> As far as you know, does this update cause any new regressions to GUI?
I don't know of any new...
Hynek Cihlar
11:13 AM Feature #2560: implement GUI DIALOG-BOX support
As far as you know, does this update cause any new regressions to GUI? Greg Shah
11:04 AM Feature #2560: implement GUI DIALOG-BOX support
Greg Shah wrote:
> Have you re-run any of the GUI testcases to see if there are regressions?
I have run the dialo...
Hynek Cihlar
10:11 AM Feature #2560: implement GUI DIALOG-BOX support
Have you re-run any of the GUI testcases to see if there are regressions?
What is the status of #2702, #2752, #272...
Greg Shah
10:09 AM Feature #2560: implement GUI DIALOG-BOX support
Greg Shah wrote:
> Code Review Task Branch 2560a Revision 10987
>
> I'm good with the changes.
>
> What is the...
Hynek Cihlar
09:35 AM Feature #2560: implement GUI DIALOG-BOX support
Code Review Task Branch 2560a Revision 10987
I'm good with the changes.
What is the status of testing?
Greg Shah
09:30 AM Feature #2560: implement GUI DIALOG-BOX support
Greg Shah wrote:
> Please post the final, clean code to bzr.
Checked in, task branch 2560a revision 10987.
Hynek Cihlar
07:42 AM Feature #2560: implement GUI DIALOG-BOX support
Please post the final, clean code to bzr. Greg Shah
04:22 AM Feature #2560: implement GUI DIALOG-BOX support
The regression results of 2560a revision 10986 show two suspicious failed tests, gso_245 and tc_codes_crew_003. When ... Hynek Cihlar
09:01 PM Feature #2560: implement GUI DIALOG-BOX support
> I didn't originally plan to keep it but if you think it may be useful I will put it to a more appropriate package, ... Greg Shah
11:12 AM Bug #2742: Problems when using the SIZE option
Eugenie Lyzenko wrote:
> Greg, Vadim,
>
> The analysis for primary issue.
> 1. The testcase to get this bug(@uas...
Vadim Gindin
10:39 AM Bug #2742: Problems when using the SIZE option
Greg Shah wrote:
> Eugenie, the trunk revision 10947 has some fixes to toggle box. 1811s does not yet include those...
Eugenie Lyzenko
10:09 AM Bug #2742: Problems when using the SIZE option
Eugenie, the trunk revision 10947 has some fixes to toggle box. 1811s does not yet include those (it is a pending re... Greg Shah
09:59 AM Bug #2742: Problems when using the SIZE option
Greg, Vadim,
The analysis for primary issue.
1. The testcase to get this bug(@uast/toggle_box/gui/tbx_static1.p@) is...
Eugenie Lyzenko
09:46 AM Bug #2742: Problems when using the SIZE option
Task branch @1811s@ for review updated to revision @10991@.
The small change to fix button text location issue in ...
Eugenie Lyzenko
10:39 AM Bug #2557: Fix MENUBAR layouting in a window
F3 focusing the menubar (fixed)
Open issues:
# Hiding bogus message.
# Focusing is still a problem.
# PUT SCREEN ...
Vadim Gindin
08:40 AM Bug #2705 (Closed): frame sizing using SIZE phrase is not honored
Greg Shah
07:07 AM Bug #2705: frame sizing using SIZE phrase is not honored
1811s rev 10988 fixes last two issues for this task (1 and 2 from note 9). Constantin Asofiei

10/18/2015

07:23 PM Bug #2742: Problems when using the SIZE option
This is the screen with fixed button size calculation. Testcase @uast/button/gui_btn_test25.p@ from revision @1382@. Eugenie Lyzenko
07:12 PM Bug #2742: Problems when using the SIZE option
Task branch @1811s@ for review updated to revision @10987@.
This is the GUI button fix for incorrect width/height ...
Eugenie Lyzenko
08:32 AM Bug #2742: Problems when using the SIZE option
Eugenie Lyzenko wrote:
> Task branch @1811s@ for review updated to revision @10986@.
>
> This is GUI button @impl...
Constantin Asofiei
10:21 PM Bug #2742: Problems when using the SIZE option
Task branch @1811s@ for review updated to revision @10986@.
This is GUI button @implicit/auto@ resize issue fix. T...
Eugenie Lyzenko
01:48 PM Feature #2560: implement GUI DIALOG-BOX support
2560a revision 10986 fixes the found ChUI regression. The problem was caused by a latent bug in browse's focus proces... Hynek Cihlar
10:53 AM Feature #2560: implement GUI DIALOG-BOX support
Greg Shah wrote:
> Code Review Task Branch 2560a Revision 10984
>
> I'm fine with the changes. I assume you'll j...
Hynek Cihlar
09:51 AM Feature #2560: implement GUI DIALOG-BOX support
Code Review Task Branch 2560a Revision 10984
I'm fine with the changes. I assume you'll javadoc and header them b...
Greg Shah
11:36 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Hynek, just to make sure that we are on the same page. The overridden @window()@ impelment...
Hynek Cihlar
05:36 AM Feature #2564: implement GUI BROWSE widget
Hynek, just to make sure that we are on the same page. The overridden @window()@ impelmentation posted in note 101 is... Stanislav Lomany
05:28 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> In order to lay out parent frame properly I have to explicitly set browse dimensions even ...
Hynek Cihlar

10/17/2015

07:13 PM Feature #2564: implement GUI BROWSE widget
In order to lay out parent frame properly I have to explicitly set browse dimensions even if browse size is implicit ... Stanislav Lomany
06:44 PM Bug #2705: frame sizing using SIZE phrase is not honored
Greg Shah wrote:
> > BUTTON implicit/auto-resize size is incorrect - can Eugenie take this part of the #2742 ?
>
...
Eugenie Lyzenko
10:15 AM Bug #2705: frame sizing using SIZE phrase is not honored
> BUTTON implicit/auto-resize size is incorrect - can Eugenie take this part of the #2742 ?
Yes. Eugenie, please t...
Greg Shah
10:07 AM Bug #2705: frame sizing using SIZE phrase is not honored
1811s rev 10985 completes dynamic widget layout started in 10983. Also, BUTTON default state is DISABLED.
The only...
Constantin Asofiei
09:38 AM Bug #2705: frame sizing using SIZE phrase is not honored
Eugenie, another issue about buttons: they should not be in "enabled" state by default. Constantin Asofiei
08:41 AM Bug #2705: frame sizing using SIZE phrase is not honored
Eugenie, can you point me to the rules you found to compute the width of the BUTTON in GUI (with label, image, label+... Constantin Asofiei
11:13 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Constantin, Greg, I found a regression if the window is opened we can't drag the task bar...
Greg Shah
11:06 AM Bug #2762: over-drawing problem with combo-box drop-down dismissal
This can be recreated in task branch 1811s. See #1811-1499 Greg Shah
11:05 AM Bug #2762 (Closed): over-drawing problem with combo-box drop-down dismissal
Greg Shah
10:59 AM Bug #2557: Fix MENUBAR layouting in a window
Are there any other issues listed above that are still a problem? Greg Shah
09:16 AM Feature #2560: implement GUI DIALOG-BOX support
Code Review Task Branch 2560a Revision 10980
I'm good with the changes.
Greg Shah
06:37 AM Feature #2560: implement GUI DIALOG-BOX support
One more chui regression from the last Majic test run, being fixed now. Hynek Cihlar
08:17 PM Feature #2560: implement GUI DIALOG-BOX support
Checked-in 2560a revision 10980:
* addressed the points from review,
* fixed all failed chui tests from the last ...
Hynek Cihlar

10/16/2015

06:07 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Constantin, there is the bug it is easy to decrease the window size but it is difficult t...
Constantin Asofiei
05:33 PM Feature #1811: implement the AJAX client driver
Constantin, there is the bug it is easy to decrease the window size but it is difficult to increase it again. It is d... Sergey Ivanovskiy
04:04 PM Feature #1811: implement the AJAX client driver
Task branch @1811s@ for review updated to revision @10984@.
Adding @TODO@ comments in both @GenericFrame@(setters ...
Eugenie Lyzenko
03:51 PM Feature #1811: implement the AJAX client driver
Constantin, Greg, I found a regression if the window is opened we can't drag the task bar. It is due to @function pro... Sergey Ivanovskiy
03:21 PM Feature #1811: implement the AJAX client driver
Committed revision 10982 added this comment that @putImageData@ uses @(x,y)@ canvas coordinates. Sergey Ivanovskiy
03:01 PM Feature #1811: implement the AJAX client driver
> since CanvasRenderer.putImageData is used with prepared actual point (x, y)
Are you saying that it is safe becau...
Greg Shah
02:43 PM Feature #1811: implement the AJAX client driver
> It is good. The only concern I have is whether the @getImageData()@ should honor the current transform for X and Y... Sergey Ivanovskiy
02:36 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811s Revision 10980
It is good. The only concern I have is whether the @getImageData()@ ...
Greg Shah
02:30 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Review for 1811s rev 10977: although this fixes @calc.p@, I'm s...
Greg Shah
02:28 PM Feature #1811: implement the AJAX client driver
Committed revision 10980 should support new composite drawing ops for web. Sergey Ivanovskiy
02:20 PM Feature #1811: implement the AJAX client driver
Eugenie Lyzenko wrote:
> Hynek,
>
> >You shouldn't set the size of frameScroll as it should always be the size of...
Hynek Cihlar
02:13 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> At first I have lost this exception in the client log
> [...]
This one is mine, for som...
Constantin Asofiei
02:11 PM Feature #1811: implement the AJAX client driver
At first I have lost this exception in the client log... Sergey Ivanovskiy
02:08 PM Feature #1811: implement the AJAX client driver
> The testcase for XOR is @uast/browse/gui/browse-gui-stat1.p@. If you need designed fonts too, there is @fonts-table... Sergey Ivanovskiy
02:01 PM Feature #1811: implement the AJAX client driver
Hynek,
>You shouldn't set the size of frameScroll as it should always be the size of its parent (and thus follow t...
Eugenie Lyzenko
01:45 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Review for 1811s rev 10977: although this fixes @calc.p@, I'm still concerned that we ha...
Hynek Cihlar
01:38 PM Feature #1811: implement the AJAX client driver
Review for 1811s rev 10977: although this fixes @calc.p@, I'm still concerned that we have different logic executed w... Constantin Asofiei
01:37 PM Feature #1811: implement the AJAX client driver
Eugenie Lyzenko wrote:
> Task branch @1811s@ for review updated to revision @10978@.
>
> This is the fix for @dem...
Hynek Cihlar
01:33 PM Feature #1811: implement the AJAX client driver
Eugenie Lyzenko wrote:
> Warning! The @1811s@ revision @10977@ has a regression in @FillInGuimpl@ with foreground te...
Constantin Asofiei
01:17 PM Feature #1811: implement the AJAX client driver
Warning! The @1811s@ revision @10977@ has a regression in @FillInGuimpl@ with foreground text color.
The screen is...
Eugenie Lyzenko
01:04 PM Feature #1811: implement the AJAX client driver
Task branch @1811s@ for review updated to revision @10978@.
This is the fix for @demo/calc.p@. Now it works.
Eugenie Lyzenko
12:34 PM Feature #1811: implement the AJAX client driver
Nice catch Sergey! Revision 10977 removes the setting of @tabIndex@. I don't see any other bad consequences of this... Greg Shah
12:09 PM Feature #1811: implement the AJAX client driver
The testcase for XOR is @uast/browse/gui/browse-gui-stat1.p@. If you need designed fonts too, there is @fonts-table.t... Stanislav Lomany
11:07 AM Feature #1811: implement the AJAX client driver
Greg, please could you provide me with the 4GL program where the XOR composite is used to test the XOR code? It is us... Sergey Ivanovskiy
09:48 AM Feature #1811: implement the AJAX client driver
> I don't want anything rolled back just yet.
>
> > The document event handlers were added to allow window resize:...
Sergey Ivanovskiy
08:31 AM Feature #1811: implement the AJAX client driver
I don't want anything rolled back just yet.
> The document event handlers were added to allow window resize: the c...
Greg Shah
08:26 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Have you noticed that the currently selected canvas now has a selection highlight around it? I t...
Sergey Ivanovskiy
08:11 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Have you noticed that the currently selected canvas now has a selection highlight around it? I t...
Constantin Asofiei
08:09 AM Feature #1811: implement the AJAX client driver
Have you noticed that the currently selected canvas now has a selection highlight around it? I think this started re... Greg Shah
07:57 AM Feature #1811: implement the AJAX client driver
Before the rev 10974 this redraw bug is present. 1) Run demo_widgets.p 2) Select item from the fist combobox 3) The r... Sergey Ivanovskiy
07:44 AM Feature #1811: implement the AJAX client driver
Committed revision 10974 prepared for review, added the dot large stroke style and refactored @CanvasRenderer@ and @L... Sergey Ivanovskiy
06:18 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > To eliminate developing deadlock planning to implement cutLi...
Sergey Ivanovskiy
06:11 AM Feature #1811: implement the AJAX client driver
> Sergey, I've just noticed something: @ctx.putImageData@ is called from @p2j.strokes.js@:
> # @DotsPathRenderer.app...
Sergey Ivanovskiy
05:20 AM Feature #1811: implement the AJAX client driver
Sergey, I've just noticed something: @ctx.putImageData@ is called from @p2j.strokes.js@:
# @DotsPathRenderer.applySt...
Constantin Asofiei
05:10 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> To eliminate developing deadlock planning to implement cutLine and cutRectangle function ...
Constantin Asofiei
04:55 AM Feature #1811: implement the AJAX client driver
To eliminate developing deadlock planning to implement cutLine and cutRectangle function to intersect with clipping r... Sergey Ivanovskiy
04:34 AM Feature #1811: implement the AJAX client driver
Constantin, what do you think it is correct to check clipping regions at the upper level to place it inside each of t... Sergey Ivanovskiy
04:21 AM Feature #1811: implement the AJAX client driver
Constantin, Greg, I am planning to fix inconsistency in the JS clipping region processing. Please, look at usages of ... Sergey Ivanovskiy
03:44 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Greg Shah wrote:
> > Constantin: would you please do a code review of the changes? I'm...
Constantin Asofiei
10:12 PM Feature #1811: implement the AJAX client driver
Task branch @1811s@ for review updated to revision @10973@.
This is the small fix for combo-box drop-down button w...
Eugenie Lyzenko
04:45 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Window may not be available in @afterConfigUpdate@.
Yes, this is true. Just don't call...
Hynek Cihlar
03:58 PM Feature #2564: implement GUI BROWSE widget
Does usage of this function seems valid to you, guys? Window may not be available in @afterConfigUpdate@. ... Stanislav Lomany
02:55 PM Feature #2564: implement GUI BROWSE widget
Hynek Cihlar wrote:
> Stanislav, before I forget. I noticed that you resolve the main window in @BrowseGuiImpl@ and ...
Constantin Asofiei
02:53 PM Feature #2564: implement GUI BROWSE widget
Stanislav, before I forget. I noticed that you resolve the main window in @BrowseGuiImpl@ and @BrowseColumnGuiImpl@ t... Hynek Cihlar
02:50 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Constantin, consider the components:
> [...]
>
> Column sets are registered using
> [...
Constantin Asofiei
02:43 PM Feature #2564: implement GUI BROWSE widget
Constantin, consider the components:... Stanislav Lomany
02:27 PM Feature #2564: implement GUI BROWSE widget
Stanislav, the abend in 1811 note 1516 is caused by the fact that @BrowseGuiImpl.rebuildColumns@ creates a scrollpane... Constantin Asofiei
09:43 AM Feature #2564: implement GUI BROWSE widget
Found additional issue related to item 5: keys misbehavior when the current row is out of the view. Stanislav Lomany
03:41 PM Bug #2705: frame sizing using SIZE phrase is not honored
From note 4, issues 1 and 2 are solved in 1811s rev 10983. Also, some NPEs related to LABEL assignment before the d... Constantin Asofiei
03:34 PM Bug #2705: frame sizing using SIZE phrase is not honored
New issue: width for BUTTON widget with LABEL is not computed correct (it uses a @text-length * font-width@ formula i... Constantin Asofiei
02:14 PM Bug #2705: frame sizing using SIZE phrase is not honored
For issue in note 2: after changing @frbtn.p@ to remove unsupported features in 1811s (default/cancel-button, alert-b... Constantin Asofiei
01:43 PM Bug #2705 (WIP): frame sizing using SIZE phrase is not honored
The issue in note 1 is solved in #2704 Constantin Asofiei
03:13 PM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> If you remove the MESSAGE statement from this testcase, then will Progress generate the "Runtime ...
Vadim Gindin
02:50 PM Bug #2557: Fix MENUBAR layouting in a window
> I beg your pardon, I probably wasn't enough clear. PROGRESS shows "Runtime error in WAIT-FOR..." warning in cases w... Greg Shah
02:36 PM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> > Yes. Behaviour is the same.
>
> So the MESSAGE statement has nothing to do with this problem...
Vadim Gindin
11:36 AM Bug #2557: Fix MENUBAR layouting in a window
> Yes. Behaviour is the same.
So the MESSAGE statement has nothing to do with this problem?
What about when you...
Greg Shah
10:04 AM Bug #2557: Fix MENUBAR layouting in a window
Greg Shah wrote:
> 1. Is this problem in ChUI only or also in GUI?
This problem happen in GUI.
> 2. You state ...
Vadim Gindin
08:41 AM Bug #2557: Fix MENUBAR layouting in a window
1. Is this problem in ChUI only or also in GUI?
2. You state this:
> PROGRESS shows bogus message in a window w...
Greg Shah
01:33 PM Bug #2704: large fill-in drawing differences
Greg Shah wrote:
> What is the plan to fix the issue in note 7? SENSITIVE is definitely used heavily in GUI so it i...
Constantin Asofiei
10:45 AM Bug #2704: large fill-in drawing differences
1811s rev 10976 improves content placement for FILL-IN; there are these notes:
# once we fix the #2727 for right-ali...
Constantin Asofiei
09:03 AM Bug #2704: large fill-in drawing differences
Greg Shah wrote:
> Is the issue in note 2 still open?
Yes, I think I'll have a fix soon.
> What is the plan to ...
Constantin Asofiei
08:46 AM Bug #2704: large fill-in drawing differences
Is the issue in note 2 still open?
What is the plan to fix the issue in note 7? SENSITIVE is definitely used heav...
Greg Shah
01:19 PM Bug #2730 (Closed): taller than default fill-in height causes text to be vertically mis-positioned
Greg Shah
12:49 PM Bug #2730: taller than default fill-in height causes text to be vertically mis-positioned
This is solved part of #2704 , 1811s rev 10976. It can be closed. Constantin Asofiei
02:21 AM Bug #2730 (WIP): taller than default fill-in height causes text to be vertically mis-positioned
Constantin Asofiei
12:52 PM Bug #2714: demo/calc.p is broken
A bit modified fix(accurate height calculation). Going to commit in @1811s@ now Eugenie Lyzenko
12:04 PM Bug #2714: demo/calc.p is broken
The main issue is in @GenericFrame.set(Width|Height)(Chars|Pixels)@ methods. If we set the width or height by changin... Eugenie Lyzenko
10:59 AM Bug #2714: demo/calc.p is broken
Eugenie, I think the problem is in @Frame.postprocess:3145@:... Constantin Asofiei
08:43 AM Bug #2714: demo/calc.p is broken
I've added Hynek and Constantin as watchers. They may have some ideas. Greg Shah
09:57 PM Bug #2714: demo/calc.p is broken
Debugging the issue. The situation become event more strange, the screen is attached.
The findings. At least one b...
Eugenie Lyzenko
11:27 AM Feature #2560: implement GUI DIALOG-BOX support
> I need to find the right use case and then decide how to deal with the TODO. I wouldn't want to delay the intergat... Greg Shah
11:23 AM Feature #2560: implement GUI DIALOG-BOX support
Greg Shah wrote:
> Code Review Task Branch 2560a Revision 10976
>
> Generally, I don't have many issues with this up...
Hynek Cihlar
11:00 AM Feature #2560: implement GUI DIALOG-BOX support
Code Review Task Branch 2560a Revision 10976
Generally, I don't have many issues with this update.
1. Our windo...
Greg Shah
08:27 AM Bug #2760: SwingEmulatedWindow.moveToTop() in Swing forces focus to shift to the window that has ...
See also #1811-1490 Greg Shah
08:16 AM Bug #2760: SwingEmulatedWindow.moveToTop() in Swing forces focus to shift to the window that has ...
A simple testcase to use is @frame-z-order/zw1.p@. This allows you to invoke the @MOVE-TO-TOP()@ and @MOVE-TO-BOTTOM... Greg Shah
08:13 AM Bug #2760 (New): SwingEmulatedWindow.moveToTop() in Swing forces focus to shift to the window tha...
Greg Shah
08:23 AM Feature #1801: add some frame options
Greg Shah wrote:
> OK, implement your approach.
Thank you. I'm working on this now.
Igor Skornyakov
08:11 AM Feature #1801: add some frame options
OK, implement your approach. Greg Shah
07:55 AM Feature #1801: add some frame options
Greg Shah wrote:
> Please describe how it would be used.
>
> > and @addBackgroundWidget()@ method to the CommonFr...
Igor Skornyakov
07:28 AM Feature #1801: add some frame options
> I suggest to add background flag to the BaseConfig
Please describe how it would be used.
> and @addBackground...
Greg Shah
06:00 AM Feature #1801: add some frame options
I suggest to add @background@ flag to the @BaseConfig@ and @addBackgroundWidget()@ method to the @CommonFrame@ interf... Igor Skornyakov
05:37 AM Feature #1801: add some frame options
The conversion of the @BACKGROUND@ clause of the @DEFINE FRAME@ statement seems to be changed to support the @BACKGRO... Igor Skornyakov
04:50 AM Feature #1801: add some frame options
@CANCEL-BUTTON@/@DEFAULT-BUTTON@ runtime support is done.
Committed to the branch 2272b revno 11013.
Igor Skornyakov

10/15/2015

07:09 PM Feature #1801: add some frame options
@ESCAPE@ is now correctly routed to the @ON CHOOSE@ trigger of the @CANCEL-BUTTON@.
Committed to branch 2272b revn...
Igor Skornyakov
05:34 AM Feature #1801: add some frame options
Implemented setters for the @THREE-D@ attribute.
Committed to the branch 2272b revno 11006
Igor Skornyakov
04:58 AM Feature #1801: add some frame options
Added support for the @STREAM-IO@ (and related @SCREEN-IO@ and @USE-TEXT@) options for @FRAME@ (including config fiel... Igor Skornyakov
06:45 PM Feature #2560: implement GUI DIALOG-BOX support
Rebased task branch 2560a from P2J trunk revision 10947. The current revision in 2560a is now 10974. Hynek Cihlar
06:21 PM Feature #2564: implement GUI BROWSE widget
Current status:
5. vertical scrolling with mouse (currently keys only) - *implemented* (still need to revisit it in ...
Stanislav Lomany
08:31 AM Feature #2564: implement GUI BROWSE widget
> when do you expect to have a look how browse works in production/demonstation?
As soon as 2560a is merged to tru...
Greg Shah
07:35 AM Feature #2564: implement GUI BROWSE widget
BTW when do you expect to have a look how browse works in production/demonstation? Stanislav Lomany
07:32 AM Feature #2564: implement GUI BROWSE widget
Current status:
0. random crashes "widget is not attached to the top-level window" - hope that Hynek works on that.
...
Stanislav Lomany
04:32 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Constantin: would you please do a code review of the changes? I'm especially worried about the @...
Constantin Asofiei
04:15 PM Feature #1811: implement the AJAX client driver
Revision 10972 implements moveToTop()/moveToBottom() at the driver level. A useful testcase is @frame-z-order/zw1.p@... Greg Shah
03:59 PM Feature #1811: implement the AJAX client driver
Regressions in notes 1483 and 1485 are fixed in 1811s rev 10971 - I've checked both ask-gui.p and demo_widgets.p. Constantin Asofiei
03:53 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> 1811s rev 10969 fixes the frame scroll issue and fill-in size in #2752 and #2704.
Con...
Eugenie Lyzenko
03:37 PM Feature #1811: implement the AJAX client driver
regression in note 1483 is from 1811s rev 10969 - I'm looking into it. Constantin Asofiei
03:35 PM Feature #1811: implement the AJAX client driver
!demo_widget_regression.png! Sergey Ivanovskiy
02:53 PM Feature #1811: implement the AJAX client driver
If I recall correctly, direct drawing of pixels using @putImageData()@ does not honor compositing. It just overwrite... Greg Shah
02:49 PM Feature #1811: implement the AJAX client driver
Ok, planning to implement XOR (https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/globalCompos... Sergey Ivanovskiy
02:33 PM Feature #1811: implement the AJAX client driver
OK, we are going to postpone further work on this until later. The client is working well enough for now. We have t... Greg Shah
02:29 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > Based on your results, how much of the delays are due to the Java r...
Sergey Ivanovskiy
12:15 PM Feature #1811: implement the AJAX client driver
Added tests diff. Sergey Ivanovskiy
12:11 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Based on your results, how much of the delays are due to the Java round trip?
The java side dela...
Sergey Ivanovskiy
11:18 AM Feature #1811: implement the AJAX client driver
Based on your results, how much of the delays are due to the Java round trip? Greg Shah
11:07 AM Feature #1811: implement the AJAX client driver
Added keys measure tests diff. Planning to measure the time between WebGuiDriver readKey and setCurrentSelection invo... Sergey Ivanovskiy
10:58 AM Feature #1811: implement the AJAX client driver
> > I think it is important to try to measure the time between sending a given key to the Java side and when the draw... Sergey Ivanovskiy
10:09 AM Feature #1811: implement the AJAX client driver
> I think it is important to try to measure the time between sending a given key to the Java side and when the drawin... Sergey Ivanovskiy
09:56 AM Feature #1811: implement the AJAX client driver
> If we press rapidly keys the browser gui thread becomes frozen, but after several seconds of inactivity all pressed... Greg Shah
09:45 AM Feature #1811: implement the AJAX client driver
1811s rev 10969 fixes the frame scroll issue and fill-in size in #2752 and #2704. Constantin Asofiei
09:32 AM Feature #1811: implement the AJAX client driver
> Is the key processing lag caused by drawing performance issues?
If we press rapidly keys the browser gui thread bec...
Sergey Ivanovskiy
09:02 AM Feature #1811: implement the AJAX client driver
> Decided to stop developing this idea.
It was a good idea to try.
Is the key processing lag caused by drawing ...
Greg Shah
08:56 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> It is interesting to check how the web drawing performance is changed if @CanvasRenderer.p...
Sergey Ivanovskiy
05:02 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> The standard demo_widgets.p at login produces the attached web screen without the combo b...
Constantin Asofiei
04:07 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> The standard demo_widgets.p at login produces the attached web screen without the combo b...
Constantin Asofiei
02:43 AM Feature #1811: implement the AJAX client driver
Eugenie Lyzenko wrote:
> Constantin,
>
> I'm not sure this question for you or not, just saw you works on font im...
Constantin Asofiei
04:25 PM Bug #2557: Fix MENUBAR layouting in a window
I'm recalling. Issue 1. Progress shows "bogus .. " message and does not show standard "Run-time error in WAIT-FOR.. "... Vadim Gindin
03:34 PM Bug #2704: large fill-in drawing differences
Constantin Asofiei wrote:
> Greg Shah wrote:
>
> > For the same code, the P2J window is smaller in both dimension...
Constantin Asofiei
02:40 PM Bug #2704: large fill-in drawing differences
Greg Shah wrote:
> For the same code, the P2J window is smaller in both dimensions. The difference is larger in hei...
Constantin Asofiei
02:30 PM Bug #2704: large fill-in drawing differences
There is one more issue here: using the @SENSITIVE@ attribute to enable a widget must not make it current focus (focu... Constantin Asofiei
12:47 PM Bug #2704: large fill-in drawing differences
After using 1811s rev 10969 AND loaded the custom fonts in the directory, I get this:
!ask-gui.p_window_sizes_p2j_...
Greg Shah
09:43 AM Bug #2704: large fill-in drawing differences
Issue in note 1 is fixed in 1811s rev 10969. Working on issue in note 2. Constantin Asofiei
07:24 AM Bug #2704 (WIP): large fill-in drawing differences
Constantin Asofiei
02:43 PM Feature #2513 (Closed): implement GUI runtime support for TOGGLE-BOX
Greg Shah
02:37 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
The branch is merged to trunk as rev 10947 Vadim Gindin
02:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
OK, I've just run at by hand and all works, login/logout and tc_codes_employees_016. Vadim Gindin
02:21 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Wait. I just looked at the results zip you posted. The failures occur on thread Driver 0. The actual tests login, ... Greg Shah
02:14 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Please just test this by hand (NOT with run_single.sh). Greg Shah
02:02 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> I have quite a bit to do other than this right now. Can you please tell me what you have found. ...
Vadim Gindin
12:54 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I have quite a bit to do other than this right now. Can you please tell me what you have found. I assume you have t... Greg Shah
12:49 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Here is the full results report. Have a look. Vadim Gindin
12:15 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
How did tc_codes_employees_016 pass if login failed? Greg Shah
12:12 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Ok, here are 2 files with results for both failed tests. Once again, I ran @run_regression.sh server-startup@ and the... Vadim Gindin
12:03 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> Now would you insist for me to run it by hand
No, but I do want to understand why login/logout failed.
> cli...
Greg Shah
11:59 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I used run_single.sh... I didn't understand you correctly. Now would you insist for me to run it by hand (i.e. server... Vadim Gindin
11:53 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> login_to_main_menu and logout_from_main_menu have failed.
What do you mean?
Weren't you testing manually?
Greg Shah
11:46 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I did it. tc_codes_employees_016 has passed. login_to_main_menu and logout_from_main_menu have failed. Vadim Gindin
11:04 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
It is documented in the timco.html.
The first two items are both done with a single command: @run_regression.sh se...
Greg Shah
10:47 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> This could happen due to timing and the lack of proper dependency encoding in our tests for this ...
Vadim Gindin
10:35 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
This could happen due to timing and the lack of proper dependency encoding in our tests for this case. It looks to m... Greg Shah
10:27 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Yes, it fails. Vadim Gindin
10:19 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Here is testing result of failed test tc_codes_employees.txt attached. It contains the test sc...
Constantin Asofiei
10:14 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Here is testing result of failed test tc_codes_employees.txt attached. It contains the test screen and expected scree... Vadim Gindin
12:23 PM Bug #2752 (Closed): ask-gui.p frame has scrollbars when it should not
Greg Shah
09:42 AM Bug #2752: ask-gui.p frame has scrollbars when it should not
#2752 and #2704 are the same issue. Fixed in 1811s rev 10969. Constantin Asofiei
07:48 AM Bug #2752 (WIP): ask-gui.p frame has scrollbars when it should not
There is an interesting issue here: in P2J, the frame layout is done with a window size of 80 chars. But in 4GL, the... Constantin Asofiei
12:22 PM Bug #2701: default font text sizing issue
BTW, in the directory entries above, I think "Segue UI" should be "Segoe UI". Greg Shah
10:46 AM Bug #2701: default font text sizing issue
> a question about the .ttf files in server/fonts - except the excelsior version, all are taken from the Windows fon... Greg Shah
10:10 AM Bug #2701: default font text sizing issue
Greg Shah wrote:
> Someone that is already licensed to those files *may* be able to use them with P2J (if we support...
Constantin Asofiei
09:31 AM Bug #2701: default font text sizing issue
Greg Shah wrote:
> In what ways does the default 4GL GUI environment depend on this font?
4GL depends on bitmap fon...
Constantin Asofiei
09:29 AM Bug #2701: default font text sizing issue
> So is it acceptable (in licensing/copyright terms) to take the .fon files from Windows and converting them to .ttf?... Greg Shah
05:34 AM Bug #2701: default font text sizing issue
About bitmap fonts in general; what they did for wine is use FontForge to transform the bitmap (.fon) files to true-t... Constantin Asofiei
09:08 AM Bug #2703: VIEW of a dynamic widget abends
This is the same problem as noted in #2754. The solution needs to be generic.
The @screen-value@ may be a trick...
Greg Shah
09:01 PM Bug #2703: VIEW of a dynamic widget abends
The root cause is in the sample:... Eugenie Lyzenko
08:59 AM Bug #2741: SELECTION-LIST sizing issues
OK, then item 2 is considered fixed.
Igor will handle the rest of the items later.
Greg Shah
08:54 AM Bug #2741: SELECTION-LIST sizing issues
The modified code:... Eugenie Lyzenko
08:33 AM Bug #2741: SELECTION-LIST sizing issues
And is BGCOLOR 1 the same blue color shown there? I guess you can test that by using color 1 on a rectangle. Greg Shah
08:29 AM Bug #2741: SELECTION-LIST sizing issues
Greg Shah wrote:
> > Take a look at the picture. Is it now OK?
>
> There is no editor in that picture, so I can't t...
Eugenie Lyzenko
08:19 AM Bug #2741: SELECTION-LIST sizing issues
> Do you mean: 2. EDITOR ignores BGCOLOR attribute in the GUI mode?
Yes.
> Take a look at the picture. Is it no...
Greg Shah

10/14/2015

07:58 PM Feature #1811: implement the AJAX client driver
Constantin,
I'm not sure this question for you or not, just saw you works on font implementation. Today after reba...
Eugenie Lyzenko
05:41 PM Feature #1811: implement the AJAX client driver
It is interesting to check how the web drawing performance is changed if @CanvasRenderer.prototype.drawPixel = functi... Sergey Ivanovskiy
04:52 PM Feature #1811: implement the AJAX client driver
The standard demo_widgets.p at login produces the attached web screen without the combo box label. If we open its ite... Sergey Ivanovskiy
03:53 PM Feature #1811: implement the AJAX client driver
Rebased task branch 1811s from P2J trunk revision 10946. The current revision in 1811s is now 10967. Greg Shah
03:26 PM Feature #1811: implement the AJAX client driver
Task branch @1811s@ for review updated to revision @10966@.
The fix for SELECTION-LIST sizing issues. The importan...
Eugenie Lyzenko
03:15 PM Feature #1811: implement the AJAX client driver
May be it is the same thing. Ok, I will focus on performance lag. Sergey Ivanovskiy
03:10 PM Feature #1811: implement the AJAX client driver
>> I assume you will work on the key performance issue next?
>
> Created this difficult #2759 task and planning to ...
Greg Shah
03:07 PM Feature #1811: implement the AJAX client driver
> > There is a general problem if we press keys rapidly, the browser ui thread can come in to the stale state or froz... Sergey Ivanovskiy
02:21 PM Feature #1811: implement the AJAX client driver
1811s rev -10956- 10965 contains a change in custom font management: if the font is BOLD and there is no custom defin... Constantin Asofiei
02:13 PM Feature #1811: implement the AJAX client driver
> There is a general problem if we press keys rapidly, the browser ui thread can come in to the stale state or frozen... Greg Shah
02:04 PM Feature #1811: implement the AJAX client driver
> Is the "no selection" case fixed at this point or is there still a problem?
It isn't reproduced now, the problem i...
Sergey Ivanovskiy
02:01 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> > there are unexpected scollbars in ask-gui.p, with 1811s.
>
> Are you referring to the same ...
Constantin Asofiei
01:59 PM Feature #1811: implement the AJAX client driver
> there are unexpected scollbars in ask-gui.p, with 1811s.
Are you referring to the same problem as noted in #2752 ?
Greg Shah
01:56 PM Feature #1811: implement the AJAX client driver
Hynek, there are unexpected scollbars in @ask-gui.p@, with 1811s. Constantin Asofiei
01:20 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811s Revision 10964
It looks good.
Is the "no selection" case fixed at this point or i...
Greg Shah
12:35 PM Feature #1811: implement the AJAX client driver
Committed revision 10964 is prepared for review. Sergey Ivanovskiy
11:51 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811s Revision 10963
It looks good.
Greg Shah
11:18 AM Feature #1811: implement the AJAX client driver
Task branch @1811s@ for review updated to revision @10963@.
Fix for message area scrollbar buttons. Had to modify ...
Eugenie Lyzenko
10:41 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811s Revision 10961
I made some minor cleanups, checked in as 10962.
1. @p2j.clipboard.js@...
Greg Shah
09:51 AM Feature #1811: implement the AJAX client driver
> Sergey: If your code is safe to check in, perhaps you should commit it so that we can both be looking at the same s... Sergey Ivanovskiy
09:33 AM Feature #1811: implement the AJAX client driver
Committed revision 10960 should fix auto-repeats for the web client and "code cleanup" is here. Sergey Ivanovskiy
08:42 AM Feature #1811: implement the AJAX client driver
> Sergey, I don't recall exactly, but I think keeping a cursor arrow pressed (i.e. right-arrow in a editor) used to w... Sergey Ivanovskiy
08:19 AM Feature #1811: implement the AJAX client driver
> Sergey: If your code is safe to check in, perhaps you should commit it so that we can both be looking at the same s... Sergey Ivanovskiy
08:10 AM Feature #1811: implement the AJAX client driver
Sergey: If your code is safe to check in, perhaps you should commit it so that we can both be looking at the same sou... Greg Shah
08:09 AM Feature #1811: implement the AJAX client driver
> I have checked that the current version 10958 generates copy/cut/paste events correctly.
This is true even when ...
Greg Shah
08:05 AM Feature #1811: implement the AJAX client driver
> > if there are no current selection and we press CTRL + C/CTRL + Insert it invokes the unimplemented method sendCli... Sergey Ivanovskiy
07:58 AM Feature #1811: implement the AJAX client driver
> if there are no current selection and we press CTRL + C/CTRL + Insert it invokes the unimplemented method sendClipb... Greg Shah
07:39 AM Feature #1811: implement the AJAX client driver
> Sergey, I don't recall exactly, but I think keeping a cursor arrow pressed (i.e. right-arrow in a editor) used to w... Sergey Ivanovskiy
07:15 AM Feature #1811: implement the AJAX client driver
1811s rev 10958 finishes window resize in Web.
Sergey, I don't recall exactly, but I think keeping a cursor arrow ...
Constantin Asofiei
06:08 PM Bug #2741: SELECTION-LIST sizing issues
Do you mean: @2. EDITOR ignores BGCOLOR attribute in the GUI mode@? Take a look at the picture. Is it now OK(no fixes... Eugenie Lyzenko
05:13 PM Bug #2741: SELECTION-LIST sizing issues
Only work on item 2. Then move to other assigned tasks. Greg Shah
05:07 PM Bug #2741: SELECTION-LIST sizing issues
>Is it quick to fix items 1, 3, 5 and 6?
It is difficult to exactly estimate. I think it can take a day to complete(...
Eugenie Lyzenko
04:44 PM Bug #2741: SELECTION-LIST sizing issues
Is it quick to fix items 1, 3, 5 and 6? If not, those can be deferred and Igor will work them after #2038.
Item 2...
Greg Shah
03:47 PM Bug #2741: SELECTION-LIST sizing issues
Greg Shah wrote:
> I assume revision 10966 in 1811s fixes item 4 above.
Yes.
>Does it fix any of the other items...
Eugenie Lyzenko
03:32 PM Bug #2741: SELECTION-LIST sizing issues
I assume revision 10966 in 1811s fixes item 4 above. Does it fix any of the other items?
If not, please do fix th...
Greg Shah
03:29 PM Bug #2741: SELECTION-LIST sizing issues
The fix committed in @1811s@. The screen is attached. Eugenie Lyzenko
03:38 PM Bug #2701: default font text sizing issue
> But this disables anti-aliasing for the entire browser... the only good news is with antialiasing off, the text is ... Greg Shah
03:18 PM Bug #2701: default font text sizing issue
Only way until now to disable anti-aliasing on Firefox is by placing a @~/.fonts.conf@ file with this content:... Constantin Asofiei
02:40 PM Bug #2701: default font text sizing issue
1811s plus testcases project rev 1378 (almost) solved this issue. For Swing, the test is identical, but for Web, the... Constantin Asofiei
03:11 PM Bug #2759: the key input becomes frozen (no deadlock) if the keys are pressed rapidly
Moved "Description" text to here:
1)Open web client for simple server running testcases/uast/demo/demo_widgets.p.
...
Greg Shah
02:52 PM Bug #2759 (New): the key input becomes frozen (no deadlock) if the keys are pressed rapidly
Sergey Ivanovskiy
02:40 PM Feature #1794: implement font support
See #2701 note 4 for font replacements via custom-fonts. Constantin Asofiei
02:23 PM Bug #2557: Fix MENUBAR layouting in a window
Any needed changes should be put into 1811s. Greg Shah
02:23 PM Bug #2736: fix GUI menu drawing problems in menu/simple_sm.p
Put your changes into task branch 1811s. Greg Shah
02:09 PM Feature #1801: add some frame options
Hynek, here is the priority for your items:
1. SCROLLABLE
2. BORDER-*
3. VIRTUAL-*
4. SCROLL-BARS
5. TOP-ONLY
Greg Shah
02:05 PM Feature #1801: add some frame options
Greg Shah wrote:
> Igor, this means your work is for these (complete them in this priority order):
>
> 1. Finish ...
Igor Skornyakov
02:03 PM Feature #1801: add some frame options
Igor, this means your work is for these (complete them in this priority order):
1. Finish CANCEL-BUTTON.
2. BACKG...
Greg Shah
12:13 PM Feature #1801: add some frame options
I would take BORDER-*, VIRTUAL-*, SCROLL-BARS, SCROLLABLE, TOP-ONLY. I think we should prioritize. Hynek Cihlar
11:42 AM Feature #1801: add some frame options
Hynek: please propose which of these would be best for you to take.
We also need to identify the priority for thes...
Greg Shah
11:21 AM Feature #1801: add some frame options
Greg Shah wrote:
> It is my understanding that all conversion items are resolved as of the current 2272b branch 1100...
Igor Skornyakov
10:57 AM Feature #1801: add some frame options
It is my understanding that all conversion items are resolved as of the current 2272b branch 11000.
Please summari...
Greg Shah
02:03 PM Feature #2373: implemented output to redirected, paged terminal via (un)named streams in GUI mode
In #1801, we implemented conversion support for STREAM-IO. The runtime support needs to be implemented in this task. Greg Shah
12:54 PM Feature #2564: implement GUI BROWSE widget
Reproduction:
# Run go.p.
# Run brws-size-implicit-dyn from it.
# Click on the right arrow of the bottom scrollbar...
Stanislav Lomany
12:39 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> I'll post the testcase here.
Please do.
Hynek Cihlar
12:38 PM Feature #2564: implement GUI BROWSE widget
"widget is not attached to the top-level window" will be resolved as part of 2560a. I already have some fixes for this. Hynek Cihlar
12:36 PM Feature #2564: implement GUI BROWSE widget
Guys, the issue random crashes "widget is not attached to the top-level window" is actually a bunch of issues caused ... Stanislav Lomany
11:45 AM Feature #2564: implement GUI BROWSE widget
I also need to know 2-3 useful GUI browse testcases that we should add to our GUI regression testing list. Greg Shah
11:44 AM Feature #2564: implement GUI BROWSE widget
OK, in branch 2564c:
* all the items from note 84
* font metrics and FontManager.getBrowseCellBottomTextOffset() ...
Greg Shah
11:29 AM Feature #2564: implement GUI BROWSE widget
Because of constant debugging I was unable to complete original tasks:
0. WIP - random crashes "widget is not attach...
Stanislav Lomany
11:09 AM Feature #2564: implement GUI BROWSE widget
The following items are high priority:
* font metrics and @FontManager.getBrowseCellBottomTextOffset()@ analysis
...
Greg Shah
11:06 AM Feature #2564: implement GUI BROWSE widget
Task branch 2564a committed into the trunk as bzr revision 10946. Stanislav Lomany
10:37 AM Feature #2564: implement GUI BROWSE widget
Greg Shah wrote:
> 1. I not sure the @getBrowseCellBottomTextOffset()@ belongs in @FontManager@. On the one hand, t...
Constantin Asofiei
10:25 AM Feature #2564: implement GUI BROWSE widget
Ad item to from note 69.
Stanislav, please check whether key events and/or scroll events are repeated when the ke...
Hynek Cihlar
10:05 AM Feature #2564: implement GUI BROWSE widget
> Hynek: do you have any thoughts regarding the issues reported in note 69?
I've fixed item 3 by changes in browse c...
Stanislav Lomany
09:29 AM Feature #2564: implement GUI BROWSE widget
Hynek: do you have any thoughts regarding the issues reported in note 69? Greg Shah
09:28 AM Feature #2564: implement GUI BROWSE widget
> I not sure the getBrowseCellBottomTextOffset() belongs in FontManager. On the one hand, there is logic that is fon... Greg Shah
09:18 AM Feature #2564: implement GUI BROWSE widget
> The 2564b changes are all merged into 2272b, right?
Yes.
> I think 2564b can be archived.
Done.
Stanislav Lomany
09:15 AM Feature #2564: implement GUI BROWSE widget
Code Review Task Branch 2564a Revision 10969
This is really impressive. Please merge to trunk immediately. The f...
Greg Shah
08:32 AM Feature #2564: implement GUI BROWSE widget
The 2564b changes are all merged into 2272b, right? I think 2564b can be archived. Greg Shah
08:29 AM Feature #2564: implement GUI BROWSE widget
Wow! OK, I'll get the code review done ASAP. Greg Shah
08:14 AM Feature #2564: implement GUI BROWSE widget
The update passed conversion and regression testing. Stanislav Lomany
06:50 AM Feature #2564: implement GUI BROWSE widget
Please review branch 2564a revision 10969. Stanislav Lomany
12:49 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Code Review Task Branch 2513b Revision 10957
It looks good. Please start testing immediately.
Greg Shah
12:16 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've rebased the branch just now. Please review. Vadim Gindin
12:09 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
My mistake, it is 2564a that we were waiting on.
Please go ahead with the rebase now.
Greg Shah
12:06 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
You'd asked me to wait for 2564b to be merged to the trunk, but Stanislav has merged 2564a. Please confirm rebasing. Vadim Gindin
11:54 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Please rebase ASAP. I'll do a final review and then you can start testing. Greg Shah
08:14 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Code Review Task Branch 2513b Revision 10956
I'm good with the changes. Please start regression testing. You don...
Greg Shah
08:10 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> Let's defer this XOR color work until after 2564b is merged to trunk. I don't want to mess with ...
Vadim Gindin
08:04 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Let's defer this XOR color work until after 2564b is merged to trunk. I don't want to mess with pulling just the XOR... Greg Shah
08:01 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Stanislav, can you help Vadim isolate the XOR-drawing changes in 2564b, so he can use/test them for the toggle-box? Constantin Asofiei
07:59 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
There are 2 branches: 2564a and 2564b. Which one? How to properly take Stanislav's changes: merge branches by hand or... Vadim Gindin
07:10 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> I need some help with XOR experiments. I've added the following code to the method that draws ...
Constantin Asofiei
07:05 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I need some help with XOR experiments. I've added the following code to the method that draws rectangle around the la... Vadim Gindin
11:52 AM Bug #2750 (Closed): status area height should not be added to the overall window height
Task branch 1811s revision 10963 fixes the last part of this issue. Greg Shah
11:20 AM Bug #2750: status area height should not be added to the overall window height
Fix for message are buttons has been committed. The final screen sample is attached. Eugenie Lyzenko
08:26 AM Bug #2758: toggle-box selection highlight color depends on the widget's text color and background...
Correction: 2564 A Stanislav Lomany
08:23 AM Bug #2758: toggle-box selection highlight color depends on the widget's text color and background...
After 2564b is merged to trunk, this task can be started.
For details, see #2513-141 (and 142), #2513-146 (and 147...
Greg Shah
08:19 AM Bug #2758 (Closed): toggle-box selection highlight color depends on the widget's text color and b...
Greg Shah

10/13/2015

07:18 PM Feature #1811: implement the AJAX client driver
> > As alternative, we can add Copy/Cut button on the Toolbar panel if we want to copy the application selection to O... Sergey Ivanovskiy
03:42 PM Feature #1811: implement the AJAX client driver
> Greg, I performed some tests and it follows that synthetic "copy&cut" commands work only if they are invoked by use... Greg Shah
03:26 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811s Revision 10957
I'm good with the changes.
Greg Shah
03:12 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811s Revision 10955
I'm OK with the changes.
Greg Shah
02:00 PM Feature #1811: implement the AJAX client driver
> Good news is the Firefox (Chrome, Explorer and Opera) supports synthetic "copy&cut" commands, but "paste" doesn't. ... Sergey Ivanovskiy
01:25 PM Feature #1811: implement the AJAX client driver
Task branch @1811s@ for review updated to revision @10957@.
Fix GUI issues in message area.
Eugenie Lyzenko
01:14 PM Feature #1811: implement the AJAX client driver
1811s rev 10956 contains first pass at window resize in web. What is left is enlarging the window via the north and w... Constantin Asofiei
09:43 AM Feature #1811: implement the AJAX client driver
Good news is the Firefox (Chrome, Explorer and Opera) supports synthetic "copy&cut" commands, but "paste" doesn't. Wo... Sergey Ivanovskiy
09:05 PM Feature #1811: implement the AJAX client driver
Task branch @1811s@ for review updated to revision @10955@.
Fix for abend in focusing frame with no focusable widget.
Eugenie Lyzenko
05:28 PM Feature #1801: add some frame options
More about note 64.
The `setup` method of the @<Frame>Def@ class should use @null@ instead of a widget name (or do n...
Igor Skornyakov
05:14 PM Feature #1801: add some frame options
Minor fix in the @FrameGuiImpl@.
Committed to branch 2272b revno 10997.
Igor Skornyakov
03:45 PM Feature #1801: add some frame options
Added logging mentioned in the note 83.
Committed to branch 2272b revno 10996.
Igor Skornyakov
03:40 PM Feature #1801: add some frame options
Greg Shah wrote:
> I understand that. My request for "detecting this non-button case and use UnimplementedFeature...
Igor Skornyakov
03:36 PM Feature #1801: add some frame options
I've added runtime support for the @CANCEL-BUTTON@ (event re-routing).
Committed to branch 2272b revno 10995.
H...
Igor Skornyakov
03:30 PM Feature #1801: add some frame options
> Actually I've changed the signature of setters so now the program which used this "feature" will at least compile.
...
Greg Shah
03:27 PM Feature #1801: add some frame options
Greg Shah wrote:
> This particular "feature" is low value. Let's defer the work. How about just detecting this non...
Igor Skornyakov
02:45 PM Feature #1801: add some frame options
Igor Skornyakov wrote:
> The attached 4GL program runs OK in 4GL but the conversion doesn't compile. Of course this ...
Greg Shah
02:42 PM Feature #1801: add some frame options
> I've noticed two issues with the attached program.
We will work those in #2705 and #2729.
Greg Shah
02:34 PM Feature #1801: add some frame options
Igor Skornyakov wrote:
> 4GL accepts *any* widget type as the @CANCEL-BUTTON@/@DEFAULT-BUTTON@ *option* value (but n...
Greg Shah
06:43 AM Feature #1801: add some frame options
I've noticed two issues with the attached program.
1. The layout of the @fr1@ frame in the converted application d...
Igor Skornyakov
05:21 PM Bug #2757: Non-button widget as CANCEL-BUTTON/DEFAULT-BUTTON option
4GL accepts non-@BUTTON@ widgets as @CANCEL-BUTTON@/@DEFAULT-BUTTON@ @FRAME@ *options* (not *attributes*). At least f... Igor Skornyakov
05:16 PM Bug #2757 (New): Non-button widget as CANCEL-BUTTON/DEFAULT-BUTTON option
Igor Skornyakov
04:53 PM Bug #2750: status area height should not be added to the overall window height
> Do you mean the scaled images from SVG sources size/position?
Yes.
Greg Shah
04:51 PM Bug #2750: status area height should not be added to the overall window height
Greg Shah wrote:
> These changes look good. Before we close this task, please look into the differences in how we d...
Eugenie Lyzenko
03:27 PM Bug #2750: status area height should not be added to the overall window height
These changes look good. Before we close this task, please look into the differences in how we draw the scrollbar bu... Greg Shah
01:30 PM Bug #2750: status area height should not be added to the overall window height
The fix @1811s@ rev @10957@ for message area includes:
1. Selected item background color and fill area location/size...
Eugenie Lyzenko
12:17 PM Bug #2750: status area height should not be added to the overall window height
>Yes, I think this should use FontManager.getFontHeight, and not gf.font().fontHeight in MessageAreaGuiImpl.doLayout
...
Eugenie Lyzenko
11:19 AM Bug #2750: status area height should not be added to the overall window height
Greg Shah wrote:
> Constantin: could this 2 pixel difference be due to a font sizing issue?
Yes, I think this shoul...
Constantin Asofiei
11:15 AM Bug #2750: status area height should not be added to the overall window height
Constantin: could this 2 pixel difference be due to a font sizing issue? Greg Shah
11:14 AM Bug #2750: status area height should not be added to the overall window height
In the recent @1811s@ code the issue looks differently. The only remaining problem is the message area height in @P2J... Eugenie Lyzenko
03:13 PM Bug #2740 (Closed): Focusing frame with no focusable widget causes an abend
Fixed in task branch 1811s revision 10955. Greg Shah
02:41 PM Bug #2705: frame sizing using SIZE phrase is not honored
Please also test/fix the code in issue 1 (frame @fr1@ layout issue) in #1801-76 Greg Shah
02:37 PM Bug #2729: alert-box usage is broken
Please also test/fix the code in #1801-76 which is another abend (hopefully related). Greg Shah
07:10 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> Vadim, I don't see any other issue in 2513b rev 10955 except what Greg noted.
Constan...
Vadim Gindin
03:55 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
As Greg mentioned, it might be a XOR formula; Stanislav found this related while working on BROWSE widget: #2564-58
...
Constantin Asofiei
03:42 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> ..
> Please see #2564-39 (and 40), #2564-42 (through 45), #2564-54 (through 60).
>
> The pro...
Vadim Gindin
01:58 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> Vadim, I don't see any other issue in 2513b rev 10955 except what Greg noted.
Yes, th...
Vadim Gindin
01:57 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim, I don't see any other issue in 2513b rev 10955 except what Greg noted. Constantin Asofiei
04:20 AM Feature #2564: implement GUI BROWSE widget
Stanislav, see the attached diff. It is not 100% accurate but could help you with the scroll updates. The commented l... Hynek Cihlar
08:17 PM Feature #2564: implement GUI BROWSE widget
Thank you for your answer! I've put the browse to work and will make adjustments you've recommented ASAP.
Just for i...
Stanislav Lomany

10/12/2015

06:56 PM Feature #1801: add some frame options
4GL accepts *any* widget type as the @CANCEL-BUTTON@/@DEFAULT-BUTTON@ *option* value (but not the *attribute*). Moreo... Igor Skornyakov
04:22 AM Feature #1801: add some frame options
Committed NPE fix (note 69) and (partial runtime support for the @CANCEL-BUTTON@/@DEFAULT-BUTTON@ options/attributes)... Igor Skornyakov
06:39 PM Feature #2564: implement GUI BROWSE widget
Stanislav, the problem was in the code initializing the scroll pane. In @BrowseGuiImpl.rebuildColumns@ you should not... Hynek Cihlar
04:18 PM Feature #2564: implement GUI BROWSE widget
Hynek, you will have to check out 2564a. Here is the testcase:... Stanislav Lomany
03:36 PM Feature #2564: implement GUI BROWSE widget
Please post your test program. Hynek Cihlar
02:47 PM Feature #2564: implement GUI BROWSE widget
Guys, after rebase I got couple of problems, one of which confuses me: scrollbars in a scroll pane are not drawn (gre... Stanislav Lomany
02:44 PM Feature #2564: implement GUI BROWSE widget
Rebased task branch 2564a from P2J trunk revision 10945. Stanislav Lomany
04:56 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Code Review Task Branch 1811s Revision 10954
>
> The changes look reasonable, I don't have a p...
Eugenie Lyzenko
04:44 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811s Revision 10954
The changes look reasonable, I don't have a problem with them. My on...
Greg Shah
04:10 PM Feature #1811: implement the AJAX client driver
Task branch @1811s@ for review updated to revision @10954@.
The tooltip issues fix. For painting coordinates and d...
Eugenie Lyzenko
03:26 PM Feature #1811: implement the AJAX client driver
> See "Structuring Java Class Files" in @handbook/coding_stds/approaches.html@.
Ok. See it is really important becau...
Sergey Ivanovskiy
03:06 PM Feature #1811: implement the AJAX client driver
> Fixed in 10953. How to summarize these code rules? For me they look like these private methods must be at the end o... Greg Shah
02:59 PM Feature #1811: implement the AJAX client driver
> Code Review Task Branch 1811s Revision 10952
Fixed in 10953. How to summarize these code rules? For me they look li...
Sergey Ivanovskiy
02:34 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811s Revision 10952
1. In @BufferedImageDrawHelper.processImage()@ and @BufferedImageDraw...
Greg Shah
12:44 PM Feature #1811: implement the AJAX client driver
Committed revision 10951, 10952 is according to the code review Task Branch 1811s Revision 10946.
Sergey Ivanovskiy
12:39 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Code Review Task Branch 1811s Revision 10949
>
> I guess there was no size issue? Perhaps it ...
Eugenie Lyzenko
11:32 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811s Revision 10949
Well done! I fixed a merge problem with a history entry (task branch...
Greg Shah
10:40 AM Feature #1811: implement the AJAX client driver
Task branch @1811s@ for review updated to revision @10949@.
The scrollbar drawing issues fixes.
Eugenie Lyzenko
10:31 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811s Revision 10946
This is significantly better. However there are some small issues to...
Greg Shah
08:00 AM Feature #1811: implement the AJAX client driver
> Greg, please clarify the clipboard task, does it need to develop the client side clipboard like it is implemented b... Greg Shah
04:08 AM Feature #1811: implement the AJAX client driver
Checking the web client keys SHIFT + INSERT (1022) , SHIFT + DELETE (639), CTRL+INSERT (2558) gives SHIFT + DELETE (1... Sergey Ivanovskiy
04:46 PM Bug #2743 (Closed): tooltip misc GUI issues and wrong painting coords
Greg Shah
04:40 PM Bug #2743: tooltip misc GUI issues and wrong painting coords
Tooltip testcases, for example:... Eugenie Lyzenko
03:51 PM Bug #2743: tooltip misc GUI issues and wrong painting coords
The attached picture presents the fix for tooltip feature.
Going to commit to the branch now.
Eugenie Lyzenko
03:43 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Code Review Task Branch 2513b Revision 10955
This seems quite a good improvement.
1. Please add a history entry...
Greg Shah
03:20 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> My directory.xml does not contain color-table and I'm running PROGRESS without specifying progress.ini. Colors are ... Greg Shah
03:03 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Have also look at the note 129. Color table verification. I'm n...
Vadim Gindin
02:54 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've committed my last changes and rebased the branch. Current revision is 10955. Please review. Vadim Gindin
05:30 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> I've found that LASTKEY is not modified by MOUSE-SELECT-CLICK events (may be other mouse event...
Constantin Asofiei
12:36 PM Bug #2756: UPDATE statement in GUI dies on GO and leaves the restarted app in an unkillable/unres...
I'll be happy to see the fix in #2560, but please note this regression is in the trunk 10945 already. Greg Shah
12:35 PM Bug #2756: UPDATE statement in GUI dies on GO and leaves the restarted app in an unkillable/unres...
The rebase of 2560a with trunk/10945 broke a few things, this seems to be one of them. I will resolve the abend in #2... Hynek Cihlar
12:07 PM Bug #2756: UPDATE statement in GUI dies on GO and leaves the restarted app in an unkillable/unres...
This can be recreated in the trunk revision 10945 or in task branch 2560a rev 10968. Run @simple_alert_box.p@ and ed... Greg Shah
12:03 PM Bug #2756 (Closed): UPDATE statement in GUI dies on GO and leaves the restarted app in an unkilla...
Greg Shah
11:33 AM Bug #2748 (Closed): scrollbar drawing differences
Greg Shah
10:46 AM Bug #2748: scrollbar drawing differences
The screens attached are the comparisons for @P2J@ and @4GL@ for scrollbar issues. The demo was modified a bit to get... Eugenie Lyzenko

10/11/2015

05:33 PM Feature #1811: implement the AJAX client driver
Greg, please clarify the clipboard task, does it need to develop the client side clipboard like it is implemented by ... Sergey Ivanovskiy
05:11 PM Feature #1811: implement the AJAX client driver
Greg, please review the committed revision 10946. The @EmbeddedImageStructure@ is not required, we can move @List<Int... Sergey Ivanovskiy
01:28 PM Feature #1811: implement the AJAX client driver
> The problem is if we get an image as a parameter of the drawImage, then this image must be transformed if the provi... Greg Shah
03:30 AM Feature #1811: implement the AJAX client driver
> Code Review caching_images_20151010.txt
>
> 2. I still don't understand why we need to use object hash codes as th...
Sergey Ivanovskiy
03:32 PM Feature #2560: implement GUI DIALOG-BOX support
Rebased task branch 2560a from P2J trunk revision 10945. The current revision in 2560a is now 10967. Hynek Cihlar
12:01 PM Bug #2754: dynamic widget attribute assignment breaks when the FRAME attribute is assigned late
I would suggest to implement a 'staging' model. I mean that a particular logic which is now performed at the attibut... Igor Skornyakov
11:48 AM Bug #2754: dynamic widget attribute assignment breaks when the FRAME attribute is assigned late
One implication is that we will need an approach that splits the assignment logic into those things that must be done... Greg Shah
11:42 AM Bug #2754: dynamic widget attribute assignment breaks when the FRAME attribute is assigned late
All attributes need to be checked for this sensitivity. Most often the result is an NPE, but it is often tricky to f... Greg Shah
11:35 AM Bug #2754 (New): dynamic widget attribute assignment breaks when the FRAME attribute is assigned ...
Greg Shah
11:42 AM Feature #1801: add some frame options
We will defer the work until later. I've created #2754 for that work. Greg Shah
10:15 AM Feature #1801: add some frame options
I've fixed NPE issue per se. However I'm not sure that my fix is absolutely correct as the additional logic is not in... Igor Skornyakov
10:02 AM Feature #1801: add some frame options
Greg Shah wrote:
> Please fix it.
I'm working on it now. However it is not trivial as the @LABEL@ setter is not just...
Igor Skornyakov
09:55 AM Feature #1801: add some frame options
> Setting the @LABEL@ attribute for the dynamic widget causes NPE if the @FRAME@ attribute was not assigned yet.
P...
Greg Shah
09:41 AM Feature #1801: add some frame options
Setting the @LABEL@ attribute for the dynamic widget causes NPE if the @FRAME@ attribute was not assigned yet. Igor Skornyakov

10/10/2015

01:36 PM Feature #1801: add some frame options
Greg Shah wrote:
> Yes, please do if it can be done quickly. The easiest way to do this is to hide the nodes in the...
Igor Skornyakov
01:26 PM Feature #1801: add some frame options
Igor Skornyakov wrote:
> The attached 4GL program runs OK in 4GL but the conversion doesn't compile. Of course this ...
Greg Shah
01:26 PM Feature #1801: add some frame options
Greg Shah wrote:
> If you find any behavior that is dependent upon frame family support, please add notes to the #17...
Igor Skornyakov
01:24 PM Feature #1801: add some frame options
Igor Skornyakov wrote:
> I have a question. In the 4GL documentation the semantics of the @DEFAULT-BUTTON@/@CANCEL-B...
Greg Shah
06:26 AM Feature #1801: add some frame options
The attached 4GL program runs OK in 4GL but the conversion doesn't compile. Of course this program is not `correct` (... Igor Skornyakov
01:14 PM Feature #1811: implement the AJAX client driver
Code Review caching_images_20151010.txt
1. The @PaintStructure@ is meant to be a class that is a simple container ...
Greg Shah
12:37 PM Feature #1811: implement the AJAX client driver
Eugenie reported the following regarding the 1811r branch runtime regression testing (conversion testing was not need... Greg Shah
05:40 AM Feature #1811: implement the AJAX client driver
Greg, please review the diff, the caching is based on the java hash code due to the draw image operation could provid... Sergey Ivanovskiy

10/09/2015

07:29 PM Feature #1801: add some frame options
I have a question. In the 4GL documentation the semantics of the @DEFAULT-BUTTON@/@CANCEL-BUTTON@ is described using ... Igor Skornyakov
06:36 PM Feature #1801: add some frame options
The @DEFAULT-BUTTON@ and @CANCEL-BUTTON@ semantics.
1. If @DEFAULT-BUTTON@/@CANCEL-BUTTON@ are specified in the fr...
Igor Skornyakov
06:36 PM Feature #1801: add some frame options
Greg Shah wrote:
> How quickly can you get the conversion parts of this done? Just stub out the runtime features th...
Igor Skornyakov
10:44 AM Feature #1801: add some frame options
How quickly can you get the conversion parts of this done? Just stub out the runtime features that aren't already th... Greg Shah
04:21 PM Feature #1811: implement the AJAX client driver
Ah, it is due to function @drawHelper.processImage(ps);@ changes some images (creates new ones). Thus it is truly my... Sergey Ivanovskiy
04:00 PM Feature #1811: implement the AJAX client driver
Okay, I am planning to fix it, but at this place we don't know its unique id, we have only the @BufferedImage@ and it... Sergey Ivanovskiy
03:51 PM Feature #1811: implement the AJAX client driver
From note 805:
> 1. Is there a need to send a hash of the image? Why not a simple 32-bit integer as an ID? The ima...
Greg Shah
03:48 PM Feature #1811: implement the AJAX client driver
> Does we need to build images each time?
No, the whole point of the caching was to only ever build it once and s...
Greg Shah
03:34 PM Feature #1811: implement the AJAX client driver
Greg, found that for each of drawing circles, for example, invoking on a key pressed, we redraw images, because an im... Sergey Ivanovskiy
03:19 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811r Revisions 10945-10974
I've made some formatting/coding standards changes and cleaned...
Greg Shah
01:42 PM Feature #1811: implement the AJAX client driver
Task branch @1811r@ for review updated to revision @10975@.
The inactive frame title color fix.
Eugenie Lyzenko
11:33 AM Feature #1811: implement the AJAX client driver
Task branch @1811r@ for review updated to revision @10974@.
The logo icon size/location fix.
Eugenie Lyzenko
09:01 AM Feature #1811: implement the AJAX client driver
Task branch @1811r@ for review updated to revision @10973@.
Adding fix for NPE regression in @radio-set@. Tested w...
Eugenie Lyzenko
08:11 AM Feature #1811: implement the AJAX client driver
> Only GUI code involved, no testing required.
It is OK to make non-GUI or GUI changes to a task branch without ru...
Greg Shah
08:09 AM Feature #1811: implement the AJAX client driver
> Can I commit this change to 1811r? Only GUI code involved, no testing required.
Yes. Unless the branch is locke...
Greg Shah
07:02 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Constantin Asofiei wrote:
> > > Does the test in note 1328 wor...
Hynek Cihlar
06:40 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Does the test in note 1328 work? Because I still see a pr...
Hynek Cihlar
06:13 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Does the test in note 1328 work? Because I still see a problem in MAJIC, ( F/M from main...
Constantin Asofiei
01:26 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > Constantin Asofiei wrote:
> > > > P...
Constantin Asofiei
11:23 PM Feature #1811: implement the AJAX client driver
Task branch @1811r@ for review updated to revision @10971@.
Fix for window title bar issues. Had to remake svg ima...
Eugenie Lyzenko
02:30 PM Bug #2726 (Closed): frame title color is wrong
Greg Shah
01:24 PM Bug #2726: frame title color is wrong
The solution will be committed soon. The screenshot is attached. To be included in 1811r. Eugenie Lyzenko
11:36 AM Bug #2726: frame title color is wrong
The core issue here is to draw the frame background and frame title color properly when a frame is not focused. Greg Shah
11:35 AM Bug #2726: frame title color is wrong
Now consider what happens when we single click on the 2nd frame:
!demo_widgets.p_after_click_on_2nd_frame_in_progr...
Greg Shah
11:30 AM Bug #2726: frame title color is wrong
Consider these images:
!demo_widgets.p_at_initial_startup_in_progress_20151009.png!
!demo_widgets.p_at_initial_...
Greg Shah
08:00 AM Bug #2726: frame title color is wrong
No, it is only fixed for some cases as I mentioned in note 3.
Try @demo/demo_widgets.p@:
!demo_widgets_frame_ti...
Greg Shah
12:37 PM Bug #2681 (Closed): the titlebar height and outline does not match the 4GL version
OK, it looks good to me. Greg Shah
12:34 PM Bug #2681: the titlebar height and outline does not match the 4GL version
In the picture attached you can see the P2J with image area filled(no icon drawn), 4GL icon and P2J icon. The size is... Eugenie Lyzenko
11:52 AM Bug #2681: the titlebar height and outline does not match the 4GL version
Is there an extra pixel (3 pixels wide) in the right margin in P2J?
Otherwise, it definitely looks correct.
Greg Shah
11:25 AM Bug #2681: the titlebar height and outline does not match the 4GL version
The fix is now committing. From the screen attached the location and size of the icon is the same I guess. Eugenie Lyzenko
10:18 AM Bug #2681: the titlebar height and outline does not match the 4GL version
Yes, we need a fix.
!gclogo_in_progress_20151009.png!
I see 2 problems:
* The 1 pixel bottom margin is missi...
Greg Shah
09:56 AM Bug #2681: the titlebar height and outline does not match the 4GL version
This is the 4GL window with logo icon. I'm not sure but looks like in P2J the icon is one pixel higher. What do you t... Eugenie Lyzenko
09:27 AM Bug #2681: the titlebar height and outline does not match the 4GL version
Yes. Greg Shah
09:21 AM Bug #2681: the titlebar height and outline does not match the 4GL version
Greg Shah wrote:
>
> In ours, I think the icon stretches too much. There are no margins.
>
> Please check this...
Eugenie Lyzenko
09:13 AM Bug #2681: the titlebar height and outline does not match the 4GL version
This is really good! I think it is nearly perfect.
!titlebar_icon_scaling_20151009.png!
Notice that the min/ma...
Greg Shah
11:25 PM Bug #2681: the titlebar height and outline does not match the 4GL version
The @1811r@ revision @10971@ should fix the issue. Eugenie Lyzenko
12:34 PM Bug #2753: window scrollbars unexpectedly appear during window resize
Use @demo/demo_widgets.p@ to recreate. Grab the bottom right corner of the window and resize it smaller. Even when ... Greg Shah
12:31 PM Bug #2753 (New): window scrollbars unexpectedly appear during window resize
Greg Shah
12:12 PM Bug #2752: ask-gui.p frame has scrollbars when it should not
Note that there are some other frame and widget sizing issues that may be related. See #2704. Greg Shah
12:11 PM Bug #2752: ask-gui.p frame has scrollbars when it should not
Use @ask-gui.p@ to recreate.
P2J:
!ask-gui.p_frame_has_scrollbars_in_p2j_swing_20151009.png!
Progress:
!a...
Greg Shah
12:10 PM Bug #2752 (Closed): ask-gui.p frame has scrollbars when it should not
Greg Shah
11:47 AM Bug #2751: dragging the scrollbar thumb buttons does not work
Use @demo/demo_widgets.p@ to recreate.
The primary issues is that dragging the scrollbar thumb buttons doesn't work....
Greg Shah
11:47 AM Bug #2751 (Closed): dragging the scrollbar thumb buttons does not work
Greg Shah
11:46 AM Bug #2750: status area height should not be added to the overall window height
See #2748-1
Use @demo/demo_widgets.p@ to recreate. The main content pane in Progress is shorter by the size of th...
Greg Shah
11:45 AM Bug #2750 (Closed): status area height should not be added to the overall window height
Greg Shah
11:44 AM Bug #2749: widget keeps drawing with focus highlight when a different from gets selected
Please see #2726-7 (and note 8)
At initial startup the focus in on the chcb widget in the 1st frame. Then when th...
Greg Shah
11:38 AM Bug #2749 (Closed): widget keeps drawing with focus highlight when a different from gets selected
Greg Shah
11:25 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've found that LASTKEY is not modified by MOUSE-SELECT-CLICK events (may be other mouse events too), but PROGRESS do... Vadim Gindin
05:25 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I think P2J might raise both mouse-clicked and mouse-dblclicked events. Please check the click-count for a @mouseCli... Constantin Asofiei
11:16 AM Bug #2748: scrollbar drawing differences
Scrollbar drawing issues:
1. Scrollbar arrow buttons 3D accents are not correct.
2. Scrollbar thumb buttons 3D ac...
Greg Shah
11:12 AM Bug #2748: scrollbar drawing differences
Using @demo/demo_widgets.p@ one can see several differences in scrollbar drawing:
!demo_widgets.p_progress_vs_p2j_...
Greg Shah
11:12 AM Bug #2748 (Closed): scrollbar drawing differences
Greg Shah
09:18 AM Feature #1794 (Closed): implement font support
The last of the font work will be completed in #1811 with some discussion taking place in #2322. As such, I'm closin... Greg Shah
08:05 AM Bug #2706 (Closed): window title attribute is not honored
I just tested this. You're right. I tested rev 10969 of 1811r and the title attribute is now working. It is also s... Greg Shah

10/08/2015

07:26 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Please go ahead, I'm not worki...
Hynek Cihlar
06:10 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> There is a change in how text metrics are retrieved. Never call @gd.getTextWidth/Height...
Eugenie Lyzenko
05:31 PM Feature #1811: implement the AJAX client driver
Eugenie Lyzenko wrote:
> Some recent @1811r@ changes cause the GUI regression in horizontal radio-set. @NPE@ in @Abs...
Constantin Asofiei
05:05 PM Feature #1811: implement the AJAX client driver
Some recent @1811r@ changes cause the GUI regression in horizontal radio-set. @NPE@ in @AbstractGuiDriver@, line 2525... Eugenie Lyzenko
04:27 PM Feature #1811: implement the AJAX client driver
Task branch @1811r@ for review updated to revision @10969@.
Fix for status line one pixel issue.
Eugenie Lyzenko
04:11 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Please go ahead, I'm not working on it.
>
> Constantin, I ha...
Constantin Asofiei
04:10 PM Feature #1811: implement the AJAX client driver
> By key echoing I mean the delay time from keys are pressed down and up on the keyboard following by their appearanc... Greg Shah
04:02 PM Feature #1811: implement the AJAX client driver
> All except this one: changing the font-table via the SYSTEM-DIALOG FONT and PUT KEY VALUE FONT (FontTable.chooseFon... Greg Shah
03:59 PM Feature #1811: implement the AJAX client driver
> Sergey: Please provide a list of the open work for the key processing improvements. In addition to note 1360 you'v... Sergey Ivanovskiy
03:44 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> > What remaining issues do you have on the list for #1794? Beside font alises/custom font support...
Constantin Asofiei
03:35 PM Feature #1811: implement the AJAX client driver
> What remaining issues do you have on the list for #1794? Beside font alises/custom font support in runtime P2J (whi... Greg Shah
03:18 PM Feature #1811: implement the AJAX client driver
1811r rev 10967 fixes a regression in GUI EDITOR drawing plus the EDITOR text selection issue in #2737 Constantin Asofiei
02:56 PM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> > The issue here is finding font replacements for FixedSys and System. I think we should alias th...
Constantin Asofiei
02:46 PM Feature #1811: implement the AJAX client driver
> On a side note: the regression in GUI is only for EDITOR, the other widgets look fine.
Good. BTW, have you look...
Greg Shah
02:42 PM Feature #1811: implement the AJAX client driver
> 3. test/fix window resize in Web (CA)
> I haven't started working on it... I will focus on fixing the regressions ...
Greg Shah
02:33 PM Feature #1811: implement the AJAX client driver
1811r rev 10966 fixes font alias support for Web client.
On a side note: the regression in GUI is only for EDITOR,...
Constantin Asofiei
02:32 PM Feature #1811: implement the AJAX client driver
Task branch @1811r@ for review updated to revision @10965@.
Fix for status line drawing issues.
Eugenie Lyzenko
02:10 PM Feature #1811: implement the AJAX client driver
Fix for status line issue is ready. The fixed screenshot attached here. Preparing to commit in task branch. Eugenie Lyzenko
02:08 PM Feature #1811: implement the AJAX client driver
1811r rev 10964:
* Fixed a regression in ChUI (events when no focus exists are sent to ACTIVE-WINDOW)
* fixed a NPE...
Constantin Asofiei
01:42 PM Feature #1811: implement the AJAX client driver
Sergey: Please provide a list of the open work for the key processing improvements. In addition to note 1360 you've ... Greg Shah
11:15 AM Feature #1811: implement the AJAX client driver
Rebased task branch 1811r from P2J trunk revision 10944. The current revision in 1811r is now 10963. Greg Shah
10:52 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> I'm trying to extract a testcase. The problem is that the search-field in the frame sho...
Hynek Cihlar
10:36 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Please go ahead, I'm not working on it.
>
> Constantin, I ha...
Constantin Asofiei
09:32 AM Feature #1811: implement the AJAX client driver
Task branch @1811r@ for review updated to revision @10958@.
Fix for window 3D like border in GUI.
Eugenie Lyzenko
08:51 AM Feature #1811: implement the AJAX client driver
> You mean commit into branch or trunk?
I mean the task branch 1811r. This is what I meant by my notes in #2679, ...
Greg Shah
08:49 AM Feature #1811: implement the AJAX client driver
> You mean commit into branch or trunk?
I mean the task branch 1811r. This is what I meant by my notes in #2679, ...
Greg Shah
08:45 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
>
> Please check in your changes as you go. The only restriction is that each check-in should no...
Eugenie Lyzenko
07:37 AM Feature #1811: implement the AJAX client driver
Eugenie Lyzenko wrote:
> The code to draw 3D line has been added to the @WindowGuiImpl.drawBorder()@. The resulting ...
Greg Shah
06:10 AM Feature #1811: implement the AJAX client driver
1811r rev 10956 contains a fix for @5. frame title looks less bold, probably due to the anti-aliasing (CA)@ - this is... Constantin Asofiei
06:03 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've found, that MOUSE-SELECT-DOUBLE-CLICK event is processed by P2J differently than in a PROGRESS. Let assume, we h... Vadim Gindin
10:23 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Have also look at the note 129. Color table verification. I'm not sure if it is a bug: colors ...
Constantin Asofiei
10:18 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> 1. Tooltip does not hiding correctly.
> 2. I have 2 triggers: VALUE-CHANGED and LEFT-MOUSE-C...
Constantin Asofiei
10:05 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Some layout inaccuracy. Have a look at attached picture and note on the space between toggle-b...
Constantin Asofiei
08:57 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> I am trying to understand the open issues and the remaining work on this task.
>
> Vadim:
>
...
Vadim Gindin
08:36 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I am trying to understand the open issues and the remaining work on this task.
Vadim:
1. Please create a task f...
Greg Shah
05:33 PM Bug #2706: window title attribute is not honored
I think I've already covered this one during the #2716 multi-window focus support, which is part of 1811r now (forgot... Constantin Asofiei
05:24 PM Bug #2726: frame title color is wrong
Looks like now the frame title color is fixed(without any my changes). See the screen attached. May be we can close t... Eugenie Lyzenko
04:48 PM Bug #2681: the titlebar height and outline does not match the 4GL version
At this point, the colors are fine. But the size and outline is still incorrect.
If this can be solved by end of ...
Greg Shah
04:46 PM Bug #2680 (Closed): status area border is not drawn correctly
Well done! It looks really good. Greg Shah
04:29 PM Bug #2680: status area border is not drawn correctly
Fixed in @1811r@ revision @10969@. Eugenie Lyzenko
03:20 PM Bug #2680: status area border is not drawn correctly
The 1811r revision 10965 solution is nearly pixel perfect:
!p2j_swing_status_area_vs_progress_20151008.png!
In ...
Greg Shah
03:59 PM Bug #2747: implement font table editing
Implement the ability to change the font-table via the SYSTEM-DIALOG FONT and PUT KEY VALUE FONT (FontTable.chooseFon... Greg Shah
03:59 PM Bug #2747 (New): implement font table editing
Greg Shah
03:40 PM Bug #2737 (Closed): Editor abends on double click
Greg Shah
03:18 PM Bug #2737: Editor abends on double click
Fixed in #1811 (1811r rev 10967) Constantin Asofiei
02:42 PM Bug #2745: fill-in sizing differences
... Stanislav Lomany
01:19 PM Bug #2745: fill-in sizing differences
Stanislav: Please post or point to the testcase being used for the problems reported in #2564-28 Greg Shah
01:17 PM Bug #2745: fill-in sizing differences
The highlighted area issue will be worked in #2727.
The vertical alignment differences will be worked in #2730.
...
Greg Shah
01:15 PM Bug #2745: fill-in sizing differences
See #2564-28 Greg Shah
01:15 PM Bug #2745 (Closed): fill-in sizing differences
Greg Shah
02:30 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Greg Shah wrote:
> Is MESSAGE SET/UPDATE support supposed to be functional at this point?
Yes, MESSAGE SET/UPDA...
Hynek Cihlar
01:11 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
I tested this on 2560a rev 10959. The testcase abends before displaying. Here is the bottom of the log:... Greg Shah
12:37 PM Bug #2679 (Closed): window borders should have a 3D appearance
I've tested the changes in branch 1811r revision 10962 and they do indeed resolve this issue. Greg Shah
12:30 PM Bug #2716 (Closed): The application with multiple windows doesn't start.
The code review was posted in #1811 note 1348.
I've confirmed that this is fixed in the branch 1811r.
Greg Shah
08:48 AM Bug #2744: dynamic widgets realize too late
Procedure @uast/toggle_box/gui/tglbox_dyn.p@. There are toggle-box is created dynamically using CREATE statement:
...
Vadim Gindin
08:44 AM Bug #2744 (New): dynamic widgets realize too late
Vadim Gindin
08:42 AM Feature #2614 (Closed): implement GUI runtime support for RADIO-SET widget
Greg Shah
08:34 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Branch @2614a@ was merged to trunk as revno @10944@ then it was archived. Eugenie Lyzenko
07:41 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
> The last two are also expected, correct?
Yes.
> So I can commit 2614a into trunk if no objections.
Yes, pl...
Greg Shah
08:49 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
The @CTRL-C@ tests passed without regressions. The results file: @2614a_10956_06069cc_20151007_evl.zip@.
So I can ...
Eugenie Lyzenko

10/07/2015

07:10 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
The main part completed without regressions, one test had to run in single mode. Continue with @CTRL-C@ part.
The ...
Eugenie Lyzenko
02:55 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Conversion part completed, no regressions, generated code sets are identical. Continue with runtime testing. Eugenie Lyzenko
11:43 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Conversion testing is in progress. Eugenie Lyzenko
10:54 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
> So I suggest to test/commit this implementation and then we can work on something from this list according to curre... Greg Shah
09:40 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Task branch @2614a@ for review updated to revision @10956@.
Fixed javadoc comment mentioned in note 42.
>Beside...
Eugenie Lyzenko
08:36 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Eugenie Lyzenko wrote:
> >In fact the radio set in Windows classic and Windows XP/7 basic theme are so different that...
Hynek Cihlar
08:29 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
And the pictures... Eugenie Lyzenko
08:24 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
>In fact the radio set in Windows classic and Windows XP/7 basic theme are so different that they will need different... Eugenie Lyzenko
08:22 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Besides the javadoc thing in note 42, is there anything else that needs to be done before this task is complete? Are... Greg Shah
08:21 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Code Review Task Branch 2614a Revision 10955
The changes look good. One thing:...
Greg Shah
08:05 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
> 1. There are several themes that we need to support. The question: do we need to support dynamic theme change?
N...
Greg Shah
04:48 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Eugenie Lyzenko wrote:
> Some considerations:
> 2. Currently we use "classic" theme. Different themes have a bit diff...
Hynek Cihlar
08:57 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
> 6. Is it possible in Windows to have non-default colors for drawing the buttons/highlights? Such a feature would ma... Eugenie Lyzenko
06:40 PM Feature #1811: implement the AJAX client driver
The Swing GUI client didn't pass the manual test due to the pressed valid keys combinations were treated as several k... Sergey Ivanovskiy
05:20 PM Feature #1811: implement the AJAX client driver
The code to draw 3D line has been added to the @WindowGuiImpl.drawBorder()@. The resulting screenshot attached to dem... Eugenie Lyzenko
03:24 PM Feature #1811: implement the AJAX client driver
1811r revision 10955 adds a workaround for a MENU-BAR bug introduced by the new clipping approach; the bug is related... Constantin Asofiei
01:59 PM Feature #1811: implement the AJAX client driver
1811r revision 10954 adds underline font support for Web client (item 8 from note 1087).
I'm working on a repaint ...
Constantin Asofiei
01:51 PM Feature #1811: implement the AJAX client driver
Committed revision 1375 adds @readme.txt@ and @scancode.doc@ specification to @testcases/uast/keyboards/keystrokes_fe... Sergey Ivanovskiy
11:58 AM Feature #1811: implement the AJAX client driver
> Sergey: what remaining work is needed for the "make Swing/web keyboard processing compatible" task?
Planning to fi...
Sergey Ivanovskiy
11:02 AM Feature #1811: implement the AJAX client driver
Sergey: what remaining work is needed for the "make Swing/web keyboard processing compatible" task? Greg Shah
11:00 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Finished keystrokes simulator for windows committed revision 1374 (testcases). (The open ...
Greg Shah
10:53 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Found that @CoordinatesConversion@ uses @BigDecimal.valueof(double...
Hynek Cihlar
10:37 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Found that @CoordinatesConversion@ uses @BigDecimal.valueof(double)@ instead of @new BigD...
Hynek Cihlar
10:28 AM Feature #1811: implement the AJAX client driver
Found that @CoordinatesConversion@ uses @BigDecimal.valueof(double)@ instead of @new BigDecimal(double)@. What is the... Sergey Ivanovskiy
10:03 AM Feature #1811: implement the AJAX client driver
> I'm thinking on drawing an "outer" rectangle (without redrawing) which shows how the new resized window would look... Greg Shah
10:02 AM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811r Revisions 10952/10953
Wow, this must fix a lot of problems! Our multi-window suppor...
Greg Shah
07:29 AM Feature #1811: implement the AJAX client driver
1811r rev 10953 contains a fix for web client plus a combo-box fix (the widgets need to be de-registered from the win... Constantin Asofiei
04:38 PM Feature #2564: implement GUI BROWSE widget
> BTW, do we need an editable browse to demonstrate?
I don't think so.
Let's get 2564a into testing after 1-3 a...
Greg Shah
02:08 PM Feature #2564: implement GUI BROWSE widget
# Right now I'm working on testcases for browse/column sizing/horizontal scrolling.
# Vertical scrolling with mouse ...
Stanislav Lomany
01:44 PM Feature #2564: implement GUI BROWSE widget
Please document the list of open items to be finished before the first pass at GUI browse runtime will be ready for t... Greg Shah
04:14 PM Feature #1801: add some frame options
The current state is described below:
+Attributes+...
Igor Skornyakov
01:22 PM Feature #1801: add some frame options
See #2272 notes 80 and 81. It should be fixed. Greg Shah
01:12 PM Feature #1801: add some frame options
I've noticed a strange change in the conversion logic.
We have a @BoxInterface@ and the following conversion rule:...
Igor Skornyakov
12:29 PM Feature #1801: add some frame options
Greg Shah wrote:
> Igor: I assume that you are working on item 2 above. Please document the gaps you found and whe...
Igor Skornyakov
12:14 PM Feature #1801: add some frame options
Igor: I assume that you are working on item 2 above. Please document the gaps you found and when do you expect it t... Greg Shah
02:58 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Some layout inaccuracy. Have a look at attached picture and note on the space between toggle-boxes (exists in P2J, bu... Vadim Gindin
02:44 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Is there a way to verify color table like font table? I'm running some test where fgColor is set to 5, for example, a... Vadim Gindin
01:34 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
1. Tooltip does not hiding correctly.
2. I have 2 triggers: VALUE-CHANGED and LEFT-MOUSE-CLICK. If LEFT-MOUSE-CLICK ...
Vadim Gindin
01:59 PM Bug #2726: frame title color is wrong
Eugenie, frame title shares the colors with main window. So whatever you set in the Windows theme settings will end u... Hynek Cihlar
01:48 PM Bug #2726: frame title color is wrong
Hynek did make some changes related to this in 1811r already, but they don't always resolve the issue. Greg Shah
01:47 PM Bug #2726: frame title color is wrong
Please put your changes into task branch 1811r. Greg Shah
01:47 PM Bug #2680: status area border is not drawn correctly
Please put your changes into task branch 1811r. Greg Shah
01:47 PM Bug #2679: window borders should have a 3D appearance
Please put your changes into task branch 1811r. Greg Shah
01:39 PM Feature #2560: implement GUI DIALOG-BOX support
Greg Shah wrote:
> > I forgot that #1811 has some conflicting changes, this will need to be merged and retested. I e...
Hynek Cihlar
01:36 PM Feature #2560: implement GUI DIALOG-BOX support
> I forgot that #1811 has some conflicting changes, this will need to be merged and retested. I expect 1 MD for this.... Greg Shah
11:10 AM Feature #2560: implement GUI DIALOG-BOX support
Hynek Cihlar wrote:
> Left known issues and todo tasks are:
> * Fix multiple show/hide of the same frame/dialog-box...
Hynek Cihlar
11:08 AM Feature #2560: implement GUI DIALOG-BOX support
Left known issues and todo tasks are:
* Fix multiple show/hide of the same frame/dialog-box. 0.25 MD
* Fix default...
Hynek Cihlar
10:57 AM Feature #2560: implement GUI DIALOG-BOX support
Please provide a detailed list of the remaining work/testing that needs to be done before you believe this is ready f... Greg Shah
12:46 PM Bug #2743: tooltip misc GUI issues and wrong painting coords
Currently found tooltip GUI issues:
1.Sometimes tooltip string is not drawing properly(the picture attached).
2.A...
Eugenie Lyzenko
11:58 AM Bug #2743 (Closed): tooltip misc GUI issues and wrong painting coords
Eugenie Lyzenko
08:15 AM Feature #2676: implement the equivalent to configurable support for a windows theme
As part of our implementation of the GUI widgets, we have already provided hard coded support for the Windows Classic... Greg Shah

10/06/2015

06:55 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Task branch @2614a@ for review updated to revision @10955@.
Notes resolution(#1-#5). For the first one I used not ...
Eugenie Lyzenko
06:43 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Greg Shah wrote:
> The screenshots look good. When do you plan to check in the version with code review changes and...
Eugenie Lyzenko
05:07 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
The screenshots look good. When do you plan to check in the version with code review changes and any remaining neede... Greg Shah
12:47 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
>7. Please post some example screenshots for some representative testcases (both horizontal and vertical) that show P... Eugenie Lyzenko
10:28 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
It should look like this:... Greg Shah
10:10 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
>4. In GuiWidgetFactory the com.goldencode.p2j.util imports should use the wildcard.
The reason I did this is issu...
Eugenie Lyzenko
08:32 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Code Review Task Branch 2614a Revision 10954
1. This code in @frame_generator.xml@ is not generic enough:...
Greg Shah
10:02 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Rebased task branch @2614a@ from P2J trunk revision @10943@, new branch revision is @10954@.
Prepared for possible...
Eugenie Lyzenko
09:13 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Task branch @2614a@ for review updated to revision @10953@.
The change is a result of the final testing. Contains ...
Eugenie Lyzenko
06:52 PM Feature #1811: implement the AJAX client driver
Finished keystrokes simulator for windows committed revision 1374 (testcases). (The open issue is how to build this d... Sergey Ivanovskiy
03:24 PM Feature #1811: implement the AJAX client driver
1811r rev 10952 contains changes for #2716 related to multi-window focus and frame placement.
From note 1087:
2. ...
Constantin Asofiei
03:11 PM Bug #2716: The application with multiple windows doesn't start.
The changes which add multi-window focus support and multi-window frame placement are in branch 1811r rev 10952. Ple... Constantin Asofiei

10/05/2015

05:28 PM Feature #1811: implement the AJAX client driver
Playing with keystrokesfeeder.dll on windev01 helps to find an interesting Progress 4GL combinations CTRL + [ that pr... Sergey Ivanovskiy
03:53 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> > Please be more specific: are you talking about existing code, new code added by you? If...
Constantin Asofiei
03:13 PM Feature #1811: implement the AJAX client driver
> Please be more specific: are you talking about existing code, new code added by you? If so, what part?
In java 7 l...
Sergey Ivanovskiy
02:55 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Constantin, @Window.java@ uses @java 8@ compiler feature to determine if local variables ...
Constantin Asofiei
02:51 PM Feature #1811: implement the AJAX client driver
Constantin, @Window.java@ uses @java 8@ compiler feature to determine if local variables are final. Sergey Ivanovskiy
11:37 AM Feature #2567 (Closed): add misc widget support part 2: more options, attributes and methods
Greg Shah
10:58 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Tha branch 2567b has been merged to P2J trunk revision 10943 Igor Skornyakov
10:48 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> I meant to do a @bzr update@ in your copy of branch 2567b so you have rev 10979 which I'...
Igor Skornyakov
10:41 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Please update your 2567b branch to rev 10979 and merge to tr...
Constantin Asofiei
10:38 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Please update your 2567b branch to rev 10979 and merge to trunk.
Sorry, but it seems ...
Igor Skornyakov
10:23 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Added comment to a recent fix.
>
> Committed to branch 2567b revno 10978
>
> The bra...
Constantin Asofiei
09:19 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added comment to a recent fix.
Committed to branch 2567b revno 10978
The branch is ready for merge.
Igor Skornyakov
08:48 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Please add the comments as described in note 412, if it is clear enough Constantin will give the go ahead to merge to... Greg Shah
08:28 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Please specify which test failed.
It was @gc_62@. Please see a detailed description abo...
Igor Skornyakov
08:10 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > As I understand, this caused one or more regressions in test...
Constantin Asofiei
07:27 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> As I understand, this caused one or more regressions in testing. Please add a comment w...
Igor Skornyakov
07:20 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor, review for 2567b rev 10977. Only one issue about the change in @SelectionList.afterConfigUpdate@:... Constantin Asofiei
05:37 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Ctrl-C tests passed Igor Skornyakov
03:42 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Only expected expected @tc_job_002@, @tc_po_item_003@, @tc_po_item_004@ tests failed in two runs after the fix.
Star...
Igor Skornyakov
10:18 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> ..
> > P.S. After I fixed it, label is drawn trimmed to "B". I'm trying to found why at...
Vadim Gindin
08:41 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> In other words:
> # The first argument of the method @gd.drawString(text, xt, yt);@ must alw...
Constantin Asofiei
08:39 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I've debugged the "idle" problem noted before with the test @ua...
Vadim Gindin
07:08 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Next found toggle-box 2 bugs:
> # ENTER doesn't change toggle-box value for PROGRESS, but for...
Constantin Asofiei
07:03 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> I've debugged the "idle" problem noted before with the test @uast/toggle_box/gui/tbx_events.p@...
Constantin Asofiei
06:55 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Does RELEASED event (for keyboard keys) supported in P2J? Vadim Gindin
06:26 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Next found toggle-box 2 bugs:
# ENTER doesn't change toggle-box value for PROGRESS, but for P2J it does.
# When mou...
Vadim Gindin
06:02 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've debugged the "idle" problem noted before with the test @uast/toggle_box/gui/tbx_events.p@ and found, that @TypeA... Vadim Gindin
08:56 AM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Sorry, that was a regression. This is what the code should have been:... Greg Shah

10/04/2015

05:47 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
After 2560a revision 10949, Window.message() in GUI no longer outputs messages to the window message area.
I think...
Hynek Cihlar
05:00 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
After the fix only two tests failed: @tc_codes_employees_021@ and @tc_job_clock_002@ (in addition to expected @tc_jo... Igor Skornyakov
11:52 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Resolved the issue with gc_62 (manual test passed).
Committed to branch 2567b revno 10977
Restarted regression test
Igor Skornyakov
05:43 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
1. Strangely enough @gso_281@ and @gso_307@ still fail due to a wrong value of the field.
2. The situation with @gc_6...
Igor Skornyakov

10/03/2015

07:00 PM Feature #1811: implement the AJAX client driver
> Have you tried absolute pathing (@"c:~\Users~\sbi~\keystrokesfeeder.dll"@) in the PROCEDURE EXTERNAL?
>
> If you...
Sergey Ivanovskiy
10:00 AM Feature #1811: implement the AJAX client driver
Have you tried absolute pathing (@"c:~\Users~\sbi~\keystrokesfeeder.dll"@) in the PROCEDURE EXTERNAL?
If you build...
Greg Shah
06:26 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Ctrl-C tests passed Igor Skornyakov
09:30 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
The other failed @gso_*@ tests also look familiar:
152 gso_307 GSO 307 - Screen does not refresh at Stock Order Se...
Igor Skornyakov
09:04 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> Regarding gso_281. The only mismatch I see is the value of the PO field. It is 662622 instead of 662621. I think I ... Greg Shah
08:56 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> As noted previously the tc_job_002, tc_po_item_003, tc_po_item_004 are all known failures which c...
Igor Skornyakov
08:50 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
As noted previously the tc_job_002, tc_po_item_003, tc_po_item_004 are all known failures which can be ignored.
Th...
Greg Shah
08:42 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
The following tests failed identically in 3 runs:
133 gso_281 GSO 281 - Column error message in PO add items. F...
Igor Skornyakov
08:27 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Please document the regression testing status here. Greg Shah

10/02/2015

07:17 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Task branch @2614a@ for review updated to revision @10952@.
The change fixes the runtime error for @int64@ values ...
Eugenie Lyzenko
07:09 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Rebased task branch 2614a from P2J trunk revision @10942@, new branch revision is @10951@. Eugenie Lyzenko
06:23 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Task branch @2614a@ for review updated to revision @10950@.
Adding change clarification and some NPE protection lo...
Eugenie Lyzenko
05:58 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
OK, go ahead with the change. Greg Shah
05:54 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> ..
> Yes, assigning it to the @FRAME@ does attach it. But if you remove the @FRAME@ assignment, the size-related ...
Vadim Gindin
09:51 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim, review for 2513b rev 10943:
> > * when computing the na...
Constantin Asofiei
09:38 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> Vadim, review for 2513b rev 10943:
> * when computing the native width, the formula is ...
Vadim Gindin
04:23 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim, review for 2513b rev 10943:
* when computing the native width, the formula is really @25pixels + the text wid...
Constantin Asofiei
05:37 PM Bug #2742: Problems when using the SIZE option
Consider we have the following var definition: @def var tbbx as logical view-as toggle-box size 15 by 1.5.@ That togg... Vadim Gindin
05:31 PM Bug #2742 (Closed): Problems when using the SIZE option
Vadim Gindin
04:30 PM Feature #1811: implement the AJAX client driver
Greg, could you help what is incorrect in the test dll. The project is committed to uast/keyboards/keystrokes_feedera... Sergey Ivanovskiy
11:36 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Please go ahead, I'm not working on it.
Constantin, I have compared 1811r revision 10...
Hynek Cihlar
07:31 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > Unfortunately this makes things worse... from the MAJIC ma...
Constantin Asofiei
07:29 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Unfortunately this makes things worse... from the MAJIC main menu, press V/F - the Find ...
Sergey Ivanovskiy
07:10 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > The problem was with insets being no...
Constantin Asofiei
06:59 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The problem was with insets being not properly translated in Ch...
Hynek Cihlar
06:46 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> The problem was with insets being not properly translated in ChUI when bordered panels were in...
Constantin Asofiei
03:03 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
I tested rev 10950 and @message-update6.p@ works properly in ChUI. I see 2 small deviations (related to the ChUI cur... Greg Shah
02:40 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Greg Shah wrote:
> I've checked in my changes as revision 10949 in branch 2560a. The window integration portions ar...
Hynek Cihlar
12:17 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Greg Shah wrote:
> I've checked in my changes as revision 10949 in branch 2560a. The window integration portions ar...
Hynek Cihlar
12:10 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
To test GUI support for @tinyInput(), please pull the latest @testcases/uast/message-update6.p@. I've made several c... Greg Shah
12:07 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
I've checked in my changes as revision 10949 in branch 2560a. The window integration portions are marked in @Window@... Greg Shah
08:44 AM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Hynek Cihlar wrote:
> Greg, just let me know, if you want me to rebase 2560a.
No, actually my changes are based o...
Greg Shah
07:03 AM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Greg, just let me know, if you want me to rebase 2560a. Hynek Cihlar
07:00 AM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Greg Shah wrote:
> Thanks, Hynek. I was worried you would say that.
>
> I have a range of other changes related ...
Hynek Cihlar
06:35 AM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Thanks, Hynek. I was worried you would say that.
I have a range of other changes related to this. Perhaps I shou...
Greg Shah
04:50 AM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Greg Shah wrote:
> Hynek: I am trying to use @ModalWindow@ directly as the containing window for a frame. Clearly t...
Hynek Cihlar
11:34 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
The @EOFException@ instances are expected. They are not a problem. We need to add @EOFException.class@ to the @Disp... Greg Shah
10:10 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Regression test on @devsrv01@ ended. The numeber of failed tests is reasonable for the first run.
However there a pl...
Igor Skornyakov
08:42 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567b from P2J trunk revision 10942 (new branch revision 10976).
Igor Skornyakov
08:12 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Fixed issues mentioned in the code review (except rebase).
>
> Committed to branch 2567b...
Constantin Asofiei
08:10 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Did conversion regression testing pass?
>
> Have you started runtime regression testing yet?
...
Igor Skornyakov
08:06 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Did conversion regression testing pass?
Have you started runtime regression testing yet?
Greg Shah
08:01 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Fixed issues mentioned in the code review (except rebase).
Committed to branch 2567b revno 10974.
Igor Skornyakov
07:53 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Thank you Constantin.
I will fix it. Of course the equality check is incorrect. Strangely the behaviour was correct ...
Igor Skornyakov
07:31 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Review branch 2567b rev 10973:
# you need to rebase again
# AutoResizableWidget, TopOnlyInterface, AutoResizable ne...
Constantin Asofiei
08:13 AM Feature #2564: implement GUI BROWSE widget
> I assume you have added 2 @PaintPrimitive@ types and the @AbstractGuiDriver.setXORComposite()/resetComposite()@ add... Stanislav Lomany
08:11 AM Feature #2564: implement GUI BROWSE widget
Fantastic! I assume you have added 2 @PaintPrimitive@ types and the @AbstractGuiDriver.setXORComposite()/resetCompos... Greg Shah
07:47 AM Feature #2564: implement GUI BROWSE widget
I have a lucky day: formula from note 55 is actually... Stanislav Lomany
06:26 AM Feature #1801: add some frame options
Instead of using 2038a, please contribute your changes into 2272b. Ovidiu has already put some changes in place in t... Greg Shah
04:27 AM Feature #2038: conversion and runtime support for frame options, attributes and methods
Created task branch 2038a from P2J trunk revision 10942 Igor Skornyakov

10/01/2015

07:25 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
The sample code to convert is:... Eugenie Lyzenko
06:10 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
> The investigation shows this special case is just not handling by rules/convert/literals.rules. I think because it ... Greg Shah
04:50 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Greg Shah wrote:
>
> See @rules/convert/literals.rules@ and search on @use64BitInt@. The support is already there...
Eugenie Lyzenko
12:39 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
> The remaining issue is how to add "L" to the int64 literal for respective radio button item
See @rules/convert/l...
Greg Shah
12:19 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Found a way to support @unknown(?)@ data initial for radio-button.
The remaining issue is how to add @"L"@ to the ...
Eugenie Lyzenko
09:02 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
The data types support investigation shows in general radio-set handles the not only character data. But there are so... Eugenie Lyzenko
06:44 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Yes, please do. I don't know when we will schedule the reboot, but it is not needed for function...
Igor Skornyakov
06:41 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
> However when I login to the devsrv01 I see a message *** System restart required ***.
> Can I start regression tes...
Greg Shah
06:25 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Here is the plan:
>
> 1. Add these items to #2741. They can be fixed together.
> 2. Constant...
Igor Skornyakov
06:16 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Here is the plan:
1. Add these items to #2741. They can be fixed together.
2. Constantin will do a code review w...
Greg Shah
06:00 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Which of these problems are new?
I don't remember exactly but it seems that only the issue wit...
Igor Skornyakov
05:55 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Which of these problems are new? Greg Shah
05:48 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
After rebase:
1. @COMBO-BOX@ redraw on the @FORMAT@ change is incorrect in the GUI mode.
2. @EDITOR@ ignores @BGCOL...
Igor Skornyakov
04:43 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Rebased task branch 2567b from P2J trunk revision 10941 (new branch revision 10973).
Started re-testing
Igor Skornyakov
03:08 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Finished with resolving issues mentioned in the code review and re-tested.
Committed to the branch 2567a revno 109...
Igor Skornyakov
06:21 PM Bug #2741: SELECTION-LIST sizing issues
After 2574b rebase:
1. @COMBO-BOX@ redraw on the @FORMAT@ change is incorrect in the GUI mode.
2. @EDITOR@ ignores ...
Igor Skornyakov
07:29 AM Bug #2741: SELECTION-LIST sizing issues
See #2567-322 for the details. Greg Shah
07:28 AM Bug #2741 (New): SELECTION-LIST sizing issues
Greg Shah
06:01 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Hynek: I am trying to use @ModalWindow@ directly as the containing window for a frame. Clearly this a bad idea:
<...
Greg Shah
04:28 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Another bug found for the procedure @uast/toggle_box/gui/tglbox_dyn.p@. There are toggle-box is created dynamically u... Vadim Gindin
04:04 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
There is some other reason of this ignoring of size statement: BaseEntity does not set @fixedWidth/fixedHeight@ flags... Vadim Gindin
09:14 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > If you want to check widget dimensions, please check the WIDTH/...
Constantin Asofiei
09:04 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> If you want to check widget dimensions, please check the WIDTH/HEIGHT-CHARS and WIDTH/HE...
Vadim Gindin
04:10 PM Feature #2564: implement GUI BROWSE widget
Yes, please investigate if you can match the WIN32 compositing with something from Java2D. If so, this is the prefer... Greg Shah
03:44 PM Feature #2564: implement GUI BROWSE widget
Guys, about dotted line drawing: so what should I finally do with it - check if is possible to do with Java2D @Compos... Stanislav Lomany
09:41 AM Feature #2564: implement GUI BROWSE widget
Here is color calculation formula for R, G or B component:... Stanislav Lomany
03:13 AM Feature #2564: implement GUI BROWSE widget
Greg Shah wrote:
> 3. In your approach, we also want to be able to detect which character is being intersected. Con...
Constantin Asofiei
12:43 PM Feature #1811: implement the AJAX client driver
The problem was with insets being not properly translated in ChUI when bordered panels were involved. Constantin, see... Hynek Cihlar
11:14 AM Feature #1811: implement the AJAX client driver
Constantin, I am suspecting the viewport to be at the wrong location, I think it should be positioned at 0,0. Let me ... Hynek Cihlar
10:07 AM Feature #1811: implement the AJAX client driver
Hynek, there is a regression in ChUI in 1811r, which can be seen in the RADIO-SET widget (but is not related to RADIO... Constantin Asofiei

09/30/2015

03:10 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Task branch @2614a@ for review updated to revision @10947@ and @10948@(this is just syntax change for comment).
Th...
Eugenie Lyzenko
09:43 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Task branch @2614a@ for review updated to revision @10946@.
The update adds changes to support size phrase handlin...
Eugenie Lyzenko
03:09 PM Feature #1811: implement the AJAX client driver
> Did you try to log out? The parent process most likely didn't refresh its environment.
Checked the PATH variable, ...
Sergey Ivanovskiy
02:47 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> > The rules are based on the platform on which Progress is running. For Windows:
> >
...
Hynek Cihlar
02:36 PM Feature #1811: implement the AJAX client driver
> The rules are based on the platform on which Progress is running. For Windows:
>
> https://msdn.microsoft.com/e...
Sergey Ivanovskiy
02:20 PM Feature #1811: implement the AJAX client driver
The rules are based on the platform on which Progress is running. For Windows:
https://msdn.microsoft.com/en-us/l...
Greg Shah
02:02 PM Feature #1811: implement the AJAX client driver
> HOWEVER, I think it is easier to create a DLL. You can pattern it off of the @/uast/library_calls/testapi/@ "proje... Sergey Ivanovskiy
01:38 PM Feature #2564: implement GUI BROWSE widget
Thank you for your help! Stanislav Lomany
01:33 PM Feature #2564: implement GUI BROWSE widget
Don't worry about the artifacts now, those have been most likely resolved in #1811, task branch 1811r. Hynek Cihlar
01:25 PM Feature #2564: implement GUI BROWSE widget
Btw., I think you should use @NativeScrollContainer@ as the base class of @ColumnSetContainer@ as your scrolling unit... Hynek Cihlar
01:23 PM Feature #2564: implement GUI BROWSE widget
The problem was in @ColumnSetContainer.draw()@, the super.draw() was not properly scoped. See the checked-in fix. Hynek Cihlar
12:53 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Hynek
> > Is the change checked in?
> 2564a
> > What does it mean "container is scroll...
Hynek Cihlar
12:36 PM Feature #2564: implement GUI BROWSE widget
Hynek
> Is the change checked in?
2564a
> What does it mean "container is scrolled ok", do you see the scroll bars m...
Stanislav Lomany
12:27 PM Feature #2564: implement GUI BROWSE widget
> I was planning to put locked and scrollable columns on different panels, so manual drawing may really be the way t... Greg Shah
12:18 PM Feature #2564: implement GUI BROWSE widget
> Java hides the line stroking logic from us. In other words, in Java, how would we know how to set the clip rectangl... Stanislav Lomany
12:00 PM Feature #2564: implement GUI BROWSE widget
> For vertical lines we can draw the text of the cell in using very small clip rectangles matching line strokes. Over... Greg Shah
09:17 AM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Guys, I've subclassed @ScrollContainer@ and added tried to scroll it with @ScrollPaneGuiIm...
Hynek Cihlar
09:08 AM Feature #2564: implement GUI BROWSE widget
Greg, please consider the other approach for "inverse" coloring (it's not actually inverse but let's call it so). Of ... Stanislav Lomany
08:42 AM Feature #2564: implement GUI BROWSE widget
Guys, I've subclassed @ScrollContainer@ and added tried to scroll it with @ScrollPaneGuiImpl@. Container is scrolled ... Stanislav Lomany
05:09 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
If you want to check widget dimensions, please check the WIDTH/HEIGHT-CHARS and WIDTH/HEIGHT-PIXELS attributes for th... Constantin Asofiei
05:08 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've committed some changes. I think, at this moment common layout width is calculated not correctly. I used @/uast/t... Vadim Gindin
04:10 AM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Yes, I like that approach better. The current approach is too "implicit" and depends upon the current window having ... Greg Shah
02:13 AM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Greg, I think @Frame.initialize()@ should use the @FrameConfig.windowID@: if is set, resolve the explicit window and ... Constantin Asofiei

09/29/2015

07:58 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
Greg Shah wrote:
> I'm analyzing the code in @Window.tinyInput()@ with the intention to start making changes to impl...
Hynek Cihlar
06:19 PM Bug #2702: MESSAGE SET/UPDATE in GUI mode implicitly enables a special VIEW-AS ALERT-BOX mode
I'm analyzing the code in @Window.tinyInput()@ with the intention to start making changes to implement GUI-specific c... Greg Shah
05:46 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Created server-side counterpart of the @AutoResizable@ interface.
Committed to branch 2567b revno 10966
Igor Skornyakov
03:40 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
>
> Anyway, please re-test with more complex GUI tests to determine if anything else is ...
Igor Skornyakov
03:37 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
About 2567b rev 10964; I've committed my changes (formatting & misc fixes) to 10965. Following are some notes:
* fi...
Constantin Asofiei
02:01 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Resolved the issues mentioned in the code review except ones related to the @EDITOR@ widgets (sections 14-17).
Com...
Igor Skornyakov
01:56 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> I'll review 2567b rev 10963 shortly. Please point me to a test for EDITOR/BUTTON/COMBO-...
Igor Skornyakov
01:46 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Actually I've done with most of the issues you've mentioned in the code review. Only those ...
Constantin Asofiei
01:34 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Igor, I did some testing and I think you are somehow correct: when AUTO-RESIZE is ON and...
Igor Skornyakov
01:30 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor, I did some testing and I think you are somehow correct: when AUTO-RESIZE is ON and the FONT gets changed, 4GL u... Constantin Asofiei
12:10 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
>> I also agree that this should be done with care. However my main concern was about unification. At this moment GUI... Greg Shah
12:00 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Hynek Cihlar wrote:
> > I think this is relatively elegant way of class composition in Jav...
Hynek Cihlar
11:33 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> OK, I understand, but at least I missed checking the auto-resizing behaviour for the wid...
Igor Skornyakov
11:24 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
> I think this is relatively elegant way of class composition in Java (but miles away from Scala...
Igor Skornyakov
11:19 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Please confirm this through testing, if you haven't already....
Constantin Asofiei
11:13 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > To make GUI widgets' code more standardized I suggest to refactor them to simulate GUI `mixin`....
Hynek Cihlar
10:27 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> I'm open to this idea. It certainly has some promise. It has definitely been an objective to us...
Igor Skornyakov
10:24 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> To make GUI widgets' code more standardized I suggest to refactor them to simulate GUI `mixin`.
>
> Something li...
Greg Shah
03:37 PM Bug #2716 (WIP): The application with multiple windows doesn't start.
Constantin Asofiei
11:29 AM Bug #2716: The application with multiple windows doesn't start.
Greg Shah wrote:
> Yes, please do.
OK, I'll build my changes in branch 1811r, otherwise the multi-window tests in P...
Constantin Asofiei
11:04 AM Bug #2716: The application with multiple windows doesn't start.
Yes, please do. Greg Shah
11:04 AM Bug #2716: The application with multiple windows doesn't start.
The abends are fixed in 1811r rev 10948. The remaining issue is multi-window focus management. Greg, do you want me... Constantin Asofiei
02:12 PM Bug #2740: Focusing frame with no focusable widget causes an abend
Tested on p2j trunk, revision 10940.
The failing code sample:...
Hynek Cihlar
02:06 PM Bug #2740 (Closed): Focusing frame with no focusable widget causes an abend
Hynek Cihlar
01:56 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
In regard to the abend in note 96:
1. I have committed this as @testcases/uast/missing_window_attachment.p@.
2. T...
Greg Shah
09:17 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > Do /uast/fonts/widget.metrics/courie...
Constantin Asofiei
09:14 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Do /uast/fonts/widget.metrics/courier new/abcdef/3d/toggle-box-...
Vadim Gindin
03:56 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim Gindin wrote:
> Do /uast/fonts/widget.metrics/courier new/abcdef/3d/toggle-box-metrics.csv values somehow corr...
Constantin Asofiei
03:46 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Do /uast/fonts/widget.metrics/courier new/abcdef/3d/toggle-box-metrics.csv values somehow correlate with metrics I'd ... Vadim Gindin
01:37 PM Bug #2729: alert-box usage is broken
If this is alert-box related, please resolve it as part of #2560 (if your other fixes for alert-box don't already fix... Greg Shah
11:02 AM Bug #2737: Editor abends on double click
OK, I've managed to duplicate it in rev 1811r, too. Constantin Asofiei
10:43 AM Bug #2737: Editor abends on double click
Constantin Asofiei wrote:
> Hynek, do you have a 4GL testcases and a branch/revision where you see this? I'm having ...
Hynek Cihlar
09:52 AM Bug #2737: Editor abends on double click
Hynek, do you have a 4GL testcases and a branch/revision where you see this? I'm having trouble recreating it. Constantin Asofiei
10:59 AM Feature #2564: implement GUI BROWSE widget
> do we have a function that returns color of the specific pixel? I'm asking because dotted line that highlights the ... Greg Shah
10:11 AM Feature #2564: implement GUI BROWSE widget
Guys, do we have a function that returns color of the specific pixel? I'm asking because dotted line that highlights ... Stanislav Lomany
10:58 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Note that the ALERT-BOX runtime is broken currently (I think i...
Constantin Asofiei
10:54 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Note that the ALERT-BOX runtime is broken currently (I think is broken in trunk, too): ...
Hynek Cihlar
10:51 AM Feature #1811: implement the AJAX client driver
In note 1319 I meant branch 1811r rev 10948, not 10947. Constantin Asofiei
10:50 AM Feature #1811: implement the AJAX client driver
Branch 1811r rev -10947- 10948 contains a refactoring on how the GUI driver is accessed: to allow concurrent usage, t... Constantin Asofiei
10:29 AM Feature #1811: implement the AJAX client driver
> Agreed, do it. Please put in a readme.txt that explains how to set it up and run it.
Committed revision 1356 for ...
Sergey Ivanovskiy
08:24 AM Feature #1811: implement the AJAX client driver
On 09/28/2015 03:41 PM, Serg Ivanovskiy wrote:
> Greg,
>
> Now, I am working on #1811-1284
>
> The template cons...
Greg Shah
07:56 AM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> Greg, I would like to commit the keystroke JS test to @testcases/uast/keyboards@ for the ...
Greg Shah
10:58 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Rebased task branch @2614a@ from P2J trunk revision @10941@, new branch revision is @10945@. Eugenie Lyzenko
09:38 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Task branch @2614a@ for review updated to revision @10944@.
Adding support for horizontal radio-set and expand att...
Eugenie Lyzenko

09/28/2015

05:50 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Please confirm this through testing, if you haven't already. But, what if @AUTO-RESIZE@...
Igor Skornyakov
05:33 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Strangely enough today in my tests (@ar*.p@) triggers are not invoked. Actullay these apps ...
Igor Skornyakov
05:20 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Strangely enough today in my tests (@ar*.p@) triggers are not invoked. Actullay these apps seem not to react on most ... Igor Skornyakov
04:33 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Thank you Constantin. I will review my code. Igor Skornyakov
04:19 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> > Second, about the EDITOR widget and all widgets which require an explicit size, and don't...
Constantin Asofiei
04:16 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Implemented @AUTO-RESIZE@ support for ChUI widgets (where applicable).
Comitted to branch 2567b revno 10963
Igor Skornyakov
11:56 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> You've been fooled by a font. :)
>
> We have found out the hard way on many, many occasions th...
Igor Skornyakov
11:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
You've been fooled by a font. :)
We have found out the hard way on many, many occasions that we really can *never*...
Greg Shah
11:50 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> This doesn't seem to be a normal case. By the time @initialize()@ is called, the parent hierarch...
Igor Skornyakov
11:49 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Please don't ever trust the 4GL documentation.
I understand but in this case it is written in ...
Igor Skornyakov
11:42 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Greg Shah wrote:
> > Hmmm. The two ways we get this argument is though @Window.resolveWin...
Greg Shah
11:42 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Greg Shah wrote:
> > Are you talking about ChUI or GUI?
> >
> > If you haven't tested i...
Greg Shah
11:38 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Are you talking about ChUI or GUI?
>
> If you haven't tested it on ChUI, please do so and reco...
Igor Skornyakov
11:33 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Are you talking about ChUI or GUI?
If you haven't tested it on ChUI, please do so and record your results.
Greg Shah
11:31 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Please put enough comments into the code such that readers can understand this. Explain that it ...
Igor Skornyakov
11:30 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Hmmm. The two ways we get this argument is though @Window.resolveWindow(this)@ or in looking up ...
Igor Skornyakov
11:28 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> The reason was that GuiFontResolver constructor was invoked with the null first (window) argument
Hmmm. The two...
Greg Shah
11:19 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > Well, I think I understand the reason.
>
> In regard to note 338, please share your findings...
Igor Skornyakov
11:15 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> The documentation explicitely states that AUTO-RESIZE semantics if for GUI only.
Please put enough comments into...
Greg Shah
11:13 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> Well, I think I understand the reason.
In regard to note 338, please share your findings. It is great that you ...
Greg Shah
11:11 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Thank you Constantin.
> First of all, please rebase and upgrade your system to Java 8.
As per Greg's instructio...
Igor Skornyakov
10:32 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
First of all, please rebase and upgrade your system to Java 8.
Second, about the EDITOR widget and all widgets whi...
Constantin Asofiei
02:49 PM Feature #1811: implement the AJAX client driver
Greg, I would like to commit the keystroke JS test to @testcases/uast/keyboards@ for the web client in order to trac... Sergey Ivanovskiy
09:13 PM Feature #1811: implement the AJAX client driver
Fixed CTRL+SHIFT. Committed revision 10947. Sergey Ivanovskiy
08:44 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> The checked in revision 10946 fixes the layout and draw issues which involved insets. Also scr...
Hynek Cihlar
08:43 PM Feature #1811: implement the AJAX client driver
The checked in revision 10946 fixes the layout and draw issues which involved insets. Also scrollbar size doesn't dep... Hynek Cihlar
10:44 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Vadim, have you tested setting the toggle-box's LABEL? Because the @FONT@ can be set at the @TOGGLE-BOX@ widget, but... Constantin Asofiei
08:52 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> I don't understand the step, described in the #2546 note 98 about excel.
Your objective is to find the formula t...
Greg Shah
10:19 AM Feature #2564: implement GUI BROWSE widget
Reference text clipping:
!w.png!
Stanislav Lomany
06:50 AM Feature #2560: implement GUI DIALOG-BOX support
Rebased task branch 2560a from P2J trunk revision 10940. The current revision in 2560a is now 10945. Hynek Cihlar

09/27/2015

04:15 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I've committed gathered toggle-box metrics. There are no possibility to set specific font for toggle-box, so I delete... Vadim Gindin
01:23 PM Feature #2564: implement GUI BROWSE widget
Stanislav Lomany wrote:
> Guys, there is an issue: when I call @draw()@ and @requestSync()@ on mouse/key event, brow...
Constantin Asofiei
01:22 PM Feature #2564: implement GUI BROWSE widget
Guys, there is an issue: when I call @draw()@ and @requestSync()@ on mouse/key event, browse offset is sometimes calc... Stanislav Lomany
06:40 AM Bug #2737: Editor abends on double click
To reproduce, position the cursor so that a double click doesn't result in a word selection, for example in between t... Hynek Cihlar
06:36 AM Bug #2737 (Closed): Editor abends on double click
Hynek Cihlar

09/26/2015

06:10 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
To make GUI widgets' code more standardized I suggest to refactor them to simulate GUI `mixin`.
Something like thi...
Igor Skornyakov
10:59 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added AUTO-RESIZE reset on the size attributes' assignment
Comitted to branch 2567b revno 10962.
Ready for the ...
Igor Skornyakov
10:39 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Added JavaDocs
Comitted to branch 2567b revno 10961.
Igor Skornyakov
09:12 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
@EDITOR:AUTO-RESIZE@ support is finished.
Comitted to branch 2567b revno 10960.
Now the behavior of the widget...
Igor Skornyakov
04:55 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
BTW: I've noticed that in many cases the @GuiFontResolver@ constructor is invoked with the @null@ @window@ argument. ... Igor Skornyakov
04:39 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> I'm very confused.
>
> With the @uast/auto_resize/are.p@ the @EDITOR@ widget seems to d...
Igor Skornyakov

09/25/2015

05:50 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
I'm very confused.

With the @uast/auto_resize/are.p@ the @EDITOR@ widget seems to doesn't `see` the @FONT@ attrib...
Igor Skornyakov
05:21 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Task branch @2614a@ for review updated to revision @10943@.
This is the first working prototype for review. Under ...
Eugenie Lyzenko
07:15 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Greg Shah wrote:
>
> Those are the most obvious possibilities. I haven't seen this particular behavior in other w...
Eugenie Lyzenko
05:51 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Eugenie Lyzenko wrote:
> Strange shadow corner started to draw after rebase with @10940@. Please see the picture, pr...
Constantin Asofiei
05:17 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Then again, you were already based off of 10939 before the recent rebase, so this must be due to some change in 10940... Greg Shah
05:00 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Starting with rev 10937, there were substantial changes to container processing, scrolling, borders... this could hav... Greg Shah
09:34 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
The picture. Eugenie Lyzenko
09:33 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Strange shadow corner started to draw after rebase with @10940@. Please see the picture, problematic area is in red. ... Eugenie Lyzenko
09:07 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Rebased task branch @2614a@ from P2J trunk revision @10940@, new branch revision is @10942@. Eugenie Lyzenko
09:07 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Task branch @2614a@ for review updated to revision @10941@.
Several fixes and more preparation to the having proto...
Eugenie Lyzenko
02:40 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Are you using the on-screen keyboard on windev01?
No, missed this important detail, check...
Sergey Ivanovskiy
02:27 PM Feature #1811: implement the AJAX client driver
1811r rev 10945 contains the fix for an artifact seen when closing the combo's drop-down: when clearing the content, ... Constantin Asofiei
01:48 PM Feature #1811: implement the AJAX client driver
Sergey Ivanovskiy wrote:
> > From Constantin:
> >
> > > Now the web client for this combination CTRL + SHIFT + '4...
Constantin Asofiei
01:26 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> 1811r revision 10944 contains misc fixes related to scroll button clip + the frame detac...
Hynek Cihlar
01:25 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek, there is an inconsistency in scrollbar drawing and paren...
Constantin Asofiei
01:21 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Hynek, there is an inconsistency in scrollbar drawing and parenting; the drawing is done...
Hynek Cihlar
01:16 PM Feature #1811: implement the AJAX client driver
1811r revision 10944 contains misc fixes related to scroll button clip + the frame detach issue from #2716.
An imp...
Constantin Asofiei
01:13 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Followup for notes 1294/1295/1...
Hynek Cihlar
01:00 PM Feature #1811: implement the AJAX client driver
> From Constantin:
>
> > Now the web client for this combination CTRL + SHIFT + '4' produces 36($ for US keyboard) a...
Sergey Ivanovskiy
12:40 PM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Followup for notes 1294/1295/1298: the scrollbar drawing is bei...
Constantin Asofiei
12:37 PM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Followup for notes 1294/1295/1298: the scrollbar drawing is being performed twice, once ...
Hynek Cihlar
12:27 PM Feature #1811: implement the AJAX client driver
Followup for notes 1294/1295/1298: the scrollbar drawing is being performed twice, once from @BorderedPanelGuiImpl@ a... Constantin Asofiei
11:02 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Hynek Cihlar wrote:
> > @BorderedPanelGuiImpl@ incorrectly translates its location twice, first ...
Hynek Cihlar
10:56 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> I don't think this is the case from note 1276. Is is possible that ... belongs to one of the p...
Constantin Asofiei
09:16 AM Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> Hynek Cihlar wrote:
> > @BorderedPanelGuiImpl@ incorrectly translates its location twice, first ...
Hynek Cihlar
09:14 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Hynek, there is an inconsistency in scrollbar drawing and parenting; the drawing is done...
Hynek Cihlar
09:10 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Hynek, there is an inconsistency in scrollbar drawing and parenting; the drawing is done...
Hynek Cihlar
08:58 AM Feature #1811: implement the AJAX client driver
Hynek, there is an inconsistency in scrollbar drawing and parenting; the drawing is done using this call chain:
<pre...
Constantin Asofiei
08:00 AM Feature #1811: implement the AJAX client driver
Constantin Asofiei wrote:
> Sergey, the problem here is that if you press CTRL-SHIFT-4 and the browser sends CTRL-$ (...
Sergey Ivanovskiy
07:10 AM Feature #1811: implement the AJAX client driver
In 1811r rev 10941 following issues are addressed (if not mentioned, it affects both Web and Swing drivers):
# windo...
Constantin Asofiei
06:56 AM Feature #1811: implement the AJAX client driver
> Looks like the putImageData function is not aware of the clipped region.
Nice find!
Greg Shah
06:02 AM Feature #1811: implement the AJAX client driver
Greg/Sergey: I found the cause of the leaked drawing in JS code. Looks like the @putImageData@ function is not aware... Constantin Asofiei
04:57 AM Feature #1811: implement the AJAX client driver
Hynek Cihlar wrote:
> @BorderedPanelGuiImpl@ incorrectly translates its location twice, first and correct before the...
Greg Shah
02:38 PM Bug #2716: The application with multiple windows doesn't start.
An example of P2J window selection done while P2J is drawing is this:... Constantin Asofiei
01:23 PM Bug #2716: The application with multiple windows doesn't start.
Greg Shah wrote:
> At some point, the Java environment has queued up a @WindowActivated@ event for one of the creat...
Constantin Asofiei
01:18 PM Bug #2716: The application with multiple windows doesn't start.
I've added the fix for notes 7/8 in 1811r rev 10944. The reason this is required is because frames are in GUI are no... Constantin Asofiei
01:12 PM Bug #2716: The application with multiple windows doesn't start.
The last results were with your fix applied. I'm not sure I fully understand the ramifications of your change. Befo... Greg Shah
01:10 PM Bug #2716: The application with multiple windows doesn't start.
The WAIT-FOR exits immediately because of this code (@waitForWorker()@):... Greg Shah
11:20 AM Bug #2716: The application with multiple windows doesn't start.
To get past the abend, override @detach()@ in @WindowGuiImpl@:... Constantin Asofiei
11:12 AM Bug #2716: The application with multiple windows doesn't start.
The problem is in @TC.viewWorker:9234@:... Constantin Asofiei
09:33 AM Bug #2716: The application with multiple windows doesn't start.
It looks to me like we have a "ghostbusters" problem here. We have "crossed streams" of drawing operations. :) Greg Shah
09:32 AM Bug #2716: The application with multiple windows doesn't start.
The code for the failing testcase:... Greg Shah
09:29 AM Bug #2716: The application with multiple windows doesn't start.
With 1811r revision 10942, the failure's actual cause can be seen:... Greg Shah
09:17 AM Bug #2734 (Closed): button/gui_btn_test4.p abend after pause
Task branch 1811r revision 10942 has the fix for this issue. Greg Shah
09:06 AM Bug #2734: button/gui_btn_test4.p abend after pause
Thank you. I'll include that change and some related comments in my next check-in. Greg Shah
08:30 AM Bug #2734: button/gui_btn_test4.p abend after pause
The P2J code fails during this invocation during drawing, as it interrogates the server-side to determine the UI them... Constantin Asofiei
08:23 AM Bug #2734: button/gui_btn_test4.p abend after pause
Greg Shah wrote:
> I guess the other question is whether it is valid to have batch still be active while returning c...
Constantin Asofiei
08:09 AM Bug #2734: button/gui_btn_test4.p abend after pause
Here is where we generate the exception (@AbstractGuiImpl@ line 1508):... Greg Shah
07:57 AM Bug #2734: button/gui_btn_test4.p abend after pause
The logging is now checked into the trunk at revision 10940. The latest run of the program abends with this:
<pre...
Greg Shah
09:10 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Yes, I can some time. Vadim Gindin
07:36 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I'll add this to the list of open issues.
Can you continue your work without this being fixed?
Greg Shah
07:02 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I had a test, that dynamically creates toggle-box in specified frames, but when I faced with that error I've removed ... Vadim Gindin
04:44 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> Does it known error?
I have not seen it before, but we have had many regressions in GUI recently so this may be ...
Greg Shah

09/24/2015

06:29 PM Feature #1811: implement the AJAX client driver
Created task branch 1811r from P2J trunk revision 10940. Greg Shah
06:26 PM Feature #1811: implement the AJAX client driver
CTRL-C testing has completed successfully.
Task branch 1811q has been merged into P2J trunk as revision 10940.
Task...
Greg Shah
04:33 PM Feature #1811: implement the AJAX client driver
Main runtime regression testing has passed. CTRL-C testing is starting now. Greg Shah
04:03 PM Feature #1811: implement the AJAX client driver
This schema of the Progress 4GL keys capture has a JS analog. http://unixpapa.com/js/testkey.html has a text area tha... Sergey Ivanovskiy
03:10 PM Feature #1811: implement the AJAX client driver
In regard to capturing more data about how the 4GL handles its key processing, we can write a WIN32 program to help u... Greg Shah
03:01 PM Feature #1811: implement the AJAX client driver
Greg/Sergey: I found the clipping problem in JS. For the Swing client, setting a new clip region means intersecting ... Constantin Asofiei
01:36 PM Feature #1811: implement the AJAX client driver
Sergey, the problem here is that if you press CTRL-SHIFT-4 and the browser sends CTRL-$ (with or without the SHIFT mo... Constantin Asofiei
01:27 PM Feature #1811: implement the AJAX client driver
Hi Constantin,
No, I don't know how to find for a key its SHIFT counterpart but it is possible to generate all cod...
Sergey Ivanovskiy
12:45 PM Feature #1811: implement the AJAX client driver
Regression testing has been restarted. On the last run, only GSO 237 and tc_codes_employees_21 failed. Greg Shah
12:42 PM Feature #1811: implement the AJAX client driver
Committed revision 11042 fixes 0...31 codes generated by CTRL + . key sequence and TAB, SHIFT-TAB according to the pa... Sergey Ivanovskiy
12:14 PM Feature #1811: implement the AJAX client driver
I got 2 failures in the main runtime regression run. They are probably false negatives. I'm just about to start ano... Greg Shah
10:22 AM Feature #1811: implement the AJAX client driver
Greg, could you permit me to commit the keyboard changes? This is important because for example TAB button is fixed a... Sergey Ivanovskiy
07:58 AM Feature #1811: implement the AJAX client driver
@BorderedPanelGuiImpl@ incorrectly translates its location twice, first and correct before the insets/border are acco... Hynek Cihlar
05:25 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
@Widget 4@ is a frame. Vadim Gindin
05:18 PM Feature #2513: implement GUI runtime support for TOGGLE-BOX
I'm trying to run (GUI) simple test:... Vadim Gindin
09:24 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
> Did I understand you right?
Roughly. Follow the process as described in #2546-98 except you should adapt it to ...
Greg Shah
08:42 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Greg Shah wrote:
> Do you have the list prepared? Please post it.
I haven't it yet. I tried to dig into size equ...
Vadim Gindin
08:34 AM Feature #2513: implement GUI runtime support for TOGGLE-BOX
Do you have the list prepared? Please post it.
Also, since this is to be the second check-in for this task, the b...
Greg Shah
04:18 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Implemented @BUTTON:AUTO-RESIZE@ support.
Committed to branch 2567b revno 10959
Igor Skornyakov
02:51 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Eugenie, can you provide some details when the combo's width is computed in ComboBoxGuiI...
Eugenie Lyzenko
02:20 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Implemented @COMBO-BOX:AUTO-RESIZE@ support.
Committed to branch 2567b revno 10958
Igor Skornyakov
02:19 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> Eugenie, can you provide some details when the combo's width is computed in ComboBoxGuiI...
Igor Skornyakov
02:01 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Eugenie, can you provide some details when the combo's width is computed in ComboBoxGuiImpl? Constantin Asofiei
01:52 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Constantin Asofiei wrote:
> I think the combo's width is computed in @ComboBoxGuiImpl.calcLimit()@.
I was thinkin...
Igor Skornyakov
01:40 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> It seems that I was not clear enough, sorry. Actually I was asking about re-computation of ...
Constantin Asofiei
01:22 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
>> On 24.09.2015 18:26, ias wrote:
>>> Constantin,
>>> I'm working now on AUTO-RESIZE support and have discovered t...
Igor Skornyakov
08:18 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > The remaining widgets are BUTTON, COMBO-BOX (working on now) and EDITOR. There is also small th...
Igor Skornyakov
08:03 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> The remaining widgets are BUTTON, COMBO-BOX (working on now) and EDITOR. There is also small thing to add setting A... Greg Shah
08:00 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Igor Skornyakov wrote:
> > The @SELECTION-LIST:AUTO-RESIZE@ support is finished.
> > Committed ...
Igor Skornyakov
07:42 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> The @SELECTION-LIST:AUTO-RESIZE@ support is finished.
> Committed to branch 2567b revno 10...
Greg Shah
07:11 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Hynek Cihlar wrote:
> I agree the @afterConfigUpdateBase()@ implemented in the class not implementing @WidgetWithCon...
Igor Skornyakov
06:48 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Igor Skornyakov wrote:
> Greg Shah wrote:
> > 1. It is generic and the more specific implementation point means that ...
Hynek Cihlar
04:55 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
The @SELECTION-LIST:AUTO-RESIZE@ support is finished.
Committed to branch 2567b revno 10957.
I've noticed the fol...
Igor Skornyakov
10:03 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
Task branch @2614a@ for review updated to revision @10940@.
Just prepare to the separation of the @GUI@ code. For ...
Eugenie Lyzenko

09/23/2015

07:55 PM Feature #1811: implement the AJAX client driver
Okay, the attached file contains fixes for the key codes from 0 to 31 (CTRL + *). Sergey Ivanovskiy
06:49 PM Feature #1811: implement the AJAX client driver
Code Review Task Branch 1811q Revision 11041
After much cleanup, this version seems like a release candidate. We ...
Greg Shah
05:55 PM Feature #1811: implement the AJAX client driver
Committed revision 11040 has minor changes for the key test.
In the attachment there is the first part of the key tes...
Sergey Ivanovskiy
04:58 PM Feature #1811: implement the AJAX client driver
Rebased task branch 1811q from P2J trunk revision 10939. The latest revision is now 11039. Greg Shah
03:11 PM Feature #1811: implement the AJAX client driver
fix NPE from #2707, fix small drawing menu bug for CHUI: mnemonic for the focused menu-item is displayed without unde... Vadim Gindin
01:07 PM Feature #1811: implement the AJAX client driver
Checked in revision 11035 resolves the abend reported in #2700 note 5. Hynek Cihlar
09:57 AM Feature #1811: implement the AJAX client driver
I would like to compare the codes produced by @GuiKeyboardReader@ with Progress 4GL key codes (./testcases/uast/keybo... Sergey Ivanovskiy
09:37 AM Feature #1811: implement the AJAX client driver
How much more work is remaining in the "first phase" of key processing? Greg Shah
09:37 AM Feature #1811: implement the AJAX client driver
From Constantin:
> Now the web client for this combination CTRL + SHIFT + '4' produces 36($ for US keyboard) as SH...
Greg Shah
09:36 AM Feature #1811: implement the AJAX client driver
From Sergey:
From the documentation ( dvpin.pdf you advised to study) it follows there is the base key set encoded...
Greg Shah
09:31 AM Feature #1811: implement the AJAX client driver
Committed revision 11034 fixes the 11032 (task 1811 note 1263). Sergey Ivanovskiy
08:10 AM Feature #1811: implement the AJAX client driver
Committed revision 11033 implements the logic from WinKeyboardReader. Planning to use Selenium to enumerate all keybo... Sergey Ivanovskiy
06:08 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Well, at least now @HEIGHT-CHARS@ and @WIDTH-CHARS@ are non-zero in GUI mode (however the values are a little greater... Igor Skornyakov
05:27 PM Feature #2567: add misc widget support part 2: more options, attributes and methods
Something strange is going on with the @EDITOR@ widget. With the @uast/auto_resize/are.p@ in ChUI mode both @HEIGHT-C... Igor Skornyakov
09:43 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> > EDITOR:(WIDTH-CHAR/WIDTH-PIXELS) are always 0.
>
> What testcase in @testcases/uast/@ can be...
Igor Skornyakov
09:41 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> EDITOR:(WIDTH-CHAR/WIDTH-PIXELS) are always 0.
What testcase in @testcases/uast/@ can be used to see this?
Greg Shah
08:35 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> Please go ahead and fix this. I think it is best to just detect that the system is in ChUI mode ...
Igor Skornyakov
08:33 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Please go ahead and fix this. I think it is best to just detect that the system is in ChUI mode (on the server side)... Greg Shah
08:30 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
Greg Shah wrote:
> What does this same program do in 4GL ChUI?
It reports an error...
Igor Skornyakov
08:24 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
> It is not possible to run an application which references to a FONT attribute in the ChUI mode.
What does this s...
Greg Shah
07:12 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
EDITOR:(WIDTH-CHAR/WIDTH-PIXELS) are always 0. Igor Skornyakov
06:52 AM Feature #2567: add misc widget support part 2: more options, attributes and methods
It is not possible to run an application which references to a @FONT@ attribute in the ChUI mode.... Igor Skornyakov
04:56 PM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
Task branch 1811q revision 11038 adds logging for unexpected throwables in Dispatcher.processInbound(). At this time ... Greg Shah
04:21 PM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
Greg Shah wrote:
> What about in virtual sessions?
If you mention virtual sessions, when remote persistence is us...
Constantin Asofiei
04:13 PM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
What about in virtual sessions? I wonder if there are cases where @StackUnwindException@ (and sub-classes) can be se... Greg Shah
04:02 PM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
Greg Shah wrote:
> What about @SilentUnwindException@ or @InterruptedException@?
Yes, these too should not be logge...
Constantin Asofiei
03:46 PM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
What about @SilentUnwindException@ or @InterruptedException@? Greg Shah
03:40 PM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
Greg Shah wrote:
> > The stacktrace was obtained by using a breakpoint in Dispatcher.processInbound:712 and evaluati...
Constantin Asofiei
03:33 PM Bug #2700 (Closed): gui_btn_test4.p abend with "Invalid frame ID 4"
Greg Shah
02:15 PM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
Greg Shah wrote:
> Please list the things to be done to get a long-term fix for this.
The method @WindowGuiImpl.t...
Hynek Cihlar
02:08 PM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
Please list the things to be done to get a long-term fix for this. Greg Shah
01:08 PM Bug #2700: gui_btn_test4.p abend with "Invalid frame ID 4"
A workaround fix for the abend from note 5 checked in to 1811q revision 11035. Hynek Cihlar
03:37 PM Bug #2707 (Closed): menu/simple_sm.p causes an infinite loop where the window flashes and the OS ...
Greg Shah
03:15 PM Bug #2707: menu/simple_sm.p causes an infinite loop where the window flashes and the OS is nearly...
fix NPE, fix small drawing menu bug for CHUI: mnemonic for the focused menu-item is displayed without underline, fix ... Vadim Gindin
03:01 PM Bug #2707: menu/simple_sm.p causes an infinite loop where the window flashes and the OS is nearly...
> I'm going to move my changes there, test it and commit.
Yes, please do.
Greg Shah
02:32 PM Bug #2707: menu/simple_sm.p causes an infinite loop where the window flashes and the OS is nearly...
Greg Shah wrote:
> Have you been able to recreate this issue?
Well, yes I've added menu-items with empty label an...
Vadim Gindin
02:26 PM Bug #2707: menu/simple_sm.p causes an infinite loop where the window flashes and the OS is nearly...
Have you been able to recreate this issue? Greg Shah
12:04 PM Bug #2707: menu/simple_sm.p causes an infinite loop where the window flashes and the OS is nearly...
Constantin reported that it was working too, but he found that his version was modified from the one in @testcases/ua... Greg Shah
11:37 AM Bug #2707: menu/simple_sm.p causes an infinite loop where the window flashes and the OS is nearly...
Greg Shah wrote:
> Vadim: could you look at this?
>
> It looks like this problem can occur when the @MenuItem.Lab...
Vadim Gindin
03:37 PM Bug #2736: fix GUI menu drawing problems in menu/simple_sm.p
See #2707-11 for details. Greg Shah
03:36 PM Bug #2736 (Closed): fix GUI menu drawing problems in menu/simple_sm.p
Greg Shah
03:34 PM Bug #2735: fix WindowGuiImpl.truncateWindowHeightQuirk()
Make sure to re-test the @button/gui_btn_test4.p@ after this is fixed to make sure that the abend does not recur. Greg Shah
03:29 PM Bug #2735: fix WindowGuiImpl.truncateWindowHeightQuirk()
See #2700-16 for details. Greg Shah
03:28 PM Bug #2735 (New): fix WindowGuiImpl.truncateWindowHeightQuirk()
Greg Shah
03:12 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
I have not checked all places in the app code, but my quick looks shows that @CHARACTER@, @INTEGER@ and @LOGICAL@ are... Greg Shah
02:31 PM Feature #2614: implement GUI runtime support for RADIO-SET widget
>Make sure that the existing widget options, attributes and methods are fully supported in the GUI runtime code.
Loo...
Eugenie Lyzenko
11:25 AM Feature #2614: implement GUI runtime support for RADIO-SET widget
Created task branch @2614a@ from trunk revision @10939@. Eugenie Lyzenko
02:13 PM Bug #2734: button/gui_btn_test4.p abend after pause
This is the abend (to see it one must have the logging added to the @Dispatcher.processInbound()@ as described in #27... Greg Shah
02:11 PM Bug #2734 (Closed): button/gui_btn_test4.p abend after pause
Greg Shah
12:35 PM Feature #2564: implement GUI BROWSE widget
> Do you have any idea if these vertical positioning rules are the same as for fill-in?
Brief investigations showe...
Stanislav Lomany
12:10 PM Feature #2564: implement GUI BROWSE widget
Do you have any idea if these vertical positioning rules are the same as for fill-in?
We already know of another c...
Greg Shah
10:33 AM Feature #2564: implement GUI BROWSE widget
I forgot about one metrics. Vertical text positioning in a cell. Unfortunatly P2J doesn't solve the similair problem ... Stanislav Lomany
11:47 AM Bug #2730: taller than default fill-in height causes text to be vertically mis-positioned
As can be seen in #2715-5 the text of a fill-in can be vertically centered in the 4GL when the fill-in is taller than... Greg Shah
11:45 AM Bug #2730 (Closed): taller than default fill-in height causes text to be vertically mis-positioned
Greg Shah
10:23 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
The slider widget testcases have been added to bzr repo(revision 1344). Eugenie Lyzenko
01:00 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Branch @2612a@ was merged to trunk as revno @10939@. Archived. Eugenie Lyzenko
12:52 AM Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
The conversion testing is completed. Generated sources are identical, starting merge into trunk. Eugenie Lyzenko
 

Also available in: Atom