Project

General

Profile

Bug #3375

Stack overflow kills the client

Added by Ovidiu Maxiniuc over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version:

History

#1 Updated by Ovidiu Maxiniuc over 6 years ago

The client got killed (not reset). Just before that the two shown windows started blinking alternatively. This is probably explained by the following stack trace I found in client log:

Caused by: java.lang.StackOverflowError
    at java.util.HashMap.hash(HashMap.java:338)
    at java.util.HashMap.get(HashMap.java:556)
    at com.goldencode.p2j.security.ContextLocal.set(ContextLocal.java:529)
    at com.goldencode.p2j.ui.client.WindowManager.processWindowActivated(WindowManager.java:1857)
    at com.goldencode.p2j.ui.client.WindowManager.windowActivated(WindowManager.java:1513)
    at com.goldencode.p2j.ui.client.chui.driver.ChuiOutputManager.activateWindow(ChuiOutputManager.java:208)
    at com.goldencode.p2j.ui.client.OutputManager.setInvalidate(OutputManager.java:1320)
    at com.goldencode.p2j.ui.client.gui.driver.GuiOutputManager.setInvalidate(GuiOutputManager.java:199)
    at com.goldencode.p2j.ui.client.OutputManager.resetInvalidate(OutputManager.java:1385)
    at com.goldencode.p2j.ui.client.OutputManager.saveInvalidate(OutputManager.java:1401)
    at com.goldencode.p2j.ui.chui.ThinClient.independentEventDrawingBracket(ThinClient.java:15226)
    at com.goldencode.p2j.ui.client.WindowManager.processWindowActivated(WindowManager.java:1865)
    at com.goldencode.p2j.ui.client.WindowManager.windowActivated(WindowManager.java:1513)
    at com.goldencode.p2j.ui.client.chui.driver.ChuiOutputManager.activateWindow(ChuiOutputManager.java:208)
    at com.goldencode.p2j.ui.client.OutputManager.setInvalidate(OutputManager.java:1320)
    at com.goldencode.p2j.ui.client.gui.driver.GuiOutputManager.setInvalidate(GuiOutputManager.java:199)
    at com.goldencode.p2j.ui.client.OutputManager.resetInvalidate(OutputManager.java:1385)
    at com.goldencode.p2j.ui.client.OutputManager.saveInvalidate(OutputManager.java:1401)
    at com.goldencode.p2j.ui.chui.ThinClient.independentEventDrawingBracket(ThinClient.java:15226)
    at com.goldencode.p2j.ui.client.WindowManager.processWindowActivated(WindowManager.java:1865)
    at com.goldencode.p2j.ui.client.WindowManager.windowActivated(WindowManager.java:1513)
    at com.goldencode.p2j.ui.client.chui.driver.ChuiOutputManager.activateWindow(ChuiOutputManager.java:208)
    [...]

#2 Updated by Hynek Cihlar over 6 years ago

Created task branch 3375a and checked in the fix. The changes passed GUI regression tests, ChUI regression testing is in progress. Please review.

#3 Updated by Ovidiu Maxiniuc over 6 years ago

  • Status changed from New to WIP
  • Assignee set to Hynek Cihlar

#4 Updated by Greg Shah over 6 years ago

Code Review Task Branch 3375a Revision 11203

I'm fine with the changes. Did ChUI regression testing finish?

#5 Updated by Hynek Cihlar over 6 years ago

Greg Shah wrote:

Code Review Task Branch 3375a Revision 11203

I'm fine with the changes. Did ChUI regression testing finish?

It finished with one regression, I am currently fixing the issue. I don't expect the fix to take long given the amount of original changes.

#6 Updated by Hynek Cihlar over 6 years ago

Hynek Cihlar wrote:

It finished with one regression, I am currently fixing the issue. I don't expect the fix to take long given the amount of original changes.

The regression is fixed in 3375a revision 11204 and ChUI regression tests restarted.

#7 Updated by Greg Shah over 6 years ago

Code Review Task Branch 3375a Revision 11204

The changes are fine. The difference now is very slight.

If it passes testing, you can merge to trunk.

#8 Updated by Hynek Cihlar over 6 years ago

Greg Shah wrote:

Code Review Task Branch 3375a Revision 11204

The changes are fine. The difference now is very slight.

If it passes testing, you can merge to trunk.

Ctrl-c passed, Main part failed with what seem to be false failures. I will do another test run.

#9 Updated by Hynek Cihlar over 6 years ago

3375a passed regression tests, rebased, merged to trunk as revision 11205 and archived.

#10 Updated by Greg Shah over 6 years ago

  • % Done changed from 0 to 100
  • Status changed from WIP to Closed

Also available in: Atom PDF