Project

General

Profile

Bug #3637

The frame is not shown with its default window after executing 'enable all with frame'

Added by Sergey Ivanovskiy almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Hynek Cihlar
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version:

History

#1 Updated by Sergey Ivanovskiy almost 6 years ago

Executing this simple program with the current trunc doesn't show the target frame with its default window

def var q1 as char label "Char field q1".
def button s1 label "Button s1".

def frame f1 q1 s1 with side-labels.

enable all with frame f1.

wait-for close of this-procedure.

#2 Updated by Greg Shah almost 6 years ago

  • Project changed from FWD to User Interface
  • Assignee set to Hynek Cihlar
  • Start date deleted (06/26/2018)

#3 Updated by Hynek Cihlar almost 6 years ago

I think the following issue is related. The sample below displays two window instances.

message "Show default window".
view default-window. /* what? another one? */
wait-for close of this-procedure.

#4 Updated by Hynek Cihlar almost 6 years ago

Constantin, is the frame._isVisible() in GenericFrame.updateDynamicContent really meant as the check for the value of the VISIBLE attribute or whether the frame has been realized and visible on the screen?

The problem is that due to the check the last line in the method body, frameBuf.setCurrentStatement(currentStatement);, is not executed and so the current statement in the screen buffer is not set. This leads to the current issue, the top-level window is not made visible.

#5 Updated by Constantin Asofiei almost 6 years ago

Hynek Cihlar wrote:

Constantin, is the frame._isVisible() in GenericFrame.updateDynamicContent really meant as the check for the value of the VISIBLE attribute

This one - just frame's visible state.

The problem is that due to the check the last line in the method body, frameBuf.setCurrentStatement(currentStatement);, is not executed and so the current statement in the screen buffer is not set. This leads to the current issue, the top-level window is not made visible.

This seems like a bug, move the setCurrentStatement call before the frame._isVisible() check.

#6 Updated by Hynek Cihlar almost 6 years ago

Fix checked in to 3600b revision 11295. Please review.

#7 Updated by Hynek Cihlar almost 6 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 90

#8 Updated by Greg Shah almost 6 years ago

Code Review Task Branch 3600b Revision 11295

I'm good with the change.

#9 Updated by Greg Shah almost 6 years ago

  • Status changed from Feedback to Test

Is there anything still to do with this task?

#10 Updated by Hynek Cihlar almost 6 years ago

  • % Done changed from 90 to 100

Greg Shah wrote:

Is there anything still to do with this task?

No, it can be closed.

#11 Updated by Eric Faulhaber almost 6 years ago

  • Status changed from Test to Closed

Also available in: Atom PDF