Project

General

Profile

Feature #3927

conversion mode that takes a file spec and a file blacklist

Added by Eric Faulhaber about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD

Related issues

Related to Conversion Tools - Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode Closed
Related to Conversion Tools - Bug #5021: improve/fix file-ignore-list.txt ('X' conversion mode) under Windows Closed
Related to Conversion Tools - Bug #5137: any text following a # character in the include or exclude file list is ignored Closed

History

#1 Updated by Eric Faulhaber about 5 years ago

The current conversion modes supported by ConversionDriver/TransformDriver are either a file specification at the command line (-S option) or a custom file whitelist (-F option).

This feature combines a command line file specification with a custom file blacklist. The blacklist is a simple text file. Each line in this file specifies a file or set of files to be excluded from the set of files that would be gathered by the command line specification. Like the existing whitelist, the blacklist file is stored in the project root directory. All file specifications in the text file must be relative to the project root directory.

Each specification in the list must reference either a single file name, or a set of zero or more files using the following wildcard characters:

  • the asterisk (*) symbol, to represent zero or more wildcard characters;
  • the question mark (?) symbol, to represent exactly one wildcard character.

There is no fixed name associated with the blacklist file. This is left to the ConversionDriver user, such as the author of a build.xml script.

#2 Updated by Eric Faulhaber about 5 years ago

  • Status changed from New to Review
  • % Done changed from 0 to 100

This feature is added in 3898a/11312. One specifies the -X option to the ConversionDriver and provides a starting directory name and inclusive file specification (like with -S), plus the name of an ignore list file. The arguments must be provided in that order. Syntax text and javadoc were updated to reflect the new option.

I did command line testing of the FileSpecList class, to which the feature was added. It seemed to work well. Testing with the ConversionDriver is still needed.

#3 Updated by Eric Faulhaber about 5 years ago

Note that the initial implementation of the this feature does not take case-sensitivity into account for name matching, though the existing custom file list mode doesn't either (for matching, that is, it does for sorting).

#4 Updated by Greg Shah about 5 years ago

Code Review Task Branch 3898a Revision 11312

I'm good with the changes.

#5 Updated by Eric Faulhaber about 5 years ago

  • Status changed from Review to Test

#6 Updated by Eric Faulhaber about 5 years ago

  • Status changed from Test to Closed

Branch 3898a was merged to trunk revision 11301.

#7 Updated by Greg Shah about 3 years ago

  • Related to Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode added

#8 Updated by Greg Shah about 3 years ago

  • Related to Bug #5021: improve/fix file-ignore-list.txt ('X' conversion mode) under Windows added

#9 Updated by Greg Shah about 3 years ago

  • Related to Bug #5137: any text following a # character in the include or exclude file list is ignored added

Also available in: Atom PDF