Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files - Conversion Tools - Golden Code Redmine

Bug #4867

Incremental conversion: change detection algorithm ignores .hints and .ext-hints files

Added by Vladimir Tsichevski almost 6 years ago. Updated 4 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Dănuț Filimon

Target version:

Start date:

Due date:

% Done:

100%

billable:

vendor_id:

GCD

case_num:

version_reported:

version_resolved:

trunk/16290

reviewer:

Greg Shah

production:

env_name:

topics:

Related issues

History

#1 Updated by Vladimir Tsichevski almost 6 years ago

Related to Bug #3471: incremental conversion is regressed added

#2 Updated by Vladimir Tsichevski almost 6 years ago

The incremental compilation dependencies calculation procedure must detect changes in .hints and .ext-hints files.

#3 Updated by Greg Shah almost 6 years ago

Project changed from Runtime Infrastructure to Conversion Tools

Sorry, it was my fault this was in the wrong project.

#4 Updated by Greg Shah about 1 year ago

Subject changed from Incremental conversion: change detection algorithm ignores .ext-hints files to Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Start date deleted (~~08/31/2020~~)

#5 Updated by Dănuț Filimon 9 months ago

Assignee set to Dănuț Filimon

#6 Updated by Dănuț Filimon 9 months ago

Status changed from New to WIP

      // check the hint files
      try
      {
         PreprocessorHints hints = new PreprocessorHints(file);
         Set<String> includes = hints.getUniqueIncludes();
         for (String finclude : includes)
         {
            if (!new File(finclude).exists())
            {
               // the include file no longer exists...
               return true;
            }

            currentHash = fdbhash.apply(finclude);
            hash = computeFileHash(finclude);
            if (!hash.equals(currentHash))
            {
               return true;
            }
         }
      }
      catch (PreprocessorException e)
      {
         throw new RuntimeException(e);
      }

This is part of the mustConvertFile() and it should work. The problem with incremental conversion is that we need include files to compare the hashes. I tried to use a simple example where I define an alias for the database in the hints, but it was not enough to get include files. The best solution would be to calculate the hash on the hints file and not on the include files, but I need an example that enters the for loop.

#7 Updated by Dănuț Filimon 9 months ago

I found https://proj.goldencode.com/projects/p2j/wiki/Chapter_12_Conversion_Hints for reference.

#8 Updated by Dănuț Filimon 9 months ago

% Done changed from 0 to 100
Status changed from WIP to Review
reviewer Greg Shah added

Committed 4867a/16236. hints and ext-hints files should trigger changes during incremental conversion.

Greg, please review.

#9 Updated by Greg Shah 8 months ago

Status changed from Review to Internal Test

Code Review Task branch 4867a Revision 16236

The changes are good.

In mustConvertFile(), before line 818 (if (!hash.equals(currentHash))), please add this comment // the hint file didn't already exist or has been modified.