Project

General

Profile

Activity

From 10/23/2025 to 11/21/2025

11/21/2025

03:39 PM Bug #10919: the source/AST view is broken in the Analytics web UI
The @.cache@ and @.p.ast@ files do exist, but they are in @./cvt/@ instead of @./abl/@ which is probably the issue. Greg Shah
03:38 PM Bug #10919: the source/AST view is broken in the Analytics web UI
I suspect this is a bug from our recent #5586 changes.
Running reports in Hotel GUI completes properly. You can l...
Greg Shah
03:30 PM Bug #10919 (Test): the source/AST view is broken in the Analytics web UI
Greg Shah
10:20 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Greg, I updated the wiki and pushed the new interface and implementation to 10804a. You should now be able to access ... Paula Păstrăguș
08:06 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Yes, you’re right! I’ll take care of it. Really appreciate the detailed guidance. Paula Păstrăguș
08:03 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> My suggestion is to wait until the end of the day, so I can finish covering most of the met...
Greg Shah
07:56 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> I think creating a table will help clarify things for both of us. At this point, I’ve gone ...
Greg Shah
05:06 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
My suggestion is to wait until the end of the day, so I can finish covering most of the methods, prepare the comparis... Paula Păstrăguș
04:49 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
I think creating a table will help clarify things for both of us. At this point, I’ve gone through the ascent/descent... Paula Păstrăguș
03:12 AM Feature #10804 (WIP): create replacement AST implementation for use with ANTLR 4
Greg, I attached the ZIP containing the test project. Inside you will find both approaches: the visitor-based impleme... Paula Păstrăguș
10:02 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
Code Review Task Branch 6889a Revisions 16267 and 16268
1. Shouldn't @cleanSources()@ be called at the end of @pro...
Greg Shah
08:47 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
Committed a null check in *6889a/16268*. Dănuț Filimon
08:36 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
I got a few questions:
* Considering #7318/#7179, should we remove files from conversion even if we are not running ...
Dănuț Filimon
05:56 AM Bug #6889 (Review): rollback the files as 'unconverted' if (incremental) conversion fails.
Committed *6889a/16267*. Rollback source files that failed processing during incremental conversion.
Greg, please ...
Dănuț Filimon
08:57 AM Bug #10912: Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "calleeType...
Alex, the fix is this:... Constantin Asofiei
06:53 AM Bug #10912: Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "calleeType...
My change seems to be too old to not be included in 7156e, so I suspect it is a later change.... Șerban Bursuc
06:50 AM Bug #10912: Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "calleeType...
... Alexandru Lungu
06:47 AM Bug #10912 (Test): Cannot invoke "java.lang.Class.isAssignableFrom(java.lang.Class)" because "cal...
Alexandru Lungu
08:13 AM Bug #4867 (Test): Incremental conversion: change detection algorithm ignores .hints and .ext-hint...
Branch 4867a was merged into trunk as rev. 16290 and archived. Dănuț Filimon
07:48 AM Bug #4867 (Merge Pending): Incremental conversion: change detection algorithm ignores .hints and ...
Merge after 10695a. Greg Shah
04:08 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Tested the customer application, no issues found. *4867a* can be merged. Dănuț Filimon
06:33 AM Feature #7318: prevent abend during conversion in case of failures when processing TRPL rules
Constantin Asofiei wrote:
> Danut, please see some changes from 9457c: @bzr status -r 16245..16270@ - there are eith...
Dănuț Filimon
06:28 AM Feature #7318: prevent abend during conversion in case of failures when processing TRPL rules
Danut, please see some changes from 9457c: @bzr status -r 16245..16270@ - there are either some commented code or abe... Constantin Asofiei

11/20/2025

09:12 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Customer conversion will be complete tomorrow morning, I'll be able to test incremental then and confirm the fix. Dănuț Filimon

11/19/2025

04:56 PM Feature #10804: create replacement AST implementation for use with ANTLR 4
> I’m not sure how this translates to the Progress grammar for example, since the grafting logic there depends much ... Greg Shah
11:06 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
Greg, I’m still a bit unclear on how to properly test these changes. I created a small separate project with a simple... Paula Păstrăguș

11/18/2025

06:22 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Please test at least one of the large customer GUI applications. As Vladimir notes, the @.ext-hints@ are used there ... Greg Shah
05:26 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Dănuț Filimon wrote:
> I tested ChUI conversion and incremental and found no issues, are there any other projects th...
Vladimir Tsichevski
04:28 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
I tested ChUI conversion and incremental and found no issues, are there any other projects that use hint files? Dănuț Filimon
06:20 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
For the rest of the incremental conversion process, I though of letting the PatternEngine.run() throw and catch error... Dănuț Filimon

11/17/2025

09:40 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Committed *4867a/16237* to add a comment. Dănuț Filimon
08:52 AM Bug #4867 (Internal Test): Incremental conversion: change detection algorithm ignores .hints and ...
Code Review Task branch 4867a Revision 16236
The changes are good.
In @mustConvertFile()@, before line 818 (@if...
Greg Shah

11/13/2025

03:13 AM Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
If incremental conversion fails during the @Scanning Progress Source (preprocessor, lexer, parser, persist ASTs)@ pha... Dănuț Filimon

11/12/2025

08:49 AM Bug #6889 (WIP): rollback the files as 'unconverted' if (incremental) conversion fails.
Dănuț Filimon
06:17 AM Bug #10850: getAst() usage from TRPL must be read-only
Greg, the idea here is to mark ASTs returned by @getAst@ as read-only but only if this is a @ProgressAst@ - the other... Constantin Asofiei
05:47 AM Bug #10850: getAst() usage from TRPL must be read-only
There's a scenario where @getAst()@ using the id of a tree, then that ast is modified. The ast can be modified, but t... Dănuț Filimon
05:34 AM Bug #10850 (New): getAst() usage from TRPL must be read-only
Dănuț Filimon

11/11/2025

03:03 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Ovidiu Maxiniuc wrote:
> If we 'merge' using a key formed only from @fileId, astId@, this structure will be able to ...
Octavian Adrian Gavril

11/10/2025

12:14 PM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Ultimately, @H2Map@ is a @HashMap@, which means it should associate values to keys. Here is the @put()@ method:
<pre...
Ovidiu Maxiniuc
07:08 AM Bug #10639: Incremental conversion - unexpected DMO generation for space-only changes
Ovidiu, is there something left to assess? Alexandru Lungu

11/07/2025

12:27 AM Feature #10190 (Internal Test): Prototype the changes to the build to add ANTLR v4
Code Review Task Branch 10190a Revision 16003
The changes look good.
Greg Shah

11/06/2025

09:36 AM Bug #6629 (Review): incremental conversion for OpenClient proxy programs
Committed *6629a/16252*. Added support for deleting program configurations.
Constantin, please review.
Dănuț Filimon
09:10 AM Feature #10190 (Review): Prototype the changes to the build to add ANTLR v4
Committed as rev *16003*.
Greg, please review.
Paula Păstrăguș
03:29 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
> There seems to be a small typo, when the grammar is not up to date, the log message displays two consecutive 'not' ... Greg Shah
02:48 AM Feature #10804: create replacement AST implementation for use with ANTLR 4
> In ANTLR 4 there’s no @CommonAST@. The parser only produces a @ParseTree@, so if we want an AST-like structure, we’... Greg Shah

11/05/2025

09:37 AM Bug #6629: incremental conversion for OpenClient proxy programs
Dănuț Filimon wrote:
> One issue with deleting a program configuration file is that deleting it will not cause all a...
Dănuț Filimon
08:08 AM Bug #6629: incremental conversion for OpenClient proxy programs
One issue with deleting a program configuration file is that deleting it will not cause all associated program files ... Dănuț Filimon
05:02 AM Bug #6629: incremental conversion for OpenClient proxy programs
Committed *6629a/16251*. Initial implementation for incremental conversion of proxy/soap/rest/web program configurati... Dănuț Filimon
05:03 AM Feature #10190: Prototype the changes to the build to add ANTLR v4
I've checked out the branch and I have a few questions regarding the current approach:
* There seems to be a small...
Paula Păstrăguș

11/04/2025

12:10 PM Feature #10804: create replacement AST implementation for use with ANTLR 4
Greg, let me summarize to make sure I’ve got the idea right, please let me know if this matches your vision:
* In ...
Paula Păstrăguș
07:40 AM Bug #6629: incremental conversion for OpenClient proxy programs
Incremental conversion is working, I plan to cleanup the implementation and see if there are any improvements that I ... Dănuț Filimon

11/03/2025

07:50 AM Bug #6629: incremental conversion for OpenClient proxy programs
Dănuț Filimon wrote:
> I looked over the REST operations, procedures and internal procedures are used and some of th...
Dănuț Filimon
07:35 AM Bug #6629: incremental conversion for OpenClient proxy programs
I looked over the REST operations, procedures and internal procedures are used and some of them only have their name ... Dănuț Filimon
07:30 PM Feature #10804: create replacement AST implementation for use with ANTLR 4
We must replace our @AnnotatedAst@ class with a new implementation that does not derive from @antlr.CommonAST@. In A... Greg Shah
07:13 PM Feature #10804 (Review): create replacement AST implementation for use with ANTLR 4
Greg Shah
07:21 PM Feature #1757: update ANTLR to latest version
We will continue to discuss and consider this issue of how we handle the IDE (from the parse tree or the AST...) but ... Greg Shah
07:10 PM Feature #1757: update ANTLR to latest version
> If we compare the two images, we can see that the tree generated by ANTLR v4 is deeper (depth 4) and more detailed ... Greg Shah
07:00 PM Feature #1757: update ANTLR to latest version
Alexandru Lungu wrote:
> > the adapter will simply take the ANTLR 4 parse tree and convert it into the annotated AST...
Greg Shah

11/02/2025

06:45 PM Feature #1757: update ANTLR to latest version
Let me provide some additional context about our work here.
1. Our requirements will likely be set by the 4GL pr...
Greg Shah
05:10 PM Feature #1757: update ANTLR to latest version
> I had an in-depth discussion with Alex,
I appreciate this, but please note that I am leading this effort directl...
Greg Shah

10/31/2025

10:20 AM Feature #1757: update ANTLR to latest version
Alex, I used the expression *2 + 3 * 4* to generate a simple AST and a ParseTree using ANTLR v2 and ANTLR v4:
!ant...
Paula Păstrăguș
09:01 AM Feature #1757: update ANTLR to latest version
Paula Păstrăguș wrote:
> We’ll also need to evaluate how this affects performance. While I would expect ANTLR 4 to b...
Ovidiu Maxiniuc
06:37 AM Feature #1757: update ANTLR to latest version
> the adapter will simply take the ANTLR 4 parse tree and convert it into the annotated AST format expected by our cu... Alexandru Lungu
06:29 AM Feature #1757: update ANTLR to latest version
I had an in-depth discussion with Alex, and we agreed to start working on upgrading @ANTLR 2@ to @ANTLR 4@. For now, ... Paula Păstrăguș
10:05 AM Bug #6629: incremental conversion for OpenClient proxy programs
I've got an implementation down for *.xpxg. Sorry Constantin, but I could not use your idea as I could not get the ri... Dănuț Filimon

10/30/2025

05:34 AM Bug #6629: incremental conversion for OpenClient proxy programs
Constantin Asofiei wrote:
> Danut, while we are at it: the .jast for the FWD OpenClient proxy programs is still in a...
Dănuț Filimon
04:25 AM Bug #10784: FWD Analytics - Visualize Call Graph can't be used due to broken file paths
Octavian Adrian Gavril wrote:
> I found as a quick fix that
Clever. Let's consider this a temporary workaround.
Greg Shah
03:28 AM Bug #10784: FWD Analytics - Visualize Call Graph can't be used due to broken file paths
I found as a quick fix that we can change in @p2j.cfg.xml@ the @basepath@ from @"./abl"@ into @"${P2J_HOME}/abl"@ *af... Octavian Adrian Gavril

10/29/2025

01:43 PM Bug #6629: incremental conversion for OpenClient proxy programs
Danut, while we are at it: the .jast for the FWD OpenClient proxy programs is still in abl/ and not in cvt/ folder. Constantin Asofiei
11:04 AM Bug #6629: incremental conversion for OpenClient proxy programs
> Greg, should soap/rest/web/proxy files be checked right at the start of the conversion or should we wait until the ... Greg Shah
10:31 AM Bug #6629: incremental conversion for OpenClient proxy programs
Greg, should soap/rest/web/proxy files be checked right at the start of the conversion or should we wait until the la... Dănuț Filimon
09:44 AM Bug #6629: incremental conversion for OpenClient proxy programs
ServiceSupport.resolveRestConfiguration for REST, resolveWebHandlers for WEB, initialize for SOAP. Those 3 will have ... Dănuț Filimon
08:50 AM Bug #6629: incremental conversion for OpenClient proxy programs
There's @resolveProxyProgramsConfiguration()@ method that is called in @middle()@ when initializing a @ServiceSupport... Dănuț Filimon
07:03 AM Bug #10569 (WIP): Semicolon is skipped while preprocessing
I'll switch this back to WIP so that we know I'm back to digging. Radu Apetrii
05:53 AM Feature #7180 (Review): create a centralized manager for the conversion list and per-file/project...
Committed *7180a/16273*. Moved getPathToConversionFolderPojoFromDmo() to the ArtifactManager.
7180a/16267 - 16273 ...
Dănuț Filimon

10/28/2025

12:40 PM Bug #6629: incremental conversion for OpenClient proxy programs
Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > Otherwise, a question: if there are changes in the SOAP, REST,...
Greg Shah
10:41 AM Bug #6629: incremental conversion for OpenClient proxy programs
Constantin Asofiei wrote:
> Otherwise, a question: if there are changes in the SOAP, REST, web or proxy/.xpxg resour...
Dănuț Filimon
08:34 AM Bug #6629: incremental conversion for OpenClient proxy programs
The issue I think was that when running incremental conversion, the OpenClient proxy generation in FWD was not includ... Constantin Asofiei
08:06 AM Bug #6629: incremental conversion for OpenClient proxy programs
Dănuț Filimon wrote:
> I got the open_client_example project from Constantin and did a simple test. After conversion...
Dănuț Filimon
06:24 AM Bug #6629 (WIP): incremental conversion for OpenClient proxy programs
I got the open_client_example project from Constantin and did a simple test. After conversion, I modified @./abl/subt... Dănuț Filimon
07:25 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Dănuț Filimon wrote:
> Dănuț Filimon wrote:
> > * @error: neutralMillisToCalendar(long,TimeZone) has private access...
Dănuț Filimon
05:37 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Dănuț Filimon wrote:
> * @error: neutralMillisToCalendar(long,TimeZone) has private access in date@
> * @error: jul...
Dănuț Filimon
05:31 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
I converted ChUI and the conversion passed, but the compile phase failed with errors and warnings like:
* @warning: ...
Dănuț Filimon
03:25 AM Bug #10784: FWD Analytics - Visualize Call Graph can't be used due to broken file paths
I attached the log that described the issue:
{{Collapse(report-server.log)...
Octavian Adrian Gavril
03:20 AM Bug #10784 (Test): FWD Analytics - Visualize Call Graph can't be used due to broken file paths
Octavian Adrian Gavril

10/27/2025

08:38 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
A few issues I found while testing hotel:
* All artifacts were created as BaseArtifact, there's a few places that re...
Dănuț Filimon
04:46 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
Constantin Asofiei wrote:
> Danut, is 10469a still required? I see it was archived as dead.
The fix from 10469a ...
Dănuț Filimon
04:45 AM Bug #10469: incremental conversion when basepath is more than one folder (aka abl/foo) with #5586
Danut, is 10469a still required? I see it was archived as dead. Constantin Asofiei

10/24/2025

08:38 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Rebased *7180a* to latest *trunk/16242*, the branch is now at revision *16270*.
Committed *7180a/16271* to make 71...
Dănuț Filimon
07:15 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Committed *7180a/16247-16248*. Removed remaining Configuration dependencies from the ArtifactManager. (refs: #7180)
...
Dănuț Filimon
04:38 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Dănuț Filimon wrote:
> The only issue left is with removing Configuration from the AM and testing.
I have two opt...
Dănuț Filimon

10/23/2025

09:49 AM Bug #4867 (Review): Incremental conversion: change detection algorithm ignores .hints and .ext-hi...
Committed *4867a/16236*. hints and ext-hints files should trigger changes during incremental conversion.
Greg, ple...
Dănuț Filimon
07:42 AM Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
I found https://proj.goldencode.com/projects/p2j/wiki/Chapter_12_Conversion_Hints for reference. Dănuț Filimon
07:40 AM Bug #4867 (WIP): Incremental conversion: change detection algorithm ignores .hints and .ext-hints...
... Dănuț Filimon
07:07 AM Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Here goes another commit to *7180a/16246*! Allow ConversionData to use artifacts, added computeHash() to Artifact, us... Dănuț Filimon
 

Also available in: Atom