Project

General

Profile

Bug #6275

SKIP-DELETED-RECORD implementation

Added by Stanislav Lomany about 2 years ago. Updated over 1 year ago.

Status:
Review
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
Due date:
% Done:

0%

billable:
No
vendor_id:
GCD
case_num:
version:

skip.p Magnifier (376 Bytes) Stanislav Lomany, 04/13/2022 04:11 AM

skip2.p Magnifier (619 Bytes) Stanislav Lomany, 04/13/2022 04:11 AM

skip-all.p Magnifier (1.97 KB) Stanislav Lomany, 08/26/2022 09:37 PM

6275.diff Magnifier (2.83 KB) Stanislav Lomany, 08/26/2022 09:37 PM

History

#1 Updated by Stanislav Lomany about 2 years ago

SKIP-DELETED-RECORD was implemented as a part of #5882. In turned out that these changes weren't necessary for fixing that task, but they fix some cases and here I want to drop the code for review.

#2 Updated by Greg Shah about 2 years ago

  • Start date deleted (04/13/2022)

Ovidiu: Please review.

#3 Updated by Ovidiu Maxiniuc about 2 years ago

Greg Shah wrote:

Ovidiu: Please review.

A single question: calls to stopOnSkippedRecord occur on first, next, and previous navigation. Shouldn't this be the case for last?

#4 Updated by Greg Shah over 1 year ago

A single question: calls to stopOnSkippedRecord occur on first, next, and previous navigation. Shouldn't this be the case for last?

Stanislav: This question is still pending.

#5 Updated by Stanislav Lomany over 1 year ago

  • File deleted (6275.diff)

#6 Updated by Stanislav Lomany over 1 year ago

A single question: calls to stopOnSkippedRecord occur on first, next, and previous navigation. Shouldn't this be the case for last?

Ovidiu, I did some testing and you're right. I updated the diff file.

Stanislav: This question is still pending.

Sorry, turns out I somehow managed to forget about this task.

#7 Updated by Stanislav Lomany over 1 year ago

  • Status changed from New to WIP

#8 Updated by Stanislav Lomany over 1 year ago

  • Status changed from WIP to Review

Also available in: Atom PDF