Project

General

Profile

Feature #6433

implement WEB-CONTEXT system handle

Added by Greg Shah about 4 years ago. Updated 5 months ago.

Status:
WIP
Priority:
Normal
Assignee:
Radu Apetrii
Target version:
-
Start date:
Due date:
% Done:

30%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
Constantin Asofiei, Greg Shah
production:
No
env_name:
topics:
WEB/WebSpeed/WebHandler

Related issues

Related to Base Language - Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality Test
Related to Base Language - Feature #9516: include pre-converted webspeed runtime code in FWD Internal Test

History

#1 Updated by Greg Shah about 4 years ago

EXCLUSIVE-ID, HTML-END-OF-LINE, HTML-END-OF-PAGE, HTML-FRAME-BEGIN, HTML-FRAME-END, HTML-HEADER-BEGIN, HTML-HEADER-END, HTML-TITLE-BEGIN, HTML-TITLE-END

#2 Updated by Constantin Asofiei over 1 year ago

  • Related to Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality added

#3 Updated by Constantin Asofiei over 1 year ago

  • Related to Feature #9516: include pre-converted webspeed runtime code in FWD added

#4 Updated by Constantin Asofiei over 1 year ago

  • Status changed from New to Review
  • % Done changed from 0 to 30
  • reviewer Greg Shah added
Created task branch 6433a from trunk rev 15674; rev 15675 contains:
  • Added conversion for ON QUIT, LEAVE - this must not rollback, but commit. Refs #9516
  • Added support for WEB-CONTEXT methods/attributes (conversion full, runtime stub), COMPILER:ERROR-ROW and COMPILER:FILE-NAME (conversion full, runtime stub). Refs #6433 #9516

Greg, please review.

#5 Updated by Greg Shah over 1 year ago

Code Review Task Branch 6433a Revision 15675

I think the changes are good.

In regard to the QUIT_COMMIT, I like the approach but I don't want to leave the feature as a TODO. I wonder if all we need to do in BlockManager.processCondition() is to bypass calling wa.tm.rollback(imple.undoLabel); if current == Condition.QUIT_COMMIT? The LEAVE processing will naturally return or unwind the stack. The top level popScope() will naturally commit.

#6 Updated by Constantin Asofiei over 1 year ago

Greg Shah wrote:

In regard to the QUIT_COMMIT, I like the approach but I don't want to leave the feature as a TODO. I wonder if all we need to do in BlockManager.processCondition() is to bypass calling wa.tm.rollback(imple.undoLabel); if current == Condition.QUIT_COMMIT? The LEAVE processing will naturally return or unwind the stack. The top level popScope() will naturally commit.

Correct, this works. The change is in 6433a rev 15723 (branch was rebased).

I'm doing conversion testing of an app now, if it passes we can merge 6433a.

#7 Updated by Constantin Asofiei over 1 year ago

Constantin Asofiei wrote:

I'm doing conversion testing of an app now

Conversion testing passed.

#8 Updated by Greg Shah over 1 year ago

  • Status changed from Review to Merge Pending

You can merge now.

#9 Updated by Constantin Asofiei over 1 year ago

Merging now. Sorry for the delay.

#10 Updated by Constantin Asofiei over 1 year ago

  • Status changed from Merge Pending to New

Branch 6433a was merged to trunk rev 15727 and archived.

Moving back to new as WEB-CONTEXT runtime needs implementing.

#11 Updated by Radu Apetrii over 1 year ago

  • Status changed from New to WIP
  • Assignee set to Radu Apetrii
  • reviewer Constantin Asofiei added
  • reviewer deleted (Greg Shah)
As part of the base implementation here, I will:
  • Take the CGI vars from RemoteWebRequest and place them in the helper created in 6506a that was designed to have the common stuff between webspeed and web services in general.
    • Do I need to move the WebContext from WebHandler to the helper as well?
  • Analyze the CGI list that I have and see what else needs to be added to the vars.
  • Add WEB-CONTEXT.

These notes might be a bit vague, but I will refine them as soon as I make progress in the implementation.

#12 Updated by Radu Apetrii over 1 year ago

  • reviewer Greg Shah added

#13 Updated by Greg Shah 5 months ago

  • topics WEB/WebSpeed/WebHandler added

Also available in: Atom PDF