FWD » Core Development » Database

If the .df has a table with no fields defined, import or loading this DMO interface fails with this:

     [java] Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
     [java]     at com.goldencode.p2j.persist.orm.RecordMeta.readPropertyMeta(RecordMeta.java:505)
     [java]     at com.goldencode.p2j.persist.orm.RecordMeta.<init>(RecordMeta.java:227)
     [java]     at com.goldencode.p2j.persist.orm.DmoClass.assembleImplementation(DmoClass.java:442)
     [java]     at com.goldencode.p2j.persist.orm.DmoMetadataManager.registerDmo(DmoMetadataManager.java:241)

A fix for the DMO interface loading (for runtime and DB import) is in 6129a/14273.

This does not solve all issues, CRUD operations still need to be checked, and import shows this (the .d for this 'no-field' table has no records, obviously):

     [java] <table>.d: Error processing import data; 200 of 0 record(s) successfully processed;  0 record(s) uncommitted due to this error;  -200 record(s) dropped.
     [java] java.lang.ArrayIndexOutOfBoundsException: 0
     [java]     at com.goldencode.p2j.persist.orm.Persister.insert(Persister.java:781)
     [java]     at com.goldencode.p2j.persist.orm.Persister.bulkInsert(Persister.java:344)
     [java]     at com.goldencode.p2j.persist.orm.Session.bulkSave(Session.java:739)
     [java]     at com.goldencode.p2j.schema.ImportWorker$Library.importTable(ImportWorker.java:1390)
     [java]     at com.goldencode.p2j.schema.ImportWorker$Library.lambda$importAsync$3(ImportWorker.java:1887)
     [java]     at java.lang.Thread.run(Thread.java:750)

Ovidiu Maxiniuc wrote:

Constantin, I reviewed it and your fix in 6129a/14273 seems logical.

I also added two changes in 6129a/14387:

• Persister.java: to avoid ArrayIndexOutOfBoundsException when persisting records with no defined fields. This is the issue you discovered with the import, but also when a record is created in the application;

I don't understand this part. It looks like we are trying to insert an "empty" record in the case of a no-column table. What does that mean? How can a no-column table have any rows, since there are no values to insert? What is an "empty" record in this context and why would we want one in such a table?

• RecordBuffer.java: allow unchanged transient records to be flushed even if no trigger is fired. Without this update, the transient records were never saved. I do not know how this case was overlooked.

I think the changes here are ok.

Eric, please review this update, especially the second issue.

Consider my questions/comments above my review. Thanks.

• created a no-field table
• inserted 20 records in it
• dumped the .d
• deleted all records
• tried to load the .d - got this error:
  

  >> ERROR! Trailer indicated 20 records, but 0 records were loaded.
  

So there is no way to load records in a no-field table.

My point was that the records exited in the original table and we need to have a table in FWD/SQL with same (well, equivalent) content. I was not referring to the process of import itself, but the final state.