Project

General

Profile

Support #6712

check generated dynamic temp-table caching to ensure that all cache keys work when generating hits

Added by Greg Shah over 1 year ago. Updated over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
Due date:
% Done:

0%

billable:
No
vendor_id:
GCD
case_num:
version:

History

#1 Updated by Greg Shah over 1 year ago

Recently, Eric found a flaw in our cache key implementation which resulted in the cache entry not being properly found in lookups. He fixed this bug but we need to followup and ensure this flaw doesn't exist for other use cases.

#2 Updated by Eric Faulhaber over 1 year ago

Greg Shah wrote:

Recently, Eric found a flaw in our cache key implementation which resulted in the cache entry not being properly found in lookups. He fixed this bug but we need to followup and ensure this flaw doesn't exist for other use cases.

Correction: I discovered it; it is not yet fixed. It is in shared code that is used in many code paths, so it needs some deeper analysis.

#3 Updated by Eric Faulhaber over 1 year ago

IIRC, the problem was that we rely on P2JField.computeHash, and the name field can vary, depending on the call path within TempTableBuilder to the P2JField c'tor.

I came upon this defect accidentally while debugging a different problem. I think I was seeing P2JField.name vary for what should have been the structurally same field created two different ways (possibly one way simply added the field, and the other added the field LIKE another field).

Also available in: Atom PDF