Feature #7147
Make FWD log outputs consistent
0%
Related issues
History
#1 Updated by Hynek Cihlar about 1 year ago
There are multiple issues with FWD log outputs for both server and client processes.
- During server bootstrap different log entry format is used until logging is configured with the server directory.
- Client log entries use different format than server.
- Jetty doesn't use java.util.logging, which completely bypasses the FWD formatting logic.
The above make the resulting log outputs inconsistent. Reading the logs with any advanced log tailers is thus unnecessarily complicated.
#2 Updated by Hynek Cihlar about 1 year ago
- File log_fixes.diff
added
The above points are resolved with the attached diff. Please review.
#3 Updated by Hynek Cihlar about 1 year ago
- File log_fixes_2.diff added
The attached diff improves the CleanFormatter to shorten the qualified names to only include first letters for the package names.
#4 Updated by Greg Shah about 1 year ago
Galya has been working on a complete rewrite of our logging support. I suspect there is some duplication of effort here, but hopefully not.
Galya: Please review and advise on how we can use these changes with your work.
#5 Updated by Greg Shah about 1 year ago
- Related to Feature #3853: implement LOG-MANAGER runtime added
#8 Updated by Greg Shah about 1 year ago
- Related to Bug #5703: rationalize, standardize and simplify the client-side log file name configuration added
#9 Updated by Greg Shah about 1 year ago
- Related to Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows) added
#10 Updated by Greg Shah about 1 year ago
- Related to Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client process) pid added
#11 Updated by Galya B about 1 year ago
Hynek, there are many issues with the current logging, formatting and init points are just some of them. Most of it is already handled in #5703. There is more work before it's merged though. Do you think there is something urgent that cannot wait for #5703 where LogHelper is not used any more and server logs are merged with clien t logs, basically rendering some of your concerns void?
If this is not urgent, I'll take a look later if jetty's output is handled by the new approach.
#12 Updated by Hynek Cihlar about 1 year ago
Galya Bogdanova wrote:
Hynek, there are many issues with the current logging, formatting and init points are just some of them. Most of it is already handled in #5703. There is more work before it's merged though. Do you think there is something urgent that cannot wait for #5703 where LogHelper is not used any more and server logs are merged with clien t logs, basically rendering some of your concerns void?
If this is not urgent, I'll take a look later if jetty's output is handled by the new approach.
I was addressing several issues I had with lnav when monitoring log files. Most importantly the different formats used for the log entries in server and client logs. lnav performs a match on the first number of entries it encounters in a log file and then sticks with the chosen format, and so it gets confused when the format suddenly changes.
It is not urgent, we have lived with this for many years, so surely it can wait a bit longer :-).
#13 Updated by Galya B about 1 year ago
Greg, did you allow Hynek to merge the changes to LogHelper? Hynek, please revert all changes related to logging.
#14 Updated by Hynek Cihlar about 1 year ago
Galya Bogdanova wrote:
Greg, did you allow Hynek to merge the changes to LogHelper? Hynek, please revert all changes related to logging.
Frankly, I should have asked more explicitly for reviewing this stuff and I don't think this was reviewed. Does it cause any particular issues?
#15 Updated by Hynek Cihlar about 1 year ago
Hynek Cihlar wrote:
Galya Bogdanova wrote:
Greg, did you allow Hynek to merge the changes to LogHelper? Hynek, please revert all changes related to logging.
Frankly, I should have asked more explicitly for reviewing this stuff and I don't think this was reviewed. Does it cause any particular issues?
To clarify I delivered the logging changes in trunk with 7010b.
#16 Updated by Hynek Cihlar about 1 year ago
Hynek Cihlar wrote:
Galya Bogdanova wrote:
Greg, did you allow Hynek to merge the changes to LogHelper? Hynek, please revert all changes related to logging.
Frankly, I should have asked more explicitly for reviewing this stuff and I don't think this was reviewed. Does it cause any particular issues?
Galya, I will appreciate if you can answer my question. Do you get conflicts, which you can not handle yourself? I can certainly help.
#17 Updated by Galya B about 1 year ago
Hynek Cihlar wrote:
Galya, I will appreciate if you can answer my question. Do you get conflicts, which you can not handle yourself? I can certainly help.
It was such a minor change that it didn't cause much troubles. It's sorted out. Thank you for being eager to help.
#18 Updated by Hynek Cihlar about 1 year ago
Galya Bogdanova wrote:
Hynek Cihlar wrote:
Galya, I will appreciate if you can answer my question. Do you get conflicts, which you can not handle yourself? I can certainly help.
It was such a minor change that it didn't cause much troubles. It's sorted out. Thank you for being eager to help.
I'm glad to hear that.