FWD » Core Development » Base Language

Could you be building on Windows using the Oracle JDK? The Oracle JDK generates a ver long list of javadoc errors as compared with OpenJDK.

Yes, it's Oracle. This explains it.

But the Oracle ones are valid issues. Can we somehow make Open JDK show them, or this is a door we don't want to open?

I don't know of a way to make OpenJDK show them. I'd be glad to see them (as long as it was optional) because to find these now we have to run Oracle JDK which is extra work.

Anyway, our policy is to fix these as we go along but only to require the ones that show in OpenJDK. We'd like to get this 100% clean someday but it is not the highest priority since we have no customers that actually use the Oracle JDK.

So do we want to open the Pandora box?

No, but I do want to have a -D option that we can use to enable it. Maybe we add something like -Dverbose_javadoc_errors=true.

Once upon a time I got a project with configured linter that wasn't used. I enabled a test plan in the CI/CD for each feature branch. If a file was updated, the linter ran for it. The failed branch couldn't be merged before the issues were resolved. You can't imagine how quickly the project got back on track. I would love to see FWD with linter in CI/CD. Then Constantin will not have to mention ant-javadoc to me in every code review, while other reviewers are sneaking in new issues.

Back to reality: I'll have to look into how to pass in -D options down to ant.

ant automatically picks up any -D options on the command line and turns them into properties that can be referenced in the .xml script.

Greg Shah wrote:

Code Review Task Branch 8119a Revisions 14874 and 14875

The changes are good.

Please rebase and we will schedule the merge.

8119a rebased on trunk r14906.

You can merge now.

Please add this new property to Build Properties.

New param javadoc.verbose added to Building_FWD_From_Source.