FWD » Core Development » User Interface

If a browse cell is of date type, and date format includes date component separators (e.g. 9999/99/99), and an unknown date is used as the model, the separators should not be displayed (the cell should be displayed as blank instead of / / for the format mentioned).
This behavior is different from that for date editing FILL-IN s, where the separators should be visible.

This issue arises due to the fact that browser cells and FILL-IN s use the same class DateFormat$DateBuf to format dates.

As of trunk rev. 14925, this behavior is implemented in the DateBuf constructor code as:

         // Do not show delimiters for unknown value
         // with either no delimiters format or browse cell fill-in.
         if(isUnknown)
         {
            if(!hasFmtSeparator())
            {
               return;
            }

            final EditableField fillIn = editableSource;
            if((fillIn instanceof FillInGuiImpl) && ((FillInGuiImpl)fillIn).isLinkedToBrowse())
            {
                  return;
            }
         }

         initScreen(screenValue, varDate);

Here an attempt is made to decide if we are inside a browse, but it fails when we are called from the following browse code:

   public static String getCellText(BrowseColumnConfig columnConfig, BaseDataType var)
   throws DisplayFormatCheckException
   {
      if (var == null)
      {
         return "";
      }

      return getDisplayFormat(columnConfig).fromVar(var).toScreenValue();
   }

Here an temporary instance of DateBuf is created by DateFormat.fromVar(var), which is not connected to any FILL-IN.

Vladimir Tsichevski wrote:

The proposed solution is to change the line:

This change fixes the browse date cell display, so now all related ChUI tests are passing.

Greg Shah wrote:

Stanislav: Please review.

Vladimir: Please put the change in a branch. What remains in this task?

Done 8204a, rev. 14941, based on trunk rev. 14940.

This fixes some cases in ChUI test suite. We can merge this to trunk now or wait until all known regressions related to date editing are fixed.

Stanislav Lomany wrote:

if (var == null || var.isUnknown())

Vladimir, your change should be limited to date, datetime and datetime-tz. For the other types unknown value is rendered as a question mark.

Thank you, Stanislav, will re-test and fix this...

Stanislav Lomany wrote:

if (var == null || var.isUnknown())

Vladimir, your change should be limited to date, datetime and datetime-tz. For the other types unknown value is rendered as a question mark.

The code changed to:

      if (var == null || (var instanceof date && var.isUnknown()))
      {
         return "";
      }  

this fixes the problem for date and sub-classes.

The program to test:

DEFINE TEMP-TABLE tt
  FIELD col1 AS DATE
  FIELD col2 AS DATETIME
  FIELD col3 AS DATETIME-TZ
  FIELD col4 AS CHARACTER
  FIELD col5 AS INTEGER
  FIELD col6 AS DECIMAL
  .
CREATE tt.
tt.col1 = ?.
tt.col2 = ?.
tt.col3 = ?.
tt.col4 = ?.
tt.col5 = ?.
tt.col6 = ?.
CREATE tt.
CREATE tt.

DEFINE QUERY q FOR tt SCROLLING.
OPEN QUERY q FOR EACH tt.

DEFINE BROWSE hBrowse QUERY q
   DISPLAY
    tt.col1 WIDTH 10 LABEL "Date" 
    tt.col2 WIDTH 10 LABEL "Datetime" 
    tt.col3 WIDTH 12 LABEL "DatetimeTZ" 
    tt.col4 WIDTH 10 LABEL "Character" 
    tt.col5 WIDTH 10 LABEL "Integer" 
    tt.col6 WIDTH 10 LABEL "Decimal" 

   ENABLE ALL      
   WITH
    SIZE-CHARS 75 BY 5
    TITLE "All-types BROWSE".

DEFINE FRAME fr
  hBrowse
  WITH TITLE "Frame" SIZE 80 BY 10 NO-LABELS .

ENABLE ALL WITH FRAME fr.

WAIT-FOR WINDOW-CLOSE OF DEFAULT-WINDOW.

The screen in FWD Swing:

The same screen in OE:

The change committed to 8204a rev. 14942.

What testing is needed?

Another fixes are required:

1. in Browse.createEditingFillIn the browse column must be set in the connected FILL-IN before initialize() is called for the FILL-IN. Otherwise the FILL-IN does not know it belongs to a browse at the moment it initializes its screen value. This fixed in 8204a rev. 14943.
2. Also the DateFormat.DateBuf(date) constructor fixed: allow the "browse with no separators" feature in ChUI also. This fixed in 8204a rev. 14944.

Also some non-functional code clean-up added in rev. 14945.

Please, review.

What testing is needed?