FWD » Core Development » User Interface

01/24/2024

01:56 PM Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...

Greg Shah wrote:
> What testing is needed?
Running Majic tests is the only tests I can think of for now. Vladimir Tsichevski

01:43 PM Bug #8204 (Internal Test): REGRESSION: separator should not show in a new date editing browse she...

What testing is needed? Greg Shah

11:33 AM Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...

I'm OK with the changes. Stanislav Lomany

10:34 AM Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...

Stanislav: Please review. Greg Shah

07:06 AM Bug #8204 (Review): REGRESSION: separator should not show in a new date editing browse shell for ...

Stanislav Lomany wrote:
> > if (var == null || var.isUnknown())
>
> Vladimir, your change should be limited to @d... Vladimir Tsichevski

11:35 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah wrote:
> > If I haven't made changes, forked session and auto-logged users would have never even had the c... Eugenie Lyzenko

10:55 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah wrote:
> Or because it is added, a stored preference will become visible. My point is that it does not ma... Galya B

10:25 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Or because it is added, a stored preference will become visible. My point is that it does not matter. We don't need... Greg Shah

09:57 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah wrote:
> > > The only thing I can think of that is not explicitly specified there is how to treat the pref... Galya B

09:53 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Eugenie, I'll be waiting for your confirmation that you don't find an issue with the requirements in #8074-101, if so. Galya B

09:46 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

> 1. Well, this is how client storage works more or less (especially Win registry) and this behavior was described in... Greg Shah

09:22 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

I want to get closure, but I also want to make sure every false or troublesome statement has been addressed.
Eugen... Galya B

09:02 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

> If I haven't made changes, forked session and auto-logged users would have never even had the chance of seeing anyt... Greg Shah

01:47 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Eugenie, I wasn't the person implementing UI themes and noone nowhere has documented how insignificant the feature is... Galya B

05:30 AM Bug #8213: Browse: NPE when pressing Shift-TAB in the first column cell

Also, navigation with @Down-Arrow@ and @Up-Arrow@ does not work in FWD. Vladimir Tsichevski

01/23/2024

04:01 PM Bug #8213: Browse: NPE when pressing Shift-TAB in the first column cell

# Open a @BROWSE@ widget with at least one cell. Set focus to any cell in the first column from the left.
# Press @S... Vladimir Tsichevski

03:55 PM Bug #8213 (Closed): Browse: NPE when pressing Shift-TAB in the first column cell

Vladimir Tsichevski

02:19 PM Bug #8204 (WIP): REGRESSION: separator should not show in a new date editing browse shell for unk...

Stanislav Lomany wrote:
> > if (var == null || var.isUnknown())
>
> Vladimir, your change should be limited to @d... Vladimir Tsichevski

02:16 PM Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...

> if (var == null || var.isUnknown())
Vladimir, your change should be limited to @date@, @datetime@ and @datetime-... Stanislav Lomany

09:48 AM Bug #8204 (Review): REGRESSION: separator should not show in a new date editing browse shell for ...

Greg Shah wrote:
> Stanislav: Please review.
>
> Vladimir: Please put the change in a branch. What remains in th... Vladimir Tsichevski

08:01 AM Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...

Stanislav: Please review.
Vladimir: Please put the change in a branch. What remains in this task? Greg Shah

02:04 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Let me share my generic thoughts here. Just my vision.
Every application has it's commonly used life cycle. And we... Eugenie Lyzenko

01:02 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

> Even if you repeat 100 times now that it's "always to be used" it needs something more to be true.
You asked for... Greg Shah

10:12 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

I believe we need to invent the @dev@ flag in our configurations (it disables all features not meant for production i... Galya B

09:38 AM Bug #8074 (WIP): Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah

09:38 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

As mentioned previously, exposing the theme to the end user was never intended to be an important feature. It was im... Greg Shah

08:30 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Eugenie Lyzenko wrote:
> Some weird addition.
>
> If web client application explicitly loads some theme (@Windows... Galya B

07:17 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > > It should not be an issue to delay the review, since the proper co... Eugenie Lyzenko

09:36 AM Bug #8210: REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL-IN is ...

Greg Shah wrote:
> When did we fix that? As far as I know, #7019 is still open to resolve that auto-zap issue.
S... Vladimir Tsichevski

08:56 AM Bug #8210: REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL-IN is ...

When did we fix that? As far as I know, #7019 is still open to resolve that auto-zap issue. Greg Shah

08:08 AM Bug #8210: REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL-IN is ...

Greg Shah wrote:
> Is this related to the auto-zap regression reported by Stanislav in #7143-583?
This issue is o... Vladimir Tsichevski

08:03 AM Bug #8210: REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL-IN is ...

Is this related to the auto-zap regression reported by Stanislav in #7143-583? Greg Shah

01/22/2024

04:26 PM Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...

Vladimir Tsichevski wrote:
> The proposed solution is to change the line:
This change fixes the browse date cell ... Vladimir Tsichevski

03:51 PM Bug #8210: REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL-IN is ...

In ChUI @FILL-IN@ is cleared with @Ctrl-Z@, this should reset date editor screen value to empty string. Currently, th... Vladimir Tsichevski

03:33 PM Bug #8210 (Test): REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL...

Vladimir Tsichevski

10:40 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Also, let me note that a customer using a custom login page is responsible for sending the selected theme the same wa... Galya B

10:16 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah wrote:
> > It should not be an issue to delay the review, since the proper configuration in directory cur... Eugenie Lyzenko

10:14 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah wrote:
> > It should not be an issue to delay the review, since the proper configuration in directory cur... Galya B

10:05 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

> It should not be an issue to delay the review, since the proper configuration in directory currently does the work... Greg Shah

09:54 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Greg, I'll be waiting for clarification to the question in #8074-92. Galya B

09:53 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Eugenie: Please review the fix.
>
> I have no objections for chang... Eugenie Lyzenko

09:26 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

I will need a day or so to completely implement the new requirement. It involves two server-side login endpoints and ... Galya B

09:10 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

> This is yet another new requirement that never existed in the original code.
OK, then that was a bug.
> So wh... Greg Shah

08:58 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah wrote:
> If the customer has configured a specific theme in the directory, that should always take precede... Galya B

08:56 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

If the customer has configured a specific theme in the directory, that should always take precedence. An end user sh... Greg Shah

08:54 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Eugenie: Please review the fix.
>
> I have no objections for chang... Galya B

08:45 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah wrote:
> Eugenie: Please review the fix.
I have no objections for changes in rev @14917@.
But I thin... Eugenie Lyzenko

07:32 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Eugenie: Please review the fix. Greg Shah

02:28 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Eugenie Lyzenko wrote:
> Galya,
>
> The problem is the preferred theme should be loaded from:
> [...]
>
> Cur... Galya B

09:03 AM Bug #8209 (New): FieldGroup tabItems out of sync after widget is dynamically deleted

Issue was first discovered in #8000-38, when the field groups from the client contained deleted widgets. It occurre... Andrei Iacob

01/20/2024

05:02 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Galya,
The problem is the preferred theme should be loaded from:... Eugenie Lyzenko

03:40 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Galya,
We have serious regression with this change. The theme defined in:... Eugenie Lyzenko

01/19/2024

10:54 AM Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...

The proposed solution is to change the line:... Vladimir Tsichevski

10:38 AM Bug #8204 (WIP): REGRESSION: separator should not show in a new date editing browse shell for unk...

If a browse cell is of date type, and date format includes date component separators (e.g. @9999/99/99@), and an unkn... Vladimir Tsichevski

09:40 AM Bug #8204 (Test): REGRESSION: separator should not show in a new date editing browse shell for un...

Vladimir Tsichevski

03:33 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

Ovidiu Maxiniuc wrote:
> * at line 23: if there are no databases with @load_at_startup@ attribute set to @true@ in d... Galya B

02:58 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

The requested changes are in r14844 and they don't work, because there is no @SecurityContext@ on the Jetty thread:
... Galya B

02:47 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

Ovidiu Maxiniuc wrote:
> The only condition here is that the @DatabaseManager.dialects@ to contain the dialect for y... Galya B

01/18/2024

11:22 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

Sorry, I do not know what you mean. That is, indeed, the code from @PersistenceFactory.getInstance(Database database)... Ovidiu Maxiniuc

01/16/2024

05:11 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Hynek Cihlar wrote:
> Galya B wrote:
> > > No, I want explicit, readable and obvious dependencies. Dependencies tha... Galya B

05:11 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Galya B wrote:
> > No, I want explicit, readable and obvious dependencies. Dependencies that will not break with fut... Hynek Cihlar

04:45 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Hynek Cihlar wrote:
> Galya B wrote:
> > So you want to refactor FWD to not use @DirectoryService.getInstance()@ an... Galya B

04:44 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Galya B wrote:
> So you want to refactor FWD to not use @DirectoryService.getInstance()@ anywhere, but instead @Dire... Hynek Cihlar

04:23 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Hynek Cihlar wrote:
> No, my argument is that someone references @LogicalTerminal@ even before the conditions are sa... Galya B

04:01 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Galya B wrote:
> Hynek Cihlar wrote:
> > Galya B wrote:
> > > If in the future there is a misuse of @LogicalTermin... Hynek Cihlar

03:48 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Hynek Cihlar wrote:
> Galya B wrote:
> > If in the future there is a misuse of @LogicalTerminal@ it will have to be... Galya B

03:45 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Galya B wrote:
> If in the future there is a misuse of @LogicalTerminal@ it will have to be fixed.
You cannot ass... Hynek Cihlar

03:28 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > Code review 8074b revision 14917.
> > >
> > ... Galya B

02:58 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Galya B wrote:
> Hynek Cihlar wrote:
> > Code review 8074b revision 14917.
> >
> > The only concern I have is th... Hynek Cihlar

02:45 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Hynek Cihlar wrote:
> Code review 8074b revision 14917.
>
> The only concern I have is the init of themes in the ... Galya B

01/15/2024

12:44 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Code review 8074b revision 14917.
The only concern I have is the init of themes in the static ctor of @LogicalTerm... Hynek Cihlar

07:13 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Hynek/Sergey: Please review. Greg Shah

06:28 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

r14917: Change to default theme resolvement. Login screen theme select shows up only with 2 or more configured direct... Galya B

02:44 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

Ovidiu Maxiniuc wrote:
> Please +try+ the following: use @PersistenceFactory.getInstance(database)@ to obtain a @Per... Galya B

01/13/2024

09:06 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

> OK, then if only one theme is added to @available-themes@, it will be set as a default even if it's not defined in ... Greg Shah

01/12/2024

12:43 PM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

Galya B wrote:
> Eric Faulhaber wrote:
> > In terms of retrieving @Dialect@ information, the @Dialect.knownDialects... Eric Faulhaber

03:02 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

Eric Faulhaber wrote:
> In terms of retrieving @Dialect@ information, the @Dialect.knownDialects@ should be populate... Galya B

02:40 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

OK, then if only one theme is added to @available-themes@, it will be set as a default even if it's not defined in @t... Galya B

01/11/2024

01:31 PM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

> That's how it's been working always. Do you want to change it somehow?
I understand this is not new. It is just... Greg Shah

07:54 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah wrote:
> Why even have the dropdown when there is only 1 choice? Shouldn't the dropdown only exist if the... Galya B

07:33 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Why even have the dropdown when there is only 1 choice? Shouldn't the dropdown only exist if there are more than 1 c... Greg Shah

03:25 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

8074b r14916 adding empty option to UI theme selector only when one or more themes are configured in directory. Galya B

01:44 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah wrote:
> The theme drop down was originally implemented to make it easy for GCD developers to test differe... Galya B

10:46 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

For most use cases of the @Database@ object, the @socketAddress@ will be @null@. However, FWD supports a mode where m... Eric Faulhaber

08:23 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

Eric, Ovidiu, in case you've missed #7884-64, it still waits for your opinion. You both asked me to use @Database@ ob... Galya B

01/10/2024

11:42 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

The theme drop down was originally implemented to make it easy for GCD developers to test different themes. It was n... Greg Shah

09:06 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Roger Borrello wrote:
> Galya B wrote:
> > Yes, it still works properly with the default Windows 10. It's just a UI... Galya B

09:05 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Nevermind... easy find.... Roger Borrello

09:03 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Galya B wrote:
> Yes, it still works properly with the default Windows 10. It's just a UI issue of showing an empty ... Roger Borrello

09:00 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Roger Borrello wrote:
> it would have a dropdown with only *Windows 10* available for selection. I removed it so tha... Galya B

08:58 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

I just wanted to clarify my post #7143-639 where I mentioned the UI Theme dropdown is appearing when it wasn't before... Roger Borrello

01/05/2024

08:05 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

Galya B wrote:
> Ovidiu Maxiniuc wrote:
> > At any rate, I think @Pair@ and @StringUtils@ are the only class from t... Greg Shah

02:42 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

Ovidiu Maxiniuc wrote:
> At any rate, I think @Pair@ and @StringUtils@ are the only class from that package/library ... Galya B

02:39 AM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

We've started discussing how to access the DB configs in #7572-134 and I mentioned an issue noone paid attention to, ... Galya B

01/04/2024

03:56 PM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

I had a look over 7884a/14843. I see it already uses some of the ideas I wrote above. I have only a few notes:
* I... Ovidiu Maxiniuc

03:27 PM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

Eric Faulhaber wrote:
> Greg Shah wrote:
> > Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved libra... Ovidiu Maxiniuc

03:01 PM Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...

In #7884-32 Galya B wrote:
> Ovidiu Maxiniuc wrote:
> > For the second part. Provided the @ldbname@, the database c... Ovidiu Maxiniuc

08:46 AM Bug #8074 (Closed): Preferred UI Theme not selected in web with auto-login and forked sessions

Greg Shah

08:42 AM Bug #8074 (Test): Preferred UI Theme not selected in web with auto-login and forked sessions

8074a was merged to trunk as rev. 14911 and archived. Galya B

08:30 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

It can be merged to trunk now. Greg Shah

07:52 AM Bug #8074 (Merge Pending): Preferred UI Theme not selected in web with auto-login and forked sess...

Galya B wrote:
> It's been tested before the review and now I've tested the newly introduced changes - @UserPreferen... Hynek Cihlar

07:18 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

It's been tested before the review and now I've tested the newly introduced changes - @UserPreferences@ needed some m... Galya B

03:45 AM Bug #8074 (Internal Test): Preferred UI Theme not selected in web with auto-login and forked sess...

Code review 8074a revisions 14865 and 14866. The changes are good, I have no more concerns. Do you plan any more test... Hynek Cihlar

02:20 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

r14866 Theme without value in directory to use class name in the dropdown Galya B

02:09 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > Code review 8074a.
> > >
> > > @WebDriverHan... Galya B

01/03/2024

12:10 PM Bug #7515: FILL-IN: editing dates issues

Another minor issue:
OE: when the cursor points to a delimiter, and the user inputs the *same* delimiter character... Vladimir Tsichevski

11:25 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Galya B wrote:
> Hynek Cihlar wrote:
> > Code review 8074a.
> >
> > @WebDriverHandler.getAvailableThemes@ should... Hynek Cihlar

01/01/2024

03:57 AM Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions

Hynek Cihlar wrote:
> Code review 8074a.
>
> @WebDriverHandler.getAvailableThemes@ should somehow handle a theme ... Galya B