FWD » Core Development » User Interface

Code Review hotel_gui_spreadsheet.20240719a.diff

Everything looks fine. Next steps:

1. Check in the changes to the Hotel GUI project.
2. Please provide instructions on how to setup/run the new code. At a minimum, we must build FWD differently. The documentation for the Guided Tour is a simplified doc. See Setup FWD and Setup Hotel GUI.

Roger: Once posted, please test out these instructions and make sure they work in Docker. I want to offer an public image that can be used to run this latest code.

The diff checked in the repository revision 340.

I updated FWD build instructions in Guided_Tour. This should be enough to make SPREADSHEET widget work in the project.

Roger Borrello wrote:

So there are no other things to do besides make sure FWD includes the sheet:war?

Yes, including the build task sheet:war is enough.

Will use of the spreadsheet control be obvious?

It should be obvious if the end-user knows it is there and how to display it.

Roger doesn't see any changes in the UI. It is not obvious how to get to it.

Please see #8991-1: "The feature can be accessed in the Guests screen. Right clicking in the browse brings up a popup menu with the option "Open in Spreadsheet...". Choosing the item will open a new window with the guests data filled in the spreadsheet. The spreadsheet screen also includes a main menu with the option to open an arbitrary spreadsheet file."

Roger Borrello wrote:

But I got this when I tried to open it. Is there a missing step?

Did you build the spreadsheet backend war file with ./gradlew sheet:war in the <p2j> dir? After the war is built, it must be deployed to <project>/deploy/lib with ant deploy.prepare.

Did you follow the instructions on the Hotel GUI wiki page?

Hynek Cihlar wrote:

After the war is built, it must be deployed to <project>/deploy/lib with ant deploy.prepare.

My libraries are in FWD_LIB=/opt/fwd, and /opt/fwd is a symlink to ~/projects/fwd/trunk and the .war file is in /opt/fwd/build/lib/fwd_sheet.war. I had to modify my helper, which was not include .war files, but that is working now.

So my classpath is very long, but does includes all the FWD jars and the fwd_sheet.war file. Does the .war file need to be next to the <project>/deploy/lib/hotel.jar file, or just in the classpath?

I also tried ant prepare.deploy and all the jars are in the deploy/lib, but I still get the same issue.

Roger Borrello wrote:

I also tried ant prepare.deploy and all the jars are in the deploy/lib, but I still get the same issue.

fwd_sheet.war doesn't need to be on the classpath, but must be in the same directory as p2j.jar.

Hynek Cihlar wrote:

fwd_sheet.war doesn't need to be on the classpath, but must be in the same directory as p2j.jar.

That is definitely the case. Should I debug the loading? If so, any tips where to break?

Roger Borrello wrote:

Hynek Cihlar wrote:

fwd_sheet.war doesn't need to be on the classpath, but must be in the same directory as p2j.jar.

That is definitely the case. Should I debug the loading? If so, any tips where to break?

First, please check the server log.

Roger Borrello wrote:

Hynek Cihlar wrote:

First, please check the server log.

See attached

directory.xml must contain the following to enable SPREADSHEET widget backend. Sorry I didn't check this directory change in the repository.

          <node class="container" name="spreadsheet">
            <node class="boolean" name="enabled">
              <node-attribute name="value" value="TRUE"/>
            </node>
          </node>

Hynek Cihlar wrote:

directory.xml must contain the following to enable SPREADSHEET widget backend. Sorry I didn't check this directory change in the repository.

I checked in the directory change in the Hotel GUI project.

Thanks... I'll update. Do you think this should be a flag stored in the JSON and configured with the tool that creates the directory?

Roger Borrello wrote:

Thanks... I'll update. Do you think this should be a flag stored in the JSON and configured with the tool that creates the directory?

No. It should always be on.

Greg Shah wrote:

Roger Borrello wrote:

Thanks... I'll update. Do you think this should be a flag stored in the JSON and configured with the tool that creates the directory?

No. It should always be on.

I was just typing in the same thing... Also, after the error there are a lot of exceptions in the log. Is that caused by the lack of configuration? Is so maybe that should be cleaned up.

24/08/01 15:38:06.657-0400 |  SEVERE | com.goldencode.p2j.ui.SpreadsheetWidget | ThreadName:Conversation [00000004:bogus], Session:00000004, Thread:00000003, User:bogus | Failed to process widget command! Spreadsheet backend has not initialized.
24/08/01 15:38:06.658-0400 | WARNING | com.goldencode.p2j.ui.SpreadsheetWidget | ThreadName:Conversation [00000004:bogus], Session:00000004, Thread:00000003, User:bogus | Cannot process command SET_SHOW_TABS. Spreadsheet backend failed to initialize.
24/08/01 15:38:15.797-0400 |  SEVERE | com.goldencode.p2j.net.HighLevelObject | ThreadName:Conversation [00000004:bogus], Session:00000004, Thread:00000003, User:bogus | Failed to obtain routing key
java.lang.IllegalStateException: The queue is not running!
    at com.goldencode.p2j.net.Queue.checkState(Queue.java:1366)
    at com.goldencode.p2j.net.Queue.transact(Queue.java:677)
    at com.goldencode.p2j.net.BaseSession.transact(BaseSession.java:273)
    at com.goldencode.p2j.net.HighLevelObject.transact(HighLevelObject.java:221)
    at com.goldencode.p2j.net.HighLevelObject.getKey(HighLevelObject.java:173)
    at com.goldencode.p2j.net.RemoteObject$RemoteAccess.obtainRoutingKey(RemoteObject.java:1547)
    at com.goldencode.p2j.net.RemoteObject$RemoteAccess.invokeCore(RemoteObject.java:1458)
    at com.goldencode.p2j.net.InvocationStub.invoke(InvocationStub.java:144)
    at com.sun.proxy.$Proxy21.removeWindow(Unknown Source)
    at com.goldencode.p2j.ui.LogicalTerminal.deregisterWindow(LogicalTerminal.java:17711)
    at com.goldencode.p2j.ui.WindowWidget.resourceDelete(WindowWidget.java:1063)
    at com.goldencode.p2j.ui.GenericWidget.delete(GenericWidget.java:6029)
    at com.goldencode.p2j.ui.WindowWidget.delete(WindowWidget.java:1080)
    at com.goldencode.p2j.util.HandleOps.delete(HandleOps.java:491)
    at com.goldencode.p2j.util.WidgetPool$WidgetPoolData.deleteResources(WidgetPool.java:1360)
    at com.goldencode.p2j.util.WidgetPool.deletePool(WidgetPool.java:796)
    at com.goldencode.p2j.util.WidgetPool.deleteNonPersistentPools(WidgetPool.java:741)
    at com.goldencode.p2j.util.WidgetPool.access$1700(WidgetPool.java:285)
    at com.goldencode.p2j.util.WidgetPool$WorkArea.scopeFinished(WidgetPool.java:1175)
    at com.goldencode.p2j.util.WidgetPool$WidgetPoolHelper.scopeFinished(WidgetPool.java:981)
    at com.goldencode.p2j.util.ProcedureManager$WorkArea.scopeFinished(ProcedureManager.java:5556)
    at com.goldencode.p2j.util.TransactionManager.processScopeNotifications(TransactionManager.java:7854)
    at com.goldencode.p2j.util.TransactionManager.popScope(TransactionManager.java:4784)
    at com.goldencode.p2j.util.TransactionManager.access$7300(TransactionManager.java:731)
...

"Note there is an issue with the guests data not initially displayed, the sheet must be manually invalidated by creating new sheet and switching to it and back.", refs #8991-1.

Roger Borrello wrote:

Are the exceptions something to look at?

Yes, please see #9033.

Roger Borrello wrote:

Is this something that should work in Swing? I tried client.sh, and it was very backlevel. I utilized a more up-to-date version, and was able to choose "Open in Spreadsheet..." but there were a lot of errors logged, and I was returned back to the Hotel login page.

SPREADSHEET widget is not supported in Swing GUI, but also FWD should not abend. I added a task to solve this in #9033.

Hynek Cihlar wrote:

Note there is an issue with the guests data not initially displayed, the sheet must be manually invalidated by creating new sheet and switching to it and back.

This is resolved with 9046a.