Project

General

Profile

Support #9349

license report inputs clutter the root of the project

Added by Greg Shah over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Roger Borrello
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
15653
reviewer:
Tomasz Domin
production:
No
env_name:
topics:

javadoc17.txt Magnifier (810 KB) Roger Borrello, 01/20/2025 04:05 PM

javadoc17_fix.txt Magnifier (65.9 KB) Roger Borrello, 01/20/2025 04:05 PM

History

#1 Updated by Greg Shah over 1 year ago

These files clutter the project root:

javascript_artifacts-front_end.xml
unknown-license-details.txt

They are only used for generating the dependency report, which is a very rare use case. It looks messy to have them in that location. Please move these to some subdirectory.

#2 Updated by Roger Borrello over 1 year ago

  • Status changed from New to WIP
  • % Done changed from 0 to 20

There are many failures running ./gradlew generateLicenseReport in the area of retrieving artifacts. There are 5 instances of:

Failed to retrieve artifacts for <SUB1>
org.gradle.api.artifacts.ResolveException: Could not resolve all dependencies for configuration ':<SUB2>'.

They are:
  1. SUB1 is group:com.github.ben-manes.caffeine, name:caffeine, version:2.9.3, ext:pom SUB2 is detachedConfiguration53
  2. SUB1 is group:com.google.guava, name:guava, version:33.1.0-jre, ext:pom SUB2 is detachedConfiguration71
  3. SUB1 is group:org.junit.platform, name:junit-platform-console, version:1.10.2, ext:pom SUB2 is detachedConfiguration591
  4. SUB1 is group:org.junit.platform, name:junit-platform-reporting, version:1.10.2, ext:pom SUB2 is detachedConfiguration594
  5. SUB1 is group:com.google.guava, name:guava, version:32.1.3-jre, ext:pom SUB2 is detachedConfiguration686

And there are 4 instances of:

Failed to retrieve artifacts for <SUB1>
org.gradle.internal.resolve.ArtifactNotFoundException: Could not find <SUB2>
Searched in the following locations:
    <SUB3>

They are:
  1. SUB1 is group:io.keikai, name:fwd-keikai-ex, version:5.12.2-2, ext:pom SUB2 is fwd-keikai-5.12.2-1.pom (io.keikai:fwd-keikai:5.12.2-1) SUB3 is https://proj.goldencode.com/artifacts/io/keikai/fwd-keikai/5.12.2-1/fwd-keikai-5.12.2-1.pom
  2. SUB1 is group:io.keikai, name:fwd-keikai-ex, version:5.12.2-2, ext:pom SUB2 is fwd-keikai-ex-5.12.2-2.pom (io.keikai:fwd-keikai-ex:5.12.2-2) SUB3 is https://proj.goldencode.com/artifacts/io/keikai/fwd-keikai-ex/5.12.2-2/fwd-keikai-ex-5.12.2-2.pom
  3. SUB1 is group:io.keikai, name:fwd-keikai-model, version:5.12.2-3, ext:pom SUB2 is fwd-keikai-model-5.12.2-3.pom (io.keikai:fwd-keikai-model:5.12.2-3) SUB3 is https://proj.goldencode.com/artifacts/io/keikai/fwd-keikai-model/5.12.2-3/fwd-keikai-model-5.12.2-3.pom
  4. SUB1 is group:io.keikai, name:fwd-keikai-poi, version:5.12.2-1, ext:pom SUB2 is fwd-keikai-poi-5.12.2-1.pom (io.keikai:fwd-keikai-poi:5.12.2-1) SUB3 is https://proj.goldencode.com/artifacts/io/keikai/fwd-keikai-poi/5.12.2-1/fwd-keikai-poi-5.12.2-1.pom

The change itself is very easy, which I will check into a branch. There are a couple of other minor build changes I'd like to check into the same branch, as well, with permission.

#3 Updated by Greg Shah over 1 year ago

There are a couple of other minor build changes I'd like to check into the same branch, as well, with permission.

Yes, as long as they are safe.

#4 Updated by Roger Borrello over 1 year ago

  • Status changed from WIP to Review
  • % Done changed from 20 to 50

Please review revision 15568 of branch 9349a.

Are some of the aforementioned issues something we could address in a separate task?

#5 Updated by Greg Shah over 1 year ago

Tomasz: Please review.

As to the other issues, you can work them wherever.

#6 Updated by Tomasz Domin over 1 year ago

Review 9349a/15568: Commit 15567 moves license report files from root directory to tools/licenseReport/, commit 15568 includes fixes to deploy script and additional comment with example of how to build native library as above mentioned minor build changes.
I am fine with all the changes.

#7 Updated by Roger Borrello over 1 year ago

Tomasz Domin wrote:

I am fine with all the changes.

Thanks, Tomasz. Do you have any ideas about the ResolveException and ArtifactNotFoundException noted? This occurs in trunk.

#8 Updated by Greg Shah over 1 year ago

  • reviewer Tomasz Domin added

#9 Updated by Tomasz Domin over 1 year ago

  • Status changed from Review to Internal Test

#10 Updated by Tomasz Domin over 1 year ago

Roger Borrello wrote:

Tomasz Domin wrote:

I am fine with all the changes.

Thanks, Tomasz. Do you have any ideas about the ResolveException and ArtifactNotFoundException noted? This occurs in trunk.

Caused by: org.gradle.internal.component.AmbiguousConfigurationSelectionException: Cannot choose between the following variants of com.github.ben-manes.caffeine:caffeine:2.9.3:
  - runtimeElements
  - shadowRuntimeElements

This is because gradle is used as dependency manager for ant in our project and I guess not all attributes are set up when not using java plugin.
There are some dependencies which have different versions depending on required usage. I will check how to resolve these.

It seems that org.gradle.internal.resolve.ArtifactNotFoundException is generated in case dependency metadata is missing - like missing POMs. Some of FWD dependencies are provided as jar files only, so there is no related metadata.

#11 Updated by Roger Borrello over 1 year ago

Tomasz Domin wrote:

It seems that org.gradle.internal.resolve.ArtifactNotFoundException is generated in case dependency metadata is missing - like missing POMs. Some of FWD dependencies are provided as jar files only, so there is no related metadata.

Is this innocuous? Can we just ignore it, or do we have to revamp how we package POMs?

#12 Updated by Roger Borrello over 1 year ago

This branch was rebased to trunk revision 15652 and is now at revision 15654.

I was wondering about the previous question if our process is good enough for the requirements, or if there is more cleanup to do.

#13 Updated by Greg Shah over 1 year ago

Roger Borrello wrote:

Tomasz Domin wrote:

It seems that org.gradle.internal.resolve.ArtifactNotFoundException is generated in case dependency metadata is missing - like missing POMs. Some of FWD dependencies are provided as jar files only, so there is no related metadata.

Is this innocuous? Can we just ignore it, or do we have to revamp how we package POMs?

Yes, it is innocuous. There is no hard requirement for a POM. When that occurs, it just means that any dependencies that the jar file has are not "visible" to the tool.

#14 Updated by Roger Borrello over 1 year ago

Then I don't think there's more to do with this task. I actually added the -quiet option to the javadoc in build.xml so that not so much noise is created. It hides actual javadoc issues.

If revision 15655 is reviewed, I don't know of anything that should hold up merging.

#15 Updated by Greg Shah over 1 year ago

Tomasz: Are you good with this update?

#16 Updated by Tomasz Domin over 1 year ago

Roger - I've tested FWD build run with and without 15655, there is no difference in reported javadoc messages - shouldn't be there any ? (my jdk is openjdk version "1.8.0_432")

#17 Updated by Roger Borrello over 1 year ago

Tomasz Domin wrote:

Roger - I've tested FWD build run with and without 15655, there is no difference in reported javadoc messages - shouldn't be there any ? (my jdk is openjdk version "1.8.0_432")

Test with JDK 17. See attached output files.

#18 Updated by Tomasz Domin over 1 year ago

Roger Borrello wrote:

Tomasz Domin wrote:

Roger - I've tested FWD build run with and without 15655, there is no difference in reported javadoc messages - shouldn't be there any ? (my jdk is openjdk version "1.8.0_432")

Test with JDK 17. See attached output files.

I've checked with JDK 17 (warnings are still reported) and I am ok with 15655.

#19 Updated by Greg Shah over 1 year ago

  • Status changed from Internal Test to Merge Pending

You can merge to trunk now.

#20 Updated by Roger Borrello over 1 year ago

  • % Done changed from 50 to 100
  • Status changed from Merge Pending to Test
  • version_resolved set to 15653

Branch 9349a was merged to trunk as revision 15653 and archived.

#21 Updated by Roger Borrello over 1 year ago

Can this be closed?

#22 Updated by Greg Shah over 1 year ago

  • Status changed from Test to Closed

Also available in: Atom PDF