Activity
From 03/09/2013 to 04/07/2013
04/07/2013
- 01:33 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- The next drop changes:
1. P2J build.xml file has been changed to pass OS architecture to the makefile for Windows com...
04/06/2013
- 12:37 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I have found that the @int64@ variables (including @extent@) were not correctly initialized to 0. I fixed this.
I ad...
04/05/2013
- 02:15 PM Feature #1639: implement socket support
- So far I've completed the connect (including ssl) on socket part and tested it, and also added code for read and wri...
- 07:44 AM Feature #1639: implement socket support
- Costin: please put details here about what you are doing with the implementation, what is completed and what is left ...
- 01:44 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I checked today and adjusted the code for the function calls (direct calls specially) and database access.
The imple... - 08:56 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- > 5 and 6 work fine, I double checked. If pos + len is 33/65 means that the bits involved are the last len bits from ...
- 08:48 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- I like it. Keep going in this direction.
- 08:23 AM Feature #1626: implement OS-DIR support as an INPUT stream
- OK, that is fine. Please put comments into that code to explain this, so that future readers will not accidentally c...
- 08:11 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Sorry I forgot to mention about that. The reason is when we have a link, getting the canonicalPath of the link file w...
- 08:01 AM Feature #1626: implement OS-DIR support as an INPUT stream
- Please describe the reasons behind the DirStream.getPathName() change in cs_upd20130404a.zip.
- 08:21 AM Feature #1613: finish FILE-INFO system handle support
- Code Feedback:
1. See note 52 in #1626.
2. The FSD.search() change to use file.getPath().startsWith(".") is not... - 04:58 AM Feature #1920: implement persistent procedures
- You can go ahead and commit/release om_upd20130405a.zip
LE: just runtime changes, no conversion regression testing n... - 04:56 AM Feature #1920: implement persistent procedures
- Comment type changed to single-line.
- 04:47 AM Feature #1920: implement persistent procedures
- Review of om_upd20130404a.zip - do not use @/*@ for adding comments, always use @//@ single-line comments. Please mak...
04/04/2013
- 01:14 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- I went on with integer-type parameter passing and implemented the same mechanism for @integer@/@int64@ as it was for ...
- 01:00 PM Feature #1920: implement persistent procedures
- This update fixes:
* @unknown@ parameter in function/procedure calls. The unknown values for some data types (@date@... - 07:35 AM Feature #1613: finish FILE-INFO system handle support
- > If the PROPATH is /path1/,/path2/,/path3/,. then a search for relative/path/to/file.txt would find /path1/relative/...
04/03/2013
- 06:40 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- Today drop has been uploaded. Includes:
1. Rework for build.xml to separate common native tasks. Adding required com... - 09:25 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- I am generally fine with the build.xml approach. The only thing I see is this:...
- 08:11 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- OK. This drop contains only changes in build.xml project build file to review. Plus one small change for filesys.c fo...
- 02:29 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Greg,
I have integrated your feedback into the code for notes 1, 2, 3 and 4.
5 and 6 work fine, I double checked. ... - 12:55 PM Feature #1613: finish FILE-INFO system handle support
- Tested by having this structure @/workcs/file.txt@ in the current folder(@/home/costins@)
and setting propath varia... - 09:03 AM Feature #1613: finish FILE-INFO system handle support
- > I removed the check for current directory because I considered it is already checked in the begining with file.exis...
- 06:08 AM Bug #2106: Missing runtime error messages in P2J
- Moved from #2080, note 74
Example:...
04/02/2013
- 04:11 PM Bug #2106: Missing runtime error messages in P2J
- Moved from #2080, note 74
Example:... - 01:22 PM Bug #2106: Missing runtime error messages in P2J
- Moved from #2080, note 78
Example:... - 01:21 PM Bug #2106: Missing runtime error messages in P2J
- Moved from #2080, note 77
Example:... - 01:19 PM Bug #2106 (New): Missing runtime error messages in P2J
- 01:29 PM Feature #1613: finish FILE-INFO system handle support
- > 2.
> You are right, the case insensitive path is now broken with your changes. Please fix it.
I'm not sure it's... - 10:37 AM Feature #1613: finish FILE-INFO system handle support
- > 3. This code looks wrong and it definitely breaks behavior that we rely upon today:
>
> // if the path length is... - 07:49 AM Feature #1613: finish FILE-INFO system handle support
- Also, please note that your update zip filename is not matching our standard naming conventions. You don't need to c...
- 06:58 AM Feature #1613: finish FILE-INFO system handle support
- Code Feedback:
1. This code in filesys.c still needs to close the file descriptor before returning:... - 06:24 AM Feature #1613: finish FILE-INFO system handle support
- > The 4GL bug which sees .. directory as hidden for os dir is described in DirStream class (it happpends because the ...
- 06:09 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- Feedback:
It is OK so far. Make sure you merge with the latest version of P2J (for example the build.xml that you... - 05:47 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Code Feedback:
1. The instantiateUnknownRaw() method should be positioned after the constructors in the raw.java.
...
04/01/2013
- 11:22 AM Feature #1920: implement persistent procedures
- Note 80 from #2080 shows a missing error for function invocation:...
- 10:53 AM Feature #1613: finish FILE-INFO system handle support
- Added proposed update, with the modified search function, eliminated the change in EnvironmentOps since it wasn't nec...
- 09:29 AM Feature #1613: finish FILE-INFO system handle support
- > In the Javadoc of EnvironmentOps.searchPath() there is this saying:
I think you mean EnvironmentOps.getSearchPat...
03/29/2013
- 07:06 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- This is update just for review to see the approach. It compiles native DLL in Windows 32-bit using mingw32-gcc. Plann...
- 01:41 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- This update adds implementation for all TODOs from @int64@ and, since the implementation is mostly the same for the @...
- 09:19 AM Bug #2105: BlockManager does not return some datatypes correctly
- A first attempt to fix would be to have only one @returnNormal@ static function with a BDT parameter and the value wr...
- 09:04 AM Bug #2105: BlockManager does not return some datatypes correctly
- Consider the following 4GL code:...
- 08:55 AM Bug #2105 (New): BlockManager does not return some datatypes correctly
03/28/2013
- 01:26 PM Feature #1613: finish FILE-INFO system handle support
- I retested the cases from UAST which contained search function or Propath and there weren't any difference,
However ... - 08:53 AM Feature #1613: finish FILE-INFO system handle support
- In the Javadoc of EnvironmentOps.searchPath() there is this saying:...
- 08:48 AM Feature #1613: finish FILE-INFO system handle support
- I don't understand why the comma is included in the default path. We already have protection against the path being ...
- 08:37 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- You are allowed to use Windows in KVM on the same Ubuntu system. It will be allowed in the standards. Thanks for as...
03/27/2013
- 04:21 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
- The question. I have idea to install The Windows inside the KVM Virtual Machine on my new Ubuntu box. Will it also co...
- 02:58 PM Feature #1613: finish FILE-INFO system handle support
- There seems to be an error in the search() logic of FileSystemDaemon.
If the given paths Array is non null it will s...
03/26/2013
- 11:13 AM Feature #1613: finish FILE-INFO system handle support
- Code Feedback:
1. StreamWrapper has no real changes other than the copyright date and the history entry. Does it ...
03/25/2013
- 04:14 PM Feature #1626: implement OS-DIR support as an INPUT stream
- Added proposed update.The update is for both #1613 and #1626
- 04:13 PM Feature #1613: finish FILE-INFO system handle support
- Added proposed update.The update is for both #1613 and #1626
- 08:40 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
- Ovidiu: your next priority should be completing the runtime work on this task. The first priority is to get the int6...
03/23/2013
- 03:18 PM Bug #2070: BlockManager Action disambiguation
- Converting the extent_params_proc.p test on windows fails with this:...
03/22/2013
- 09:37 AM Feature #1920: implement persistent procedures
- Merged with latest bzr version, contains both CA 0322a.zip and CA 0322f.zip changes. committed to bzr revision 10313.
- 08:24 AM Feature #1920: implement persistent procedures
- The code is OK. It can be committed and distributed when it passes testing.
- 07:54 AM Feature #1920: implement persistent procedures
- Fixes the case when a method param has subscript:...
- 06:04 AM Feature #1920: implement persistent procedures
- The code is OK. If it passes conversion testing you can check it in and distribute it.
- 05:31 AM Feature #1920: implement persistent procedures
- Fixed conversion support for HANDLE attribute, when used with system handles:...
- 06:59 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Checked in to bzr as revision 10310.
- 05:26 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Conversion testing passed. Check it in and distribute it.
03/21/2013
- 04:10 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Added merged update
- 01:51 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Code Feedback:
1. The javadoc and formatting of ConnectableServer should be this:... - 01:13 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Added proposed update which fixes connect for AppServer
- 10:37 AM Feature #1608: implement full appserver support (from 4GL clients only)
- You can force things to be wrapped in that case where there is more than 1 parameter.
- 10:27 AM Feature #1608: implement full appserver support (from 4GL clients only)
- > [javac] .../server/common/Apitest1.java:134: error: no suitable method found for connect(String,character,character...
- 01:32 PM Bug #2099 (Closed): "ASSIGN widget." statement does not convert properly in some cases
- 12:53 PM Bug #2099 (Review): "ASSIGN widget." statement does not convert properly in some cases
- > Check it in and distribute it.
Committed to bzr revision 10308. - 12:46 PM Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
- This looks good. Check it in and distribute it.
- 11:41 AM Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
- This update has passed conversion regression testing. There are some changes in MAJIC, but they do not affect runtime...
- 09:45 AM Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
- I'm still missing something, lots of invalid changes in MAJIC.
- 08:58 AM Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
- This is a fix attempt for this issue. Looks like the solution was to explicitly set the frame name, in case the "fram...
- 11:23 AM Feature #2089 (Closed): INPUT function returning string value
- 10:37 AM Feature #2089: INPUT function returning string value
- Please do check in and distribute the change.
- 10:14 AM Feature #2089: INPUT function returning string value
- Yes, they all are OK.
- 09:51 AM Feature #2089: INPUT function returning string value
- Here are the results of the conversion testing:...
- 08:12 AM Feature #2089: INPUT function returning string value
- Code Review:
It looks good. 1 minor issue: the comment was corrupted in "handle_implicit_input" in the latest com...
03/20/2013
- 05:54 PM Feature #1641: implement SAX XML support
- The update evl_upd20130320b.zip has been committed in bzr as 10303.
- 05:46 PM Feature #1641: implement SAX XML support
- > If it passes testing you can check it in and distribute it.
Conversion testing has been passed. I'm going to com... - 04:40 PM Feature #1641: implement SAX XML support
- If it passes testing you can check it in and distribute it.
- 03:11 PM Feature #1641: implement SAX XML support
- This update merged with bzr 10302. Starting the conversion testing.
- 02:46 PM Feature #1641: implement SAX XML support
- Code feedback: everything looks good.
The only issue is that you need to merge with the recent bzr revision. Ple... - 02:36 PM Feature #1641: implement SAX XML support
- The update includes:
1. Changing for constant types.
2. Adding history entries.
3. Fixes for misspelled words in S... - 02:16 PM Feature #2089: INPUT function returning string value
- Yes, please do.
- 02:13 PM Feature #2089: INPUT function returning string value
- > When we search upward for KW_VALIDATE and enable implicit input testing, we must ensure that we are a descendant of...
- 02:00 PM Feature #2089: INPUT function returning string value
- When we search upward for KW_VALIDATE and enable implicit input testing, we must ensure that we are a descendant of t...
- 01:49 PM Feature #2089: INPUT function returning string value
- Note that...
- 12:26 PM Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
- This case was exposed by server folder compilation, in #2068 note 172:...
- 12:08 PM Bug #2099 (Closed): "ASSIGN widget." statement does not convert properly in some cases
03/19/2013
- 07:46 PM Feature #2089: INPUT function returning string value
- 1 compile problem in Majic:...
- 03:13 PM Feature #2089: INPUT function returning string value
- The code looks good. I will put it into conversion testing here since it will be faster.
- 02:58 PM Feature #2089: INPUT function returning string value
- Not yet regression-tested.
- 09:42 AM Feature #2089: INPUT function returning string value
- > Stanislav: when will the update be ready?
I'm writing javadocs / merging it. - 09:17 AM Feature #2089: INPUT function returning string value
- Actually, this should be pretty much done at this point. Let's finish it now.
Stanislav: when will the update be ... - 07:51 AM Feature #2089: INPUT function returning string value
- Greg/Stanislav: we can make this a low priority, as after the latest schema VALEXP changes in #1620, the problematic ...
- 11:41 AM Feature #1641: implement SAX XML support
- > AFAIK any field declared in an interface is by default "static final" (the compiler takes care to put these modifie...
- 11:08 AM Feature #1641: implement SAX XML support
- > 1. Please make the constants all @public final static@ instead of just @public@ (which is editable, something we do...
- 09:45 AM Feature #1641: implement SAX XML support
- Code Feedback (Eugenie: you can make the final changes to the code Constantin posted):
1. Please make the constant... - 08:18 AM Feature #1641: implement SAX XML support
- Eugenie: attached you have the runtime support for this; please go ahead with the conversion support.
Greg: the co... - 08:13 AM Feature #1641: implement SAX XML support
- Eugenie, please implement the following:
These constants are recognized by the parser but we do not emit them as l... - 07:03 AM Feature #1620: implement EXTENT parameter support
- Attached merged update, committed to bzr revision 10298.
- 07:02 AM Feature #1620: implement EXTENT parameter support
- > If it passes conversion testing AND if you deem the Majic changes to be correct, then go ahead and check in/distrib...
03/18/2013
- 05:35 PM Feature #2089: INPUT function returning string value
- Understood.
- 05:27 PM Feature #2089: INPUT function returning string value
- > Also: this fuzzy matching may have bad side effects on other places we use expressionType(). For this reason, I th...
- 03:36 PM Feature #2089: INPUT function returning string value
- Yes, that is my point. getSignature(int, int, String[]) should be modified to return the default as the first one de...
- 03:13 PM Feature #2089: INPUT function returning string value
- > In regard to your idea about a default signature, I am OK with that approach. How about this: if the signature mat...
- 03:07 PM Feature #2089: INPUT function returning string value
- Greg Shah wrote:
> OK, you have to some some additional things here.
>
> 1. Before you set the implicit_input, yo... - 02:59 PM Feature #2089: INPUT function returning string value
- OK, you have to some some additional things here.
1. Before you set the implicit_input, you must first know the de... - 02:14 PM Feature #2089: INPUT function returning string value
- > Please post the code you are using to implement the implicit_input analysis....
- 01:50 PM Feature #2089: INPUT function returning string value
- In regard to your idea about a default signature, I am OK with that approach. How about this: if the signature match...
- 01:34 PM Feature #2089: INPUT function returning string value
- Please post the code you are using to implement the implicit_input analysis.
- 01:16 PM Feature #2089: INPUT function returning string value
- > What is the problem with the use of ParmType.BDT (BaseDataType) as the 1st parameter (the way it was originally cod...
- 12:19 PM Feature #2089: INPUT function returning string value
- What is the problem with the use of ParmType.BDT (BaseDataType) as the 1st parameter (the way it was originally coded)?
- 11:25 AM Feature #2089: INPUT function returning string value
- Signature of the @LENGTH@ function stored into @SignatureHelper.map_func@ map is @{ ParmType.BDT, ParmType.CHAR }@. A...
- 12:30 PM Feature #1620: implement EXTENT parameter support
- This makes sense. I should have read the surrounding code more carefully and I would have seen this.
If it passes... - 11:58 AM Feature #1620: implement EXTENT parameter support
- > My only question is this: the schema_validation.rules includes support for the INSERT statement, but then the FORMA...
- 11:52 AM Feature #1620: implement EXTENT parameter support
- Code Review:
My only question is this: the schema_validation.rules includes support for the INSERT statement, but ... - 10:42 AM Feature #1620: implement EXTENT parameter support
- New version of the update in which:
# the NO-VALIDATE clause with a frame must affect only the schema validation exp...
03/17/2013
- 04:34 PM Feature #1620: implement EXTENT parameter support
- I'm OK with the changes. If all of the Majic modifications appear to be correct, we will go ahead with runtime testin...
- 11:16 AM Feature #1620: implement EXTENT parameter support
- There are lots of changes in MAJIC converted code, here are some examples:
# for extent fields, all elements get the... - 10:03 AM Feature #1620: implement EXTENT parameter support
- Renamed test file.
- 10:01 AM Feature #1620: implement EXTENT parameter support
- When fixing conversion of schema validation expressions for extent fields, it hit me that the P2J approach using SCHE...
03/14/2013
- 05:07 PM Feature #2089: INPUT function returning string value
- ...
- 09:55 PM Feature #2089: INPUT function returning string value
- I have an update posted in #2053. It is in testing, but hopefully you can use it to test your changes.
- 12:04 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
- Committed to bzr revision 10285.
- 10:27 AM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
- The update looks good. You can check it in and distribute it.
- 09:56 AM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
- Correct, good letter, wrong date. Attached is the good one.
- 08:13 AM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
- I think the wrong update is posted here.
03/13/2013
- 06:14 PM Feature #2089: INPUT function returning string value
- About note 8: no.
You can do the following:
1. Determine the type (wrapper classname: like "integer") of the va... - 06:00 PM Feature #2089: INPUT function returning string value
- Yes, you should work on item 2 and my changes will enable item 1. Please note that I don't want to transform all val...
- 04:42 PM Feature #2089: INPUT function returning string value
- In regards to #2: should I parent all occurrences of a validated value with FUNC_POLY node as a solution?
- 02:12 PM Feature #2089: INPUT function returning string value
- OK, I missed that. So your question remains.
- 02:11 PM Feature #2089: INPUT function returning string value
- Greg was saying that "I am currently working to extend that facility to be more robust, including detecting the case ...
- 01:53 PM Feature #2089: INPUT function returning string value
- Stanislav Lomany wrote:
> So, am I correct that except checking the runtime part we have two problems:
> 1. It is n... - 01:47 PM Feature #2089: INPUT function returning string value
- So, am I correct that except checking the runtime part we have two problems:
1. It is not properly recognized that a... - 03:15 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
- The update has passed conversion regression testing.
- 02:33 PM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
- The only remaining problem was with char field initializers, which were not handled (it was parsers fault). The notes...
03/12/2013
- 04:05 PM Feature #2089: INPUT function returning string value
- As Constantin notes, the INPUT function in the 4GL can return either the actual data type of the widget OR it can ret...
- 03:46 PM Feature #2089: INPUT function returning string value
- Greg, how should correctly converted validation code look like for the following example?...
- 03:12 PM Feature #2089: INPUT function returning string value
- Copied from #2068:
*CA*
Another problem found in at least rtb/ folder:... - 03:09 PM Feature #2089 (Closed): INPUT function returning string value
03/11/2013
- 11:09 AM Feature #1640: implement DOM XML support
- Added more missing APIs. Committed to bzr revision 10276
- 11:05 AM Feature #1884: add some of the v10 data types and core built-ins
- -Added more missing APIs. Committed to bzr revision 10276- was for task #1640
03/09/2013
- 03:57 PM Bug #2076: DMO setter fails when parameter is BaseDataType
- A simple change to ECW fixes this. I am making some other changes to the ECW as well. Then I will conversion test t...
- 11:25 AM Bug #2076: DMO setter fails when parameter is BaseDataType
- There is a regression related to this update:...
- 03:56 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
- Yes, I'm thinking about what is the right solution here. I wonder if I should make the previous solution (the extra ...
- 03:52 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
- Hmm... on a second thought, this is similar to the DMO setter case... it should wrap the _POLY/DB_NON_REF in a logica...
- 03:34 PM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
- I'm not sure the problem is in the ECW. Actually, there is never any attempt to call the ECW for these cases. If I ...
- 11:13 AM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
- The strange thing is that I already put in support for all of these cases. I guess it is not working properly. I wi...
- 07:28 AM Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
- The ExpressionConversion worker needs to treat the cases when a _POLY is used in a logical test, as in:...
- 11:11 AM Feature #2087 (Closed): add support for extent vars/fields used with a PUT statement (stream-only...
- Checked in as bzr revision 10273.
- 04:44 AM Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
- The ges_upd20130308g.zip update has passed conversion regression testing.
- 03:01 AM Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
- Thanks, that did the trick. I'm putting it through conversion regression testing.
- 11:06 AM Bug #2065 (Closed): ambiguity in date/decimal literals that is not handled properly by the Progre...
- 11:06 AM Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
- Passed conversion testing and checked in as bzr revision 10272.
- 02:55 AM Feature #1640: implement DOM XML support
- Adds two missing APIs in XmlFactory, related to WIDGET-POOL clause. Committed to bzr revision 10271.
Also available in: Atom