Project

General

Profile

Activity

From 03/15/2013 to 04/13/2013

04/14/2013

09:12 PM Feature #1980 (WIP): runtime support for DOM XML processing
Evgeny Kiselev
09:11 PM Feature #2012 (WIP): runtime support for _MSG() built-in
Evgeny Kiselev
09:03 PM Feature #1632: implement _MSG() undocumented built-in function
Corrected javadoc according to №18 comment. Evgeny Kiselev

04/13/2013

05:58 PM Feature #1980: runtime support for DOM XML processing
Please put all history entries into the parent task #1640. Greg Shah
05:57 PM Feature #1632: implement _MSG() undocumented built-in function
I am fine with the proposed changes.
I do think we need to improve the javadoc. We should explain that the getE...
Greg Shah
08:07 PM Feature #1632: implement _MSG() undocumented built-in function
Attached update evk_upd20130412c.zip with testcase. Evgeny Kiselev

04/12/2013

07:05 PM Feature #1632: implement _MSG() undocumented built-in function
fixed error with int64 Evgeny Kiselev
06:12 PM Feature #1632: implement _MSG() undocumented built-in function
Attached update evk_upd20130412a.zip. Implemented getErrorNumberAtIndex method.
Also will provide testcase soon.
Evgeny Kiselev
07:02 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> ... Eugenie Lyzenko
03:18 PM Feature #1613: finish FILE-INFO system handle support
>> - Unix P2J and 4GL will not find anything when given the path with the opposite separator,
>> - On Windows 4GL yo...
Greg Shah
02:37 PM Feature #1613: finish FILE-INFO system handle support
> I don't think this is right. For example, why are you appending the \ to ./ in this code: pathName.startsWith("./" ... Costin Savin
01:54 PM Feature #1613: finish FILE-INFO system handle support
> - Unix P2J and 4GL will not find anything when given the path with the opposite separator,
> - On Windows 4GL you ...
Greg Shah
12:41 PM Feature #1613: finish FILE-INFO system handle support
Tested with the file separator changed to opposite of what the OS uses,
The results are:
- Unix P2J and 4GL will no...
Costin Savin
09:05 AM Feature #1613: finish FILE-INFO system handle support
> The resulting code in the FSD.search() method has some blank lines removed where they previously existed. Please pu... Greg Shah
04:58 AM Feature #1613: finish FILE-INFO system handle support
Added proposed update. Costin Savin
02:59 PM Feature #1639: implement socket support
Code Feedback:
1. Some of the error messages are still wrong (the host is hard coded to "localhost" but it should ...
Greg Shah
02:06 PM Feature #1639: implement socket support
End of the day update. Costin Savin
07:04 AM Feature #1792: implement widget-pool support
Should the runtime task include working on the resources which can be added in a pool or add just the pooling support... Constantin Asofiei
06:02 AM Feature #1984: make methods to act as "read-only" attributes
From #1920 (note 76):
*GES*
1. The read_only_attribute function in common-progress.rules seems like it will be pain...
Constantin Asofiei
05:45 AM Feature #1921: implement super-procedures
A resume on what else needs to be done regarding super-procedure chains:
* make the SEARCH-TARGET and SEARCH-SELF em...
Constantin Asofiei
05:32 AM Bug #1971: emit worker versions for functions to fix source-procedure handle
This has two parts:
# the conversion part, where the worker method is added
# the runtime part, which involves the ...
Constantin Asofiei
05:28 AM Feature #2123: map the converted method/attribute names to their legacy name
Note 54 from #1920:
About the invalid API calls (when the invoked API is not valid for the current referent). 4GL ...
Constantin Asofiei
05:21 AM Feature #2123 (New): map the converted method/attribute names to their legacy name
Constantin Asofiei
05:10 AM Feature #2013: implement the SELF system handle
About the runtime implementation of SELF handles: I don't want to do this in a separate task; instead, each case whic... Constantin Asofiei
04:51 AM Bug #1968: implement MAP TO actual-name IN handle clause for function definitions
This clause should be easy to integrate in the ControlFlowOps invocation mechanism, as we only need to add a "hook" f... Constantin Asofiei
04:46 AM Bug #1969: buffer names in get-signature
The unknown part at this time is how the schema can be interogated to get the original buffer name. I expect we alrea... Constantin Asofiei
04:33 AM Feature #1972: provide full-support for DYNAMIC-FUNCTION set to function parameters
This is a _POLY case which should be solved by #2068 changes for _POLY cases. Estimate 1h to confirm. Constantin Asofiei

04/11/2013

05:08 PM Feature #1639: implement socket support
Code Review:
1. Messages that embed the local host's port number must be built dynamically at runtime with the cor...
Greg Shah
03:12 PM Feature #1639: implement socket support
Added "end of the day" update, this doesn't contain fix for all the issues from review (valid() I must see behavior). Costin Savin
02:18 PM Feature #1639: implement socket support
> I solved them by using complete name of java.net.Socket
That is fine for now.
Greg Shah
02:17 PM Feature #1639: implement socket support
More feedback:
This code in SocketListenerImpl.startListening() is wrong:...
Greg Shah
02:12 PM Feature #1639: implement socket support
The list of things to be done at the moment:
On SOCKET side:
- I modified the read methods because the GET-BYTES-AV...
Costin Savin
02:10 PM Feature #1639: implement socket support
Code Review for
1. Remember that we do NOT put individual import statements in code unless we are needing to over...
Greg Shah
01:20 PM Feature #1639: implement socket support
> what is left to be done
I am still waiting to see a detailed list of what is left to be implemented OR investiga...
Greg Shah
04:20 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> I would suggest to replace this call with:
> ...
> sb.append(pkgroot.replaceAll("\\.", StringHelper.fixupRegex(fi...
Greg Shah
03:48 PM Feature #1613: finish FILE-INFO system handle support
Code Review of cs_upd20130410a.zip:
Generally I am fine with this update.
The resulting code in the FSD.searc...
Greg Shah
02:48 PM Feature #1613: finish FILE-INFO system handle support
> Were any of your changes applied at the time?
Yes the allowDir additional check only but that should not affect an...
Costin Savin
02:42 PM Feature #1613: finish FILE-INFO system handle support
Which bzr revision of P2J did you use to get the results of note 42?
Were any of your changes applied at the time?...
Greg Shah
01:25 PM Feature #1613: finish FILE-INFO system handle support
Considering we have the following directory structure:... Costin Savin
03:00 PM Feature #1634: implement full native library (.so or DLL) support
About the parameter validation: as the native side has no idea of the routine's signature (thanks for the details, it... Constantin Asofiei
12:11 PM Feature #1634: implement full native library (.so or DLL) support
> How will the native code know to convert a value from "ABL data type" to "ABL DLL type" (better said, if signature ... Greg Shah
11:08 AM Feature #1634: implement full native library (.so or DLL) support
> I was referring to NativeInvoker.invoke(). I'd like you to take that part. I will handle NativeInvoker.invokeRout... Constantin Asofiei
10:34 AM Feature #1634: implement full native library (.so or DLL) support
> Looks like I skipped the "native" modifier for the NativeInvoker.invokeRoutine() signature. Idea is this is a nativ... Greg Shah
05:34 AM Feature #1634: implement full native library (.so or DLL) support
Greg Shah wrote:
> I was planning to build the part of the solution from the NativeInvoker.invokeRoutine() on down t...
Constantin Asofiei
12:16 PM Feature #2121: implement Java runtime support for native libraries
This is just for time tracking. Place all history in parent task #1634. Greg Shah
12:15 PM Feature #2121 (Closed): implement Java runtime support for native libraries
Greg Shah

04/10/2013

05:56 PM Feature #1634: implement full native library (.so or DLL) support
I was planning to build the part of the solution from the NativeInvoker.invokeRoutine() on down to the OS. It is not... Greg Shah
07:04 AM Feature #1634: implement full native library (.so or DLL) support
Some ideas on how the code for native proc call should work and what needs to be done:
* determine how the argument v...
Constantin Asofiei
03:03 PM Feature #1635: implement MEMPTR/RAW support
The error behavior of all the BinaryData.get/set*() methods will need to be researched before implementation. If all... Greg Shah
02:39 PM Feature #1635: implement MEMPTR/RAW support
A more detailed look at NIO ByteBuffer makes it clear that it is not a suitable solution for our problem. In particu... Greg Shah
12:28 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The issues(related or partially) to discuss so far:
1. The source file com/goldencode/p2j/util/SourceNameMapper.ja...
Eugenie Lyzenko
11:24 AM Feature #1613: finish FILE-INFO system handle support
After some tests I found some more problems in the search algorithm for example the file.isAbsolute() check should a... Costin Savin
08:09 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
OK, after you are finished with #1650, you can fix the propath assignment behavior. When that is done we will close ... Greg Shah

04/09/2013

07:09 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
> Is this done?
I have clarified this point. Both Windows and Linux 4GL systems shows the same behavior:...
Eugenie Lyzenko
04:46 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The final work with this task was checked in as bzr revision 10152 on January 17, 2013. As far as I know this task m... Greg Shah
05:05 PM Feature #1634: implement full native library (.so or DLL) support
Constantin: can you define the native API you will need in order to finish the ControlFlowOps support for native proc... Greg Shah
04:56 PM Feature #1613: finish FILE-INFO system handle support
While you are working on the final fixes to FSD.search(), I would like to get a safe version of all the other changes... Greg Shah
02:03 PM Feature #1613: finish FILE-INFO system handle support
These investigations are all going in the right direction. Continue your analysis and make a list of the problems in... Greg Shah
12:37 PM Feature #1613: finish FILE-INFO system handle support
This part of the previous code ... Costin Savin
09:48 AM Feature #1613: finish FILE-INFO system handle support
After I retested to see what I've missed (both Unix and Windows) I realized that the behavior of search for files and... Costin Savin
01:28 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> Reworked file names to simplify. Unfortunately for now process.h has compilation issue in Windows. So the file is:... Greg Shah
08:30 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The next drop includes:
1. Restored missing code for linux process file to handle SIGCHLD
2. Reworked file names to...
Eugenie Lyzenko

04/08/2013

07:16 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> 2. Please use the "simple" process.h and filesys.h instead of the longer *_helper.h versions.
I had the same ide...
Eugenie Lyzenko
06:59 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
Code Feedback:
1. Please remove the following from future updates:...
Greg Shah
01:48 PM Feature #1639: implement socket support
As mentioned in note 58, please document the list of things that still need to be completed, fixed or investigated. ... Greg Shah
01:15 PM Feature #1639: implement socket support
Added an intermediate update, this is just initial form, there are still many things to implement and bring to a clea... Costin Savin
12:26 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I will be reviewing the 0406 updates shortly.
I assume you are now working on the datetime/datetime_tz changes. P...
Greg Shah
11:40 AM Feature #2108: event model rationalization
The 4GL event model is inherently "client" oriented. It's primary usage is built around the user-interface and the i... Greg Shah
11:07 AM Feature #2108 (Closed): event model rationalization
Greg Shah

04/07/2013

01:33 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The next drop changes:
1. P2J build.xml file has been changed to pass OS architecture to the makefile for Windows com...
Eugenie Lyzenko

04/06/2013

12:37 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I have found that the @int64@ variables (including @extent@) were not correctly initialized to 0. I fixed this.
I ad...
Ovidiu Maxiniuc

04/05/2013

02:15 PM Feature #1639: implement socket support
So far I've completed the connect (including ssl) on socket part and tested it, and also added code for read and wri... Costin Savin
07:44 AM Feature #1639: implement socket support
Costin: please put details here about what you are doing with the implementation, what is completed and what is left ... Greg Shah
01:44 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I checked today and adjusted the code for the function calls (direct calls specially) and database access.
The imple...
Ovidiu Maxiniuc
08:56 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
> 5 and 6 work fine, I double checked. If pos + len is 33/65 means that the bits involved are the last len bits from ... Greg Shah
08:48 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
I like it. Keep going in this direction. Greg Shah
08:23 AM Feature #1626: implement OS-DIR support as an INPUT stream
OK, that is fine. Please put comments into that code to explain this, so that future readers will not accidentally c... Greg Shah
08:11 AM Feature #1626: implement OS-DIR support as an INPUT stream
Sorry I forgot to mention about that. The reason is when we have a link, getting the canonicalPath of the link file w... Costin Savin
08:01 AM Feature #1626: implement OS-DIR support as an INPUT stream
Please describe the reasons behind the DirStream.getPathName() change in cs_upd20130404a.zip. Greg Shah
08:21 AM Feature #1613: finish FILE-INFO system handle support
Code Feedback:
1. See note 52 in #1626.
2. The FSD.search() change to use file.getPath().startsWith(".") is not...
Greg Shah
04:58 AM Feature #1920: implement persistent procedures
You can go ahead and commit/release om_upd20130405a.zip
LE: just runtime changes, no conversion regression testing n...
Constantin Asofiei
04:56 AM Feature #1920: implement persistent procedures
Comment type changed to single-line. Ovidiu Maxiniuc
04:47 AM Feature #1920: implement persistent procedures
Review of om_upd20130404a.zip - do not use @/*@ for adding comments, always use @//@ single-line comments. Please mak... Constantin Asofiei

04/04/2013

01:14 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I went on with integer-type parameter passing and implemented the same mechanism for @integer@/@int64@ as it was for ... Ovidiu Maxiniuc
01:00 PM Feature #1920: implement persistent procedures
This update fixes:
* @unknown@ parameter in function/procedure calls. The unknown values for some data types (@date@...
Ovidiu Maxiniuc
07:35 AM Feature #1613: finish FILE-INFO system handle support
> If the PROPATH is /path1/,/path2/,/path3/,. then a search for relative/path/to/file.txt would find /path1/relative/... Costin Savin

04/03/2013

06:40 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
Today drop has been uploaded. Includes:
1. Rework for build.xml to separate common native tasks. Adding required com...
Eugenie Lyzenko
09:25 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
I am generally fine with the build.xml approach. The only thing I see is this:... Greg Shah
08:11 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
OK. This drop contains only changes in build.xml project build file to review. Plus one small change for filesys.c fo... Eugenie Lyzenko
02:29 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Greg,
I have integrated your feedback into the code for notes 1, 2, 3 and 4.
5 and 6 work fine, I double checked. ...
Ovidiu Maxiniuc
12:55 PM Feature #1613: finish FILE-INFO system handle support
Tested by having this structure @/workcs/file.txt@ in the current folder(@/home/costins@)
and setting propath varia...
Costin Savin
09:03 AM Feature #1613: finish FILE-INFO system handle support
> I removed the check for current directory because I considered it is already checked in the begining with file.exis... Greg Shah
06:08 AM Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 74
Example:...
Vadim Nebogatov

04/02/2013

04:11 PM Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 74
Example:...
Vadim Nebogatov
01:22 PM Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 78
Example:...
Vadim Nebogatov
01:21 PM Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 77
Example:...
Vadim Nebogatov
01:19 PM Bug #2106 (New): Missing runtime error messages in P2J
Vadim Nebogatov
01:29 PM Feature #1613: finish FILE-INFO system handle support
> 2.
> You are right, the case insensitive path is now broken with your changes. Please fix it.
I'm not sure it's...
Costin Savin
10:37 AM Feature #1613: finish FILE-INFO system handle support
> 3. This code looks wrong and it definitely breaks behavior that we rely upon today:
>
> // if the path length is...
Costin Savin
07:49 AM Feature #1613: finish FILE-INFO system handle support
Also, please note that your update zip filename is not matching our standard naming conventions. You don't need to c... Greg Shah
06:58 AM Feature #1613: finish FILE-INFO system handle support
Code Feedback:
1. This code in filesys.c still needs to close the file descriptor before returning:...
Greg Shah
06:24 AM Feature #1613: finish FILE-INFO system handle support
> The 4GL bug which sees .. directory as hidden for os dir is described in DirStream class (it happpends because the ... Greg Shah
06:09 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
Feedback:
It is OK so far. Make sure you merge with the latest version of P2J (for example the build.xml that you...
Greg Shah
05:47 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Code Feedback:
1. The instantiateUnknownRaw() method should be positioned after the constructors in the raw.java.
...
Greg Shah

04/01/2013

11:22 AM Feature #1920: implement persistent procedures
Note 80 from #2080 shows a missing error for function invocation:... Constantin Asofiei
10:53 AM Feature #1613: finish FILE-INFO system handle support
Added proposed update, with the modified search function, eliminated the change in EnvironmentOps since it wasn't nec... Costin Savin
09:29 AM Feature #1613: finish FILE-INFO system handle support
> In the Javadoc of EnvironmentOps.searchPath() there is this saying:
I think you mean EnvironmentOps.getSearchPat...
Greg Shah

03/29/2013

07:06 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
This is update just for review to see the approach. It compiles native DLL in Windows 32-bit using mingw32-gcc. Plann... Eugenie Lyzenko
01:41 PM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
This update adds implementation for all TODOs from @int64@ and, since the implementation is mostly the same for the @... Ovidiu Maxiniuc
09:19 AM Bug #2105: BlockManager does not return some datatypes correctly
A first attempt to fix would be to have only one @returnNormal@ static function with a BDT parameter and the value wr... Ovidiu Maxiniuc
09:04 AM Bug #2105: BlockManager does not return some datatypes correctly
Consider the following 4GL code:... Ovidiu Maxiniuc
08:55 AM Bug #2105 (New): BlockManager does not return some datatypes correctly
Ovidiu Maxiniuc

03/28/2013

01:26 PM Feature #1613: finish FILE-INFO system handle support
I retested the cases from UAST which contained search function or Propath and there weren't any difference,
However ...
Costin Savin
08:53 AM Feature #1613: finish FILE-INFO system handle support
In the Javadoc of EnvironmentOps.searchPath() there is this saying:... Costin Savin
08:48 AM Feature #1613: finish FILE-INFO system handle support
I don't understand why the comma is included in the default path. We already have protection against the path being ... Greg Shah
08:37 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
You are allowed to use Windows in KVM on the same Ubuntu system. It will be allowed in the standards. Thanks for as... Greg Shah

03/27/2013

04:21 PM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The question. I have idea to install The Windows inside the KVM Virtual Machine on my new Ubuntu box. Will it also co... Eugenie Lyzenko
02:58 PM Feature #1613: finish FILE-INFO system handle support
There seems to be an error in the search() logic of FileSystemDaemon.
If the given paths Array is non null it will s...
Costin Savin

03/26/2013

11:13 AM Feature #1613: finish FILE-INFO system handle support
Code Feedback:
1. StreamWrapper has no real changes other than the copyright date and the history entry. Does it ...
Greg Shah

03/25/2013

04:14 PM Feature #1626: implement OS-DIR support as an INPUT stream
Added proposed update.The update is for both #1613 and #1626 Costin Savin
04:13 PM Feature #1613: finish FILE-INFO system handle support
Added proposed update.The update is for both #1613 and #1626 Costin Savin
08:40 AM Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Ovidiu: your next priority should be completing the runtime work on this task. The first priority is to get the int6... Greg Shah

03/23/2013

03:18 PM Bug #2070: BlockManager Action disambiguation
Converting the extent_params_proc.p test on windows fails with this:... Constantin Asofiei

03/22/2013

09:37 AM Feature #1920: implement persistent procedures
Merged with latest bzr version, contains both CA 0322a.zip and CA 0322f.zip changes. committed to bzr revision 10313. Constantin Asofiei
08:24 AM Feature #1920: implement persistent procedures
The code is OK. It can be committed and distributed when it passes testing. Greg Shah
07:54 AM Feature #1920: implement persistent procedures
Fixes the case when a method param has subscript:... Constantin Asofiei
06:04 AM Feature #1920: implement persistent procedures
The code is OK. If it passes conversion testing you can check it in and distribute it. Greg Shah
05:31 AM Feature #1920: implement persistent procedures
Fixed conversion support for HANDLE attribute, when used with system handles:... Constantin Asofiei
06:59 AM Feature #1608: implement full appserver support (from 4GL clients only)
Checked in to bzr as revision 10310. Costin Savin
05:26 AM Feature #1608: implement full appserver support (from 4GL clients only)
Conversion testing passed. Check it in and distribute it. Greg Shah

03/21/2013

04:10 PM Feature #1608: implement full appserver support (from 4GL clients only)
Added merged update Costin Savin
01:51 PM Feature #1608: implement full appserver support (from 4GL clients only)
Code Feedback:
1. The javadoc and formatting of ConnectableServer should be this:...
Greg Shah
01:13 PM Feature #1608: implement full appserver support (from 4GL clients only)
Added proposed update which fixes connect for AppServer Costin Savin
10:37 AM Feature #1608: implement full appserver support (from 4GL clients only)
You can force things to be wrapped in that case where there is more than 1 parameter. Greg Shah
10:27 AM Feature #1608: implement full appserver support (from 4GL clients only)
> [javac] .../server/common/Apitest1.java:134: error: no suitable method found for connect(String,character,character... Costin Savin
01:32 PM Bug #2099 (Closed): "ASSIGN widget." statement does not convert properly in some cases
Greg Shah
12:53 PM Bug #2099 (Review): "ASSIGN widget." statement does not convert properly in some cases
> Check it in and distribute it.
Committed to bzr revision 10308.
Constantin Asofiei
12:46 PM Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This looks good. Check it in and distribute it. Greg Shah
11:41 AM Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This update has passed conversion regression testing. There are some changes in MAJIC, but they do not affect runtime... Constantin Asofiei
09:45 AM Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
I'm still missing something, lots of invalid changes in MAJIC. Constantin Asofiei
08:58 AM Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This is a fix attempt for this issue. Looks like the solution was to explicitly set the frame name, in case the "fram... Constantin Asofiei
11:23 AM Feature #2089 (Closed): INPUT function returning string value
Greg Shah
10:37 AM Feature #2089: INPUT function returning string value
Please do check in and distribute the change. Greg Shah
10:14 AM Feature #2089: INPUT function returning string value
Yes, they all are OK. Stanislav Lomany
09:51 AM Feature #2089: INPUT function returning string value
Here are the results of the conversion testing:... Greg Shah
08:12 AM Feature #2089: INPUT function returning string value
Code Review:
It looks good. 1 minor issue: the comment was corrupted in "handle_implicit_input" in the latest com...
Greg Shah

03/20/2013

05:54 PM Feature #1641: implement SAX XML support
The update evl_upd20130320b.zip has been committed in bzr as 10303. Eugenie Lyzenko
05:46 PM Feature #1641: implement SAX XML support
> If it passes testing you can check it in and distribute it.
Conversion testing has been passed. I'm going to com...
Eugenie Lyzenko
04:40 PM Feature #1641: implement SAX XML support
If it passes testing you can check it in and distribute it. Greg Shah
03:11 PM Feature #1641: implement SAX XML support
This update merged with bzr 10302. Starting the conversion testing. Eugenie Lyzenko
02:46 PM Feature #1641: implement SAX XML support
Code feedback: everything looks good.
The only issue is that you need to merge with the recent bzr revision. Ple...
Greg Shah
02:36 PM Feature #1641: implement SAX XML support
The update includes:
1. Changing for constant types.
2. Adding history entries.
3. Fixes for misspelled words in S...
Eugenie Lyzenko
02:16 PM Feature #2089: INPUT function returning string value
Yes, please do. Greg Shah
02:13 PM Feature #2089: INPUT function returning string value
> When we search upward for KW_VALIDATE and enable implicit input testing, we must ensure that we are a descendant of... Stanislav Lomany
02:00 PM Feature #2089: INPUT function returning string value
When we search upward for KW_VALIDATE and enable implicit input testing, we must ensure that we are a descendant of t... Greg Shah
01:49 PM Feature #2089: INPUT function returning string value
Note that... Stanislav Lomany
12:26 PM Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This case was exposed by server folder compilation, in #2068 note 172:... Constantin Asofiei
12:08 PM Bug #2099 (Closed): "ASSIGN widget." statement does not convert properly in some cases
Constantin Asofiei

03/19/2013

07:46 PM Feature #2089: INPUT function returning string value
1 compile problem in Majic:... Greg Shah
03:13 PM Feature #2089: INPUT function returning string value
The code looks good. I will put it into conversion testing here since it will be faster. Greg Shah
02:58 PM Feature #2089: INPUT function returning string value
Not yet regression-tested. Stanislav Lomany
09:42 AM Feature #2089: INPUT function returning string value
> Stanislav: when will the update be ready?
I'm writing javadocs / merging it.
Stanislav Lomany
09:17 AM Feature #2089: INPUT function returning string value
Actually, this should be pretty much done at this point. Let's finish it now.
Stanislav: when will the update be ...
Greg Shah
07:51 AM Feature #2089: INPUT function returning string value
Greg/Stanislav: we can make this a low priority, as after the latest schema VALEXP changes in #1620, the problematic ... Constantin Asofiei
11:41 AM Feature #1641: implement SAX XML support
> AFAIK any field declared in an interface is by default "static final" (the compiler takes care to put these modifie... Greg Shah
11:08 AM Feature #1641: implement SAX XML support
> 1. Please make the constants all @public final static@ instead of just @public@ (which is editable, something we do... Constantin Asofiei
09:45 AM Feature #1641: implement SAX XML support
Code Feedback (Eugenie: you can make the final changes to the code Constantin posted):
1. Please make the constant...
Greg Shah
08:18 AM Feature #1641: implement SAX XML support
Eugenie: attached you have the runtime support for this; please go ahead with the conversion support.
Greg: the co...
Constantin Asofiei
08:13 AM Feature #1641: implement SAX XML support
Eugenie, please implement the following:
These constants are recognized by the parser but we do not emit them as l...
Greg Shah
07:03 AM Feature #1620: implement EXTENT parameter support
Attached merged update, committed to bzr revision 10298. Constantin Asofiei
07:02 AM Feature #1620: implement EXTENT parameter support
> If it passes conversion testing AND if you deem the Majic changes to be correct, then go ahead and check in/distrib... Constantin Asofiei

03/18/2013

05:35 PM Feature #2089: INPUT function returning string value
Understood. Greg Shah
05:27 PM Feature #2089: INPUT function returning string value
> Also: this fuzzy matching may have bad side effects on other places we use expressionType(). For this reason, I th... Stanislav Lomany
03:36 PM Feature #2089: INPUT function returning string value
Yes, that is my point. getSignature(int, int, String[]) should be modified to return the default as the first one de... Greg Shah
03:13 PM Feature #2089: INPUT function returning string value
> In regard to your idea about a default signature, I am OK with that approach. How about this: if the signature mat... Stanislav Lomany
03:07 PM Feature #2089: INPUT function returning string value
Greg Shah wrote:
> OK, you have to some some additional things here.
>
> 1. Before you set the implicit_input, yo...
Stanislav Lomany
02:59 PM Feature #2089: INPUT function returning string value
OK, you have to some some additional things here.
1. Before you set the implicit_input, you must first know the de...
Greg Shah
02:14 PM Feature #2089: INPUT function returning string value
> Please post the code you are using to implement the implicit_input analysis.... Stanislav Lomany
01:50 PM Feature #2089: INPUT function returning string value
In regard to your idea about a default signature, I am OK with that approach. How about this: if the signature match... Greg Shah
01:34 PM Feature #2089: INPUT function returning string value
Please post the code you are using to implement the implicit_input analysis. Greg Shah
01:16 PM Feature #2089: INPUT function returning string value
> What is the problem with the use of ParmType.BDT (BaseDataType) as the 1st parameter (the way it was originally cod... Stanislav Lomany
12:19 PM Feature #2089: INPUT function returning string value
What is the problem with the use of ParmType.BDT (BaseDataType) as the 1st parameter (the way it was originally coded)? Greg Shah
11:25 AM Feature #2089: INPUT function returning string value
Signature of the @LENGTH@ function stored into @SignatureHelper.map_func@ map is @{ ParmType.BDT, ParmType.CHAR }@. A... Stanislav Lomany
12:30 PM Feature #1620: implement EXTENT parameter support
This makes sense. I should have read the surrounding code more carefully and I would have seen this.
If it passes...
Greg Shah
11:58 AM Feature #1620: implement EXTENT parameter support
> My only question is this: the schema_validation.rules includes support for the INSERT statement, but then the FORMA... Constantin Asofiei
11:52 AM Feature #1620: implement EXTENT parameter support
Code Review:
My only question is this: the schema_validation.rules includes support for the INSERT statement, but ...
Greg Shah
10:42 AM Feature #1620: implement EXTENT parameter support
New version of the update in which:
# the NO-VALIDATE clause with a frame must affect only the schema validation exp...
Constantin Asofiei

03/17/2013

04:34 PM Feature #1620: implement EXTENT parameter support
I'm OK with the changes. If all of the Majic modifications appear to be correct, we will go ahead with runtime testin... Greg Shah
11:16 AM Feature #1620: implement EXTENT parameter support
There are lots of changes in MAJIC converted code, here are some examples:
# for extent fields, all elements get the...
Constantin Asofiei
10:03 AM Feature #1620: implement EXTENT parameter support
Renamed test file. Constantin Asofiei
10:01 AM Feature #1620: implement EXTENT parameter support
When fixing conversion of schema validation expressions for extent fields, it hit me that the P2J approach using SCHE... Constantin Asofiei
 

Also available in: Atom